summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add a bunch of missing bug references to FLAKY testsstuartmorgan@chromium.org2010-10-2712-4/+14
| | | | | | | | | BUG=None TEST=N/A Review URL: http://codereview.chromium.org/4135007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64150 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 64127 - sync: hide encryption tabstriptim@chromium.org2010-10-271-16/+15
| | | | | | | | | | | | BUG=59631 TEST=open configure dialog, note no 'Data Type'/'Encryption' tabstrip. Review URL: http://codereview.chromium.org/4155006 TBR=tim@chromium.org Review URL: http://codereview.chromium.org/4097007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64149 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some tiny javascript lint errors.dmazzoni@chromium.org2010-10-271-11/+13
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/4203002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64148 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix file selector moving up one dir each time you use it.avi@chromium.org2010-10-271-2/+8
| | | | | | | | | | | If default_path is a directory, start the file open dialog in that dir, rather than in the parent with that dir selected. BUG=49081 TEST=see #2 on bug Review URL: http://codereview.chromium.org/4106003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64146 0039d316-1c4b-4281-b951-d872f2087c98
* Disable JingleChromotingConnectionTest under TSan again.sergeyu@chromium.org2010-10-271-0/+0
| | | | | | | | BUG=57832 TEST=None TBR=timurrrr git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64145 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit Roll 70636:70691.dglazkov@chromium.org2010-10-271-1/+1
| | | | | | | | | | TBR=mnaganov TEST=nope BUG=none Review URL: http://codereview.chromium.org/4205002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64144 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up a bad file path, and remove a deleted file.dmaclach@chromium.org2010-10-271-2/+1
| | | | | | | | | TEST=BUILD BUG=NONE Review URL: http://codereview.chromium.org/3961006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64143 0039d316-1c4b-4281-b951-d872f2087c98
* Forward textfield focus event to the browser.rjkroege@google.com2010-10-275-4/+64
| | | | | | | | | | | | Add two messages in IPC channel: 1. The renderer needs to inform the browser if an element that can accept use input gains focus. This is useful when the browser may want to take some action against such events. For example, in case a textfield is focused, the browser may want to show an on-screen keyboard. 2. The browser needs some way to inform the renderer to scroll the currently focused element into the view frame. This is useful when, for instance, the browser resize the frame and the focused element goes out of visible frame. BUG=none TEST=none Review URL: http://codereview.chromium.org/3474007 Patch from Varun Jain <varunjain@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64142 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 64114 - Second attempt to land http://codereview.chromium.org/4003006davemoore@chromium.org2010-10-277-59/+7
| | | | | | | | | | | | | | Added mock implementation of prewarm method TBR: nkostylev@chromium.org BUG=chromium-os:7971 TEST=Login and examine /tmp/login-times-sent Review URL: http://codereview.chromium.org/4133002 TBR=davemoore@chromium.org Review URL: http://codereview.chromium.org/4186005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64140 0039d316-1c4b-4281-b951-d872f2087c98
* Unrevert again r63919: "Part 2 of immutable Extension refactor."mpcomplete@chromium.org2010-10-2737-463/+472
| | | | | | | | | | | | | | | | | | | | | | | | | | (Last landing broke chromeos and chromium linux builder.) I made Extension a refcounted object, and privitized the existing con/destructor and InitFromValue. The only way to get an Extension is to call a factory method. In the next CL, I plan to make the factory method return a const Extension, to guarantee that no one can modify the Extension object after creation. Note: There was a tricky part of this CL because of the difference in semantics between scoped_ptr and scoped_refptr. I had to be careful not to use ptr.release(), since that would result in leaks (an un-Released AddRef). BUG=56558 TEST=no functional change Original Review URL: http://codereview.chromium.org/3982001 TBR=aa Review URL: http://codereview.chromium.org/4119010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64139 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disabling test GPUTest.UITestLaunchedWithOSMesa on linux.apatrick@chromium.org2010-10-272-2/+2
| | | | | | | | | | | | | Test was new in r64122 and failed. http://build.chromium.org/p/chromium/builders/Linux%20Tests%20x64/builds/761/steps/ui_tests/logs/stdio TEST=none BUG=none TBR=kbr@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64138 0039d316-1c4b-4281-b951-d872f2087c98
* Moving the autocomplete unit test to be run as browser tests.jcivelli@google.com2010-10-271-1/+1
| | | | | | | | | | | | | | These tests are creating a new instance of WebKit, which cannot be done in-process (WebKit cannot be started/stoped/started in the same process). BUG=None TEST=Unit-tests and browser tests should work with Webkit CL https://bugs.webkit.org/show_bug.cgi?id=41283 Review URL: http://codereview.chromium.org/4124004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64133 0039d316-1c4b-4281-b951-d872f2087c98
* Fix file URL detection in WebDragDestGtk.dcheng@chromium.org2010-10-271-2/+5
| | | | | | | | | BUG=60804 TEST=Drag links into input boxes. Review URL: http://codereview.chromium.org/4151007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64132 0039d316-1c4b-4281-b951-d872f2087c98
* Try to track down Linux perf regressions. TBR=skyjam@chromium.org2010-10-271-1/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64131 0039d316-1c4b-4281-b951-d872f2087c98
* Adds suppression for leak.sky@chromium.org2010-10-271-3/+13
| | | | | | | | | BUG=60958 TEST=none Review URL: http://codereview.chromium.org/4119012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64130 0039d316-1c4b-4281-b951-d872f2087c98
* sync: hide encryption tabstriptim@chromium.org2010-10-271-15/+16
| | | | | | | | | BUG=59631 TEST=open configure dialog, note no 'Data Type'/'Encryption' tabstrip. Review URL: http://codereview.chromium.org/4155006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64127 0039d316-1c4b-4281-b951-d872f2087c98
* In ImportantFileWriter, print out the error code/message on failure.thestig@chromium.org2010-10-271-6/+5
| | | | | | | | BUG=none TEST=more useful log messages Review URL: http://codereview.chromium.org/4187003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64126 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 62695 - Revert 62644 - During shutdown delete any pending tasks if ↵thestig@chromium.org2010-10-271-2/+2
| | | | | | | | | | | | running under Heapchecker. BUG=50345 TEST=Suppression no longer gets used. Original Review URL: http://codereview.chromium.org/3791006 Revert Review URL: http://codereview.chromium.org/3779008 Review URL: http://codereview.chromium.org/4111005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64125 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fix broken borders in gtk-theme in incognito mode.erg@google.com2010-10-271-12/+13
| | | | | | | | | | | | | We generating some tints after we computed other values that used those tints. We also used the current color instead of the default colors (the frame image was the default color). BUG=52815 TEST=In gtk mode, open an incognito window. Look at the border. The color should be continuous. (Some themes require taking a screenshot and look at the color magnified to see the previous bug.) Review URL: http://codereview.chromium.org/4168004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64123 0039d316-1c4b-4281-b951-d872f2087c98
* ui_tests run with --use-gl=osmesa so they use the OSMesa software renderer ↵apatrick@chromium.org2010-10-278-31/+137
| | | | | | | | | | | | | for GL. This to ensure that ui_tests run consistently regardless of the GPU capabilities, or absense, of the box they run on. TEST=try BUG=none Review URL: http://codereview.chromium.org/4138003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64122 0039d316-1c4b-4281-b951-d872f2087c98
* Fix destruction order of ContextGroupgman@chromium.org2010-10-274-7/+11
| | | | | | | | | TEST=none BUG=60777 Review URL: http://codereview.chromium.org/4153003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64121 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 64094 - Mac: turn on file access checks for the UI thread.nick@chromium.org2010-10-271-1/+1
| | | | | | | | | | | | BUG=60211 TEST=bots Review URL: http://codereview.chromium.org/4144003 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/4208001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64120 0039d316-1c4b-4281-b951-d872f2087c98
* Specify client version 2 when creating EGL contexts.apatrick@chromium.org2010-10-271-2/+6
| | | | | | | | | | | | | It was doing this already for SecondaryEGLContext but not for NativeViewEGLContext, which made it default to EGL version 1 on non-ANGLE EGL implementations. I also fixed ANGLE upstream in r468 so it fails to create a context unless version 2 is explicitly requested. TEST=try BUG=53823 Review URL: http://codereview.chromium.org/4089006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64119 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 64070 - Revert 64065 - testserver.py listens on ephemeral ports by ↵cbentzel@chromium.org2010-10-275-69/+75
| | | | | | | | | | | | | | | | | | | | | default. If --port is specified on the command line, testserver.py will listen on that port, otherwise it will listen on an ephemeral port. If --startup_pipe is specified, the port number is written to the pipe as a 2 byte unsigned int in host order. TestServer by default spawns testserver.py to listen on an ephemeral port and reads the port value from the pipe. If necessary, the port can still be fixed using TestServer::ForcePort, but that will hopefully get deprecated quickly. BUG=56814 TEST=try bots pass Review URL: http://codereview.chromium.org/3549003 TBR=cbentzel@chromium.org Review URL: http://codereview.chromium.org/4165004 TBR=cbentzel@chromium.org Review URL: http://codereview.chromium.org/4146008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64118 0039d316-1c4b-4281-b951-d872f2087c98
* Change locale uitests so that the language environment will be restored even ↵csilv@chromium.org2010-10-271-6/+4
| | | | | | | | | | if an assertion occurs in SetUp(). BUG=59337 TEST=Verify locale uitests stay green. Review URL: http://codereview.chromium.org/4021004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64117 0039d316-1c4b-4281-b951-d872f2087c98
* Disable find_in_page.FindMatchTests.testSearchWithinSpecialURLnirnimesh@chromium.org2010-10-271-0/+2
| | | | | | | | | BUG=60953 TEST= Review URL: http://codereview.chromium.org/4151006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64116 0039d316-1c4b-4281-b951-d872f2087c98
* Don't load the plugins right away when saving the plugin preferences, so ↵jam@chromium.org2010-10-273-6/+14
| | | | | | | | | that we don't slow down startup. BUG=60942 Review URL: http://codereview.chromium.org/4145006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64115 0039d316-1c4b-4281-b951-d872f2087c98
* Second attempt to land http://codereview.chromium.org/4003006davemoore@chromium.org2010-10-277-7/+59
| | | | | | | | | | | Added mock implementation of prewarm method TBR: nkostylev@chromium.org BUG=chromium-os:7971 TEST=Login and examine /tmp/login-times-sent Review URL: http://codereview.chromium.org/4133002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64114 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanups in the chromotocol code.sergeyu@chromium.org2010-10-2733-453/+479
| | | | | | | | | | | | | | | 1) Renamed ChromotingServer to ChromotocolServer. 2) Renamed ChromotingConnection to ChromotocolConnection. 3) Added documentation for ChromotocolServer. 4) Fixed methods names in ChromtocolConnection. 5) Removed some unncessary references to media/*. BUG=None TEST=None Review URL: http://codereview.chromium.org/4105002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64113 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Fixed memory leak in CacheInvalidationPacketHandler.akalin@chromium.org2010-10-275-5/+111
| | | | | | | | | | | | | Added unit tests. Added NonThreadSafe member. BUG=None TEST=New unit tests Review URL: http://codereview.chromium.org/4204001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64111 0039d316-1c4b-4281-b951-d872f2087c98
* Reenable remoting_unittests under TSan.sergeyu@chromium.org2010-10-272-1/+5
| | | | | | | | | | | | | Increase timeouts for remoting_unittests in valgrind. Reenable remoting_unittests under TSan on Linux. The test is still disabled on Windows. BUG=57832 TEST=None Review URL: http://codereview.chromium.org/4106004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64109 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 64104 - Prewarm google auth urldavemoore@chromium.org2010-10-276-56/+7
| | | | | | | | | | | | | | | | As cros has no system level dns cache, every login needs to access google.com for the first time. This change causes us to preconnect to the login url while the login panel is being shown. BUG=chromium-os:7971 TEST=Login and examine /tmp/login-times-sent Review URL: http://codereview.chromium.org/4003006 TBR=davemoore@chromium.org Review URL: http://codereview.chromium.org/4197003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64108 0039d316-1c4b-4281-b951-d872f2087c98
* media_bench output width and height of mediafbarchard@chromium.org2010-10-271-3/+8
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/4128006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64107 0039d316-1c4b-4281-b951-d872f2087c98
* Fix race condition in histogram renderingdavemoore@chromium.org2010-10-272-12/+12
| | | | | | | | | | | BUG=None TEST=None - There was a race where if the first host responded too quickly we would fail to count it. This is fixed by incrementing the count of hosts before sending the message. I also allow the number of pending hosts to fall below 0. In addition I lock during the increment (which wasn't being done). Plus I fixed some spelling errors. Review URL: http://codereview.chromium.org/4121007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64106 0039d316-1c4b-4281-b951-d872f2087c98
* Do not launch Google Talk until it has been opened once.seh@chromium.org2010-10-272-1/+13
| | | | | | | | | | BUG=none TEST=launch on a ChromeOS device. Gmail and Supermoles chats should open in on-page moles until the extension has been launched once. Delete the localStorage boolean hasOpenedInViewer to reset. Review URL: http://codereview.chromium.org/4110005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64105 0039d316-1c4b-4281-b951-d872f2087c98
* Prewarm google auth urldavemoore@chromium.org2010-10-276-7/+56
| | | | | | | | | | | | | As cros has no system level dns cache, every login needs to access google.com for the first time. This change causes us to preconnect to the login url while the login panel is being shown. BUG=chromium-os:7971 TEST=Login and examine /tmp/login-times-sent Review URL: http://codereview.chromium.org/4003006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64104 0039d316-1c4b-4281-b951-d872f2087c98
* Grab keyboard input when showing domui/views menu.oshima@chromium.org2010-10-274-29/+41
| | | | | | | | | | BUG=chromium-os:8118 TEST=manual: open more than 2 windows, then open wrench menu and hit alt-tab. It will not switch to other window. Review URL: http://codereview.chromium.org/4189002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64103 0039d316-1c4b-4281-b951-d872f2087c98
* Pass Chrome's UA with chromeframe appended at the end in the user agent ↵ananta@chromium.org2010-10-271-6/+9
| | | | | | | | | | | | | | passed in ChromeFrame requests initiated in IE. Fixes bug http://b/issue?id=3022937 Bug=3022937 Review URL: http://codereview.chromium.org/4202003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64102 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Added unittests for XmppConnectionGenerator.akalin@chromium.org2010-10-274-21/+122
| | | | | | | | | | | Removed unused public function. BUG=None TEST=notifier_unit_tests Review URL: http://codereview.chromium.org/4141004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64101 0039d316-1c4b-4281-b951-d872f2087c98
* Don't verify thread IO safety on ChromeOS for now.evan@chromium.org2010-10-272-2/+2
| | | | | | | | | | | It needs someone to sit down and look through the bugs it finds; I didn't intend to turn it on for ChromeOS. BUG=60211 Review URL: http://codereview.chromium.org/4152006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64100 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable the disabled stop/reload button after hovering briefly (1.35 ↵pkasting@chromium.org2010-10-276-80/+172
| | | | | | | | | | seconds, to be exact). BUG=58185 TEST=Navigate to cnn.com. Hover the stop button. After it changes to a disabled stop button, wait, and it should change to an enabled reload button. Review URL: http://codereview.chromium.org/4116003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64099 0039d316-1c4b-4281-b951-d872f2087c98
* Fix up SharedMemory implementation so that it is more equivalent on Windows ↵dmaclach@chromium.org2010-10-2732-226/+246
| | | | | | | | | | | | | vs Posix and enforces exclusive creates. Clean up some naming to make it clearer what size you are getting by changing max_size to created_size. BUG=NONE TEST=BUILD Review URL: http://codereview.chromium.org/4034006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64097 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/4154003/show for Timo.sky@chromium.org2010-10-271-4/+13
| | | | | | | | | BUG=59679 TEST=see bug Review URL: http://codereview.chromium.org/4206001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64096 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Don't crash in -[AcceleratedPluginView drawView] when the RWHVMac went ↵thakis@chromium.org2010-10-271-3/+5
| | | | | | | | | | | | | away. I should've added this check in http://codereview.chromium.org/3534010 but failed to do so. BUG=58902 TEST=fewer crashes on the crash servers Review URL: http://codereview.chromium.org/4141005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64095 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: turn on file access checks for the UI thread.thakis@chromium.org2010-10-271-1/+1
| | | | | | | | | BUG=60211 TEST=bots Review URL: http://codereview.chromium.org/4144003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64094 0039d316-1c4b-4281-b951-d872f2087c98
* Allow constrained dialog to resize by not using fixed size.xiyuan@chromium.org2010-10-271-1/+1
| | | | | | | | | BUG=chromium-os:6945 TEST=Verify fix for chromium-os:6945. Review URL: http://codereview.chromium.org/4094004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64093 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for OnClose event in ActiveX and NPAPIamit@chromium.org2010-10-278-2/+124
| | | | | | | | | | | | | | | Provide event notification for window.close called within ActiveX and NPAPI. Currently this is handled in ActiveDocument to close the popups. In ActiveX and NPAPI plugin we just fire an event as it is upto the container to decide what's the right thing to do. BUG=59664 TEST=New tests ChromeFrameTestWithWebServer.FullTabModeIE_WindowClose, ChromeFrameTestWithWebServer.FullTabModeFF_WindowClose Review URL: http://codereview.chromium.org/4152005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64092 0039d316-1c4b-4281-b951-d872f2087c98
* Move speech input behind a flag for M8 beta and stable.satish@chromium.org2010-10-275-1/+10
| | | | | | | | | | | | The speech input feature (http://code.google.com/p/chromium/issues/detail?id=53598) is work in progress and it should only be enabled in the dev channel but behind a flag for beta and stable. After this change gets merged with the beta branch I'll roll it back on the trunk. BUG=60918 TEST=browser_tests --gtest_filter=SpeechInputBrowserTest.* Review URL: http://codereview.chromium.org/4096005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64091 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the TTS completion callback in a generic way so that the callbackdmazzoni@chromium.org2010-10-2724-66/+607
| | | | | | | | | | | | always gets called. Support queueing utterances. Add new extension api tests to test this logic with mocks. BUG=none TEST=Adds new browser tests. Review URL: http://codereview.chromium.org/3999004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64089 0039d316-1c4b-4281-b951-d872f2087c98
* Marks NewTabUITest.FLAKY_NTPHasThumbnails as flaky.sky@chromium.org2010-10-271-1/+2
| | | | | | | | | | BUG=60946 TEST=none TBR=cbentzel@chromium.org Review URL: http://codereview.chromium.org/4193004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64088 0039d316-1c4b-4281-b951-d872f2087c98