| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/40171
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Split the lines >80 cols. (Part 1)
Review URL: http://codereview.chromium.org/39206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
between Windows and Mac.
Review URL: http://codereview.chromium.org/40180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39212
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/40174
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
different - the diagonal lines are anti-aliased in a slightly different shade, and the text is drawn differently.
Review URL: http://codereview.chromium.org/39053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
not the enclosing frame." The diffrence between this one and the previous version
of this patch is the addition of test_webview_delegate.
BUG=1686837
Review URL: http://codereview.chromium.org/39163
Review URL: http://codereview.chromium.org/40175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
https://bugs.webkit.org/show_bug.cgi?id=24299
This is everything up to "not supposed to be using STL container classes."
Review URL: http://codereview.chromium.org/40122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
now, so everytime this appears was dead code.
Review URL: http://codereview.chromium.org/39200
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
several layout tests that required these strings. We need to rebaseline them because the strings Chromium uses differ from the strings WebKit.org uses.
Review URL: http://codereview.chromium.org/40170
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
scrolled. Basically, when a spell check language changes, it is added to the accept languages list so that it is remembered later. However, when the list gets scrolled, it keeps adding all the languages it scrolled. So, I decided to fix this by adding only the latest language selected as the spell check dictionary language in the drop down.
Issue=8374
Review URL: http://codereview.chromium.org/40145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
RenderWidget, since that could lead to the terminateworker message being dropped.
Review URL: http://codereview.chromium.org/39176
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
all platforms. Also, we sort dictionary keys by value so
the path moved.
BUG=8339
Review URL: http://codereview.chromium.org/39174
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/40177
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I changed two instances of kUnrelatedControlLargeVerticalSpacing to
the shorter kUnrelatedControlVerticalSpacing.
Tested on XP (Luna, no theme) and Vista Aero.
BUG= 5511
R= ben
Review URL: http://codereview.chromium.org/40148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Committed on behalf of Craig Schlenter.
http://codereview.chromium.org/40158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=nsylvain
Review URL: http://codereview.chromium.org/39210
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=eroman
Review URL: http://codereview.chromium.org/39198
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39203
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
enclosing frame.
BUG=1686837
Review URL: http://codereview.chromium.org/39163
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/40168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
../third_party/WebKit/WebCore/dom/Document.cpp don't stop the build.
Review URL: http://codereview.chromium.org/39155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
needed rebaseline in the mean time. the original baselines where taken
with the wrong scrollbar, font, etc. settings. So both the image and the text
expects were wrong.
Review URL: http://codereview.chromium.org/39195
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39196
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
Review URL: http://codereview.chromium.org/39197
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39193
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=8338
TEST=covered by unit tests
Review URL: http://codereview.chromium.org/39175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
that trigger this rule at the moment.
Review URL: http://codereview.chromium.org/39192
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The first one is one you removed yesterday, you might
want to take a look at it.
The second one started being flaky about at the same
time, but I don't see the reason.
Review URL: http://codereview.chromium.org/39194
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
It simply does not work. It is testing the exact time between a key
event and a search event. A GC or any other variation at an unlucky
time will make this fail.
Review URL: http://codereview.chromium.org/40165
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- large set of keyboard tests now passing thanks to avi's cl the other day.
- one test only fails in debug, mark as such.
- one test timed out 16 of the last 20 runs, marking as timeout or pass.
Review URL: http://codereview.chromium.org/39190
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tests, and it might have caused a unit tests failure.
purify error : UMR in URLRequest::response_data_file
failing test:
URLFetcherHeadersTest.Headers:
c:\b\slave\chromium-rel-builder\build\src\chrome\browser\net\url_fetcher_unittest.cc(222): error: Value of: source->response_headers()->GetNormalizedHeader("cache-control", &header)
Actual: false
Expected: true
c:\b\slave\chromium-rel-builder\build\src\chrome\browser\net\url_fetcher_unittest.cc(223): error: Value of: header
Actual: ""
Expected: "private"
c:\b\slave\chromium-rel-builder\build\src\chrome\browser\net\url_fetcher_unittest.cc(181): error: Value of: response_code
Actual: 404
Expected: 200
Release only.
Review URL: http://codereview.chromium.org/39191
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
on the global object in event handling code.
Review URL: http://codereview.chromium.org/39187
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
supporting icon scaffolding.
Review URL: http://codereview.chromium.org/39132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The previous prototype took only a std::string, unless you used the less convenient output parameter version. This required copying char* input to a std::string. Using a StringPiece the input will be implicitly both std::string and char* without any copying. This helps especially on Linux, where all input we get will be in utf8 char*.
Review URL: http://codereview.chromium.org/40106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- Remove the invalid import os statement (PRESUBMIT.py shouldn't import anything).
- Add excluded paths. Mostly third parties.
- Increase what is considered a source file.
- Don't check for DO NOT SUBMIT on upload.
Review URL: http://codereview.chromium.org/28219
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem seems to be an error when overwriting file which is in use
(that's how EvictFileFromSystemCache works on Windows). So I used
a standard workaround for such Windowsic problems and created a wrapper
which retries 10 times. Similar code was there before my porting patch.
TBR=agl
Review URL: http://codereview.chromium.org/40160
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- Methods of RenderView are called only on render thread in DevToolsAgent(earlier routing_id() was called on IO thread)
BUG=8378
Review URL: http://codereview.chromium.org/39182
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This test failed for a period of time on Linux because of a bad V8
revision.
Review URL: http://codereview.chromium.org/39181
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27240
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
terminate because it contains exponential regexps. It is safe to
disable because we run the same tests (sans the nonterminating ones)
as part of the v8 tests.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10977 0039d316-1c4b-4281-b951-d872f2087c98
|