summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* This adds some plumbing for propagating the status and error code of a ↵gspencer@chromium.org2010-12-1462-238/+560
| | | | | | | | | | | | | | | | | | | | | renderer process that went away so that we can tell at the UI level what happened to the tab: did it crash, or was it killed by the OOM killer (or some other reason). This is in preparation for implementing a new UI for when a process is killed by the OOM on ChromeOS which handles it differently from a crash. Most of the changes are modifications of the argument list to include a status and error code for the exited process, but in addition the following was done: - Changed the name of DidProcessCrash to GetTerminationStatus. - Added TerminationStatus enum in process_util.h, so it can be used as the status returned by GetTerminationStatus. - Improved process_util_unittest to actually test for crashing and terminated processes on all platforms. - Added a new notification for renderers that were killed. - Added error code information to crash notification. - Added status and error code information to renderer IPC message for RenderViewGone. - Added a UMA histogram count for number of renderer kills. BUG=http://crosbug.com/8505 TEST=ran new unit test. Test passes on try servers. Review URL: http://codereview.chromium.org/5172009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69082 0039d316-1c4b-4281-b951-d872f2087c98
* Cookies tree js code touch up.xiyuan@chromium.org2010-12-141-5/+16
| | | | | | | | | BUG=none. TEST=No behavior change. Review URL: http://codereview.chromium.org/5685008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69081 0039d316-1c4b-4281-b951-d872f2087c98
* Add crash 66741 to the known crashes.csilv@chromium.org2010-12-141-0/+3
| | | | | | | | BUG=66741 TEST=none Review URL: http://codereview.chromium.org/5746006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69080 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r68893 after fixing allowing blocking IO on shutdown.willchan@chromium.org2010-12-145-0/+29
| | | | | | | | | | | | | | | | | | This time I just turned off the checking for Chrome/Windows because Chrome/Windows shutdown is a clusterf***. TODO(willchan): Give a shit about Windows, get a machine that runs Windows, debug Chrome shutdown on Windows, enable this ThreadRestrictions for Chrome/Windows. Consider PlatformThread::Join() to be blocking IO. Marks PlatformThread::Join() as blocking IO using ThreadRestrictions. Whitelists existing spots where we join on the UI/IO threads. Also noteworthy is I allow blocking IO on shutdown. BUG=65530, 66077, 66082 TEST=existing Review URL: http://codereview.chromium.org/5750003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69079 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust perf expectations after v8 and ref roll.chase@chromium.org2010-12-141-10/+10
| | | | | | | | | | | | | | | | | | | | | mac-release-10.5/intl1/times/t mac-release-10.5/intl2/times/t mac-release-10.5/startup/times/t mac-release-10.5/v8_benchmark/score/score mac-release-10.6/v8_benchmark/score/score vista-release-dual-core/v8_benchmark/score/score xp-release-dual-core/intl1/times/t xp-release-dual-core/intl2/times/t xp-release-dual-core/morejs/times/t xp-release-dual-core/v8_benchmark/score/score BUG=none TEST=perf steps are green TBR=nsylvain@chromium.org Review URL: http://codereview.chromium.org/5781007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69078 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Eliminiate @interface NoOp from base.thakis@chromium.org2010-12-141-17/+3
| | | | | | | | | | | I don't think eliminating _all_ objc from base is the right answer -- the remaining objc has to move out of the static libbase. But if it's easy to have fewer objc to move, that's good. BUG=46929 TEST=One fewer duplicate symbol is reported when loading the pdf plugin. Review URL: http://codereview.chromium.org/5716007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69077 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ResourceMessageFilter to RenderMessageFilter, since that's what it ↵jam@chromium.org2010-12-1427-323/+317
| | | | | | | | actually is. I will add a ResourceMessageFilter just for resource IPCs in a future change. Review URL: http://codereview.chromium.org/5701004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69076 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix.evan@chromium.org2010-12-141-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69075 0039d316-1c4b-4281-b951-d872f2087c98
* webkit: use string16 in ContextMenuParamsevan@chromium.org2010-12-1410-11/+18
| | | | | | | | | BUG=23581 TEST=compiles Review URL: http://codereview.chromium.org/5712003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69074 0039d316-1c4b-4281-b951-d872f2087c98
* Fix extension packer command-line code for Mac. Instead of blocking in a ↵andybons@chromium.org2010-12-137-101/+109
| | | | | | | | | | | | | janky way by running the message loop, I added an option to run the extension packer job synchronously. One thing to note as it pertains to the bug report is that the path must be fully qualified. ~/ for home directories doesn't work for me. BUG=65645 TEST=none Review URL: http://codereview.chromium.org/5703004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69073 0039d316-1c4b-4281-b951-d872f2087c98
* Add a browser test for safebrowsing service.lzheng@chromium.org2010-12-137-35/+455
| | | | | | | | BUG=none TEST=safe_browsing_service_browsertest Review URL: http://codereview.chromium.org/5544008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69072 0039d316-1c4b-4281-b951-d872f2087c98
* Added 'dry run' tag to the print job, to test proxy health without wasting ↵gene@google.com2010-12-1310-9/+76
| | | | | | | | | | | paper/ink. BUG=none TEST=Make sure 'dry run' jobs does not get printed. Review URL: http://codereview.chromium.org/5736004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69071 0039d316-1c4b-4281-b951-d872f2087c98
* An attempt to fix the flakiness with the ChromeFrame Javascript window open ↵ananta@chromium.org2010-12-131-1/+1
| | | | | | | | | | | | | test on IE9. We receive multiple NavigateComplete notifications at times. BUG=none TEST=none Review URL: http://codereview.chromium.org/5703005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69070 0039d316-1c4b-4281-b951-d872f2087c98
* emacs: use curl to fetch trybot output, improve mac performanceevan@chromium.org2010-12-132-209/+1877
| | | | | | | | | | | | | By using a command to fetch trybot output, we can pipe the result through a sed script that trims down the Mac output. This makes the output small enough so that compilation-mode can handle it. While I'm at it, I can use file:/// URLs to unify more of the "real" and "test" code paths. Review URL: http://codereview.chromium.org/5737005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69069 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix stuck hover state in bookmark buttonsail@chromium.org2010-12-131-10/+42
| | | | | | | | | | | | | | | | Bookmark buttons would get stuck with a hover state if they were obscured while the mouse was inside the button. The problem was that the hover state only tracked the mouse entered and exited events. Unfortunately if the button is obscured because it has been removed from the window then a mouse exited event is not sent. Fix was to also update the hover state in the -[NSCell resetCursorRect:inView:] event. This change also improves the mouse tracking code by checking if the mouse is already in over the button. BUG=27073 TEST=Changed tabs with the mouse over a bookmark button. Verified that the hover effect was no longer there after closing the new tab. Did a similar test by entering full screen. Verified that the hover effect was no longer there. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69068 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux] Workaround issue 45478: IME dysfunctional after BACKSPACEsuzhe@google.com2010-12-132-15/+38
| | | | | | | | | | | | | | The reason of the issue is ibus intercepts all key events and does not forward them to chrome at all, while webkit relies on key events to reset one of its internal flag. This CL just fakes key down/up events if the input method intercepts all key events. BUG=45478 TEST=see bug report. Review URL: http://codereview.chromium.org/5787004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69067 0039d316-1c4b-4281-b951-d872f2087c98
* Improve filtering for false positive crashesamit@chromium.org2010-12-133-61/+42
| | | | | | | | | | | | | | | ...by inspecting if the module with the crash has the topmost handler in the SEH chain. If that's the case then the exception will very likely be handled. This covers the case of IsBadReadPtr adn family without any special code. It also lets us address IsValidInterface, an internal helper in urlmon. BUG=64348 TEST=covered by existing unit tests Review URL: http://codereview.chromium.org/5622006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69066 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI: Rename PasswordsException* to PasswordManager*.jhawkins@google.com2010-12-1311-82/+83
| | | | | | | | | BUG=59282 TEST=none Review URL: http://codereview.chromium.org/5810002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69065 0039d316-1c4b-4281-b951-d872f2087c98
* Single deinlining in first_run.{cc,h}erg@google.com2010-12-132-8/+18
| | | | | | | | | | | (This used to break chrome_frame linking, but after rebasing, there doesn't seem to be any issue.) BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5708004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69064 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI: Fix Shift+Ctrl selection of the list for Windows.arv@chromium.org2010-12-131-1/+2
| | | | | | | | | | | | | BUG=64964 TEST=1. On Windows go to Bookmarks manager. 2. Go to a folder with multiple bookmarks. 3. Select a bookmark 4. Hold down Shift and Ctrl. Click on another bookmark. All the bookmarks between the items should also be selected. Review URL: http://codereview.chromium.org/5780002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69063 0039d316-1c4b-4281-b951-d872f2087c98
* Update OTR icon; deeper shadows match the other platforms better.avi@chromium.org2010-12-131-189/+261
| | | | | | | | | BUG=none TEST=OTR icon's glasses are near-black, not gray Review URL: http://codereview.chromium.org/5808002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69062 0039d316-1c4b-4281-b951-d872f2087c98
* mac output cleanup script: fix match for "nothing to do" make outputevan@chromium.org2010-12-131-1/+1
| | | | | | | | Shoulda written a test! Review URL: http://codereview.chromium.org/5739006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69061 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug where icon is not displayed in extension install bubblesaa@chromium.org2010-12-134-8/+22
| | | | | | | | | | | | when installed from store. BUG=65346 TEST=Install any extension from the web store. Should see icon in install success bubble. Review URL: http://codereview.chromium.org/5690004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69060 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Remove obsolete dump_signature.py.thestig@chromium.org2010-12-132-57/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5721004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69058 0039d316-1c4b-4281-b951-d872f2087c98
* Fix problems from my change to IndexedDBDispatcherHost.jam@chromium.org2010-12-131-0/+20
| | | | | | | TBR=jorlow Review URL: http://codereview.chromium.org/5696003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69057 0039d316-1c4b-4281-b951-d872f2087c98
* Update expectations after v8 and ref roll.chase@chromium.org2010-12-131-14/+14
| | | | | | | | | | | | | | | | | | | | | | | | | mac-release-10.5/morejs/times/t mac-release-10.6/dhtml/times/t mac-release-10.6/morejs/times/t mac-release-10.6/moz/times/t vista-release-dual-core/intl1/times/t vista-release-dual-core/morejs/times/t vista-release-dual-core/moz/times/t xp-release-dual-core/moz/times/t xp-release-dual-core/moz/total_byte_b/IO_b xp-release-dual-core/moz/total_byte_r/IO_r xp-release-dual-core/moz/total_op_b/IO_op_b xp-release-dual-core/moz/total_op_r/IO_op_r xp-release-dual-core/moz/vm_peak_b/vm_pk_b xp-release-dual-core/moz/vm_peak_r/vm_pk_r BUG=none TEST=perf waterfall steps are green TBR=nsylvain@chromium.org Review URL: http://codereview.chromium.org/5782002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69056 0039d316-1c4b-4281-b951-d872f2087c98
* emacs: conditionalize behavior based on the OS we're parsingevan@chromium.org2010-12-131-33/+48
| | | | | | | | | We don't want to run the (expensive) Windows path fixup regex on the (verbose) Mac output. Review URL: http://codereview.chromium.org/5774003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69055 0039d316-1c4b-4281-b951-d872f2087c98
* fix bad mergejam@chromium.org2010-12-131-1/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69054 0039d316-1c4b-4281-b951-d872f2087c98
* Fix problem with my last change ↵jam@chromium.org2010-12-131-0/+1
| | | | | | | | | (http://src.chromium.org/viewvc/chrome?view=rev&revision=69050). TBR=jorlow Review URL: http://codereview.chromium.org/5809002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69053 0039d316-1c4b-4281-b951-d872f2087c98
* Make IndexedDBDispatcherHost be a message filter and move its messages into ↵jam@chromium.org2010-12-1322-1515/+1307
| | | | | | | | a separate file. Review URL: http://codereview.chromium.org/5680007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69050 0039d316-1c4b-4281-b951-d872f2087c98
* Make DOMStorageDispatcherHost be a message filter (and rename it ↵jam@chromium.org2010-12-1331-747/+771
| | | | | | | | accordingly). It now derives from BrowserMessageFilter and hence gets message dispatching to different threads for free. Review URL: http://codereview.chromium.org/5722003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69049 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFillField::set_heuristic_type: avoid redundant logic in DCHECKisherman@chromium.org2010-12-131-3/+6
| | | | | | | | | | | Just a bit of code cleanup BUG=none TEST=none Review URL: http://codereview.chromium.org/5241001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69048 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFillProfile: don't replicate logic in Clone()isherman@chromium.org2010-12-132-12/+13
| | | | | | | | | BUG=none TEST=unit_tests --gtest_filter=AutoFillProfileTest.Clone Review URL: http://codereview.chromium.org/5608004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69047 0039d316-1c4b-4281-b951-d872f2087c98
* Verify that previously saved username/password shows up in Regular Window, ↵nirnimesh@chromium.org2010-12-131-0/+30
| | | | | | | | NTP and incognito window. Review URL: http://codereview.chromium.org/5675001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69046 0039d316-1c4b-4281-b951-d872f2087c98
* Remove layer of indirection in PhoneNumberTestisherman@chromium.org2010-12-132-36/+11
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5728005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69045 0039d316-1c4b-4281-b951-d872f2087c98
* Pin the Module after we register a hook.mad@google.com2010-12-131-0/+6
| | | | | | | | | | This shouldn't be needed since the hook machinery is responsible to load our DLL when it's needed, and we only need to register hooks for threads running in the IE process, but we received a dump for a user where the Broker crashed because of a call from the hook machinery to an unmapped address, and this address is within a range where we have seen the ceee_ie dll sit in other debugging session, and in the crash dump, the ceee_ie dll isn't part of the module list. BUG=66434 TEST=None Review URL: http://codereview.chromium.org/5778002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69044 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in instant where we wouldn't initially tell the page thesky@chromium.org2010-12-135-16/+76
| | | | | | | | | | | | | | | | real bounds of the omnibox. The bug occurred because we didn't initially send down the bounds so that when the init script ran it sent a bounds of 0x0. When the browser then processed the response that the page supported instant it incorrectly assumed the page was told the right bounds. BUG=65463 TEST=see bug (specifcally comment 5). this is now covered by an interactive ui test as well. Review URL: http://codereview.chromium.org/5697003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69043 0039d316-1c4b-4281-b951-d872f2087c98
* Don't create bogus 's' key in registry during Chrome Frame registrationgrt@chromium.org2010-12-131-1/+1
| | | | | | | | BUG=none TEST=register Chrome Frame on a fresh machine and note that bogus key HKCR\MIME\Database\s is no longer created. Review URL: http://codereview.chromium.org/5810001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69042 0039d316-1c4b-4281-b951-d872f2087c98
* Even more virtual method deinlining.erg@google.com2010-12-13129-407/+949
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5741001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69041 0039d316-1c4b-4281-b951-d872f2087c98
* Added facility to compile Mesa EGL implementation. Fixed a few issues so ↵alokp@chromium.org2010-12-134-0/+77
| | | | | | | | that it can be compiled against standard EGL 1.4 headers. Review URL: http://codereview.chromium.org/5750002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69040 0039d316-1c4b-4281-b951-d872f2087c98
* Make shader and program object lifetimes match OpenGL ES spec.gman@chromium.org2010-12-1310-97/+429
| | | | | | | | | TEST=unit tests BUG=65705 Review URL: http://codereview.chromium.org/5676003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69039 0039d316-1c4b-4281-b951-d872f2087c98
* Add compile assertions to enforce the sizes of all structs and enums in the ↵dmichael@google.com2010-12-1342-114/+402
| | | | | | | | | | | | | | | | C API. Adjust some structs to make their sizes consistent across architectures. Note that some structs contain pointers, so are difficult to make consistent between 32-bit and 64-bit. Those types are in test_struct_sizes.c. Other types have a compile assertion immediately after their definition. This was broken off from a bigger CL: http://codereview.chromium.org/5340003/ BUG=61004,92983 TEST=test_struct_sizes.c, compile assertions throughout See this CL for the code that helped generate the static assertions and find affected interfaces: http://codereview.chromium.org/5730003 Review URL: http://codereview.chromium.org/5674004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69038 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded browser_thread.h usage.thestig@chromium.org2010-12-1354-71/+46
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5676004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69037 0039d316-1c4b-4281-b951-d872f2087c98
* touchui: Fix painting issues caused by the X message pump.sadrul@chromium.org2010-12-132-5/+11
| | | | | | | | | | | | | | | | WidgetGtk has two GtkWidgets, |widget_|, and |window_contents_| inside it. |window_contents_| is the widget that receives the GTK+ expose events and shows up on top of |widget_|. However, RenderWidgetHostViewViews paints on |widget_|s window, because |widget_| is considered as the NativeView. So change native_view() to return |window_contents_| instead of |widget_| so that the correct canvas is used for painting. BUG=None TEST=Webpages show up correctly with the X message pump. Review URL: http://codereview.chromium.org/5776002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69036 0039d316-1c4b-4281-b951-d872f2087c98
* Add 'Delete' key to cookies tree in settings UI.xiyuan@chromium.org2010-12-131-0/+18
| | | | | | | | | BUG=chromium:65320 TEST=Verify fix for chromium:65320 Review URL: http://codereview.chromium.org/5745001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69035 0039d316-1c4b-4281-b951-d872f2087c98
* Add TEXT_PLAIN as a drag and drop target. And accept TEXT_PLAIN as a target ↵pinkerton@chromium.org2010-12-136-29/+99
| | | | | | | | | | | | | at CompleteDrop(). In the function classify the word and make the URL.(Linux) If the drop source is not URL, use the source as plain text and pass it to tab_strip_controller and classify it. To pass if the source is URL or plain text, use is_plain_text flag. (Mac) patch from takano.naoki@gmail.com BUG=42797 TEST= 1. Open any site which has text. (news.google.com) 2. Select 2-3 words of text and drag n drop selected text to tabstrip. 3. Chrome opens a new tab with search results (using selected search engine in preferences). git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69034 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI Settings: UTH: Fix up the Privacy checkboxes text.kmadhusu@chromium.org2010-12-133-10/+8
| | | | | | | | | BUG=63834 TEST=none Review URL: http://codereview.chromium.org/5797001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69033 0039d316-1c4b-4281-b951-d872f2087c98
* [gtk] tabcontents fade-out for instant.estade@chromium.org2010-12-1313-40/+135
| | | | | | | | | BUG=58937 TEST=manual Review URL: http://codereview.chromium.org/5790002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69032 0039d316-1c4b-4281-b951-d872f2087c98
* Make DatabaseDispatcherHost be a message filter so that ↵jam@chromium.org2010-12-1319-605/+465
| | | | | | | | ResourceMessageFilter doesn't have to know about it. Review URL: http://codereview.chromium.org/5757002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69031 0039d316-1c4b-4281-b951-d872f2087c98
* Track the amount of time chrome spends verifying the certificate.mbelshe@chromium.org2010-12-132-1/+15
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5652002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69030 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 05:45:51 +0000