| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Starting at gyp r1717, link_settings no longer propagate outside
shared_library targets. These changes are necessary to fix link_settings
that were poorly specified in the past because of relying on the GYP bug.
Details about the specific changes are documented in:
https://codereview.chromium.org/23557010/
BUG=
R=agl@chromium.org, mark@chromium.org, shess@chromium.org, thakis@chromium.org
Review URL: https://codereview.chromium.org/24078004
Patch from Shezan Baig <sbaig1@bloomberg.net>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=dfalcantara@chromium.org, tedchoc@chromium.org
Review URL: https://codereview.chromium.org/23819012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem should be fixed by now: fake frames are always initialized -
see codec_test.cc.
BUG=167481
R=alexeypa@chromium.org
Review URL: https://codereview.chromium.org/23450034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The installClip functionality seems to be an optimization for the renderer to only render content within a clipped area. This is implemented in Windows, but not on Aura in general. As such logging statements get produced for calling into a non existent feature. Removed the calls into that function since it is "optional" anyways.
BUG=288815
TEST=none
Review URL: https://chromiumcodereview.appspot.com/23883008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
First patch was reverted. Need to destroy BrowserStatusMonitor early on in ChromeLauncherController as BrowserStatusMonitor calls back into ChromeLauncherController during destruction.
Original description:
I'm seeing a crash where we have a dangling TabStripModelObserver,
this is one possible place. At the same time I'm making the class only
look for HOST_DESKTOP_TYPE_ASH browsers.
BUG=286162
TEST=none
R=skuhne@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23464053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also add a SimulateKeyPress helper for browser_tests that takes both a UIEvent |code| and a ui::KeyboardCode.
BUG=284754
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222168
Review URL: https://chromiumcodereview.appspot.com/23542008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Show the Views Textfield context menu on Shift+F10 / Menu key.
Set itself as Textfield's context menu controller on init.
Add a Views Textfield unit test check for the controller.
Note: the menu shows at textfield center, not at the cursor.
(matches IE, file explorer, etc., but not Chrome's Win Textfield)
I'll fix placement in a followup (for separate merge consideration).
BUG=276822
TEST=Shift+F10 and Menu keys trigger the context menu on Win [aura] (all versions) and Linux Aura. Fixes the Menu key on linux_chromeos, but the context menu doesn't seem to trigger on CrOS Shift+F10 (seems ok, not sure that's even wanted).
R=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/24084002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/24055006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
These (in mouseCaptureLost() and setFocus()) have been there
since 2010.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/24040003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(Attempt 2)
BUG=261814
Review URL: https://chromiumcodereview.appspot.com/23962003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Implement the stubs of SyncEngineInitializer and add an initial test for it.
BUG=240165
TEST="unit_tests --gtest_filter=SyncEngineInitializerTest.*"
Review URL: https://chromiumcodereview.appspot.com/23949002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move InspectBackgroundPage() and InspectExtensionHost() from ExtensionService
into extensions::devtools_util.
BUG=157279
TBR=brettw@chromium.org (tab_contents), finnur@chromium.org (webui)
Review URL: https://chromiumcodereview.appspot.com/23923010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
Review URL: https://chromiumcodereview.appspot.com/23464055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
worldview to an "offsets point between characters" worldview.
This more closely aligns with how the omnibox autocomplete code (which is what
this was originally written for) expects things to behave.
Direct fallout from this change:
* An input offset of 0 will always map to an output offset of 0.
* An input offset of (length of string) will always map to the length of the
output string, instead of npos.
* It's possible for multiple unique input offsets to map to a single non-npos
output offset, if they e.g. point to the start and end of a collapsed
sequence.
* Input offsets pointing into the middle of a completely-removed sequence may
not be set to npos if they fall on the boundaries of a subsequence processed
by the transformer. For example, when running FormatUrlWithOffsets() on
"http://user:pass@domain.com/" and directing it to omit both the scheme and
username/password, an input offset of "7" that points in between the scheme
and the username/password will be transformed to an output offset of 0
instead of npos.
Indirect fallout:
* A caller like SearchProvider::NavigationToMatch() will now mark certain
matches as "allowed to be default" that it didn't before. Specifically, if
the user's input string ends at the same point as the desired
|fill_into_edit|, the autocomplete offset will be calculated as (length of
string) instead of npos, and thus the match will be thought of as "inlinable"
and thus "allowed to be default".
BUG=284781
TEST=none
R=msw@chromium.org, willchan@chromium.org
Review URL: https://codereview.chromium.org/23619016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=247077
TEST=none
R=gavinp@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23907007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
R=jennyz,jamescook
TBR=sky
Review URL: https://chromiumcodereview.appspot.com/23819045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=278366
R=bauerb@chromium.org
TEST=manually using the snippet in the bug report
Review URL: https://chromiumcodereview.appspot.com/23799010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
These code was used for "surprise me"/"change wallpaper daily" feature. All the logic is now moved to javascript side. So these code are no longer necessary.
BUG=288942
Review URL: https://chromiumcodereview.appspot.com/23451034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Screenshot: https://docs.google.com/file/d/0B1B1Up4p2NRMM0NtMXpWWmJ5czg/edit?usp=sharing
BUG=257033
TEST=From the avatar menu, click the "Users" button. This should open a top-level window, that looks like the screenshot.
Review URL: https://chromiumcodereview.appspot.com/22918002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=269131
TEST=manual, trybot
Review URL: https://chromiumcodereview.appspot.com/23703012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Enable the native InvalidationServiceAndroid to call into the Java-side InvalidationController in order to register for invalidations for arbitrary objects. Currently only Sync objects can be registered for. This change is motivated by the need to receive invalidations for enterprise user policy on Android.
BUG=263287
Review URL: https://chromiumcodereview.appspot.com/23643002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/23622024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
When getUserMedia is called with |audio.optional.chromeRenderToAssociatedSink = true|, Chrome will start rendering mediastream output to an output device that's associated with the input stream that was opened via getUserMedia.
BUG=276894
Review URL: https://chromiumcodereview.appspot.com/23558010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
While looking at crbug.com/280741 I found that we were scanning over
all earlier transactions for each queued transaction to determine
if it was blocked/unblocked. This would impact that bug by reporting
a transaction as blocked on a running transaction, even if it was
queued behind another blocked transaction.
This CL just eliminates the O(n^2) behavior by building up a set
of locked stores as the queue is scanned.
R=alecflett@chromium.org,dgrogan@chromium.org
BUG=280741
Review URL: https://chromiumcodereview.appspot.com/23889011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=288923
Review URL: https://chromiumcodereview.appspot.com/23480063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=260005
Review URL: https://chromiumcodereview.appspot.com/23454013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On posix systems the cache implements asynchronous IO with a worker pool.
This CL replaces the deprecated WorkerPool with SequencedWorkerPool, and
removes the InFlightIO controller that keeps track of all pending operations.
Now there's no way to wait for operations to complete on production code, but
the cache switched a while ago to only wait on unit tests.
BUG=251774, 268646
TEST=net_unittests
R=gavinp@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23752005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
StopCaching may transition the transaction to passtrhough without taking full
account of the current state. As a result, if the transaction requires any
form of authentication, we may end up with reading_ being true and no response
headers. Now we account for that at the transaction destructor.
BUG=277011
TEST=net_unittests
R=gavinp@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23726023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=xiyuan@chromium.org
BUG=288221
Review URL: https://chromiumcodereview.appspot.com/23708022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some code from chrome/browser|common/extensions will move to the top level
extensions component. Once this happens some dependencies from apps
to chrome can be removed.
This change removes the dependencies to the chrome/browser/extensions
and chrome/common/extensions folders and replaces them with the individual
files.
This will prevent new dependencies being added accidentally and provides
a list of things which need to move from chrome to extensions.
BUG=159366
Review URL: https://chromiumcodereview.appspot.com/23451038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in order to avoid a state inconsistency caused by aynchronous
X property updates.
BUG=286278
TEST=Manually test using Fullscreen API toggling.
R=erg@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23670008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=288085
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/23654028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
window's minimum width.
Previously the lack of consideration of the minimum width resulted in the window ending up partially offscreen when snapped to a smaller width than its minimum width
BUG=None
TEST=SnapSizerTest.*
Review URL: https://chromiumcodereview.appspot.com/23645009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This value is already sent during update checks. Possible values of this
attribute are "dev", "stable", "beta", and "canary".
BUG=245318
TBR=cpu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23570008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, the tests manually changes the current schema to look like
an old schema, then targetted specific implementation functions.
Change to instead create the schema from a golden file, testing that
Init() works correctly, and the expected data is in place.
BUG=none
R=pkotwicz@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/23536014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
By locking the session, the system tray menu gets closed through DestroySystemBubble which does not deactivate the system tray. On the other hand "HideBubbleWithView" is calling DestroySystemBubble as well.
Note that there are also other special cases like UpdateLoginStatusChange which were destroying the system bubble without clearing the activation state (which should be fixed by this CL as well).
BUG=288233
TEST=visual
Review URL: https://chromiumcodereview.appspot.com/23620034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes:
- ScopedRefNPObject is wrapped into scoped_ptr<> when passed as a callback between threads since ScopedRefNPObject's ref-counting is not thread-safe.
- Made HostNPScriptObject::DoGenerateKeyPair a static method to make bouncing between threads safe.
- Switched the completion callbacks passed to the daemon controller and pairing registry to use a weak pointer to HostNPScriptObject.
- Clarified threading semantic of DaemonController::Delegate.
BUG=156257,173509
Review URL: https://chromiumcodereview.appspot.com/23578017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should be unnoticeable, except for improved resolution in places such as window.performance.now().
The feature is enabled if the user is running Canary channel or has manually specified the --enable-high-resolution-time flag. This will only work if the CPU has a non-stop TSC and isn't a broken Athlon processor. UMA data show this is a safe combination.
The flag is propagated to renderer processes so that they know to enable it too.
BUG=158234
Review URL: https://chromiumcodereview.appspot.com/23147002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This will vibrate if the user has set the Android setting to vibrate on touch.
BUG=150151
Review URL: https://chromiumcodereview.appspot.com/23050012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the situation.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/23556010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DumpWithoutCrashing() was looking up DumpProcess instead of
DumpProcessWithoutCrash. The former generates a dialog to restart
chrome while the latter does not. Neither actually crashes the
browser process.
Prior to the CL, anything invoking DumpWithoutCrashing() would appear
to the user as if a crash had occurred, allowing the user to start
a new browser process/window, but leaving the original up and running
(unless the caller subsequently crashed the browser itself).
R= rtenneti@chromium.org, mseaborn@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23484022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
NOTRY=true
TBR=thestig@chromium.org
BUG=181680
Review URL: https://chromiumcodereview.appspot.com/23464064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows opening a file with a packaged app by dropping the file the
app shim's dock icon or app bundle.
A base::FilePath param is added to the Launch and Focus IPC messages and
respective AppShimHandler methods. The file path ultimately is added to
the command line used by OpenApplication.
The shim is modified to set a custom NSApplicationDelegate early in
order to capture the call to application:openFile:. The file name is
saved and sent via LaunchApp in AppShimController::Init.
BUG=168080
TEST=Drag a file onto an app shim.
The app should start and open the file.
Drag a file onto the app shim's dock icon.
The app should open the file.
Review URL: https://chromiumcodereview.appspot.com/21005003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Updated InternetOptionsHandler and network_list.js to observe LoginState
updates, so that using UIAccountTweaks is not the only way to determine
whether or not the current user is owner. This is because |loadTimeData|
may not contain the current user login details if the logged in user type
updates after the UI fills in the UIAccountTweaks info.
BUG=285589
R=stevenjb@chromium.org
Review URL: https://codereview.chromium.org/23466015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/23549025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=288208
Review URL: https://chromiumcodereview.appspot.com/23549023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Also remove TabModel::GetSecurityLevel as it isn't really used
BUG=277135
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/23518005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This send min/max sizing information to the X server on Layout().
BUG=285387
Review URL: https://chromiumcodereview.appspot.com/23461042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
R=jamesr@chromium.org
Review URL: https://codereview.chromium.org/23902021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This updates Database::AddMetric() to use DLOG(ERROR)
instead of LOG(ERROR) when discarding invalid metrics (e.g.
page load times that exceed 15 minutes).
BUG=none
Review URL: https://chromiumcodereview.appspot.com/23514046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222383 0039d316-1c4b-4281-b951-d872f2087c98
|