| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1703014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=42877
Review URL: http://codereview.chromium.org/1763021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
over a non-folder bookmark in the bookmark bar.
BUG=None.
TEST=Pop up a folder bookmark item on the bookmark bar then mouse over a non-folder bookmark and verify that the old folder menu is dismissed.
Review URL: http://codereview.chromium.org/1752020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
directly from upstream. FYI licenses.py is still complaining about missing README.chromium for SPECIAL_CASES.
Review URL: http://codereview.chromium.org/1712014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1712020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
testDownloadNoHistory,testRedirectHistory -- from Deepak.
Also, move _DownloadAndWaitForStart (re-used by the new tests) to a common
location.
TEST=python chrome/test/funtional/history.py
Review URL: http://codereview.chromium.org/1702010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
and extension_error_reporter to browser, so that the UIs surrounding them can be in the browser.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1705009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=42866
Review URL: http://codereview.chromium.org/1790008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a bug where we would have missing images in the bookmark manager.
BUG=42817
TEST=Open the bookmark manager. No icons should be missing.
Review URL: http://codereview.chromium.org/1697017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
phantom tabs.
BUG=42698
TEST=per bug. Might want to re-test dragging single tabs and dragging tabs out when there are pinned tabs (not phantoms).
Review URL: http://codereview.chromium.org/1727013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
initial value for kHomePageIsNewTabPage.
BUG=42669
TEST=TwoClientLivePreferencesSyncTest.Sanity
Review URL: http://codereview.chromium.org/1801006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The documentation states that we can't pass NULL as the fourth
parameter to png_set_write_fn().
BUG=28399
TEST=none
Review URL: http://codereview.chromium.org/1759016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This makes "./out/Debug/test_shell path/to/file.html" do the right thing.
In theory I should use URLFixerUpper but that's deep inside chrome/browser/;
this is simple enough anyway.
Review URL: http://codereview.chromium.org/1711024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Does not yet handle rewriting the URL for the PAC resolver.
BUG=42666
Review URL: http://codereview.chromium.org/1699023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=net_unittests --gtest_filter="*HttpAlternateProtocols*"
Review URL: http://codereview.chromium.org/1699026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is an interface-only change, nothing is really moving to another thread yet.
BUG=26730
TEST=none
Review URL: http://codereview.chromium.org/983007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1708016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(it caused this roll to be reverted at http://src.chromium.org/viewvc/chrome?view=rev&revision=45840)
Removes downstream test expectations for:
traversal/node-iterator-prototype.html
fast/images/svg-background-partial-redraw.html
fast/text/international/bold-bengali.html
fast/text/international/khmer-selection.html
Review URL: http://codereview.chromium.org/1775011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1739019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for wave to switch to Chrome in the current page/tab.
The ChromeFrame install flow instantiates the ChromeFrame ActiveX which ensures that the IMoniker patches are in place for switching
to work. However ChromeFrame relies on the BHO to be loaded in order to determine that a URL is a top level URL.
The ChromeFrame ActiveX now attempts to load the BHO dynamically and registers it with the top level IWebBrowser for the page.
This fixes bug http://code.google.com/p/chromium/issues/detail?id=42790
Bug=42790
Review URL: http://codereview.chromium.org/1789007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
or to JSON.
This is similar to the display of about:net-internals, and is intended to be used when attaching log info to bug reports.
The formatting is still fairly crude, and there are some remaining TODOs.
BUG=37421
Review URL: http://codereview.chromium.org/1703018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40735
TEST=manual clicking about, trybots
Review URL: http://codereview.chromium.org/1783010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
menus.Prevent dropping bookmark folders onto their children to avoid creating cycles and crashing. Keep folder menu windows open after a cut/copy/paste/delete and drop operation. Add test helpers for easing comparison of bookmark model changes.
BUG=41217,36614,32064, 41404
Add and implement cut/copy/paste to the bookmark bar and folder context menus.Prevent dropping bookmark folders onto their children to avoid creating cycles and crashing. Keep folder menu windows open after a cut/copy/paste/delete and drop operation.
TEST=1) Present the context menu for the bookmark bar in various places and insure that the cut/copy/paste menu items are shown and properly enabled or disabled.
2) Present the context menu for a folder menu in various places and insure that the cut/copy/paste menu items are shown and properly enabled or disabled.
3) Perform cut/copy/paste/delete operations in a folder menu and subfolder menu and verify that the menu remains presented after the operation completes.
4) Drag a bookmark item from the bar to another location on the bar and verify that the button no longer shows up in the old location but does show up in the new location.
5) Drag a bookmark item from the bar to be within a folder located _after_ the item being dragged. Verify the bar no longer shows the bookmark item. Verify the folder does show the bookmark item. Verify that the folder window has shifted to the left so that it remains aligned with it corresponding bar folder indicator.
6) Drag a bookmark item from the bar to be within a folder located _before_ the item being dragged. Verify the bar no longer shows the bookmark item. Verify the folder does show the bookmark item. Verify that the folder window has _not_ shifted to the left and that it remains aligned with it corresponding bar folder indicator.
7) Drag a bookmark around within the same folder and verify that the folder window does not move.
8) Drag a bookmark item from a folder to the bar in a position _after_ the folder form which the item comes. The folder menu window should close.
9) Drag a bookmark item from a folder to a different folder and verify that the original folder closes and the new folder remains open.
10) Drag an item from a parent folder to a child folder and verify that both folders remain open. Verify that the subfolder remains aligned to its associated folder icon in the parent folder.
11) Drag an item from a child folder to a parent folder. Verify that the child folder closes and the parent folder remains open.
12) Try dragging a parent folder onto a child folder and verify that the drag is not allowed to complete.
13) Hover over a folder item in a folder menu window. Verify that the folder opens up a subview menu window. Now drag the original folder (the one being hovered over) and verify that its subfolder menu automatically closes.
14) Slowly shrink window width until "off the side" menu appears; make sure it appears as soon as the last button gets removed. Now slowly grow window and make sure it goes away at the right time.
15) Add enough bookmarks to the bookmark bar to nearly fill the width of the window. Verify that the off-the-side chevron is not showing. Slowly shrink the width of the window until the off-the-side-chevron appears. Verify that the right-most bookmark button has disappeared and does not draw over the top of the chevron. Continue to shrink the window and verify that bookmark buttons disappear. View the contents of the chevron and verify that the bookmark buttons which previously appeared on the bar now appear in the chevron. Slowly grow the window and verify that bookmark buttons reappear without drawing over the top of the chevron. Verify that those bookmark buttons no longer appear in the chevron when it is popped up. Continue growing the window until all bookmark buttons appear in the bar and the chevron disappears.
16) Shrink the window so that the off-the-side chevron appears and contains three or more bookmarks. Pop open the chevron. Drag bookmarks up and down in the chevron menu and verify that moves and copies are performed. Drag a bar bookmark into the chevron and verify that the chevron pops up and allows the drag. Verify that the bar and chevron contents rearrange such that buttons on the bar fill but do not overflow the bar. Drag a chevron bookmark out onto the bar. Once again verify that the bar and chevron buttons rearrange such that the bar is full but not overflowing.
Review URL: http://codereview.chromium.org/1742003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We currently have two copies of these enums, one in Chrome
and one in Chrome OS. I'm switching us to have a single
copy in the libcros repo.
This reverts r45955, which reverted r45952. I've added
third_party/cros to the browser directory's DEPS file to fix
the checkdeps.py failure.
http://codereview.chromium.org/1811002/show contains the
review of the original change.
BUG=none
TEST=built it and ran checkdeps.py manually
Review URL: http://codereview.chromium.org/1705017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/1725007 ), r=me.
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes mouse-exit events for plugins touching the edge of the content area; likely also fixes similar bugs in HTML.
BUG=33100
TEST=Plugins should receive mouse exit events on edges touching the content area edge.
Review URL: http://codereview.chromium.org/1774014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Flipping a bitmap vertically was deferred to the texture, which is fine, unless the bitmap actually gets modified before the texture gets made, so now flipVertically() actually flips the image.
Review URL: http://codereview.chromium.org/1699021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
GLEW was not being initialized and the back buffer was not being cleared.
Back buffer was not being deallocated in OSMesaGLContext::Destroy.
TEST=trybots
BUG=none
Review URL: http://codereview.chromium.org/1792008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(fixed the ChromeOS build).
The app launcher now uses the location bar (instead of the autocomplete edit), so
it has "tab to search" and the icons on the left side,
Also split location_bar_view.cc so that every inner-class gets its own .h and .cc
file.
BUG=None
TEST=Make sure the location bar works as expected (tab to search, bookmark star,
page actions...).
Open the app launcher, make sure "tab to search" works as expected.
Review URL: http://codereview.chromium.org/1792010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a test which excercises this, update old test.
Also,
- Remove some old prefs hooks. They were not easy to use and required the user to know what a preference type was, with no way of listing them out.
- replace if-else statements for json handlers with a map.
- Fix json error strings. json prefers " over ' (automation_provider.cc)
BUG=42701
TEST=python chrome/test/functional/prefs.py
Review URL: http://codereview.chromium.org/1712019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1692017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1730001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix namespace usage.
Change ProcessEntry to have a common interface accross platforms and change ProcessFilter::Includes() to make use of it.
Split NamedProcessIterator in two.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1689012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We currently have two copies of these enums, one in Chrome
and one in Chrome OS. I'm switching us to have a single
copy in the libcros repo.
BUG=none
TEST=built it
Review URL: http://codereview.chromium.org/1811002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=stoyan
TEST=flaky
BUG=32293
Review URL: http://codereview.chromium.org/1815001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The space after the extension name was included in the
link.
BUG=29739
TEST=chrome://extensions, make sure the link does not
contain a space.
Review URL: http://codereview.chromium.org/1699025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jam
TEST=none
BUG=34997
Review URL: http://codereview.chromium.org/1687021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=mpcomplete
TEST=flaky
BUG=42844
Review URL: http://codereview.chromium.org/1705014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=rogerta
TEST=flaky
BUG=37554
Review URL: http://codereview.chromium.org/1695024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=32356,42842
Review URL: http://codereview.chromium.org/1703020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
received when destroying a WebPluginDelegateProxy.
Since bugs 27510 and 26754 have been fixed, WebPluginDelegateProxy keeps old
TransportDIB objects alive until the plugin process confirms that they are no
longer necessary by sending a PluginHostMsg_UpdateGeometry_ACK message. Upon
receipt of this message, WebPluginDelegateProxy asks the browser process to
free the old TransportDIB. In case a plugin process hangs or crashes
(unfortunately, these things happen) while such a geometry change is in
flight, the renderer will never try to free the old TransportDIB.
In this change, old TransportDIB objects are always released by the renderer
process' WebPluginDelegateProxy destructor. At the point that the destructor
fires, no more PluginHostMsg_UpdateGeometry_ACK could possibly be processed,
and any old unfreed TransportDIB objects are no longer of any use.
This fix avoids a potential shared memory leak, and a browser process file
descriptor leak.
BUG=42791
TEST=none
Review URL: http://codereview.chromium.org/1727016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=skerner
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1812004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=compiles, and manually.
Patch from Thiago Farina <thiago.farina@gmail.com>
Review URL: http://codereview.chromium.org/1648016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is destroyed.
On the Mac, transport DIBs are allocated by the browser process (due to the
sandbox) and are also freed by the browser process. This change causes the
renderer to ask the browser to free allocated transport DIBs when a
WebPluginDelegateProxy is destroyed. This avoids a shared memory leak and
file descriptor leak in the browser process.
BUG=38383
TEST=Using test_chrome_fd_leak from bug 38383 and lsof, the browser process
should not show an fd leak on Mac.
Review URL: http://codereview.chromium.org/1789006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Part of aftermath of eliminating the native bookmark managers.)
BUG=38908
TEST=everything keeps working
Review URL: http://codereview.chromium.org/1745021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Verify ChromeOS valgrind(3) green.
Review URL: http://codereview.chromium.org/1780014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
autocomplete edit), so
it has "tab to search" and the icons on the left side,
Also split location_bar_view.cc so that every innerclass gets its own .h and .cc
file.
BUG=None
TEST=Make sure the location bar works as expected (tab to search, bookmark star,
page actions...).
Open the app launcher, make sure "tab to search" works as expected.
Review URL: http://codereview.chromium.org/1746009
TBR=jcivelli@google.com
Review URL: http://codereview.chromium.org/1737021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
edit), so
it has "tab to search" and the icons on the left side,
Also split location_bar_view.cc so that every inner-class gets its own .h and .cc
file.
BUG=None
TEST=Make sure the location bar works as expected (tab to search, bookmark star,
page actions...).
Open the app launcher, make sure "tab to search" works as expected.
Review URL: http://codereview.chromium.org/1746009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=agl
BUG=42538
TEST=new unit test SSLClientSocketTest.PrematureApplicationData
Review URL: http://codereview.chromium.org/1811003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(Includes WOFF support)
BUG=25543
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45932 0039d316-1c4b-4281-b951-d872f2087c98
|