summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fixing audio in machclam@chromium.org2009-09-173-8/+94
| | | | | | | | | | | | | | | | | | | | | | | | TEST=media_unittests BUG=21574 Several problems in mac audio: 1. AudioQueueEnqueueBuffer doesn't accept empty buffers. But we often hit buffer underrun with various reasons. In order to simulate the behavior of Windows that empty buffer would make the callback be called after a short time, we write a short buffer of silence. 2. Mac audio doesn't provide pending bytes (unplayed buffer size in audio buffer). This is now fixed by having a running counter. 3. After Stop() is called, Start() will take a long time for the audio packet to be played. It is found that AudioQueueEnqueueBuffer should be called before AudioQueueStart otherwise we'll hit this problem of long delay for start. Review URL: http://codereview.chromium.org/194112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26510 0039d316-1c4b-4281-b951-d872f2087c98
* Changes font_skia to use font bounding box rather thansky@chromium.org2009-09-171-5/+12
| | | | | | | | | | | | | ascent/descent. This gets us closer to sizes used by pango. It's not ideal, but as we can't switch to pango (startup hit), this is the best I can do. BUG=20823 TEST=see bug Review URL: http://codereview.chromium.org/211003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26509 0039d316-1c4b-4281-b951-d872f2087c98
* Implement WebKitTabToLinksPreferenceKey for the test_shell.arv@chromium.org2009-09-179-9/+29
| | | | | | | | | | BUG=21267 TEST=Run layout tests Review URL: http://codereview.chromium.org/212004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26508 0039d316-1c4b-4281-b951-d872f2087c98
* Stylistic fixes in the new dock menu code:sgk@google.com2009-09-172-16/+15
| | | | | | | | | | | * Initialize variables when declared. * Descriptive name (dock_menu) for the returned value. * Use a scoped_nsobject in the unit test, not autorelease. BUG=none TEST=AppControllerTest.DockMenu Review URL: http://codereview.chromium.org/200126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26507 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused prefs.tony@chromium.org2009-09-172-34/+0
| | | | | | | | | | No code references these, so I'm removing them. I kept some printing prefs that maruel says he's going to be using soon. Review URL: http://codereview.chromium.org/209019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26506 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress leak in AudioObjectGetPropertyData. The leaking call changed inmark@chromium.org2009-09-171-1/+1
| | | | | | | | | r26478. BUG=9351 Review URL: http://codereview.chromium.org/207022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26505 0039d316-1c4b-4281-b951-d872f2087c98
* This updates the DEPS for V8, Chrome and NaCl.gspencer@google.com2009-09-173-6/+7
| | | | | | | | | It also fixes two other minor problems: a signed/unsigned mismatch in the gapi_decoder, and a switch from sys.argv[0] to __file__ in codegen.py. Review URL: http://codereview.chromium.org/208015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26504 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug introduced by a WebKit merge where we did notpaul@chromium.org2009-09-171-0/+1
| | | | | | | | | | | | | tell our autocomplete popup to hide when it was closed. BUG=22032 TEST=Navigate to a page with an autocompletable input box (e.g. google.com login page) and notice that the autocomplete box hides when you select an item from it and hit enter. Review URL: http://codereview.chromium.org/211005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26503 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the Linux Views build, sigh. We need a trybot.pkasting@chromium.org2009-09-171-2/+3
| | | | | | | | BUG=21028 TEST=none Review URL: http://codereview.chromium.org/209024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26502 0039d316-1c4b-4281-b951-d872f2087c98
* Add Profile Import Process Type.jeremy@chromium.org2009-09-178-1/+105
| | | | | | | | | | | | | | | | | | | | | | | | This is currently only used on OS X. We need a separate process to do profile import for 3 reasons: 1)In Firefox we load external libraries which we have no control over. 2)Conceptually it's safer to run parsing code OOP. 3)quoth chrome/browser/importer/nss_decryptor_mac.mm : """ On OS X the nss3 libraries are compiled with depedencies on one another, referenced using dyld's @executable_path directive. To make a long story short in order to get the libraries to load, dyld's fallback path needs to be set to the directory containing the libraries. To do so, the process this function runs in must have the DYLD_FALLBACK_LIBRARY_PATH set on startup to said directory. """ BUG=14458 TEST=None Possible Review URL: http://codereview.chromium.org/193131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26501 0039d316-1c4b-4281-b951-d872f2087c98
* Pause for <video> should have immediate effect on audiohclam@chromium.org2009-09-172-3/+4
| | | | | | | | | | | | | BUG=20351 A bug found while fixing mac audio. IPCAudioSouce transist to a wrong state after Play() is called. Resulting to pause having no effect. This will solve the problem of audio keeps playing a while after it is paused. Review URL: http://codereview.chromium.org/193095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26500 0039d316-1c4b-4281-b951-d872f2087c98
* Fix code that gets the Chrome SVN revision to pass in a path.ojan@chromium.org2009-09-172-7/+9
| | | | | | | On the bots, the "." directory is not actually in an SVN checkout. Review URL: http://codereview.chromium.org/205013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26499 0039d316-1c4b-4281-b951-d872f2087c98
* Try renabling the WMP plugin tests again. The new one works on my Windows 7 ↵jam@chromium.org2009-09-171-3/+2
| | | | | | | | | | box, the old one I can't run since I don't have an XP box. BUG=4809 Review URL: http://codereview.chromium.org/208014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26498 0039d316-1c4b-4281-b951-d872f2087c98
* Try to make ImageBubbles draw correctly on Linux Views as well. This also ↵pkasting@chromium.org2009-09-172-68/+92
| | | | | | | | | | fixes an error in the window region calculation (I used right()/bottom() where I should have used width()/height()) and updates some comments and variable names in the hope of more clarity. BUG=21028 TEST=Look at image bubbles on Linux Views Review URL: http://codereview.chromium.org/207021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26497 0039d316-1c4b-4281-b951-d872f2087c98
* prefs::kDownloadDefaultDirectory should always be initialized in ↵thestig@chromium.org2009-09-171-13/+5
| | | | | | | | | | DownloadManager::RegisterUserPrefs, remove code that assumes otherwise. BUG=none TEST=none Review URL: http://codereview.chromium.org/209003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26496 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up cmd-0..8 as "select Nth tab" and cmd-9 as "select last tab".pinkerton@chromium.org2009-09-171-0/+11
| | | | | | | | BUG=none TEST=as described. Review URL: http://codereview.chromium.org/212009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26495 0039d316-1c4b-4281-b951-d872f2087c98
* Add all locales to the appropriate generated file lists in .gyp files.thestig@chromium.org2009-09-174-30/+22
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/208002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26494 0039d316-1c4b-4281-b951-d872f2087c98
* Tweak Carlos' change to cater for the additional cases:cevans@chromium.org2009-09-171-3/+7
| | | | | | | | | | | | | | - More (ordered) segments than we expect - would previously cause stack-based buffer overflow. - Less segments than we expect, where the missing segments are a strict truncation rather than missing in the middle. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/209001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26493 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline tests whose expectations also changed upstream, remove 2 crashers ↵dglazkov@chromium.org2009-09-174-10/+6
| | | | | | | | | | | | that were fixed. R=jparent TEST=none BUG=14091 Review URL: http://codereview.chromium.org/209021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26492 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Get rid of default drag icon for tab drags.estade@chromium.org2009-09-172-9/+18
| | | | | | | | | | | I guess this regressed at some point. BUG=none TEST=none Review URL: http://codereview.chromium.org/209002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26491 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore remote requests to open tabs that would open external protocol handlers.mdm@chromium.org2009-09-171-0/+7
| | | | | | | | | BUG=21934 TEST=none Review URL: http://codereview.chromium.org/213003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26490 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrote full-screen support on Windows. O3D now always creates its ownkbr@google.com2009-09-1713-313/+353
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | window in which to render, rather than rendering into either the browser's window or a separate full-screen window. The O3D window is removed from the browser's hierarchy and made top-level in order to go to full-screen mode via Direct3D. This solves fundamental focus fighting problems seen on Windows Vista. This change allowed the event forwarding code in the plugin's window message loop to be deleted, but a new workaround for a flicker upon the first mouse click in O3D in Firefox was required. Split the Renderer's fullscreen API into GoFullscreen and CancelFullscreen to solve chicken-and-egg problems with coming out of full-screen mode. Changed how the plugin detects resize events. Rather than responding to WM_SIZE messages, NPP_SetWindow is now responsible for propagating resize events to the client. Changed the ActiveX host control to call NPP_SetWindow in response to SetObjectRects. Fixed RendererGL::IsCurrent() on non-Mac platforms. Removed the bogus current_renderer_ static variable. Tested the following scenarios in IE and Firefox on Windows: - Full-screen involving display mode change, Escape to exit. - Full-screen involving display mode change, Alt-Tab to exit. - Full-screen involving display mode change, Alt-F4 to exit. - Full-screen involving display mode change, timeout to exit. - Full-screen with no display mode change, Escape to exit. - Full-screen with no display mode change, Alt-Tab to exit. - Full-screen with no display mode change, Alt-F4 to exit. - Full-screen with no display mode change, timeout to exit. - Beach demo, particle demo, other tests. Tested the following scenarios on the Mac in Safari (for which the code path didn't change): - Full-screen, escape to exit. - Full-screen, Alt-Tab to exit. - Full-screen, timeout to exit. When http://crbug.com/21921 is fixed, full-screen mode will work on Windows Vista with Aero on in Chrome. Review URL: http://codereview.chromium.org/210005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26489 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 26482.thomasvl@chromium.org2009-09-173-246/+79
| | | | | | | | | | | | relied on making the field editable which really doesn't work for legal text you show a user BUG=20493 BUG=20855 BUG=22179 BUG=22180 Review URL: http://codereview.chromium.org/212010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26488 0039d316-1c4b-4281-b951-d872f2087c98
* Add xdisplaycheck as a dependency on Linux for tests that use the UI. This ↵thestig@chromium.org2009-09-173-3/+17
| | | | | | | | | | way we don't have to explicitly build xdisplaycheck on all the bots where we run tests. BUG=none TEST=none Review URL: http://codereview.chromium.org/207020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26487 0039d316-1c4b-4281-b951-d872f2087c98
* revert bad merge.tommi@chromium.org2009-09-171-3/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26486 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a dlog that could dereference a null pointer.tommi@chromium.org2009-09-171-2/+3
| | | | | | | | | TEST=run automation tests. BUG=non Review URL: http://codereview.chromium.org/207017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26485 0039d316-1c4b-4281-b951-d872f2087c98
* This is not production code; landing some experimental network code.mbelshe@google.com2009-09-1716-0/+3769
| | | | | | | | | BUG=none TEST=flip_session_unittest.cc flip_network_transaction_unittest.cc flip_framer_test.cc Review URL: http://codereview.chromium.org/200084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26484 0039d316-1c4b-4281-b951-d872f2087c98
* linux: expose the ProcessSingleton timeout to speed testsevan@chromium.org2009-09-173-3/+17
| | | | | | | | | We have a 20-second timeout normally, but for testing purposes 1 second is plenty. Review URL: http://codereview.chromium.org/209018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26483 0039d316-1c4b-4281-b951-d872f2087c98
* Make links in the cocoa about dialog clickable.erg@chromium.org2009-09-173-79/+246
| | | | | | | | | | | | | | | This replaces an NSTextField with an NSTextView so the file owner can implement some of NSTextView's delegate interface to respond to links. While we're here, also add an additional newline between the main text and the Google build's terms and conditions. BUG=20493 BUG=20855 Review URL: http://codereview.chromium.org/203084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26482 0039d316-1c4b-4281-b951-d872f2087c98
* Update rollover/press images for close box to please Linus/Sundar.pinkerton@chromium.org2009-09-172-1329/+2290
| | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26481 0039d316-1c4b-4281-b951-d872f2087c98
* Use NSApp in preference to [NSApplication sharedApplicaton]mark@chromium.org2009-09-176-13/+8
| | | | | | | | BUG=0 TEST={} Review URL: http://codereview.chromium.org/207001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26480 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a few pasteboard-related things in the Mac unit_tests. Most of thesemark@chromium.org2009-09-175-42/+41
| | | | | | | | | | | | changes are non-functional or minimally functional. There are a couple of functional changes in here too. Hopefully this will resolve some of the Valgrind failures. BUG=21479 TEST=unit_tests Review URL: http://codereview.chromium.org/210006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26479 0039d316-1c4b-4281-b951-d872f2087c98
* AudioHardwareGetProperty is deprecated in Mac OS X 10.6 ("Snow Leopard").mark@chromium.org2009-09-171-5/+15
| | | | | | | | | | | All audio hardware properties can be accessed via AudioObjectGetPropertyData, present since Mac OS X 10.4 ("Tiger"). BUG=20925 sort of TEST=Builds in all sorts of configurations Review URL: http://codereview.chromium.org/210009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26478 0039d316-1c4b-4281-b951-d872f2087c98
* Use delegate protocols present in the 10.6 SDK. For previous SDKs, providemark@chromium.org2009-09-1715-15/+65
| | | | | | | | | | empty protocol definitions for compatibility. BUG=20925 TEST=build Review URL: http://codereview.chromium.org/209004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26477 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed a few data races on reference counters.timurrrr@chromium.org2009-09-173-3/+4
| | | | | | | BUG=18488 Review URL: http://codereview.chromium.org/215011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26476 0039d316-1c4b-4281-b951-d872f2087c98
* Add expectations from the r26471 48468:48483 WebKit mergemark@chromium.org2009-09-171-4/+5
| | | | | | | | BUG=22170 TEST=this Review URL: http://codereview.chromium.org/208013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26475 0039d316-1c4b-4281-b951-d872f2087c98
* Bring the Mac Chromium render theme up to date and easier to keep merged. ↵avi@chromium.org2009-09-172-2/+12
| | | | | | | | | | | Chromium side of things. BUG=http://crbug.com/19604 TEST=no visible change on Leopard, draws correctly on Snow Leopard Review URL: http://codereview.chromium.org/173212 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26471 0039d316-1c4b-4281-b951-d872f2087c98
* Disable VisitedLinkRelayTest.Basics as it hangs on linux valgrind unit botdkegel@google.com2009-09-171-0/+2
| | | | | | | | BUG=22160 Review URL: http://codereview.chromium.org/211014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26468 0039d316-1c4b-4281-b951-d872f2087c98
* Update favicon leak suppression to make valgrind bot happydkegel@google.com2009-09-171-0/+10
| | | | | | | | BUG=17451 Review URL: http://codereview.chromium.org/216011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26467 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress more clipboard tests in valgrind.dkegel@google.com2009-09-171-1/+1
| | | | | | | | BUG=22138 Review URL: http://codereview.chromium.org/213008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26462 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: temporary disable TestConsoleLog and TestEvalGlobal that would ↵yurys@google.com2009-09-171-2/+2
| | | | | | | | fail with next WebKit roll. Review URL: http://codereview.chromium.org/208009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26460 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: add WatchExpressionsSidebarPane.js to devtools.htmlyurys@google.com2009-09-171-0/+1
| | | | | | Review URL: http://codereview.chromium.org/216007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26455 0039d316-1c4b-4281-b951-d872f2087c98
* Add 2 known leaks that are caused by 9/16/09's webkit merge.nsylvain@chromium.org2009-09-171-0/+65
| | | | | | | BUG=22021 Review URL: http://codereview.chromium.org/207016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26454 0039d316-1c4b-4281-b951-d872f2087c98
* r21342 moved IPC tests from unit_tests to ipc_tests,dkegel@google.com2009-09-173-3/+7
| | | | | | | | | | | | | | | | so tell chrome_tests.py to look in ipc rather than chrome for its gtest.txt file, and actually move it. (At least for valgrind. Purify may need the same change.) Disable IPCChannelTest.ChannelTest and VisitedLinkEventsTest.Coalescense on valgrind, as they hang there today on linux bots. BUG=22141,22146 TEST=none Review URL: http://codereview.chromium.org/165064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26453 0039d316-1c4b-4281-b951-d872f2087c98
* Update test expectations to add another failing test, resulting from WebKit ↵dglazkov@chromium.org2009-09-171-0/+1
| | | | | | | | | | | | Update 48423:48468. TBR=ukai TEST=none BUG=none Review URL: http://codereview.chromium.org/209017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26451 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress ClipboardTest.ClearTest on valgrind as it hung the bot today (and ↵dank@chromium.org2009-09-171-1/+4
| | | | | | | | | | hung my local run two weeks ago) BUG=22138 Review URL: http://codereview.chromium.org/208006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26450 0039d316-1c4b-4281-b951-d872f2087c98
* A build fix for gcc 4.3 (and later).craig.schlenter@chromium.org2009-09-171-25/+35
| | | | | | | | | | | | Comparing a function with NULL has been prohibited since gcc 4.3 and produces a compilation error. This change encloses your code which compares a function with NULL with "#if defined(OS_MACOSX) && MAC_OS_X_VERSION_MIN_REQUIRED < MAC_OS_X_VERSION_10_5" and "#endif". BUG=none TEST=build chromium with gcc 4.3 (and later) Review URL: http://codereview.chromium.org/206024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26449 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit Update 48423:48468.dglazkov@chromium.org2009-09-172-1/+7
| | | | | | | | | | TBR=ukai BUG=none TEST=none Review URL: http://codereview.chromium.org/214009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26448 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the memcheck suppression rule for bug 22109.tyoshino@google.com2009-09-171-4/+0
| | | | | | | | | | | | The signature was too specific. Extend the matching rule for similar failures. BUG=22109 TEST=none Review URL: http://codereview.chromium.org/215009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26447 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ExtensionViews and toolstrip browser tests becausensylvain@chromium.org2009-09-171-2/+4
| | | | | | | | | they crash all the time on the new vista bot (in skia). BUG:22135 Review URL: http://codereview.chromium.org/209015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26446 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 23:02:14 +0000