summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Make sure DecodeIcon is only called from the File thread.finnur@chromium.org2010-04-064-13/+21
| | | | | | | | | BUG=38521 TEST=None, Chrome should work as before. Review URL: http://codereview.chromium.org/1525009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43751 0039d316-1c4b-4281-b951-d872f2087c98
* quiet noisy preferences log during unit testserikkay@chromium.org2010-04-061-1/+6
| | | | | | | | | | | (also fixes a lint error) BUG=40577 TEST=none Review URL: http://codereview.chromium.org/1600011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43750 0039d316-1c4b-4281-b951-d872f2087c98
* Make PreferredCacheSize(avail) <= avail*0.8 and f(x) <= f(x+1). nsylvain@chromium.org2010-04-062-38/+60
| | | | | | | | | | | | | Contributed by slamm@google.com BUG=40079 TEST=DiskCacheTest.AutomaticMaxSize http://codereview.chromium.org/1564007 Review URL: http://codereview.chromium.org/1566021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43749 0039d316-1c4b-4281-b951-d872f2087c98
* Rename kChromeUIFavIconPath to kChromeUIFavIconHost for consistency.arv@chromium.org2010-04-063-3/+3
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/1568015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43748 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 57147:57160.pfeldman@chromium.org2010-04-061-1/+1
| | | | | | Review URL: http://codereview.chromium.org/1629002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43747 0039d316-1c4b-4281-b951-d872f2087c98
* Theme delegate fixes for the 10.6 SDK folllowing r43708.mark@chromium.org2010-04-062-6/+24
| | | | | | | | | | | | | | | | | | | | In the 10.6 SDK, -[NSWindow delegate] returns id<NSWindowDelegate>, not just id, and the three selectors used in r43708 are not declared in NSWindowDelegate. This results in errors such as "warning: '-themeProvider' not found in protocol(s)". Testing the selectors before using them is safe and not incorrect, but you guys might actually want to make more of an assertion about what it means to be a ChromeBrowserWindow's or FullscreenWindow's delegate, or perhaps even a ChromeEventProcessingWindow's delegate. Alternatively, it may be appropriate to add a ChromeThemedWindow layer as a subclass of CEPW and superclass of CBW and FW. (CEPW's other subclass is InfoBubbleWindow.) BUG=none TEST=none Review URL: http://codereview.chromium.org/1630001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43746 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bad URL in sample code.kathyw@chromium.org2010-04-062-2/+2
| | | | | | | | | | TBR=ericbidelman BUG=40063 TEST=none Review URL: http://codereview.chromium.org/1539025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43745 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 43741 - [Mac] Make Mac phantom tabs match the appearance of the other ↵rsesek@chromium.org2010-04-062-5/+12
| | | | | | | | | | | | | | platforms. BUG=none TEST=Open a new tab, navigate, and pin it. Open a new tab. Close the pinned tab. No tab background should be drawn, just the favicon. Review URL: http://codereview.chromium.org/1562014 TBR=rsesek@chromium.org Review URL: http://codereview.chromium.org/1627004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43744 0039d316-1c4b-4281-b951-d872f2087c98
* Cl for readabilitydhg@chromium.org2010-04-063-80/+139
| | | | | | Review URL: http://codereview.chromium.org/1290001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43742 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Make Mac phantom tabs match the appearance of the other platforms.rsesek@chromium.org2010-04-062-12/+5
| | | | | | | | | BUG=none TEST=Open a new tab, navigate, and pin it. Open a new tab. Close the pinned tab. No tab background should be drawn, just the favicon. Review URL: http://codereview.chromium.org/1562014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43741 0039d316-1c4b-4281-b951-d872f2087c98
* Change bookmark bar toggle to ctrl-shift-b.pkasting@chromium.org2010-04-063-6/+3
| | | | | | | | BUG=40565 TEST=ctrl-b does nothing; ctrl-shift-b toggles bookmark bar. Review URL: http://codereview.chromium.org/1567025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43740 0039d316-1c4b-4281-b951-d872f2087c98
* Convert variables in chrome/common/env_vars.cc from wchar_t to char. Enable ↵thestig@chromium.org2010-04-0616-104/+135
| | | | | | | | | | ChromeLoggingTest along the way. BUG=none TEST=none Review URL: http://codereview.chromium.org/1559016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43738 0039d316-1c4b-4281-b951-d872f2087c98
* Remove VLC from the Mac plugin blacklist now that it's not crashingstuartmorgan@chromium.org2010-04-061-4/+0
| | | | | | | | | BUG=37072 TEST=Install the VLC plugin, and Play embedded VLC content; it should work correctly. Review URL: http://codereview.chromium.org/1528020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43737 0039d316-1c4b-4281-b951-d872f2087c98
* Fix extension checkPermission for notifications.rafaelw@chromium.org2010-04-061-8/+1
| | | | | | | | | | This fixes checkPermission for chrome-extension: urls that are granted the permission via requestPermission (which is stored in the prefs). BUG=40495 Review URL: http://codereview.chromium.org/1517018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43736 0039d316-1c4b-4281-b951-d872f2087c98
* A three-phase commit related to changing the params of ↵rafaelw@chromium.org2010-04-062-3/+6
| | | | | | | | webkitNotifications.checkPermission() & requestPermission() went awry and notification_provider.cc was no longer implementing a called method. As a result requestPermission() became non-functional. Review URL: http://codereview.chromium.org/1542010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43735 0039d316-1c4b-4281-b951-d872f2087c98
* In the GetIETemporaryFilesFolder helper function in ChromeFrame we should ↵ananta@chromium.org2010-04-061-2/+0
| | | | | | | | | | | | not be freeing the relative pidl. It is a pointer into the absolute pidl. Thanks to Tommi for pointing this out. Bug=none Review URL: http://codereview.chromium.org/1568017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43734 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Deps roll for GTM to pick up fudge factor for radio groups like ↵thomasvl@chromium.org2010-04-061-1/+1
| | | | | | | | | | checkboxes, also bumps the fudge factor to try and better handle kerning of some Europeans accents characters. TEST=see bug BUG=39383 Review URL: http://codereview.chromium.org/1622007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43733 0039d316-1c4b-4281-b951-d872f2087c98
* Use CSS word-wrap property to prevent long single words from causing ugly ↵johnnyg@chromium.org2010-04-063-0/+6
| | | | | | | | | | | notifications. BUG=32847 TEST=create notification with a very long word, should be no horizontal scroll Review URL: http://codereview.chromium.org/1613005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43732 0039d316-1c4b-4281-b951-d872f2087c98
* On sites like hulu.com while playing a video the cursor would not disappear ↵ananta@chromium.org2010-04-061-2/+7
| | | | | | | | | | | | | | | | | | if it was within the bounds of the plugin. This was because of the SetCursorPatch for the flash plugin in Windows. The plugin periodically calls SetCursor and we only allow this call in the context of a HandleEvent for a mouse event. This results in the SetCursor attempt by the plugin to fail. The reason we do this is to prevent annoying flicker if the plugin in the background tab keeps changing the cursor. Fix is to set the cursor only if has changed. Fixes bug http://code.google.com/p/chromium/issues/detail?id=33549 Bug=33549 Review URL: http://codereview.chromium.org/1576020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43731 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for basic extension automation through the Automation Proxy.kkania@chromium.org2010-04-0621-48/+1201
| | | | | | | | BUG=36171 TEST=none Review URL: http://codereview.chromium.org/1048002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43730 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memcheck valgrind errorcmasone@google.com2010-04-062-26/+22
| | | | | | | | | | BUG=40481 TEST=The leaking code is only called in a GoogleAuthenticator unit test, so I ran `sh tools/valgrind/chrome_tests.sh -t unit "--gtest_filter=GoogleAuthenticatorTest.*"` and it passed Review URL: http://codereview.chromium.org/1606014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43729 0039d316-1c4b-4281-b951-d872f2087c98
* linux: properly handle pixbuf refcountevan@chromium.org2010-04-061-0/+1
| | | | | | | | | gfx::GdkPixbufFromSkBitmap() returns an image with a refcount of 1. Fixes heapcheck error seen on buildbots. Review URL: http://codereview.chromium.org/1578012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43728 0039d316-1c4b-4281-b951-d872f2087c98
* Add a simple example history extension.skerner@chromium.org2010-04-064-0/+138
| | | | | | | | | BUG=32362 TEST=Manual. Review URL: http://codereview.chromium.org/1568012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43727 0039d316-1c4b-4281-b951-d872f2087c98
* Win32 plumbing for dragend event.dcheng@chromium.org2010-04-067-22/+68
| | | | | | | | | | | This plumbs the actual dropEffect that occurred back into WebKit so that dragend is dispatched with the correct dropEffect. Note that this only helps with drags that start in Chrome and end outside of Chrome. Since WebDropTarget always lies and claims that no drop occurred, drags that start in Chrome and end in Chrome will still be incorrect. BUG=39399 TEST=Manual testing using the attached test case on the bug. Review URL: http://codereview.chromium.org/1136007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43726 0039d316-1c4b-4281-b951-d872f2087c98
* Disable incremental linking for startup_tests. A trybot could not link this ↵thestig@chromium.org2010-04-061-0/+9
| | | | | | | | | | binary anymore after I added some shutdown tests. BUG=none TEST=none Review URL: http://codereview.chromium.org/1569022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43725 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: simplify dump_app_syms since newer versions of Breakpad no longer ↵thestig@chromium.org2010-04-061-20/+6
| | | | | | | | | | generates different signatures for stripped/unstripped binaries. BUG=none TEST=none Review URL: http://codereview.chromium.org/1627001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43724 0039d316-1c4b-4281-b951-d872f2087c98
* Show Page Info dialog on mouse up, not mouse down.pkasting@chromium.org2010-04-062-2/+12
| | | | | | | | | BUG=40229 TEST=Visit a page. Click down, then up on the location bar icon. The dialog should only appear on mouse up. Review URL: http://codereview.chromium.org/1621003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43723 0039d316-1c4b-4281-b951-d872f2087c98
* Fixe for #38367 AutoFill UI bug: extra-long fields behaved incorrectly.georgey@chromium.org2010-04-061-2/+2
| | | | | | | | BUG=38367 TEST=In the bug. Review URL: http://codereview.chromium.org/1625002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43722 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Implement status icons on linux.evan@chromium.org2010-04-068-3/+181
| | | | | | | | | | | | | (Retry with less build breakage this time.) BUG=37375 TEST=out/Debug/unit_tests --gtest_filter=StatusTrayGtkTest.* Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/1421001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43721 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Add a call to |-layoutTabs| so that restored pinned tabs look as they ↵rsesek@chromium.org2010-04-061-0/+4
| | | | | | | | | | | should. BUG=39900 TEST=Open a new tab, navigate, and pin it. Close the window. Restore the window. Tab should still appear pinned. Review URL: http://codereview.chromium.org/1628004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43720 0039d316-1c4b-4281-b951-d872f2087c98
* Linux UI tweaks: adjust spacing, add a string, make Customize button ↵dantasse@chromium.org2010-04-062-17/+24
| | | | | | | | invisible instead of disabled Review URL: http://codereview.chromium.org/1591017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43719 0039d316-1c4b-4281-b951-d872f2087c98
* Enforce valid Mac plugin event and drawing model pairingsstuartmorgan@chromium.org2010-04-065-7/+17
| | | | | | | | | | | Refuse to load plugins that violate the specs. BUG=38341 TEST=none Review URL: http://codereview.chromium.org/1558020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43718 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix a couple of libc calls in a compromised context.agl@chromium.org2010-04-061-8/+17
| | | | | | | | | | | We shouldn't call memset nor socketpair once we have crashed. BUG=39292 TEST=none http://codereview.chromium.org/1210006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43717 0039d316-1c4b-4281-b951-d872f2087c98
* Make Mac plugin window interposing more conservative about activating pluginstuartmorgan@chromium.org2010-04-061-2/+23
| | | | | | | | | | | Don't switch to the plugin process for offscreen windows (like the one opened by Unity). BUG=38996 TEST=Open a Unity sample. It shouldn't lose focus on every mouse event (although it will still lose focus once). Review URL: http://codereview.chromium.org/1626002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43716 0039d316-1c4b-4281-b951-d872f2087c98
* detect preferences errorserikkay@chromium.org2010-04-0640-134/+412
| | | | | | | | | BUG=38352 TEST=none Review URL: http://codereview.chromium.org/1120006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43715 0039d316-1c4b-4281-b951-d872f2087c98
* Relaxes tab strip memory leak suppression as it was too specific.sky@chromium.org2010-04-061-11/+1
| | | | | | | | | | BUG=40475 TEST=none TBR=oshima@chromium.org Review URL: http://codereview.chromium.org/1566018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43714 0039d316-1c4b-4281-b951-d872f2087c98
* Enable WorkerTest.WorkerScriptError which now have same results on win, ↵yurys@chromium.org2010-04-061-2/+1
| | | | | | | | | | linux and mac after http://trac.webkit.org/changeset/57147 is rolled. BUG=38918 Review URL: http://codereview.chromium.org/1596011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43712 0039d316-1c4b-4281-b951-d872f2087c98
* Abstracted language switch logic to its model class.glotov@google.com2010-04-068-109/+176
| | | | | | | | | BUG=37070 TEST=none Review URL: http://codereview.chromium.org/1596007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43711 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 57137: 57147pfeldman@chromium.org2010-04-061-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43710 0039d316-1c4b-4281-b951-d872f2087c98
* Fix docking behaviour for devtools windows that don't have an associated ↵mnissler@chromium.org2010-04-069-26/+38
| | | | | | | | | | | browser window BUG=40090 TEST=none Review URL: http://codereview.chromium.org/1567014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43709 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Get theme providers from a window's delegate, not its window ↵rohitrao@chromium.org2010-04-062-6/+6
| | | | | | | | | | controller. These are actually the same object, but they are set at different times during the switch to fullscreen. BUG=39323 TEST=Go fullscreen with the Android Robot theme installed. Tab text for unselected tabs should be grey, not black. Review URL: http://codereview.chromium.org/1576019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43708 0039d316-1c4b-4281-b951-d872f2087c98
* Add menu and menu item events to the accessibility extension api, anddmazzoni@chromium.org2010-04-0614-85/+325
| | | | | | | | | | | | | | generate menu item notifications for gtk menus. The code to generate menu open and close events is a little more complicated and will come in a future patch. BUG=none TEST=navigated menus with keyboard, watched notifications fire Review URL: http://codereview.chromium.org/1585011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43707 0039d316-1c4b-4281-b951-d872f2087c98
* Make DidProcessCrash a bit more solid and accurate on Windowsphajdan.jr@chromium.org2010-04-065-14/+38
| | | | | | | | | | | | | I hit the NOTREACHED() inside it while debugging an unrelated problem. Also, now there is one less special case in this function's contract. TEST=none BUG=38048 Review URL: http://codereview.chromium.org/1315009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43706 0039d316-1c4b-4281-b951-d872f2087c98
* Add NormalizeLanguageCode() to normalize language codes.satorux@chromium.org2010-04-063-9/+50
| | | | | | | | | | | | | | The normalization is needed to avoid duplicates in the language table in the language config diloag, as well as the combobox in the "add language" dialog, when engines return "jpn" and "ja" as language codes. Along the way, fixed typos in function names. TEST=added unit tests, and manually Review URL: http://codereview.chromium.org/1512022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43705 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a suppression entry added in r39812 since the suppression seems not ↵yusukes@google.com2010-04-061-24/+0
| | | | | | | | | | | | to be necessary anymore. BUG=36616 TEST=see the linux valgrind bot keeps green TBR=dpranke Review URL: http://codereview.chromium.org/1559017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43704 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 57067:57139.pfeldman@chromium.org2010-04-061-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43703 0039d316-1c4b-4281-b951-d872f2087c98
* Relaxes the suppression rule for Issue 40505.hbono@chromium.org2010-04-061-9/+0
| | | | | | | | | | | This change just relaxes the suppression rule for Issue 40505 to cover Linux bots. TBR=georgey BUG=40505 TEST=make valgrind bots green. Review URL: http://codereview.chromium.org/1561015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43702 0039d316-1c4b-4281-b951-d872f2087c98
* Enable interactive_ui_testsoshima@chromium.org2010-04-068-69/+145
| | | | | | | | | | | | | | | | | | | | | | | * changed DCHECK in tree_node_model to make it easy to find how it failed. * Fixed compilation error in find_bar_host_interactive_uitest.cc on linux/views. * Disabled BrowserKeyEventsTest.AccessKeys for Chromeos Added/Changed ui_test_utils::RunAllPendingInMessageLoop where necessary. * Disabled tab_dragging_tests. I included the source so that we can catch compilation error even if tests do not run. Changed the comment from // -> /* as GCC complains the use of "\" (and potentially dangerous) * Added SleepInMessageLoop to allow event loop to execute the tasks/events while waiting. * For RunAllPendingInMessageLoop change, please see http://codereview.chromium.org/1591004 BUG=39736 TEST=interactive_ui_tests should pass with following cls http://codereview.chromium.org/1594003 http://codereview.chromium.org/1545011. Review URL: http://codereview.chromium.org/1576008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43701 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding:oshima@chromium.org2010-04-064-24/+131
| | | | | | | | | | | | | | | | | BookmarkBarView tests fixes * Add BOOKMARK_CONTEXT_MENU_SHOWN notification. On Linux, event handling is asynchronous, but the showing context menu is blocking, so we can't use RunAllPending(). * Convert gtk keycode to Win when checking accelerator. BUG=39736 TEST=none (interactive_ui_tests should pass once enabled it'll be enabled by http://codereview.chromium.org/1576008 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43699 Review URL: http://codereview.chromium.org/1545011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43700 0039d316-1c4b-4281-b951-d872f2087c98
* Suppression memcheck:Addr4 error in chromium os valgrind(4) ui_testoshima@chromium.org2010-04-061-0/+15
| | | | | | | | | | BUG=40505 TEST= chromium os valgrind (4) should cycle green TBR=mrossetti@chromium.org Review URL: http://codereview.chromium.org/1562013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43699 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 08:48:56 +0000