| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
take out the ability to access the clipboard since it's not exposed to HTML for security reasons.
Review URL: http://codereview.chromium.org/2841028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
syncer thread has not yet been started or it has been started and is waiting for a connection.
From an API standpoint, the caller of SyncerThread::Pause and SyncerThread::Resume should not need to consider if the thread is already running. The channel responses (PAUSED and RESUMED) should be the same regardless. Furthermore, edge cases like "pause before thread is started and resume after thread is started" should be handled correctly.
This change is supposed to be fixing various offline startup problems we've been having and it includes a new integration test for this. However, it is not yet complete but we might need to check this is before it is ready.
TEST=unit
BUG=45814
Review URL: http://codereview.chromium.org/2814014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Started out just trying to change PrefService::GetString and ::SetString. This snowballed a little bit. Had to change a bunch of url strings in search_engines/ from wstring to string (some of them may be better off as GURLs, but UTF-8 is a step in the right direction, since that's what GURL uses internally, as well as externally via its setters/getters).
TODO (later patch): things that ask for accepted languages should use std::string, not std::wstring.
BUG=none
TEST=try bots
Review URL: http://codereview.chromium.org/2854015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
if it exceeds its window's height.
Review URL: http://codereview.chromium.org/2834029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47241
TEST=Navigate between a few folders and then click on the right pane. Now hit Cmd+A.
Review URL: http://codereview.chromium.org/2832034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
when pressed, leaving "standard" buttons (like used on the toolbar) to darken as expected.
BUG=44574
TEST=test bookmark buttons and toolbar buttons with different themes, make sure the appearance isn't crappy
Review URL: http://codereview.chromium.org/2866031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Promote Stop() to engine interafce and make it Asynchronous.
2. Add Pause() and Flush() in engine interface.
3. Notify buffer return in ffmpeg engine so that future recycling could use it.
4. Add Pause logic in OMX decode engine.
to fully support seek in hardware path, some pipeline work and video render work is required. that will be in the next patch (maybe jia will write it).
1. some renderer hack is required for now. but current pause model of videoRenderBase is not suitable for hardware case. we need to resolve that.
2. Seek after EOS is not supported.
3. Seek for EGL image path is not yet tested, some code is required to return EGLImage buffer to allocator's side.
Review URL: http://codereview.chromium.org/2808022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
upstream. This is guaranteed to work as the HTML5DocumentParser class has since
been renamed to HTMLDocumentParser.
BUG=47080
TEST=None
Review URL: http://codereview.chromium.org/2807030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=erikkay
BUG=47575
TEST=Greener bot
Review URL: http://codereview.chromium.org/2822037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Issue was unreproducible, and recent valgrind bot runs do not show the
suppression being triggerred (e.g.
http://build.chromium.org/buildbot/memory/builders/Chromium%20OS%20UI%20(valgrind)(3)/builds/3971).
BUG=46421
TEST=none
Review URL: http://codereview.chromium.org/2803029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding extra buttons on the translate infobar to let user easily set the "never/always translate this language" property when they declined/accepted translation for a language more than 3 times.
Original review:
http://codereview.chromium.org/2825015/show
BUG=NONE
TEST=Visit a page in a foreign language, translate the page. Repeat 4 times. On the fourth time, the "before translate" infobar should show a button that says "always translate".
Similarly when declining translations 4 times.
Review URL: http://codereview.chromium.org/2835025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
that the dll unloads correctly
after every test.
Review URL: http://codereview.chromium.org/2813039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
There's still discussion about the design for this, so to minimize breakage on the dev channel, I'm backing the check out temporarily.
BUG=47675,45542
Review URL: http://codereview.chromium.org/2815035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47797
TEST=Open a new window, create 4 NTP tabs and 1 navigated tab. Close the window. The History menu has a "1 Tab" submenu with the navigated page.
Review URL: http://codereview.chromium.org/2800032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2821018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
when mouse is inside. Fix to gradient button to not show border on mouseover when disabled. Adjust "overlap" between the toolbar and bookmark bar to allow for larger buttons w/out clipping.
Nib change: All buttons changed to not bordered, button cell tags are 0. Buttons are 31x31 and spread out a bit more.
BUG=44574
TEST=toolbar and bookmark bar appearance, hidden, always showing, and detached on NTP.
Review URL: http://codereview.chromium.org/2806041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=rebuilt chromoting proj files
Review URL: http://codereview.chromium.org/2832033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For the actual changes, see
http://codereview.chromium.org/2843032/show
http://codereview.chromium.org/2001011/show
BUG=40496,38632
TEST=See TEST fields for the above two CLs.
TBR=gwilson
Review URL: http://codereview.chromium.org/2866030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=34647
TEST=none
Review URL: http://codereview.chromium.org/2836032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
of its children.
I made the parent_ pointer a WeakPtr. It is correct to not free the offscreen texture ID if the parent is destroyed first. It is freed as part of the parent's destruction.
TEST=trybot
BUG=47594
Review URL: http://codereview.chromium.org/2882004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
are bad.
BUG=44797
TEST=make sure control-alt-b doesn't work.
Review URL: http://codereview.chromium.org/2885003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47809
TEST=notifications on windows
Review URL: http://codereview.chromium.org/2861035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=erikkay
BUG=47575
TEST=Greener bots
Review URL: http://codereview.chromium.org/2887001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds test coverage for the various update cases to make sure they are all handled correctly.
Also fixes a regression during the recent PasswordStore refactoring that caused the Mac implementation to run queries on the wrong thread (found by the new unit tests).
BUG=35603
TEST=See bug; other password update cases should continue to work as before.
Review URL: http://codereview.chromium.org/2818035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=thestig
BUG=47863
TEST=Greener valgind bots
Review URL: http://codereview.chromium.org/2810039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=levin
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2832032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44407
TEST=Perform the steps outlined in the bug and verify that after step #5 the folders are no longer still active.
Review URL: http://codereview.chromium.org/2849026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Turns out calling Close() from an infobar class to close it is a bad idea
as it only removes its associated view so it is not displayed, but the
tab contents still belives it is showing.
RemoveInfoBar() should be called instead.
I made the InfobarContainer methods private and made InfobarContainer a friend
to prevent other people from running into the same problem.
BUG=47669
TEST=Open a www.google.de In the translate infobar, click Nope. Navigate away
from the page, it should not crash.
Review URL: http://codereview.chromium.org/2873029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
chromium-linux-fontconfig-renderstyle.html is failing because of differences in
the Freetype library across platforms. Suppress this test until I can spin up
a build on a Hardy box to generate a new baseline.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Tooltip text is changed from email to "<display name> (<domain>)".
BUG=cros:2318
TEST=Verify that tooltips are shown only for users with equal display names. Tooltips show display name and domain.
Review URL: http://codereview.chromium.org/2877002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
doesn't appear in latest logs, so no point in keeping the code around.
BUG=44642
TEST=none
Review URL: http://codereview.chromium.org/2824036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=sky
BUG=47575
TEST=Green dbg-shlib Linux bot
Review URL: http://codereview.chromium.org/2827035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crosbug.com/323
TEST=none
Review URL: http://codereview.chromium.org/2870033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47846
TBR=dglazkov,patrick,huanr
Review URL: http://codereview.chromium.org/2847034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
linux/views.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2811023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47844
TEST=TSan/Mac should become green
TBR=glider
Review URL: http://codereview.chromium.org/2799040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=47843
TBR=glider
Review URL: http://codereview.chromium.org/2827034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47839
TBR=patrick,dglazkov
Review URL: http://codereview.chromium.org/2855028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
setup right for Xcode (when expressed in the .gyp files). So this shouldn't be needed any more.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2848030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TSan/Win
TBR=glider
BUG=47836
Review URL: http://codereview.chromium.org/2876015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The members added into ViewMsg_Print_Params will be used to tell
printers' setting to renderer process.
Maybe ViewMsg_Print_Params::printable_size should be printable_area,
but I've just added margin_top and margin_left for now because
printable_size is used from several code so I wanted to avoid
a big change.
The members added into ViewHostMsg_DidPrintPage_Params will be used
to tell web authors' page setting to browser process.
BUG=47277
TEST=none
Review URL: http://codereview.chromium.org/2805045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=levin
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2810038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tracking patch by mavrommatis, original review here:
<http://codereview.chromium.org/1991005>
Original description follows:
(1) Group plugins with the same name together. (2) Show a download link for
plugin versions with known security problems in about:plugins.
BUG=3910
TEST=Open "chrome://plugins", see that plugins are grouped, and that any vulnerable plugins are marked red. Try enabling and disabling plugin groups.
Review URL: http://codereview.chromium.org/2835018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2743003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
There is a case while SocketStream is connecting, WebSocketJob is closed and SocketStream notifies it is connected. In this case, we should just ignore OnConnected event.
BUG=47818
TEST=websocket/tests/url-with-credential.html
Review URL: http://codereview.chromium.org/2823034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2886001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2852027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=mnaganov@chromium.org
TEST=None
BUG=None
Review URL: http://codereview.chromium.org/2859032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47277
TEST=none
Review URL: http://codereview.chromium.org/2847025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51104 0039d316-1c4b-4281-b951-d872f2087c98
|