summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Delete bad sleep based testsgman@google.com2009-07-211-21/+0
| | | | | | | | | | | If you need the tests, refractor them to follow the guidelines instead of having them fail intermittently http://big.corp.google.com/~joejoejoe/testing/2008/05/episode-90-sleeping-synchronization_27.html Review URL: http://codereview.chromium.org/159117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21209 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for keys not working when plugin has focus in pingpong sample.apatrick@google.com2009-07-211-15/+4
| | | | | | | | http://code.google.com/p/o3d/issues/detail?id=67 Review URL: http://codereview.chromium.org/155872 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21208 0039d316-1c4b-4281-b951-d872f2087c98
* Make GTK file dialog box modal for parent window, instead of for the entireestade@chromium.org2009-07-215-7/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | application. This works by adding the top-level GtkWindow objects, such as BrowserWindowGtk and BookmarkManagerGtk, to their own unique window groups. Without this change, all top-level windows are added to a default application-wide window group. This ensures that all grabs created with gtk_grab_add(...) only affect the window group of the grabbed widget, as opposed to the entire application. Note that gtk_window_set_modal(...) is implemented with gtk_grab_add(...) and therefore is only modal to a specific window group. In order for this to work correctly, changes were also made to the info bubble and render widget popup (<select> tag) code. Since these widgets also call gtk_grab_add(...), they must be added to the top level window group to work correctly. Test 1: - Open two new chrome window: A and B - Open "Save file as..." dialog in window A - Verify that window A does not respond to keyboard or mouse events. - Verify that window B does responde to keyboard and mouse events. - Open "Save file as..." dialog in window B - Verify that window B does not respond to keyboard or mouse events. - Cancel dialog on window A. - Verify that window A starts responding to keyboard and mouse events. - Cancel dialog on window B. - Verify that window B starts responding to keyboard and mouse events. Test 2: - Verify that <select> tag allows for correct selection of items. Test 3: - Click bookmark star and verify that info bubble works correctly. BUG=8727 TEST=none patch by Mohit Muthanna Cheppudira <mohit.muthanna [at] gmail> original review url: <http://codereview.chromium.org/155852> Review URL: http://codereview.chromium.org/159147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21207 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Popup notification is readable with dark themes in chrome theme mode.erg@google.com2009-07-212-2/+50
| | | | | | Review URL: http://codereview.chromium.org/155860 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21206 0039d316-1c4b-4281-b951-d872f2087c98
* Make download shelf themeable.thakis@chromium.org2009-07-211-45/+33
| | | | | | | | BUG=none TEST=Install a theme, notice that the download shelf now at least somewhat fits with the new theme. Review URL: http://codereview.chromium.org/159126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21205 0039d316-1c4b-4281-b951-d872f2087c98
* Widen jam's suppression from this morning to match different inlining choicesdkegel@google.com2009-07-211-0/+1
| | | | | | | | | BUG=16128 TEST=watch valgrind ui bots go green Review URL: http://codereview.chromium.org/155867 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21204 0039d316-1c4b-4281-b951-d872f2087c98
* This change list improves IME support on Linux. Many corner cases that were notestade@chromium.org2009-07-213-180/+616
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | handled in original code are addressed, for example the input method in password box case. The most important change in this CL is the change to key event processing flow. In old code, a key event will first be sent to webkit then dispatched to IME for filtering. With this CL, a key event will first be dispatched to IME for filtering, then how to send the event to webkit is decided by the filtering result. This CL tries to emulate the keyboard input behavior on Windows as much as possible. For example, if a keydown event is filtered by IME, then its virtual key code will be changed to VK_PROCESSKEY(0xE5) to prevent webkit from processing it again. This behavior can workaround bug 16281. To test this CL, you may cut and save following html code into a file and open it in chrome. ------------------8<----cut here----->8--------------------- <html><head> <meta http-equiv="content-type" content="text/html; charset=utf-8"> <script> function keyEventHandler(event) { var props = [ "type", "charCode", "keyCode", "altKey", "ctrlKey", "shiftKey", "metaKey" ]; var info = document.getElementById('info'); var s = ''; for (var i in props) { s += props[i] + ':' + event[props[i]] + ' '; } info.value += s + '\n'; } function textEventHandler(event) { info.value += "type:" + event['type'] + " data:" + event['data'] + '\n'; } function passwordChangeEventHandler(event) { var input2 = document.getElementById('input2'); info.value += "password:" + input2.value + '\n'; } function onLoad() { var input = document.getElementById('input'); input.addEventListener('keydown', keyEventHandler, false); input.addEventListener('keyup', keyEventHandler, false); input.addEventListener('keypress', keyEventHandler, false); input.addEventListener('textInput', textEventHandler, false); var input2 = document.getElementById('input2'); input2.addEventListener('change', passwordChangeEventHandler, false); } </script> </head><body onload="onLoad()"> <input id="input" size="20"> <input id="input2" type="password" size="20"> <p> <textarea id="info" rows="40" cols="150"></textarea> </p></body></html> ------------------8<----cut here----->8--------------------- This CL was confirmed to fix following issues: BUG=16281 "arrow keys and backspace/delete keys move/delete two characters at a time when xim immodule is used" BUG=16282 "Disable IMEs in a password input" BUG=16596 "fcitx (chinese input method) not working in ubuntu 9.04" BUG=16659 "Crash near RenderWidgetHostViewGtk::IMEUpdateStatus" BUG=16699 "Can't move cursor to omnibox and use input method if cursor is currently in a text input box in web page." BUG=16796 "Input method issue: When inputting text in a text box, if there is a composition string then pressing Backspace or Delete will cause the composition string be cleared and the text box refuses to accept any further input. All tests assume above html code is used. TEST=Start scim with "scim -d" and start chrome with GTK_IM_MODULE=xim and XMODIFIERS=@im=SCIM. Type something in input box, eg. "hello", then press backspace, to see if only one character is deleted. TEST=Move cursor to password input box, press ctrl-space to see if input method is not activated. Switch keyboard layout to Canadian-French then type a'[{' key and an 'a' key, then press enter, to see if a Latin character "U+00E2" is inputted in password box. TEST=Install fcitx with "sudo apt-get install fcitx" (assume you are using Ubuntu/Debian). Open a terminal, export XMODIFIERS=@im=fcitx and GTK_IM_MODULE=xim then run fcitx, then start chrome. Move cursor into an input box, press ctrl-space and input something, eg. "nihao" then press space. Check if some Chinese characters are inputted. TEST=Start chrome with GTK_IM_MODULE=scim. Move cursor into a text input box then move into a password box, chrome should not crash. TEST=Move cursor into a text input box, then click omnibox, and see if the text input box has lost focus. Press ctrl-space to activate input method, then type something, and see of the input goes into omnibox. TEST=Move cursor into a text input box and enable a Chinese Pinyin input method, then type something, eg. "dajiahao", make sure a composition string is displayed in the text input box, then press backspace and see if there is still a composition string and backspace is handled by input method. patch by James Su <james.su [at] gmail> original review URL: <http://codereview.chromium.org/149755> Review URL: http://codereview.chromium.org/155869 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21203 0039d316-1c4b-4281-b951-d872f2087c98
* Fix two crashers with TOOLKIT_VIEWS build:ben@chromium.org2009-07-212-2/+11
| | | | | | | | | | | - NativeViewHostGtk::RemovedFromWidget crashes due to WidgetGtk::window_contents_ being NULL... basically when RemovedFromWidget is called from the RootView's dtor, the window_contents_ and widget_ properties of the containing WidgetGtk are NULL. It seems acceptable to not clean up in this case. - TabContentsViewGtk dtor needs to call CloseNow(). This is similar to ~TabContents() calling DestroyWindow on the view's HWND. Without this, the TabContentsViewGtk object was destroyed but the corresponding GtkWidget wasn't, and so subsequent signal handlers would crash. BUG=none TEST=none Review URL: http://codereview.chromium.org/159130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21202 0039d316-1c4b-4281-b951-d872f2087c98
* Use a real download item.thakis@chromium.org2009-07-2110-254/+762
| | | | | | | | | BUG=14659,17100 TEST=Download multiple things. Items should now be inserted from the left. When a download is in progress, the time to completion should be displayed, when it's done the time should fade out and the filename should move down. Download items should appear in a sweep animation. Clicking the download directly should open it; clicking the arrow on the right of the download item should show the correct context menu. If a download filename is long, it should be elided in the middle. Review URL: http://codereview.chromium.org/159060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21201 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Get text color from a label object; this should fix some theme ↵erg@google.com2009-07-212-18/+23
| | | | | | | | | | | | text problems. GTK Themes can set colors on a per widget basis, and many do. Previously we were getting the text color from a GtkWindow object, which sometimes is wrong--the theme just sets the text color on labels... Review URL: http://codereview.chromium.org/159143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21200 0039d316-1c4b-4281-b951-d872f2087c98
* Add theme support for the yellow star on the Mac.avi@chromium.org2009-07-214-610/+659
| | | | | | | | | BUG=none TEST=go to a bookmarked page; the outline of the yellow star should be themed Review URL: http://codereview.chromium.org/155851 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21199 0039d316-1c4b-4281-b951-d872f2087c98
* Don't dispatch the extensions bindings unload event during GC.mpcomplete@chromium.org2009-07-211-12/+26
| | | | | | | | | BUG=17289 TEST=no Review URL: http://codereview.chromium.org/159095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21197 0039d316-1c4b-4281-b951-d872f2087c98
* Skia merge 250:278agl@chromium.org2009-07-212-3/+7
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21196 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION build from 195.0 to 196.0jon@chromium.org2009-07-211-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21194 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Detect control-key changes in autocomplete field.shess@chromium.org2009-07-215-1/+97
| | | | | | | | | http://crbug.com/10934 TEST=Type 'something', and press Control. Autocomplete should show www.something.com at the top. If that's what you'd get anyhow, try a different word. Control-enter should take you there. Review URL: http://codereview.chromium.org/159105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21192 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Prevent the field from updating the font panel and any ruler state.shess@chromium.org2009-07-211-0/+13
| | | | | | Review URL: http://codereview.chromium.org/155816 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21190 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring of tabbed-pane component so it can be ported to Linux toolkit_view.jcampan@chromium.org2009-07-2114-131/+401
| | | | | | | | BUG=None TEST=Make sure the Options dialog still works as expected (tab selection, focus traversal...) Review URL: http://codereview.chromium.org/155668 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21189 0039d316-1c4b-4281-b951-d872f2087c98
* o3djs.utils.makeClients checks that Renderer has been initialized.apatrick@google.com2009-07-211-1/+5
| | | | | | | | Prevents case where init callback is called before NPP_SetWindow (which initializes the renderer). Review URL: http://codereview.chromium.org/155716 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21188 0039d316-1c4b-4281-b951-d872f2087c98
* Fix another d&d crash that happens when the tab contentstc@google.com2009-07-214-10/+51
| | | | | | | | | | | | | | | | is swapped out while a drag is happening. Since the tab contents is swapped out, our RVH that the drag started on is no longer valid. Simply null out the pointer and no longer try to send feedback to the drag source. This allows the user to continue the drag even though the source RVH is gone. BUG=16073 Review URL: http://codereview.chromium.org/159040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21187 0039d316-1c4b-4281-b951-d872f2087c98
* Add FirefoxImporterTest.Firefox3NSS3Decryptor to filter list.erikkay@google.com2009-07-211-0/+3
| | | | | | | | | | BUG=17370 TEST=FirefoxImporterTest.Firefox3NSS3Decryptor isn't run by the purify bots TBR=wtc Review URL: http://codereview.chromium.org/159141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21186 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for the URL status bubble overlapping the download shelf.paul@chromium.org2009-07-2110-15/+70
| | | | | | | | | | BUG=14662 (http://crbug.com/14662) TEST=Download something so that the shelf is visible and make sure that hovering over links on the page produce a status bubble above the download shelf. Review URL: http://codereview.chromium.org/155706 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21185 0039d316-1c4b-4281-b951-d872f2087c98
* Adding 17366 and 17367 to known list.huanr@chromium.org2009-07-211-0/+6
| | | | | | Review URL: http://codereview.chromium.org/155859 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21184 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: In GTK mode, bookmark buttons should be the same size as "Other ↵erg@google.com2009-07-211-0/+21
| | | | | | | | | | bookmarks". Disable all possible things a theme can do to make this false on the GtkToolbar widget. Review URL: http://codereview.chromium.org/155821 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21183 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: pass users' font settings through to renderer.agl@chromium.org2009-07-2112-22/+136
| | | | | | | | | | | | The renderer doesn't give the settings to Skia yet -- that'll go in after agl's work on hinting and subpixel rendering in Skia. http://codereview.chromium.org/155787 (Patch by Dan Erat) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21182 0039d316-1c4b-4281-b951-d872f2087c98
* Update the callstack of a supressed leak since my recent code refactoring ↵jam@chromium.org2009-07-211-2/+3
| | | | | | | | | changed the callstack. TBR=dkegel Review URL: http://codereview.chromium.org/155836 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21181 0039d316-1c4b-4281-b951-d872f2087c98
* Fix single process mode and the unit_tests on Linux.jam@chromium.org2009-07-214-12/+20
| | | | | | | argh, this used to work in my previous change but it must have regressed before checkin. Review URL: http://codereview.chromium.org/155846 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21180 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: mute accidental refresh requests while on DevTools window.pfeldman@chromium.org2009-07-211-0/+13
| | | | | | | | BUG=12956 Review URL: http://codereview.chromium.org/159132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21177 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools Profiler: small UI improvements.mnaganov@chromium.org2009-07-212-2/+36
| | | | | | | | | | | | - if profile is generated, and no profile is shown, show the new one; - display processed ticks count during processing to show that we're alive. BUG=none TEST=none Review URL: http://codereview.chromium.org/159135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21176 0039d316-1c4b-4281-b951-d872f2087c98
* Script to build valgrind for chromiumdank@chromium.org2009-07-211-0/+34
| | | | | | Review URL: http://codereview.chromium.org/155848 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21170 0039d316-1c4b-4281-b951-d872f2087c98
* Add way to override optimization level for release build. dkegel@google.com2009-07-211-1/+4
| | | | | | | | | | Will be used with valgrind to speed up the bots more. This was suggested during http://codereview.chromium.org/67199, finally need it. Review URL: http://codereview.chromium.org/155817 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21169 0039d316-1c4b-4281-b951-d872f2087c98
* Set GTK_PATH to CHROMIUM_SAVED_GTK_PATH before launching xdg-open.thestig@chromium.org2009-07-213-3/+37
| | | | | | | | | | | | Wrappers that launch Chromium will need to set CHROMIUM_SAVED_GTK_PATH before modifying GTK_PATH. This can be done later in separate CLs. BUG=15565 TEST=see bug Review URL: http://codereview.chromium.org/159112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21168 0039d316-1c4b-4281-b951-d872f2087c98
* Add a bogus baseline for LayoutTests/media/controls-styling.html to appease ↵ericroman@google.com2009-07-213-0/+12
| | | | | | | | | | | | | | | | the layout test runner script. It complains if there are no baselines, even though this test is expected to fail. (The upstream mac baseline was removed in <http://trac.webkit.org/changeset/46140>). TEST=none BUG=http://crbug.com/13907 TBR=paul Review URL: http://codereview.chromium.org/155844 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21167 0039d316-1c4b-4281-b951-d872f2087c98
* Update a test expectationeroman@chromium.org2009-07-211-1/+1
| | | | | | | | | BUG=http://crbug.com/17332 TBR=rniwa Review URL: http://codereview.chromium.org/155843 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21166 0039d316-1c4b-4281-b951-d872f2087c98
* Disable RenderThread unittests. They're causing the unit tests to not complete.thestig@chromium.org2009-07-211-2/+2
| | | | | | | TBR=jam Review URL: http://codereview.chromium.org/159127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21165 0039d316-1c4b-4281-b951-d872f2087c98
* Remove tests that now pass again from the selenium test failureager@chromium.org2009-07-211-1/+1
| | | | | | | | | | | expectations. BUG=16691 TBR=nsylvain@chromium.org Review URL: http://codereview.chromium.org/159125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21164 0039d316-1c4b-4281-b951-d872f2087c98
* Adding ignores.thomasvl@chromium.org2009-07-210-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21162 0039d316-1c4b-4281-b951-d872f2087c98
* Add crashing layout tests to list.eroman@chromium.org2009-07-211-0/+2
| | | | | | | | | | TEST=NONE BUG=http://crbug.com/17332 TBR=rniwa Review URL: http://codereview.chromium.org/155837 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21161 0039d316-1c4b-4281-b951-d872f2087c98
* Enable DOM_STORAGE in our build. Put LocalStorage and SessionStorage behind ↵jorlow@chromium.org2009-07-219-10/+113
| | | | | | | | their own flags. Add the beginnings of StorageNamespaceProxy since it implements WebCore::StorageNamespace::____StorageNamespace and we'd get link errors otherwise.--enable-local-storage and --enable-session-storage are the new flags. If you enable them and try to use DOM Storage, Chromium will crash.Originally Committed in http://src.chromium.org/viewvc/chrome?view=rev&revision=21059 but then backed out due to include path issues.BUG=4360TEST=none Review URL: http://codereview.chromium.org/159059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21157 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit merge 46141:46143.eroman@chromium.org2009-07-212-1/+8
| | | | | | | | | | TEST=NONE BUG=NONE TBR=paul Review URL: http://codereview.chromium.org/155832 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21156 0039d316-1c4b-4281-b951-d872f2087c98
* Updating test expectation bug number.scherkus@chromium.org2009-07-211-1/+1
| | | | | | | | | | BUG=17287 TEST=none Review URL: http://codereview.chromium.org/159123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21155 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r21137 to fix Chromium mac valgrindhclam@chromium.org2009-07-2119-190/+196
| | | | | | | | TBR=scherkus Review URL: http://codereview.chromium.org/159122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21154 0039d316-1c4b-4281-b951-d872f2087c98
* Remove qtfaststart for now from build filefbarchard@chromium.org2009-07-211-7/+0
| | | | | | Review URL: http://codereview.chromium.org/159121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21153 0039d316-1c4b-4281-b951-d872f2087c98
* Add link button for certificate management, linking to wiki page ↵mattm@chromium.org2009-07-212-1/+38
| | | | | | | | | | LinuxCertManagement BUG=11507 Review URL: http://codereview.chromium.org/159115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21152 0039d316-1c4b-4281-b951-d872f2087c98
* Add a layout test to expectations list which crashes on mac following webkit ↵eroman@chromium.org2009-07-211-2/+3
| | | | | | | | merge (is a new test). Review URL: http://codereview.chromium.org/155833 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21151 0039d316-1c4b-4281-b951-d872f2087c98
* qt-faststart is a tool that moves the 'moov' to the start of file, reducing ↵fbarchard@chromium.org2009-07-212-0/+333
| | | | | | | | | | | | | | startup latency. This version handles 'free' atoms, which are produced by mp4box and other tools, but impact ffmpeg seeks on playback. The code follows ffmpeg coding standards. BUG=17304 TEST=instrument seeks or measure latency performance and play videos with and without qt-faststart applied to the data. Review URL: http://codereview.chromium.org/149439 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21150 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes for selenium test failures. Using the color factor to correct color ↵vangelis@google.com2009-07-212-4/+4
| | | | | | | | | | differences in 2d sample. Increasing the pixel diff threshold for texturesamplers and zsorting to its previous glory until we figure out what the proper values are. Bumping up DEPS for assets to pick up new reference image for zsorting sample. Review URL: http://codereview.chromium.org/159120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21149 0039d316-1c4b-4281-b951-d872f2087c98
* linux: use tiny font in tab stripevan@chromium.org2009-07-211-2/+2
| | | | | | | | BUG=15864 Review URL: http://codereview.chromium.org/159119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21148 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit merge 46126:46141.eroman@chromium.org2009-07-212-1/+5
| | | | | | | | | | BUG=NONE TBR=paul TEST=NONE Review URL: http://codereview.chromium.org/159110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21146 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Fix RTL layout of page title for strong right-to-left characters. When ↵jhawkins@chromium.org2009-07-211-0/+4
| | | | | | | | | | pango detects strong RTL characters in the layout, it switches the text direction. For our uses of DrawStringInt, we've already handled the layout and don't want the direction switched. This matches the behavior of Windows. BUG=16970 TEST=Open a browser in a RTL language. Navigate to google.com and notice that the tab title is right-aligned. Open up the history page and notice that the title (in Hebrew) is right-aligned as well. Review URL: http://codereview.chromium.org/155829 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21145 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: allow the desktop file name to be given in an environment variable ↵mdm@chromium.org2009-07-212-5/+17
| | | | | | | | | | | for development Chromium builds, to avoid conflicting with packaged Chromium. BUG=none TEST=none Review URL: http://codereview.chromium.org/159108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21144 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 13:36:25 +0000