summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Implement "Email Link To Page" menu command.snej@chromium.org2009-12-039-10/+53
| | | | | | | | | | | | | | | | | | | This menu item only exists in the Mac build, but the code is cross-platform so it could be hooked up on other platforms as well, if desired. It works by generating a URL of the form mailto:?subject=Fwd:%20PAGETITLE&body=%0A%0APAGEURL and telling platform_utils to open it. This is my first patch involving command handling; I've tried to follow the way similar menu commands like Print are implemented, but feel free to tell me if there are better ways. I didn't find any place for unit tests for TabContents; if this needs tests, let me know where they should go. BUG=29232 TEST=none Review URL: http://codereview.chromium.org/466019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33746 0039d316-1c4b-4281-b951-d872f2087c98
* widget_gtk: Alphabetize CallXXX() functions.tony@chromium.org2009-12-032-114/+125
| | | | | | | | | | | BUG=None TEST=None Patch written by Thiago Farina <thiago.farina@gmail.com>. Review URL: http://codereview.chromium.org/451001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33745 0039d316-1c4b-4281-b951-d872f2087c98
* Revert some of the change to go back to multiple experimentscpu@chromium.org2009-12-035-11/+12
| | | | | | | | | | | | | | | - Brian wants two experiments - This is not a full revert because I need to merge to 195 in stages BUG=none TEST=none TBR=kuchhal Review URL: http://codereview.chromium.org/467009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33744 0039d316-1c4b-4281-b951-d872f2087c98
* Switch Mac plugins back to a UI runloopstuartmorgan@chromium.org2009-12-033-44/+49
| | | | | | | | | | | This makes Cocoa-event plugins (e.g., Flash 10.1 preview) happier, and Carbon full-screen still gets key events. BUG=28000 TEST=Flash 10.1 preview should play even without mouse movement. Flash 10 full screen should still accept keyboard commands (e.g., esc). Review URL: http://codereview.chromium.org/460052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33743 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable the appcache layout tests with more specific expectations for the ↵jennb@chromium.org2009-12-031-8/+16
| | | | | | | | | | | flaky tests. TEST=none BUG=2844 Review URL: http://codereview.chromium.org/468010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33742 0039d316-1c4b-4281-b951-d872f2087c98
* This "new" trace has come up several times with NPSWF at the very top of the ↵vandebo@chromium.org2009-12-031-0/+2
| | | | | | | | | | | trace. i.e. http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Reliability/builds/7140/steps/reliability:%20complete%20result%20of%20previous%20build/logs/stdio BUG=none TEST=green reliability bot Review URL: http://codereview.chromium.org/468009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33741 0039d316-1c4b-4281-b951-d872f2087c98
* Extension Doc Changes (no building or testable changes)rafaelw@chromium.org2009-12-0363-98/+106
| | | | | | | | | | | | Fix pageTitle/pageName error (and do some cleanup to try to prevent confusion in the future). Note that the pageData-title has changed to pageData-name in all the static pages. TBR=kathyw,aa Review URL: http://codereview.chromium.org/465039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33740 0039d316-1c4b-4281-b951-d872f2087c98
* Makes views not draw focus for native controls on Gtk. As Gtk renderssky@chromium.org2009-12-0314-12/+63
| | | | | | | | | | | the focus for us, this resulted in double the focus indicators. BUG=none TEST=none Review URL: http://codereview.chromium.org/468004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33739 0039d316-1c4b-4281-b951-d872f2087c98
* roll deps to pick up mac lighttpd .so files.tony@chromium.org2009-12-031-1/+1
| | | | | | | | TBR=ojan Review URL: http://codereview.chromium.org/468007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33738 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes the layout test formatter to properly detect new form of the layout ↵gwilson@google.com2009-12-031-1/+1
| | | | | | | | | | | | test summary, should find failures successfully. R=ojan BUG=none TEST=run layout test formatter against one of the canaries, it should find failures Review URL: http://codereview.chromium.org/465032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33735 0039d316-1c4b-4281-b951-d872f2087c98
* Un-revert r33715 (i.e., re-apply r33709 and r33640), we think the failures weredpranke@google.com2009-12-038-1006/+594
| | | | | | | | | | | | false negatives. R=ojan@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/462024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33733 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome updates should not change shortcut icon if there is an index ↵kuchhal@chromium.org2009-12-034-10/+176
| | | | | | | | | | | specified in prefs file. BUG=none TEST=Specify a chrome with alternative icon (using master prefs), install an update and make sure the icon doesnt change. Review URL: http://codereview.chromium.org/455041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33732 0039d316-1c4b-4281-b951-d872f2087c98
* Send Keystone ID to Omaha for Extensions Gallery update checks.asargent@chromium.org2009-12-031-0/+16
| | | | | | | | | | | This is the OSX complement to http://src.chromium.org/viewvc/chrome?view=rev&revision=32853 BUG=b/2168147 TEST=extension autoupdate should still work on MacOS Review URL: http://codereview.chromium.org/431033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33731 0039d316-1c4b-4281-b951-d872f2087c98
* Move lighttpd to deps. Step 2: remove from trunk/src and updatetony@chromium.org2009-12-03115-2801/+6
| | | | | | | DEPS for mac and win to pull from trunk/deps/third_party. Review URL: http://codereview.chromium.org/460051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33730 0039d316-1c4b-4281-b951-d872f2087c98
* Update an inaccurate expectation.ojan@chromium.org2009-12-031-5/+8
| | | | | | Review URL: http://codereview.chromium.org/463019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33729 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the deprecated version of FixupURL and fix the callers.thakis@chromium.org2009-12-037-24/+14
| | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/455022 Patch from tfarina. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33728 0039d316-1c4b-4281-b951-d872f2087c98
* Fix data races in Safe Browsing Service that were possible with aggressive ↵pkasting@chromium.org2009-12-032-14/+31
| | | | | | | | | | compiler optimizations. BUG=28559 TEST=none Review URL: http://codereview.chromium.org/455039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33726 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DCHECK that thinks fd = 0 is invalid.thestig@chromium.org2009-12-031-1/+1
| | | | | | | | BUG=25762 TEST=none Review URL: http://codereview.chromium.org/466023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33725 0039d316-1c4b-4281-b951-d872f2087c98
* Rename README.txt to README.chromium to reflect that it containsevan@chromium.org2009-12-031-0/+0
| | | | | | Chrome-specific notes. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33724 0039d316-1c4b-4281-b951-d872f2087c98
* Rename AtomicFlag to CancelFlag, change its semantics a bittimurrrr@chromium.org2009-12-037-147/+141
| | | | | | Review URL: http://codereview.chromium.org/454025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33723 0039d316-1c4b-4281-b951-d872f2087c98
* Don't ping for extension blacklist when no extensions are installed.pam@chromium.org2009-12-034-5/+44
| | | | | | | | BUG=24168 TEST=covered by unit tests Review URL: http://codereview.chromium.org/466012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33720 0039d316-1c4b-4281-b951-d872f2087c98
* Make no-tcmalloc (really, non-base/allocator) builds work again,dank@chromium.org2009-12-038-32/+81
| | | | | | | | | | | | | | | | | | | | | | | | | | | | (i.e. this is a plain vanilla build used when layers like base/allocator are getting in the way of debugging) and make sure they use msvcrt rather than libcmt (libcmt is used to help shim malloc/free, but it gets in the way of valgrind doing the same thing). Sadly, this is now a gyp-time operation rather than a Configuration option. Had to remove hardcoded C prototype for _set_new_mode, as that caused link errors. Also add variables win_{release,debug}_{Optimization,RuntimeLibrary} to let the valgrind build override those settings. Fix calling convention on _set_new_mode to match the one in <new.h> BUG=none TEST=build with ~/.gyp/include.gypi set as described in comment in common.gypi, gclient runhooks, do release build, verify all exe's and dll's linked against msvcrt dll Review URL: http://codereview.chromium.org/455037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33719 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce the logging output when running startup tests on linux/mac.tony@chromium.org2009-12-031-1/+1
| | | | | | Review URL: http://codereview.chromium.org/464021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33717 0039d316-1c4b-4281-b951-d872f2087c98
* Rollback r33709, r33640 until we can figure out why the output is gettingdpranke@google.com2009-12-038-594/+1006
| | | | | | | | | | | | interleaved in the buildbots on linux ... BUG=none R=ojan TEST=none Review URL: http://codereview.chromium.org/464022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33715 0039d316-1c4b-4281-b951-d872f2087c98
* Mark the tests as disabled on mac with a bug to revisit, this should allow ↵thomasvl@chromium.org2009-12-031-2/+12
| | | | | | | | | | browser_tests to run on the mac. BUG=29331 TEST=none Review URL: http://codereview.chromium.org/466021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33713 0039d316-1c4b-4281-b951-d872f2087c98
* Change WideToASCII to WideToUTF8 to ensure that CJK tips are properly displayed.mirandac@chromium.org2009-12-031-1/+1
| | | | | | | | | BUG= none TEST= CJK tips should display properly. Review URL: http://codereview.chromium.org/467003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33712 0039d316-1c4b-4281-b951-d872f2087c98
* Shard the fast and http directories on the V8-latest webkit bots.ojan@chromium.org2009-12-032-3/+12
| | | | | | | | | With the layout tests dashboard we can identify new flakiness that results. If the flakiness is small and manageable, then we can turn this on for all the bots. Review URL: http://codereview.chromium.org/467005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33711 0039d316-1c4b-4281-b951-d872f2087c98
* Add mpeg audio mime type allowing mp3 to play with chrome on more websites.fbarchard@chromium.org2009-12-031-0/+1
| | | | | | | | | BUG=29288 TEST=play this file: http://www.louderproductions.com/mp3/Killshot.mp3 and make sure controls work. Review URL: http://codereview.chromium.org/455044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33710 0039d316-1c4b-4281-b951-d872f2087c98
* Modify run_webkit_tests to process results incrementally as they happen, insteaddpranke@google.com2009-12-032-32/+24
| | | | | | | | | | | | | | of in a batch at the end. This by itself is a pretty useless change, but will allow us to actually display results more coherently as they occur (which will show up in my next patch). R=ojan@chromium.org TEST=none BUG=none Review URL: http://codereview.chromium.org/464011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33709 0039d316-1c4b-4281-b951-d872f2087c98
* Remove change-values-from-transition as a flaky test from test_expectations, ↵jparent@chromium.org2009-12-031-2/+0
| | | | | | | | | | | | | | as it is no longer flaky. Upstream fix: http://trac.webkit.org/changeset/51613/ Visual dipictrion of un-flakiness: http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/flakiness_dashboard.html#tests=LayoutTests%2Ftransitions%2Fchange-values-during-transition.html BUG=10403,9798 TEST=none Review URL: http://codereview.chromium.org/460045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33708 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mac perf moz expectation.chase@chromium.org2009-12-031-1/+1
| | | | | | | | | BUG=29318 TEST=mac moz perf test goes green Review URL: http://codereview.chromium.org/466020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33707 0039d316-1c4b-4281-b951-d872f2087c98
* Remove erroneous DCHECK that is reached when loading pages that don't call ↵robertshield@chromium.org2009-12-032-11/+21
| | | | | | | | | | | | | | | out to wininet like about:blank. Altering constant name pulled in from latest platform SDK to avoid naming conflicts for those with said SDK. Add slightly more logging to error messages. BUG=DCHECK hit when loading about:blank. TEST=Load about:blank in a debug build and no DCHECK is seen. Review URL: http://codereview.chromium.org/465030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33706 0039d316-1c4b-4281-b951-d872f2087c98
* Extension Doc Changes (no building or testable changes)rafaelw@chromium.org2009-12-0338-230/+563
| | | | | | | | | | This includes three minor doc changes. (1) Conditional text for description of callback based on whether it is optional -- to be less confusing. (2) Setting the page title to "" from the static pageData-title no longer shows a leading " - ". (C) Allows for a page to specify whether it shows the sideNav (and index.html declines to do so). TBR=kathyw,aa Review URL: http://codereview.chromium.org/460039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33705 0039d316-1c4b-4281-b951-d872f2087c98
* Linux is showing this leak with fun:malloc on the stack twice, so add a ... ↵thomasvl@chromium.org2009-12-031-0/+1
| | | | | | | | | | to try and only catch an optional extra one. BUG=20113 TEST=none Review URL: http://codereview.chromium.org/460046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33703 0039d316-1c4b-4281-b951-d872f2087c98
* Adding product names to safe browsing report_error and report_phish URLs on ↵robertshield@chromium.org2009-12-031-2/+15
| | | | | | | | | | | | Windows. These names will be different for Google Chrome, Chromium and Chrome Frame. On Mac / Linux, leaving the name as "googlechrome" for all builds. BUG=None TEST=Verify that the safe browsing URLs are tagged with the correct product name for each product. Review URL: http://codereview.chromium.org/455035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33702 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a profile leak I've seen a few times the yesterday/today.thomasvl@chromium.org2009-12-031-0/+11
| | | | | | | | TEST=none BUG=29325 Review URL: http://codereview.chromium.org/463018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33701 0039d316-1c4b-4281-b951-d872f2087c98
* Add perf expectations for vista, other tests.chase@chromium.org2009-12-031-0/+16
| | | | | | | | | BUG=29318 TEST=perf tests are green Review URL: http://codereview.chromium.org/464019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33699 0039d316-1c4b-4281-b951-d872f2087c98
* Do not set io_loop_ to NULL until we have deleted request_ and setwtc@chromium.org2009-12-031-4/+3
| | | | | | | | | | | | | | request_ to NULL, otherwise Cancel() may fail to post a CancelURLRequest task because io_loop_ is NULL but request_ is not NULL. (That task adds a reference to the OCSPRequestSession object to ensure that it lives longer than the URLRequest object.) R=ukai BUG=28526 TEST=none Review URL: http://codereview.chromium.org/460040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33698 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed typo.apatrick@google.com2009-12-031-1/+1
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/468001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33697 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid implicit char*-to-AtomicString conversion, which will soon become illegal.snej@chromium.org2009-12-031-1/+1
| | | | | | | | | | | | (See https://bugs.webkit.org/show_bug.cgi?id=30187 for the patch that will remove this conversion.) BUG=29313 TEST=none Review URL: http://codereview.chromium.org/465033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33696 0039d316-1c4b-4281-b951-d872f2087c98
* Misc. cleanup of safe_browsing_util.cc:pkasting@chromium.org2009-12-033-178/+135
| | | | | | | | | | | | | | | | | | | | * Shorten code where easy to do so * Remove an unneeded line * Better function parameter names for one function * Be consistent about not using {} on one-line bodies (some places did, some didn't) * Be consistent about using "a" and "!a" instead of "a != 0" and "a == 0" (some places did one, some did the other) * No else after return/continue * Reduce duplicated code by reordering lines * Use for () instead of while () where doing so would shorten things * More comments in a few places * Use iterators in a few cases where doing so avoids more verbose or complex code * Name a few constants BUG=none TEST=none Review URL: http://codereview.chromium.org/452043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33695 0039d316-1c4b-4281-b951-d872f2087c98
* Change BugReportView to use the bug report types from the cross-platform ↵mirandac@chromium.org2009-12-031-23/+12
| | | | | | | | | | | BugReportUtil class. BUG= 27281 TEST= "report bug" dialog in windows should not change at all. Review URL: http://codereview.chromium.org/464017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33694 0039d316-1c4b-4281-b951-d872f2087c98
* Backout webkit roll.sky@chromium.org2009-12-031-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/463016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33693 0039d316-1c4b-4281-b951-d872f2087c98
* Rolling WebKit DEPS forward to 51622.atwilson@chromium.org2009-12-031-1/+1
| | | | | | | | TBR=ajwong BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33689 0039d316-1c4b-4281-b951-d872f2087c98
* Make new FTP LIST parsing code more robust.phajdan.jr@chromium.org2009-12-0315-16/+386
| | | | | | | | | | | | | | Some highlights: - more tests (including non-ASCII characters in different encodings) - handling more variants of "ls" listing - handling spaces in file names in "ls" listings TEST=Covered by net_unittests. BUG=25520 Review URL: http://codereview.chromium.org/449011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33688 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: FIXME -> TODO, viettrungluu@gmail.com -> viettrungluu, remove ↵viettrungluu@chromium.org2009-12-038-13/+13
| | | | | | | | | | | whitespace at EOL. BUG=none TEST=none Review URL: http://codereview.chromium.org/467002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33687 0039d316-1c4b-4281-b951-d872f2087c98
* Notify user that Chrome is already synced if promo banner "sync me" link is ↵mirandac@chromium.org2009-12-033-2/+16
| | | | | | | | | | | clicked. BUG= 28795 TEST= sync bookmarks, then click "sync" link in promo again. see notification that you are already synced. Review URL: http://codereview.chromium.org/462011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33685 0039d316-1c4b-4281-b951-d872f2087c98
* linux: use TabContents to launch url for link in crash pagekuan@chromium.org2009-12-033-26/+40
| | | | | | | | | | | - used to use BrowserList::GetLastActive but that's null in chrome-frame release. - TabContents is passed into constructor and only if it's non-null is the link created. BUG=29034 TEST=verify that crash per bug report doesn't happen. Review URL: http://codereview.chromium.org/466016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33684 0039d316-1c4b-4281-b951-d872f2087c98
* Add regex escaping code to Mac sandbox implementation and re-enable the ↵jeremy@chromium.org2009-12-039-31/+452
| | | | | | | | | | | | | | | utility process on OS X. Other changes: * An error initializing the sandbox on OS X is now treated as fatal. * Improved error reporting for sandbox-related failures. BUG=26492,23837 TEST=Installing extensions and themes should still work on OS X. Review URL: http://codereview.chromium.org/434077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33682 0039d316-1c4b-4281-b951-d872f2087c98
* Add paranoid logging to ChannelImpl::ProcessOutgoingMessages() to help track ↵jeremy@chromium.org2009-12-031-1/+10
| | | | | | | | | | | down bug. BUG=29225 TEST=none Review URL: http://codereview.chromium.org/462021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33677 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-06-03 08:02:01 +0000