| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=240165
NOTRY=true
Review URL: https://codereview.chromium.org/109893002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The feature was disabled due to http://crbug.com/310407 , and I'd like to enable the feature again by default.
BUG=310407
TEST=Done manually.
Review URL: https://codereview.chromium.org/108003002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The hung renderer dialog did not explicitly set its app id. This causes
unpredictable grouping. This patch explicitly sets the app id of the
hung renderer dialog to the app id of browsers of the same profile.
BUG=306961
TEST=With chrome exited, open app launcher. Open a chrome tab which points at google.com. Enter chrome:hang into the url bar. The dialog that pops up after a few seconds should be grouped with the browser and not the app launcher.
Review URL: https://codereview.chromium.org/107943002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
GetTempDir() does not do file IO, therefore it can be used from other threads
to create file paths. No other platform implementation has that assert.
Review URL: https://codereview.chromium.org/76633002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Idealy this should be added to PRESUMIT like it's being done
in https://codereview.chromium.org/109263003/.
BUG=None
TEST=app_list_unittests
TBR=xiyuan@chromium.org
Review URL: https://codereview.chromium.org/109783002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(PortSuggester) to suggest what ephemeral source port
should be used when opening a UDP client socket in QUIC.
This should increase the likelihood of 0-RTT connections, even if a strike server is not used across a server cluster.
BUG=326545
Review URL: https://codereview.chromium.org/107803002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
used on. Add "ws" and "wss" to that list.
This CL adds them even on iOS, where the libnet WebSocket implementation is not
used, but this should be harmless.
BUG=319104
TEST=net_unittests
Review URL: https://codereview.chromium.org/71523003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=322188
Review URL: https://codereview.chromium.org/99153005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to allow regex matches in gtest to be shared between Windows and other
systems, we tell gtest to always use it's internal engine.
The syntax supported by the internal engine initially looks like a subset of
POSIX regexs. However character class shortcuts are not valid POSIX.
Even more confusingly the system POSIX regex function often defines extra
features not actually part of the standard allowing regex that work on Linux
fail on Mac OS X.
A search through the code base did not reveal any locations where features not
supported by the internal regex engine where used.
See bug https://code.google.com/p/chromium/issues/detail?id=317224 for more detailed description.
BUG=317224
Review URL: https://codereview.chromium.org/55983002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=263527
TEST=manual
Review URL: https://codereview.chromium.org/98403009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=CrOS Asan bots get greener
R=sadrul@chromium.org, sadrul
TBR=oshima
Review URL: https://codereview.chromium.org/100863004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the CL was committed with an incorrect description
TBR=pkotwicz@chromium.org
Review URL: https://codereview.chromium.org/109683003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=307622
TEST=AcceleratorCommandsBrowserTest.ToggleFullscreen
Manual
1) Enable "Enable immersive fullscreen for non browser windows" in chrome://flags
2) Open the task manager
3) With the task manager having focus, hit <F4>. Check that the window goes fullscreen
4) Hover the mouse at the top of the screen. Check that the window controls slide onscreen
5) Hit <F4> again. Check that the window exits fullscreen.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239403
R=benwells@chromium.org, oshima@chromium.org
Review URL: https://codereview.chromium.org/84743003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=299782
TBR=ilevy@chromium.org
Review URL: https://codereview.chromium.org/108733003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
"custom_display_name" must be set only if the "name" field is CUSTOM.
Removed optional values.
Review URL: https://codereview.chromium.org/108253004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
there is a pending read or pending write, we could read/write into a
buffer that was already released.
BUG=273917, 326715
R=jar@chromium.org
Review URL: https://codereview.chromium.org/107413005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The compositor is notified of a lost context event through the ContextProvider's
lost context callback. We also had various pieces of code that expilcitly polled
the context to see if it was still alive and attempted to fail faster if the context
was lost. This logic is not really necessary, however, since on a lost context the
callback will always be invoked sooner or later and these early exit + recover paths
add significantly complexity to the compositor and the context bindings.
This strips out code that polls for a lost context inside cc and instead performs
recovery on the lost context callback.
This also stops attempting to make the compositor's context current before making calls.
Since we use the object-oriented C++ bindings to talk to the context implementation,
there's no need to update the current context pointer in TLS in order to issue GL calls.
Ganesh still uses the TLS pointer for its bindings so we do have an entry point to make
that context current when necessary.
BUG=181120
Review URL: https://codereview.chromium.org/107193003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
DEFLATE compression.
R=agl@chromium.org,rsleevi@chromium.org
BUG=326618
TEST=none
Review URL: https://codereview.chromium.org/106683003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=xiyuan@chromium.org
BUG=313904
TEST=manually
Review URL: https://codereview.chromium.org/105773004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=263527
TEST=manual
Review URL: https://codereview.chromium.org/104063003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removing offsetting of focus rect as this introduces painting
artifacts and doesn't look good. Additionally moves painting of focus
rect to PaintChildren() since we need the focus rect to appear on top
of the omnibox view.
BUG=326356
TEST=none
Review URL: https://codereview.chromium.org/104043006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Nobody in components/autofill/core/browser is including from
chrome/common/, so this entry is not necessary anymore.
BUG=140037
TBR=joi@chromium.org
Review URL: https://codereview.chromium.org/100473007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=covered by test
R=ben@chromium.org
Review URL: https://codereview.chromium.org/98073007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
JSON schemas are used by extensions that support enterprise management,
to declare the policies that they support. The current parser rejects
schemas with unknown attributes; this CL lifts that restriction for 2 reasons:
- the JSON schema spec does not mandate this behavior for validators
- it restricts future extensions to this format
BUG=108992
Review URL: https://codereview.chromium.org/94043003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is not point in including ui/base/ui_export.h in files outside of
the domain of ui/base, since UI_EXPORT is intended to be used within
only the files built into 'ui' target.
BUG=299841
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/93513005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This uses the gpu::gles2::GLES2Interface type in the gl renderer's shader
and program code instead of WebGraphicsContext3D. For production code, the
GLES2Interface is a direct interface to the real command buffer in use. For
cc_unittests, the GLES2Interface is a stub that wraps TestWebGraphicsContext3D
so we can continue to use the same stubs/mocks for now. Once we port all of
the production code over to using GLES2Interface we should port the test context
classes over to the new base interface.
BUG=181120
Review URL: https://codereview.chromium.org/93433004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
module doesn't exit)
BUG=226278
Review URL: https://codereview.chromium.org/91483002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=307622
TEST=AcceleratorCommandsBrowserTest.ToggleFullscreen
Manual
1) Enable "Enable immersive fullscreen for non browser windows" in chrome://flags
2) Open the task manager
3) With the task manager having focus, hit <F4>. Check that the window goes fullscreen
4) Hover the mouse at the top of the screen. Check that the window controls slide onscreen
5) Hit <F4> again. Check that the window exits fullscreen.
Review URL: https://codereview.chromium.org/84743003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome's bookmarks via a policy.
BUG=108992
TEST=None
Review URL: https://codereview.chromium.org/10817029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke all bots 9_9
> Revert 239280 "Move more file_util functions to base namespace."
>
> dbus_unittests started fialing on Linux Tests (dbg)(2) and Linux Tests (dbg)(2)(32).
> This CL is the only in the intersection of CLs in the first failing build on
> the two builders, so giving a speculative revert a try (rlarocque already
> tried a clobber, it didn't help).
>
> http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29/builds/41806
> http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29%2832%29/builds/8544
>
>
> > Move more file_util functions to base namespace.
> >
> > TBR=sky
> >
> > Review URL: https://codereview.chromium.org/109043002
>
> TBR=brettw@chromium.org
>
> Review URL: https://codereview.chromium.org/105823009
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/100923007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
dbus_unittests started fialing on Linux Tests (dbg)(2) and Linux Tests (dbg)(2)(32).
This CL is the only in the intersection of CLs in the first failing build on
the two builders, so giving a speculative revert a try (rlarocque already
tried a clobber, it didn't help).
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29/builds/41806
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29%2832%29/builds/8544
> Move more file_util functions to base namespace.
>
> TBR=sky
>
> Review URL: https://codereview.chromium.org/109043002
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/105823009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The code moved to component/policy can be included on iOS, but can't depend
on chrome/. This move includes an exception for the policy protobufs:
- the generic cloud policy protobufs will be moved into a new repository,
due to a dependency from a ChromeOS package
- the user cloud policy protobuf and its decoding will move into a new component
for user policy
BUG=271392
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/109743002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This test tries to verify Chrome OS multi-profile behavior but does not actually
enable multi-profile support.
BUG=326832
TBR=dzhioev@chromium.org
Review URL: https://codereview.chromium.org/109703002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/104433007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The purpose if this is to reduce the overhead of timeline recording so that speed index might be run with page cyclers.
It's been established that timeline events should be inaccessible by Telemetry measurements until recording is stopped, so it seems reasonable to switch to this mode for any timeline recording.
BUG=295334
Review URL: https://codereview.chromium.org/46503003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=318535
TEST=Shrink Chrome browser window to be as short as possible, ensure that the
rAc dialog is still usable.
R=groby@chromium.org
Review URL: https://codereview.chromium.org/109453002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=pkasting@chromium.org
Review URL: https://codereview.chromium.org/109073002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This obsoletes the WebGraphicsContext3D::setVisibilityCHROMIUM call and
instead routes surface visibility notifications from the compositor to
the gpu stack through gpu::ContextSupport and from the gpu stack to the
command buffer embedder through gpu::GpuControl. The implementation of
gpu::ContextSupport (GLES2Implementation) frees up command buffers/etc
that it owns and the implementation of gpu::GpuControl
(CommandBufferProxyImpl) sends the content IPC that drives the memory
manager.
This means migrating some logic from content::WebGraphicsContext3DCommandBufferImpl
down to gpu::GLES2Implementation, such as the free everything when invisible.
BUG=181120
R=piman
Review URL: https://codereview.chromium.org/107663002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When there are several cards with same Chrome ID, we now not simply choose the one with the highest priority and call it a day.
Instead, for every moment of time, we show the card with the highest priority, chosen from ones that should be visible at this moment.
Also, added Closure annotations to enable static type analysis.
BUG=164227
Review URL: https://codereview.chromium.org/107033002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added the basic implementation of NfcAdapterChromeOS, with no tag/peer logic.
BUG=316471
TEST=device_unittests
Review URL: https://codereview.chromium.org/100393011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/105743007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=Automated. Added RemoteToLocalSyncerTest.Conflict_CreateNestedFolderOnFile
BUG=240165
Review URL: https://codereview.chromium.org/104503002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We will now inspect outcome of /ListAccounts call to check if the primary
session SID/LSID cookies got run over by browser session restore process.
For now, the outcome of this test is just reported as a UMA histogram.
BUG=309131
TEST=none
Review URL: https://codereview.chromium.org/103463003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Speculative fix to see if there's any perf change.
BUG=325311
TEST=none
R=willchan@chromium.org
Review URL: https://codereview.chromium.org/109363002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(a) Add support for three new columns: street address, dependent locality, and
sorting code.
(b) Migrate data stored in the address_line_1 and address_line_2 columns into
the new street_address column, and drop the old columns.
(c) Drop two long deprecated columns: country (as opposed to country code) and
phone number type (fax vs. phone).
BUG=299154
TEST=unit_tests
R=estade@chromium.org
Review URL: https://codereview.chromium.org/101093002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=estade@chromium.org
BUG=323334
TEST=unit_tests, no bubble hiding w/ form.onautocomplete = function(){ this.submit(); };
Review URL: https://codereview.chromium.org/107193004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/98063004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This simply provides an in-memory registration in ServiceWorkerContext. It provides basic registration/unregistration,
adding stub ServiceWorkerRegistry and ServiceWorkerVersion classes.
BUG=285976
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/62203007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also Copy{From,To} -> Convert{From,To}.
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/101743003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239379 0039d316-1c4b-4281-b951-d872f2087c98
|