| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
I got to undo some hacks, too!
TEST=compiles
Review URL: http://codereview.chromium.org/5535003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This does two things:
- Adds a mode to the DOMUI List class where the list auto-sizes.
- Overrides the default list styling to make it more like the mocks (just basic cosmetic styling at this point).
BUG=None
TEST=Lists in DOMUI prefs should look more like the current mocks.
Review URL: http://codereview.chromium.org/5628001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=content settings page displays
Review URL: http://codereview.chromium.org/5632001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=yutak
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
respectively.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/5527003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Client doesn't crash when shuttind down connection.
Review URL: http://codereview.chromium.org/5604002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=60761
TEST=interactive_ui_tests and repro steps in bug
Review URL: http://codereview.chromium.org/5326011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=glider@chromium.org
BUG=16128
TEST=none
Review URL: http://codereview.chromium.org/5516003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
should not expose functions that aren't accessible to normal plugins. The
proxy can just use the trusted interface directly without having a public C++
wrapper.
TEST=it compiles
BUG=53889
Review URL: http://codereview.chromium.org/5532001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
version of this API synchronous. Otherwise, the caller may end up trying to
draw over the text that isn't there yet.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/5555004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=65170
TEST=unit_tests
Review URL: http://codereview.chromium.org/5619001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=63423
TEST=Open DOMUI prefs, highlight a startup page, then open the search engine manager subpage. The selected row should not draw over the sheet.
Review URL: http://codereview.chromium.org/5544003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=rafaelw@chromium.org
BUG=39963
TEST=none:w
Review URL: http://codereview.chromium.org/5530003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The logic that parses responses from Google Accounts servers was
defaulting to INVALID_GAIA_CREDENTIALS, which indicate a successful
communication with teh backend that resulted in a failing
authentication attempt. Gibberish was thus interpreted this way. We
should instead interpret gibberish as an unsuccessful communication
attempt.
BUG=chromium-os:8943
TEST=unit tests, installed on device and ran successful login and failed login autotests. Also tried live login.
Review URL: http://codereview.chromium.org/5309007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
TBR=erg
Review URL: http://codereview.chromium.org/5611003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
update it.
BUG=57904
TEST=none
Review URL: http://codereview.chromium.org/5524004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is in preparation of moving the lists to the sub-sub-pages (which don't exist yet).
This leaves the settings in a slightly less usable state as there is no way to add new exceptions or remove old ones. Tough luck, about:flags canariers.
BUG=64153
TEST=lists are always visible; have borders; OTR lists are visible when an otr session is active and not when it's not
Review URL: http://codereview.chromium.org/5427001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
requiring 'experimental' permission without --enable-experimental-extension-apis
flag.
BUG=none
TEST=ExtensionManifestTest.ExperimentalPermission
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
user attempts
to reload a ChromeFrame page which was received as a result of a top level form post.
We should also not be treating form resubmits as top level navigations being routed back
to the host browser as this nullifies the effect of the form post.
Fixes portions of bug http://code.google.com/p/chromium/issues/detail?id=64901
BUG=64901
TEST=Navigate to the url mentioned in the bug in ChromeFrame and on posting the form hit
F5. This should put up a confirmation dialog and on accepting it should display the
expected values on the page.
Review URL: http://codereview.chromium.org/5530001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This property was used by the GPU process to determine whether a particular renderer process had the right to render to a window. It turns out that this is no longer needed because now the browser tells the GPU process which child compositor window to render to and the GPU process trusts the browser process.
Also uncovered and fixed a bug in gpu_channel_host.cc where the renderer would hang if the GPU process failed to return a command buffer.
TEST=try
BUG=64834
Review URL: http://codereview.chromium.org/5607001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=65171
TEST=none
Review URL: http://codereview.chromium.org/5627001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MediaResourceLoaderBridge.
One thing to notice is that both buffered_data_source_unittest and simple_data_source_unittest need to have a way to inject a MockWebURLLoader into the BufferedResourceLoader and the SimpleDataSource. In order to make sure a new one is not created during a Start(), I introduced the function SetURLLoaderForTest and keep_test_loader flag.
Patch by annacc@chromium.org:
http://codereview.chromium.org/3863002/
BUG=16751
TEST=src/xcodebuild/Debug/test_shell_tests --gtest_filter=Buffered*
src/xcodebuild/Debug/test_shell_tests --gtest_filter=Simple*
src/webkit/tools/layout_tests/run_webkit_tests.sh --debug media
webkit/tools/layout_tests/run_webkit_tests.sh --debug http/tests/media
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The initialization call was happening on one place on Windows, then later on OS X.
This moves Windows down alongside OS X.
The comment above this code, dating back to 2008, says that we must initialize
the sandbox before the crash handler. But this code as it currently works
runs way after we initialize breakpad (we do breakpad in WinMain, which
then loads this code from chrome.dll and runs it) and there is no breakpad
code in between its old location and its new one.
Review URL: http://codereview.chromium.org/5439003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Windows.
BUG=65109
TEST=Verified that the api isn't present on OSX with this change and that it is on Windows.
Review URL: http://codereview.chromium.org/5593001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
used to get inputs and outputs, but we have other scripts for
that now.
Review URL: http://codereview.chromium.org/5544001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the disallow_trusted_interfaces_ flag which I hardcoded to false. In the
future, we can use this to lock down the proxy more if necessary.
This also fixes a bug where I swapped two arguments in the audio proxy.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/5549004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This replaces many of the generic license templates with the
versions from the tarballs.
BUG=chromium-os:7840
TEST=looked at it; also got signoff from dannyb
TBR=davemoore
Review URL: http://codereview.chromium.org/5621001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=61847
TEST=Verified that the privacy note gets displayed on Chrome and Chrome OS correctly.
Review URL: http://codereview.chromium.org/5573004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
IEFrame handle.
BUG=65120
TEST=See Bug description.
Review URL: http://codereview.chromium.org/5578002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5589002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=65165
TEST=Manually tested that the notifications get smaller. Automated tests are my
next priority.
Review URL: http://codereview.chromium.org/5611001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=52689
TEST=Enable canvas 2D acceleration in about:flags, naviate to a page with canvas, Find "GPU.WebGraphicsContext3D_Init_CanLoseContext" in GPU.about:histograms
Review URL: http://codereview.chromium.org/5524001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=65175
TEST=none
TBR=estade@chromium.org
Review URL: http://codereview.chromium.org/5606003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
prevents O3D from loading.
TEST=loaded O3D several times in Chrome until the problem repro'ed and verified that O3D loaded and worked anyway
BUG=none
Review URL: http://codereview.chromium.org/5615001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:8552
TEST=See issue, but note: networks should only be remembered if the owner is logged in, i.e. 'guest' apples to any non owner login.
Review URL: http://codereview.chromium.org/5278011
TBR=stevenjb@google.com
Review URL: http://codereview.chromium.org/5548005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
It's been moved upstream with http://trac.webkit.org/changeset/73050
Review URL: http://codereview.chromium.org/5539004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
file_path_watcher into subdir
profile* into profiles/ subdir
login* into ui/login
visitedlink* into subdir
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/5606002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on the accelerated compositor for 3D CSS, Video, Plugins and Animations.
Also the compositor will now always be enabled for WebGL and accelerated 2D
canvas content.
In addition, added an about:flags entry for the flag using the same name and description as our old "enable accelerated compositing" entry had, however triggering the new flag.
This CL must be checked in after the patch for https://bugs.webkit.org/show_bug.cgi?id=50301 lands.
BUG=64589
Review URL: http://codereview.chromium.org/5421001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
for the pages containing non-HTML frames.
BUG=64986
TEST=DCHECK should not fire on pages containing non-HTML frames.
Review URL: http://codereview.chromium.org/5515001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Move the 'Enable Autofill' checkbox to the main page.
- Change 'Autofill options' to 'Manage Autofill settings'
BUG=63828, 63829
TEST=run chrome with --enable-tabbed-options, these two changes should be verified
on the Personal Stuff page.
Review URL: http://codereview.chromium.org/5379004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL is based on work by pinkerton@chromium.org.
BUG=39260,53508
TEST=With --enable-blocked-content-animation, visit http://popuptest.com and run a test. The omnibox should run an animation indicating a blocked popup.
Review URL: http://codereview.chromium.org/5297008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
user-level installation to complete without error.
Also fix the presubmit script to allow checkins to toolband_module.cc again (it was picking up DllRegisterServer members in a class declaration).
Also add line number printing to the presubmit error message.
BUG=62403
TEST=User-level installs of CF work again.
Review URL: http://codereview.chromium.org/5539002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=compiles, unittests
Review URL: http://codereview.chromium.org/5068001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The initialization call was happening on one place on Windows, then later on OS X.
This moves Windows down alongside OS X.
The comment above this code, dating back to 2008, says that we must initialize
the sandbox before the crash handler. But this code as it currently works
runs way after we initialize breakpad (we do breakpad in WinMain, which
then loads this code from chrome.dll and runs it) and there is no breakpad
code in between its old location and its new one.
Review URL: http://codereview.chromium.org/5439003
TBR=evan@chromium.org
Review URL: http://codereview.chromium.org/5522006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes a crash in which if a feedback tab is open and a user opens it from a different tab again, feedback will crash on sending a report. This is due to browser_navigator; this change decouples us from the Singleton tab logic and adds our own.
Additionally, code to take screenshots on other platforms is also added.
BUG=64971,61847
TEST=Tested by opening feedback from multiple tabs; sent reports successfully. Additionally tested with sending screenshots from Linux.
Review URL: http://codereview.chromium.org/5514001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
this would happen.
BUG=64836
TEST=none
Review URL: http://codereview.chromium.org/5591001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
touch.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/5364005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/5605001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68049 0039d316-1c4b-4281-b951-d872f2087c98
|