| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
As we didn't support animation of SVG, the original expected image was wrong.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/165232
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To read this crash dump, this issue is caused by my mistake that this jumplist.cc calls "icon_urls_.front()" for an empty list.
This change added some checks that verifies a std::list has one or more items.
This change also fixes linker errors because of conflicted symbols: CLSID_DestinationList and CLSID_EnumerableObjectCollection, which is caused by my mistake that I forgot removing "EXTERN_C" keywords when I moved them into an anonymous namespace. This change removes the "EXTERN_C" keywords for VS2008.
BUG=18837 "Crash - JumpList::OnFavIconDataAvailable(int,bool,scoped_refptr<RefCountedVector<unsigned char> >,bool,GURL)"
TEST=Show JumpList on Windows 7.
TEST=Build Chromium with VS2008.
Review URL: http://codereview.chromium.org/159853
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We must not see the vertical scrollbar. So, the original expected image was wrong.
BUG=9916
TEST=none
Review URL: http://codereview.chromium.org/164246
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=10476
TEST=none
Review URL: http://codereview.chromium.org/165231
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This happened because the name of SVG nodes are changed (RenderImage => RenderSVGImage).
BUG=10463
BUG=10998
TEST=none
Review URL: http://codereview.chromium.org/165228
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Diffs only font metrics
BUG=10282
TEST=none
Review URL: http://codereview.chromium.org/164245
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18333
TEST=none
TBR=agl
Review URL: http://codereview.chromium.org/164234
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This test is affected by an upstream change (NBSPs turning to spaces). See <http://code.google.com/p/chromium/issues/detail?id=15132#c5>.
BUG=15132
TEST=none
Review URL: http://codereview.chromium.org/164243
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
WebKit Inspector is localized using a JS file containing the following map:
localizedStrings[<english text>] = <translated text>;
Review URL: http://codereview.chromium.org/164066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is working just like Safari.
BUG=15132
TEST=none
Review URL: http://codereview.chromium.org/164242
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It pastes the content with blue color as expected.
BUG=9159
TEST=none
Review URL: http://codereview.chromium.org/165225
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It is working like Safari.
BUG=15132
TEST=none
Review URL: http://codereview.chromium.org/164239
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I tried to avoid unnecessary changes in this CL to help make it easier to
review.
As part of this CL, glue/webtextinput* are folded into WebFrame / WebFrameImpl.
R=dglazkov
BUG=10034
TEST=none
Review URL: http://codereview.chromium.org/164225
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to URLPickerDelegate.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/164149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a user pressed RELOAD, FORWARD, or BACK buttons.
Note that this change does not revert the bar when Command+r is pressed. That's intentional. Please see the comment #7 by pkasting in http://crbug.com/15464 .
Windows change: http://codereview.chromium.org/155908
Linux change: http://codereview.chromium.org/164137
BUG=18710
TEST=The same as http://codereview.chromium.org/155908 (except the F5 stuff since Chromium Mac seems not to support F5 reload?)
Review URL: http://codereview.chromium.org/164145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=60
TEST=Download something, open context menu, click "remove" -- item should be removed from shelf. It leaves a hole behind right now (bug 17831), will fix that later.
Review URL: http://codereview.chromium.org/160444
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
necessary 'chromium_builders' module when GYP gets updated to
use a more generic default.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/164216
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Switched to using the latest nacl and using their gyp files.
Added a copy/rename step so that o3dConverter gets the dll
it needs for other build steps.
BUG=None
TEST=None
TBR=gspencer
Review URL: http://codereview.chromium.org/164238
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it shouldn't be assumed that /MP should be set for O3D.
In particular this can disrupt O3D being build on the buildbot infrastructure
which uses VS2005 builders.
BUG=None
TEST=None
TBR=gspencer
Review URL: http://codereview.chromium.org/164237
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unlike gyp files, the hooks are run at the level the .gclient file is at.
So you want --depth=. (not ..)
This was causing the path to the platform sdk used in chromium's
common.gypi to be wrong.
BUG=None
TEST=None
TBR=gspencer
Review URL: http://codereview.chromium.org/164236
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=rafaelw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=rafaelw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/165045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
lower the window. This is Chromium's custom titlebar, not the one provided
by the window manager.
BUG=15430
Review URL: http://codereview.chromium.org/165123
Patch from Nigel Tao <nigeltao@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The existing code attempted to do this but it had a bug.
BUG=18530
Review URL: http://codereview.chromium.org/165094
Patch from Doug Muir <dmuir@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/164178
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
upstream.
TBR=jorlow
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/164233
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=18714
Review URL: http://codereview.chromium.org/164219
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://bugs.webkit.org/show_bug.cgi?id=28094 is in. Until then, this will be flaky and crash the browser.
TBR=jam
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/165211
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of the client area as a data url (which is a base64
encoded string of a png file)
data urls are part of the HTML5 standard and supported
by firefox, safari and chrome.
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#dom-canvas-todataurl
That means you can now do this
var dataURL = client.toDataURL();
// make an IMG tag display the screenshot
someImgTag.src = dataURL;
// use the IMG tag to draw into a canvas
someCanvasContext.drawImage(someImageTag, ...);
It also means there is no need for the test builds
anymore "test-dbg-d3d", "test-opt-d3d" etc as
toDataURL is part of the public API and can
therefore always be used to take screenshots
in any build.
I updated the selenium code to use it.
There are a few issues:
1) The GL version has the same limitations as taking
a screenshot before. Namely that the client area
must be on screen. We need to fix this.
2) We need to add support for origin-clean. See
https://tracker.corp.google.com/story/show/180334
Review URL: http://codereview.chromium.org/164130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jam
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/164227
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
For some reason when getting values back out of a
luminance texture the signs are all ABSed out
even though the texture displays correctly
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=5022
TEST=test_shell_tests
Review URL: http://codereview.chromium.org/165188
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebKit/WebCore to set WebCore::Page settings. Create an implementation that actually does the modifications. Alter glue/webview to create the instance lazily and alter the webPreference code to use it.
In the next CL, we'll pull the WebPreference code out of WebView completely, so this interface will be of more use.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/164087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
explicit casts that are no longer needed.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/164221
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Updated to include google_chrome_strings_*.xtb.
BUG= None
TEST= None
Review URL: http://codereview.chromium.org/165209
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
so that video can decide to use power of 2
if it needs to.
Review URL: http://codereview.chromium.org/164210
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
In addition to the xtbs, I've modified app_strings.grd to uncomment the
xtb bundles and use the correct path (remove 'resources/').
TEST= None
BUG= None
Review URL: http://codereview.chromium.org/164222
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/165134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ukai
BUG=10911,13336
TEST=Visit https://migs.mastercard.com.au/ma/. Chromium
should not say the cert is revoked.
Review URL: http://codereview.chromium.org/165206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is one string update, for
<message
name="IDS_FORM_FILE_MULTIPLE_UPLOAD"
desc="text to display next to file buttons in HTML forms when 2 or more files
are selected for uploading. This is not used for a case that just 1
file is selected."
>
R= tony,dglazkov
BUG= none
TEST= none
Review URL: http://codereview.chromium.org/165152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the main window, in the default theme, we still use the chrome icons.
There are still several more places that need updating: the tab strip, the task manager, etc. I will deal with that later.
BUG=13320
Review URL: http://codereview.chromium.org/165194
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16010,16638,17174
TEST=none
Review URL: http://codereview.chromium.org/165193
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
backward / forward cache.
Review URL: http://codereview.chromium.org/164174
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Reading past the last page of a mmapped file will SIGBUS.
BUG=18174
TEST=truncate Default/Cache/data_* to zero bytes, launch chrome, try to load a website. It shouldn't crash.
Review URL: http://codereview.chromium.org/165174
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
this bug was masked by how long bookmarks take to create in the primary window (as the bookmark system is loaded late)
BUG=18550
TEST=Install a theme with custom colors for bookmark bar text, then open a new window and verify that the bookmark bar text is themed correctly.
Review URL: http://codereview.chromium.org/165172
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Imports Glen's new icons, and creates centered versions of all of them. Then
use these icons in the GTK theme interface.
Also selects the button tinting color to be a lighter color on some very dark
backgrounds.
Review URL: http://codereview.chromium.org/164202
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22839 0039d316-1c4b-4281-b951-d872f2087c98
|