summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Relanding r22644, "GTK: Rounded corner on status bubble."erg@google.com2009-08-062-28/+128
| | | | | | | | | | | | | | The previous patch made ui_tests red because we don't always have a GdkWindow when a widget's size-allocate signal is called. Move all responsibility into the expose-event handler. http://crbug.com/18309 Original Review URL: http://codereview.chromium.org/164010 Review URL: http://codereview.chromium.org/164104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22692 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Remove tips and downloads and introduce a recently closed bar instead.arv@google.com2009-08-066-330/+168
| | | | | | | | | | | | | | Make the list mode only show one column and make the items look like links. BUG=None TEST= On the new tab page try opening and closing tabs and windows. The closed tabs and windows should appear in the recently closed bar at the bottom. Review URL: http://codereview.chromium.org/165095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22691 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: only-child-pseudo-class.html is working now.agl@chromium.org2009-08-061-1/+1
| | | | | | | BUG=17635 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22690 0039d316-1c4b-4281-b951-d872f2087c98
* Move ClosePage method to WebView.darin@chromium.org2009-08-067-16/+16
| | | | | | | | | | | | Since it is about closing a page, WebView is a better home for it. R=dglazkov BUG=10034 TEST=none Review URL: http://codereview.chromium.org/164105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22689 0039d316-1c4b-4281-b951-d872f2087c98
* When the plugin crashes, cleanup references to its window in the renderer.piman@chromium.org2009-08-067-2/+33
| | | | | | | | | This avoids spurious messages when the plugin crashes, and potential issues (plugin crashes, the HWND/XID gets destroyed, a new one gets created by a new instance and gets the same HWND/XID, the browser operates on the new one instead of the old one). Review URL: http://codereview.chromium.org/160614 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22688 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the error I introduced into the installer build.scons file.gspencer@google.com2009-08-061-1/+1
| | | | | | Review URL: http://codereview.chromium.org/165098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22687 0039d316-1c4b-4281-b951-d872f2087c98
* Enable new FTP for Windows TestShell so that the results of block-test.html aredarin@chromium.org2009-08-066-24/+8
| | | | | | | | | | | | | | | | | the same across platforms. WTC tells me that it should be ready to go, and it anyways is only exercised by these two security/block-test*.html tests. Also, add back the fix from r22651. Extend that fix a bit so that when we do not have a special mapping, we just spit out the existing error code value. This way, if we get an unexpected result, the output will tell us what the original error code was. This change doesn't impact any layout tests. R=dglazkov,wtc BUG=18665 TEST=none Review URL: http://codereview.chromium.org/165091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22686 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up copy pasta hotkeys in gtk bookmark manager.estade@chromium.org2009-08-062-4/+32
| | | | | | | | | | | Also change the display hotkey for tab reload from f5 (windowsy) to ctrl+r (linuxy). BUG=none TEST=use the new hotkeys Review URL: http://codereview.chromium.org/164097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22685 0039d316-1c4b-4281-b951-d872f2087c98
* Don't pack an empty label into bookmarks with empty titles.estade@chromium.org2009-08-061-9/+16
| | | | | | | | BUG=18348 Review URL: http://codereview.chromium.org/164101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22684 0039d316-1c4b-4281-b951-d872f2087c98
* Fix video sync error when framerate or playback rate is lowkylep@chromium.org2009-08-062-6/+15
| | | | | | | | BUG=18441 TEST=play a low framerate video or under low rate and verify it stays synced Review URL: http://codereview.chromium.org/160620 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22683 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding Coverity fixes from http://codereview.chromium.org/159862 ↵phajdan.jr@chromium.org2009-08-0610-14/+18
| | | | | | | | | | | | | excluding the broken ones. The change of GURL -> const GURL& caused some nasty crash and the change got reverted. TEST=none BUG=none Review URL: http://codereview.chromium.org/164095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22682 0039d316-1c4b-4281-b951-d872f2087c98
* CL 22502 dropped the app_strings as part of the switch, so we don't have ↵thomasvl@chromium.org2009-08-061-0/+3
| | | | | | | | | | some of the strings we actually need to run. BUG=none TEST=none (no really good way to confirm that app_strings are in there now, pending cl uses them). Review URL: http://codereview.chromium.org/164098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22681 0039d316-1c4b-4281-b951-d872f2087c98
* This completes the building of o3d.msi from the GYP build.gspencer@google.com2009-08-0615-35/+422
| | | | | | Review URL: http://codereview.chromium.org/164044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22680 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Pass font settings through to interstitial renderers.derat@chromium.org2009-08-065-46/+77
| | | | | | | | | BUG=18483 TESTED=restarted and visited a page with a broken SSL cert a few times while changing font settings via gnome-appearance-properties Review URL: http://codereview.chromium.org/164094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22679 0039d316-1c4b-4281-b951-d872f2087c98
* Add recent crash found by reliability bot to known_crashes.txt. Bug for ↵senorblanco@chromium.org2009-08-061-0/+2
| | | | | | | | | | | crash logged as 18700. BUG=http://crbug.com/18700 TEST=less redness == more goodness Review URL: http://codereview.chromium.org/165092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22678 0039d316-1c4b-4281-b951-d872f2087c98
* Flaky timeoutpkasting@chromium.org2009-08-061-1/+2
| | | | | | | | | TBR=ojan BUG=18702 TEST=none Review URL: http://codereview.chromium.org/165093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22677 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Don't choke when there's no selection in the bookmark editor tree view.estade@chromium.org2009-08-062-7/+24
| | | | | | | | | 1) disable "new folder" when no folder is selected 2) if a user clicks apply when no folder is selected, apply the title/url edits but leave it in its original location Review URL: http://codereview.chromium.org/164016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22676 0039d316-1c4b-4281-b951-d872f2087c98
* Properly size accepted dangerous downloads.estade@chromium.org2009-08-061-4/+6
| | | | | | | | BUG=18448 Review URL: http://codereview.chromium.org/165086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22675 0039d316-1c4b-4281-b951-d872f2087c98
* Add filters for IPC::SyncChannel leaks on purify.tim@chromium.org2009-08-061-0/+135
| | | | | | | | | | | | | | | | | | | | Most already are suppressed and have bugs for valgrind. RevocableStore- issue 17385 CreateChannel - issue 17979 IPC::Channel::Channel() - issue 17888 SyncChannel::SyncChannel - issue 16128 CreatePipe - issue 18696 ReceivedSyncMsgQueue - issue 8469 OnAddFilter - 18698 IPC::Channel::ChannelImpl::Connect - issue 18699 BUG=17385, 17979, 17888, 16128, 18696, 8469, 18698, 18699 Review URL: http://codereview.chromium.org/165088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22674 0039d316-1c4b-4281-b951-d872f2087c98
* Port of WebKit's appcache manifest parser code.michaeln@google.com2009-08-065-163/+516
| | | | | | | | | | | | | | | Added unittests for manifest parser to test_shell_tests. This is a clone of jennb's CL here. http://codereview.chromium.org/160608 TBR=jennb BUG=none TEST=manifest_parser_unittest.cc Review URL: http://codereview.chromium.org/165072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22673 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly handle extensions width in the GTK extension shelf.phajdan.jr@chromium.org2009-08-066-6/+14
| | | | | | | | | | | Also make the method name used on Windows shorter and more obvious. TEST=none http://crbug.com/16759 Review URL: http://codereview.chromium.org/164092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22672 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak in AudioRendererBaseTest::OneCompleteReadCyclehclam@chromium.org2009-08-062-2/+4
| | | | | | | | | | | | | | | | We should a local reference of the input buffer, so that buffer gets cleanup after it is out of scope. Also disabled AudioUtilTest.FoldChannels_s16_benchmark because it is running too long. It shold be run locally instead of on the build bots. TEST=media_unittests --gtest_filter=AudioRendererBaseTest.OneCompleteReadCycle TBR=scherkus Review URL: http://codereview.chromium.org/165087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22671 0039d316-1c4b-4281-b951-d872f2087c98
* Define _FILE_OFFSET_BITS=64 in order to support large files (>2GB).thestig@chromium.org2009-08-064-282/+253
| | | | | | | | | | | | | | | | | | _FILE_OFFSET_BITS=64 is incompatible with fts (issue 17492), so file_util::Delete, file_util::CopyDirectory file_util::FileEnumerator are reimplemented without fts. Delete and CopyDirectory are now implemented using FileEnumerator. Patch from vandebo@google.com, original review: http://codereview.chromium.org/160479 BUG=13718,17492 TEST=none Review URL: http://codereview.chromium.org/165085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22670 0039d316-1c4b-4281-b951-d872f2087c98
* Add patch to the Linux build deps script.thestig@chromium.org2009-08-061-1/+1
| | | | | | Review URL: http://codereview.chromium.org/160622 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22669 0039d316-1c4b-4281-b951-d872f2087c98
* Move consistent crashers into their own bugs.dglazkov@chromium.org2009-08-061-2/+2
| | | | | | | | | TBR=pkasting TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22668 0039d316-1c4b-4281-b951-d872f2087c98
* Submitting http://codereview.chromium.org/164076 for syf1984@gmail.com (aka ↵robertshield@chromium.org2009-08-063-3/+57
| | | | | | | | | | | | miletus): Make the timeout in WaitToStart() of TestServerLauncher parametrized and expose this parameter to HTTPTestServer::CreateServer() TBR=syf1984@gmail.com, tommi@chromium.org Review URL: http://codereview.chromium.org/164090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22667 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the size of a cancelled download in the download shelf.paul@chromium.org2009-08-062-5/+3
| | | | | | | | | | | | | Patch created by Thiago Farina, original CL: http://codereview.chromium.org/160465 BUG=17180 (http://crbug.com/17180) TEST=Download some file, then cancel it and notice the shelf UI does not any longer display the size of download. Review URL: http://codereview.chromium.org/165073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22666 0039d316-1c4b-4281-b951-d872f2087c98
* Report apt-get failures in install-build-deps.shdkegel@google.com2009-08-061-14/+35
| | | | | | | | | Patch from gmatht, originally reviewed at http://codereview.chromium.org/160630 Review URL: http://codereview.chromium.org/164091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22665 0039d316-1c4b-4281-b951-d872f2087c98
* Properly handle invalid server control responses.phajdan.jr@chromium.org2009-08-062-1/+28
| | | | | | | | | | | We should immediately stop the ftp network transaction in such case. TEST=Covered by net_unittests. http://crbug.com/18546 Review URL: http://codereview.chromium.org/164067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22664 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 22651.darin@chromium.org2009-08-062-2/+1
| | | | | | Review URL: http://codereview.chromium.org/165084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22663 0039d316-1c4b-4281-b951-d872f2087c98
* Switch extension update manifest parse errors to LOG(WARN).asargent@chromium.org2009-08-061-1/+1
| | | | | | | | | | | | | | | | Before this patch they are using ExtensionErrorReporter, but I don't think it's actually useful for users to see them on the chrome://extensions page. BUG=http://crbug.com/18565 TEST=You should no longer see messages like "Extension update manifest parse error: Invalid codebase url"on the chrome://extensions page. Review URL: http://codereview.chromium.org/164008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22662 0039d316-1c4b-4281-b951-d872f2087c98
* Another day, another round of suppressions from my local continous mac ui ↵dank@chromium.org2009-08-063-13/+61
| | | | | | | | | | | | | | | valgrind run. Move one suppression from 6547 to new bug 18664 as we widen it, 'cause 6547 was marked closed, and the history was messy. Also disable ErrorPageTest.DNSError_GoBack2Forward2 -- it hangs often on mac under valgrind, possibly a bug in valgrind. BUG=6547,16628,18661,18664 TEST=swing mac around your head on its power cord, see if any memory leaks out Review URL: http://codereview.chromium.org/165076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22661 0039d316-1c4b-4281-b951-d872f2087c98
* More theme fixes.tc@google.com2009-08-065-30/+38
| | | | | | | | | | | | | | 1) Fix the bookmark bar to draw the same as the toolbar (tile the background image and have a transparent background). 2) Fix the tab backgrounds to be offset correctly rather than always drawing as if we're the first tab. Some small code cleanup in views/tabs/tab_renderer.h. Review URL: http://codereview.chromium.org/165078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22660 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: handle Escape in omnibox when numlock/scrolllock/caps lock is on.estade@chromium.org2009-08-061-1/+2
| | | | | | | | | BUG=18643 TEST=turn on num lock. Escape in omnibox resets the address. Review URL: http://codereview.chromium.org/165079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22659 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Enable MediaLeakTest.*"scherkus@chromium.org2009-08-061-2/+2
| | | | | | | | | | | TBR=hclam BUG=18461 TEST=tests should be disabled Review URL: http://codereview.chromium.org/165082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22658 0039d316-1c4b-4281-b951-d872f2087c98
* Updated to o3d revision 113.apatrick@google.com2009-08-061-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22657 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "GTK: Rounded corner on status bubble."erg@google.com2009-08-062-124/+28
| | | | | | | | | | This reverts commit d98d01314c8b0905ac236d98dc39508ad8acfd05 (r22644). This should make the linux ui tests green. Review URL: http://codereview.chromium.org/164086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22656 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of warning on CHROME_OS builder.jam@chromium.org2009-08-061-2/+2
| | | | | | Review URL: http://codereview.chromium.org/165080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22655 0039d316-1c4b-4281-b951-d872f2087c98
* Renderer busy looping after video (with sound) or audio endshclam@chromium.org2009-08-062-2/+76
| | | | | | | | | | | | BUG=18434 TEST=AudioRendererBaseTest.CompleteLifeTime This patch fixes the busy looping and leaks by ignore the end-of-stream packet. Review URL: http://codereview.chromium.org/165023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22654 0039d316-1c4b-4281-b951-d872f2087c98
* Enable message ports for workers.jam@chromium.org2009-08-0624-86/+283
| | | | | | | TEST=included ui test Review URL: http://codereview.chromium.org/160576 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22653 0039d316-1c4b-4281-b951-d872f2087c98
* Updated wav_ola_test.kylep@chromium.org2009-08-061-1/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/165026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22652 0039d316-1c4b-4281-b951-d872f2087c98
* With our posix TCP implementation, attempting to load an URL with IP addressdarin@chromium.org2009-08-062-1/+2
| | | | | | | | | | | | | | | | 255.255.255.255 results in ERR_ADDRESS_UNREACHABLE whereas on Windows it results in ERR_ADDRESS_INVALID. Map both of these errors to the same value of -1004 for the sake of matching the layout test behavior of WebKit for the Mac. This may also fix ChromiumMac, but I haven't tested it there yet. R=dglazkov BUG=18665 TEST=none Review URL: http://codereview.chromium.org/165077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22651 0039d316-1c4b-4281-b951-d872f2087c98
* Linux valgrind UI bot has a flaky leak. Suppress it (see bugsenorblanco@chromium.org2009-08-061-0/+15
| | | | | | | | | | | for trace). BUG=http://crbug.com/18654 TEST=Linux valgrind UI tests greener Review URL: http://codereview.chromium.org/164082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22650 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the Mac-specific implementation of LaunchApp, and share the Linux ↵stuartmorgan@google.com2009-08-064-151/+77
| | | | | | | | | | | | | version. Fixes a race condition with file descriptors, and gives the Mac access to the environment-alterning version of LaunchApp BUG=11174 TEST=Launching render/plugin/utility processes should still work on the Mac Review URL: http://codereview.chromium.org/165067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22649 0039d316-1c4b-4281-b951-d872f2087c98
* Remove linux crash expectation for LayoutTests/fast/canvas/set-colors.html.erg@google.com2009-08-061-4/+0
| | | | | | | | | | | Upstream bug was fixed and test did not crash after 100 iterations locally, nor did valgrind find anything amiss. http://crbug.com/10439 Review URL: http://codereview.chromium.org/164083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22648 0039d316-1c4b-4281-b951-d872f2087c98
* Test is flaky on release as well.tim@chromium.org2009-08-061-1/+1
| | | | | | | | | BUG=15267 TBR=pkasting Review URL: http://codereview.chromium.org/165074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22647 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: use 'settings' for system libpng.agl@chromium.org2009-08-061-1/+1
| | | | | | | | It turns out that 'settings' is the correct GYP target type for this sort of thing. Thanks to Evan for pointing out my mistake. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22646 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add GYP flag to build with system jpeg.agl@chromium.org2009-08-062-68/+96
| | | | | | | | | | This follows the general style of r21663, which we agreed was the way to do this. http://codereview.chromium.org/164080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22645 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Rounded corner on status bubble.erg@google.com2009-08-062-28/+124
| | | | | | | | http://crbug.com/18309 Review URL: http://codereview.chromium.org/164010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22644 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a "not all control paths return a value" warning and correct indentation.darin@chromium.org2009-08-061-3/+6
| | | | | | | | | | R=scherkus BUG=none TEST=none Review URL: http://codereview.chromium.org/165034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22643 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-14 19:53:35 +0000