summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fixes almost all of the rest of lint errors in the chrome/ directory (minus ↵erg@google.com2009-11-13287-690/+676
| | | | | | | | the really hard ones which will need actual review instead of rubber-stamping.) Review URL: http://codereview.chromium.org/386026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31932 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the problem that file URL is not converted to file path in drag-and-drop ↵jianli@chromium.org2009-11-131-1/+5
| | | | | | | | | | | on Linux. BUG=none TEST=none Review URL: http://codereview.chromium.org/385100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31931 0039d316-1c4b-4281-b951-d872f2087c98
* Part 1 of removing PathSTring. I scrubbed files that are notmunjal@chromium.org2009-11-1323-54/+66
| | | | | | | | in chron's CL to avoid merge. Review URL: http://codereview.chromium.org/393011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31930 0039d316-1c4b-4281-b951-d872f2087c98
* Building FFmpeg in tree for armhclam@chromium.org2009-11-137-34/+905
| | | | | | | | | Changes yasm to be built for host instead of target. Also don't need to depend on yasm if build ing for arm. Review URL: http://codereview.chromium.org/387023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31929 0039d316-1c4b-4281-b951-d872f2087c98
* Split *AndAdjustOffset() functions into their own header, to restore ↵pkasting@chromium.org2009-11-1312-296/+509
| | | | | | | | | | utf_string_conversions.h to a simple, readable state. BUG=4010 TEST=none Review URL: http://codereview.chromium.org/387012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31928 0039d316-1c4b-4281-b951-d872f2087c98
* Remove extra suppression with line numbers for ChromeThread unit test.jam@chromium.org2009-11-131-7/+0
| | | | | | | TBR=scherkus Review URL: http://codereview.chromium.org/393014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31927 0039d316-1c4b-4281-b951-d872f2087c98
* Remove theme.pak cleanup since it's been 2 weeks and most peopletony@chromium.org2009-11-131-10/+0
| | | | | | | | | | | probably have the file deleted by now. TEST=none BUG=none Review URL: http://codereview.chromium.org/393013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31926 0039d316-1c4b-4281-b951-d872f2087c98
* Note: purify and valgrind suppressions already exist. If the purify ↵jam@chromium.org2009-11-131-3/+1
| | | | | | | | | | | | | | | | | | expression isn't being used, something else is wrong. Revert 31914 - Disable ChromeThreadTest.NotReleasedIfTargetThreadNonExistent until suppression is added. BUG=27630 TEST=n/a TBR=scherkus Review URL: http://codereview.chromium.org/385095 TBR=scherkus@chromium.org Review URL: http://codereview.chromium.org/384124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31925 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash by using correct type in class decl.ben@chromium.org2009-11-131-4/+4
| | | | | | | | | | | Patch by Std.Denis. http://crbug.com/27291 TEST=Open fonts and languages dialog box and click OK. Should not crash. Review URL: http://codereview.chromium.org/384123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31924 0039d316-1c4b-4281-b951-d872f2087c98
* Add suppression for new mac mem leak.levin@chromium.org2009-11-131-0/+21
| | | | | | | | | | TBR=atwilson@chromium.org BUG=27644 TEST=valgrind (see bug) Review URL: http://codereview.chromium.org/395003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31923 0039d316-1c4b-4281-b951-d872f2087c98
* Small clean-up to not expose base::Process from RenderProcesHost, and ↵jam@chromium.org2009-11-1317-48/+46
| | | | | | | | instead only expose base::ProcessHandle. Precursor to moving process startup off the UI thread. Review URL: http://codereview.chromium.org/387047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31922 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the UMA stats for whether the renderer was in a new desktop or not.jam@chromium.org2009-11-137-62/+0
| | | | | | Review URL: http://codereview.chromium.org/391045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31921 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Only show one per-tab sheet at a time per tab.thakis@chromium.org2009-11-136-14/+79
| | | | | | | | | BUG=26900 TEST=Go to http://www/~thakis/cgi-bin/test.html . Test that two sheets show up (the first expects "u" as user and no pass, the other "v" and no pass). The first sheet appears immediately, the second after 2 seconds. Try entering u for the first faster than 2 seconds and switch tabs, when coming back to the original tab, the 2nd sheet should wait for you. Try closing the window and the tab while a sheet is showing, both when the tab with the sheet is in the background and in the foreground. Review URL: http://codereview.chromium.org/384113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31920 0039d316-1c4b-4281-b951-d872f2087c98
* Add a Mac plugin quirk for ignoring QuickTime's negotiated drawing modelstuartmorgan@chromium.org2009-11-132-6/+26
| | | | | | | | | | | Since QuickTime sometimes asks for the wrong drawing model, and the only model we have that works for it is QD, force it to use that. BUG=25978 TEST=Testcase from bug should play the movie, rather than crashing the plugin. Review URL: http://codereview.chromium.org/385082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31919 0039d316-1c4b-4281-b951-d872f2087c98
* Load manifest data for newest cache from storage to compare against fetched ↵jennb@chromium.org2009-11-133-65/+102
| | | | | | | | | | | manifest. TEST=updated BUG=none Review URL: http://codereview.chromium.org/386013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31918 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ProfileSyncServiceTest_ServerChangeProcessing due to purify error.scherkus@chromium.org2009-11-131-1/+2
| | | | | | | | | | | BUG=27630 TEST=n/a TBR=nick Review URL: http://codereview.chromium.org/393012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31917 0039d316-1c4b-4281-b951-d872f2087c98
* Added a regression test which validates that keystrokes are received ↵ananta@chromium.org2009-11-134-1/+127
| | | | | | | | | | | | | | | correctly in ChromeFrame. We specifically test for uppercase characters generated in combination with the Shift key. Added a helper function to explicitly give focus to a passed in HWND. This is done by sending the mouse move/mouse down and mouse up events to the window. We also use this in the AboutChromeFrame test, which was flaky at times. Bug=27173,26549 Review URL: http://codereview.chromium.org/389029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31915 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ChromeThreadTest.NotReleasedIfTargetThreadNonExistent until ↵scherkus@chromium.org2009-11-131-1/+3
| | | | | | | | | | | | | suppression is added. BUG=27630 TEST=n/a TBR=jam Review URL: http://codereview.chromium.org/385095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31914 0039d316-1c4b-4281-b951-d872f2087c98
* Rename loaded() to EnsureLoaded() to match my previous change.brettw@chromium.org2009-11-132-5/+5
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/391053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31913 0039d316-1c4b-4281-b951-d872f2087c98
* New image for the extensions promo on the NTP.mirandac@chromium.org2009-11-131-0/+0
| | | | | | | | BUG= 27393 TEST= none Review URL: http://codereview.chromium.org/395001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31912 0039d316-1c4b-4281-b951-d872f2087c98
* Write a test for loading libcros.so on startup of Chrome. You just pass thebrettw@chromium.org2009-11-1313-38/+49
| | | | | | | | | | | | | | | --test-load-libcros on the command line. The browser will exit immediately and the error code (and error messages) will indicate success or failure. I also renamed loaded() static functions related to loading this library. These are not simple getters since they will actually load the library if its not loaded yet. I renamed it to EnsureLoaded. TEST=This is a test BUG=none Review URL: http://codereview.chromium.org/387014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31911 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the test_shell output the page title too in didReceiveTitle.brettw@chromium.org2009-11-132-5/+2
| | | | | | | | | BUG=22014 TEST=LayoutTests/http/tests/loading/redirectwith-no-location-crash.html Checked in for Kinuko Yasuda Original review: http://codereview.chromium.org/384082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31909 0039d316-1c4b-4281-b951-d872f2087c98
* Disable print selection for M4.maruel@chromium.org2009-11-131-1/+4
| | | | | | | | TEST=selection checkbox is not available when even when text is selected. BUG=22937 Review URL: http://codereview.chromium.org/384122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31908 0039d316-1c4b-4281-b951-d872f2087c98
* Draw download item background like windows does if a theme is installed.thakis@chromium.org2009-11-134-7/+75
| | | | | | | | | BUG=27221 TEST=Download something, install theme. Download item should look different. Review URL: http://codereview.chromium.org/384115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31907 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes for Report Bug Dialog:mirandac@chromium.org2009-11-135-70/+163
| | | | | | | | | | | | | * Honor "send screenshot" checkbox * Save bug description and send screenshot state if user chooses "phishing report" function (that disables both); restore if the user goes back to a non-phishing bug. * Make bug report give consistent and correct values for bug type. BUG= 27283, 27282, 27281 TEST= Fill in data in bug description, toggle send screenshot "on". Move between "phishing" and non-phishing reports before sending. Note that description goes away and reappears appropriately. Review URL: http://codereview.chromium.org/385047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31906 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Add support for removeNode from elements panel implemented upstream.pfeldman@chromium.org2009-11-131-0/+1
| | | | | | | TBR=yurys git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31903 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: right align numbers in heap profile view, show absolute values ↵mnaganov@chromium.org2009-11-132-4/+36
| | | | | | | | | | | initially. BUG=27606 TEST=none Review URL: http://codereview.chromium.org/385093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31902 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling some failing tests after the recent WebKit roll.levin@chromium.org2009-11-131-9/+9
| | | | | | | | | | TBR=pfeldman@chromium.org TEST=None BUG=27603 Review URL: http://codereview.chromium.org/385090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31901 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 246.0 to 247.0chrome-bot@google.com2009-11-131-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31900 0039d316-1c4b-4281-b951-d872f2087c98
* Follow up from WebKit roll.levin@chromium.org2009-11-131-4/+4
| | | | | | | | | | | | Some text expectation fixes. TBR=brettw@chromium.org BUG=27555 TEST=None Review URL: http://codereview.chromium.org/384119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31899 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit DEPS 50840:50929.levin@chromium.org2009-11-133-11/+35
| | | | | | | | | | TBR=brettw@chromium.org BUG=None TEST=None Review URL: http://codereview.chromium.org/391049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31898 0039d316-1c4b-4281-b951-d872f2087c98
* Load default browser action icons only once per-window. Thisaa@chromium.org2009-11-132-33/+31
| | | | | | | | | | | | | | | also changes the loading logic to be just like the GTK port, because it was nicer, and because it is nice for them to be parallel as much as possible. It would be better to only load this icon once per application session, but that would require something fancier. BUG=27485 Review URL: http://codereview.chromium.org/389032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31897 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Use DieFileDie in UILayoutTest instead of a custom poll'n'loop.phajdan.jr@chromium.org2009-11-131-22/+8
| | | | | | | | | TEST=Covered by ui_tests. BUG=none Review URL: http://codereview.chromium.org/386018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31896 0039d316-1c4b-4281-b951-d872f2087c98
* Update OTS from r4 (initial commit) to r10 (reviewed revision).yusukes@google.com2009-11-131-1/+1
| | | | | | | | | | | http://code.google.com/p/ots/source/detail?r=10 BUG=17818 TEST=none Review URL: http://codereview.chromium.org/387045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31895 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the build of view_examples for Linux.yusukes@google.com2009-11-131-0/+6
| | | | | | | | | | | | | | TableView and TableView2 are not yet ported to Linux. #ifdef out the related code for Linux. BUG=none TEST=manually built and ran view_examples on Linux Original patch by satorux@chromium.org via: http://codereview.chromium.org/384117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31894 0039d316-1c4b-4281-b951-d872f2087c98
* Add new link to bottom right of extension management page.aa@chromium.org2009-11-133-7/+34
| | | | | | Review URL: http://codereview.chromium.org/394002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31893 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 31873 - Revert 31862 Ensure AutomationMsg_SetCookieAsync is sent on ↵levin@chromium.org2009-11-131-1/+11
| | | | | | | | | | | | | IO thread. Restoring this change as it seems the blame list was incorrect on some bot and this change wasn't to blame but r31865 was in fact the real culprit. TBR=stoyan@chromium.org Review URL: http://codereview.chromium.org/384116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31892 0039d316-1c4b-4281-b951-d872f2087c98
* Cleans up a bit the DB-related methods.dumi@chromium.org2009-11-1310-80/+69
| | | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/394006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31891 0039d316-1c4b-4281-b951-d872f2087c98
* Updated suppression signature to reflect changed method params.atwilson@chromium.org2009-11-131-1/+1
| | | | | | | | | BUG=22923 TBR=levin@chromium.org Review URL: http://codereview.chromium.org/385087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31890 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 31888 - This change depended on a new version of WebKit levin@chromium.org2009-11-131-21/+24
| | | | | | | | | which is no longer present in chromium a the moment. TBR=dumi@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31889 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up os_unix.c.dumi@google.com2009-11-131-24/+21
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/384075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31888 0039d316-1c4b-4281-b951-d872f2087c98
* Partially revert WebKit.gyp switch-over, because it broke build bot setupdglazkov@google.com2009-11-137-24/+24
| | | | | | | | | | | | | | | | | in subtle and devious ways. Renaming webkit.gyp -> webkit_glue.gyp changed webkit.sln to webkit_glue.sln, which occured unbeknownst to the builders who continued to build webkit.sln for most of the day. This wasn't an issue until we did a WebKit roll, where the trickery was discovered and hell broke loose. TBR=yaar TEST=green bots BUG=none Review URL: http://codereview.chromium.org/385084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31887 0039d316-1c4b-4281-b951-d872f2087c98
* Close immediately if no context is setukai@chromium.org2009-11-131-1/+6
| | | | | | | | | | | | | | Profile::GetDefaultRequestContext() is initialized lazily, on the UI thread. So, if SocketStreamHost runs before it has gotten lazily initialized yet, SocketStream won't have context. In this case, SocketStream will die. Rather than that, just close immediately. BUG=none TEST=none Review URL: http://codereview.chromium.org/384077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31886 0039d316-1c4b-4281-b951-d872f2087c98
* Changed WorkerProcessHost::WorkerInstance to use std::list instead of std::set,atwilson@chromium.org2009-11-132-30/+41
| | | | | | | | | | | | because the posix version of std::set has no way to update the iterator when calling erase(), and using the old invalid iterator was corrupting memory. BUG=27589 TBR=levin@chromium.org Review URL: http://codereview.chromium.org/385083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31885 0039d316-1c4b-4281-b951-d872f2087c98
* Style nit -- bind asterisks to the left rather than right.eroman@chromium.org2009-11-133-3/+3
| | | | | | Review URL: http://codereview.chromium.org/384112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31884 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 31871 - WebKit merge 50840:50904levin@chromium.org2009-11-132-27/+8
| | | | | | | | | | After the WK roll, 750 unexpected crashes are happening, so it is being reverted. TBR=brettw@chromium.org Review URL: http://codereview.chromium.org/384111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31883 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 31879 - Try to make the Linux webkit builder happy. levin@chromium.org2009-11-131-5/+5
| | | | | | | | | | | | After the WK roll, 750 unexpected crashes are happening, so it is being reverted. Review URL: http://codereview.chromium.org/391043 TBR=brettw@chromium.org Review URL: http://codereview.chromium.org/387046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31882 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb LoadLog into SocketStreamukai@chromium.org2009-11-1313-216/+362
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/385003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31881 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 31877 - Revert 31869 Ignore keyboard messages from enter key in ↵scherkus@chromium.org2009-11-132-1/+30
| | | | | | | | | | | | | | | | renderer if they were not initiated there. BUG=26755 TEST=Enter messages initiated in omnibox should not propagate to renderer Review URL: http://codereview.chromium.org/384101 TBR=georgey@chromium.org Review URL: http://codereview.chromium.org/384109 TBR=scherkus@chromium.org Review URL: http://codereview.chromium.org/393005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31880 0039d316-1c4b-4281-b951-d872f2087c98
* Try to make the Linux webkit builder happy. I used IMAGE+TEXT since this wasbrettw@chromium.org2009-11-131-5/+5
| | | | | | | | | | | | the failure on Mac, but apparently Linux's TEXT-only failure doesn't get covered by this rule. Trying "IMAGE TEXT" instead of "IMAGE+TEXT" to see if it fixes the problem. TEST=this is a friggin test BUG=none Review URL: http://codereview.chromium.org/391043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31879 0039d316-1c4b-4281-b951-d872f2087c98