| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
test_shell and valgrind ui.
BUG=22791
TEST=none
TBR=agl
Review URL: http://codereview.chromium.org/251059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23379
TEST=Load the print_browser_action extension from the samples test dir and click it. The icon and name should update.
Review URL: http://codereview.chromium.org/242081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
default implementations.
This also makes all the subclasses use the same code to add/remove observers.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/244054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Note which sqlite version we are based off.
- Note some prerequisite packages for running the tests.
- Note that a couple of tests fail.
BUG=n/a
TEST=n/a
Review URL: http://codereview.chromium.org/257016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Make the show_in_folder menu and link "Show in Finder" on the Mac as requested by Cole.
BUG=22647
BUG=23548
TEST=Download shelf menus (for inprogress download and completed download) should be in title case. Mac should say "Finder" instead of "Folder"
Review URL: http://codereview.chromium.org/246065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
and a relevant OpenRadar bug id (rdar://7223948)
This patch was prepared by Alexander Potapenko (cc'ed)
Review URL: http://codereview.chromium.org/251058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
DISPLAY_MODE_DEFAULT only for now (mode switching is evil anyways ;) ). Small bit of code cleanup in renderer.h.
TESTED=entered and exited fullscreen; tested leaving with Esc, Alt+F4, click on region, and right-click on taskbare -> Close; all with both Compiz on and off, on gHardy.
Review URL: http://codereview.chromium.org/258004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/252008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This will speed up ThreadSanitizer by 1.5-2x on some tests.
This may result in missing data races on V8 (will address later)
Review URL: http://codereview.chromium.org/255038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=14721
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/251057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/244053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/249053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it. Pango scales all font sizes by a factor. Scaling the font size,
then asking skia for the metrics gives us exactly the same sizes as
Pango. WAHOO!
BUG=22791
TEST=see bug
Review URL: http://codereview.chromium.org/251054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Chrome Frame to display chrome-extension URLs when running in privilegedmode.BUG=noneTEST=see unit tests
Review URL: http://codereview.chromium.org/246050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It was previously breaking the interactive UI tests.
That was because I changed the button base class to be focusable by default which led to many button beings added to the tab traversal order.
I now explicitly make these buttons non focusable.
Also because of the way we clear the native focus on Gtk (by setting focus to NULL on the top level window), views now default to clearing the focus when focused (so that views non backed by a native window don't leave the native focus on the previously native window).
On Windows we used to focus the WidgetWin's HWND, and now we focus the top-level HWND. The WidgetWin class had to be changed to forward the key events to the root view that contains the focused view because of that. (otherwise it would send it to the top-level root-view, and if the focused view was in a child root-view it would not recieve the keyboard messages).
Note that the mouse wheel does not need that, as the mouse-wheel Windows messages are sent to the HWND under the cursor.
See:
http://codereview.chromium.org/246030/show
TEST=Run the tests
BUG=NONE
Review URL: http://codereview.chromium.org/255008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This looks just fine though the font is different.
BUG=10423
TEST=none
Review URL: http://codereview.chromium.org/242093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
makes it more inline with windows and with the buttons when they do have bookmarks.
TEST=Show bookmark bar with no bookmarks, font should be closer to the font bookmark buttons use.
BUG=none
Review URL: http://codereview.chromium.org/242094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
use IsFormatAvailableByString rather than IsFormatAvailable.
BUG=21106
TEST=see bug, also covered by unit test now.
Review URL: http://codereview.chromium.org/256016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary
-------
Mostly implemented the unblocking for visual resources for the Privacy Blacklist.
Merging now before I leave. Eveything here only has effect if the --privacy-blacklist
flag specifies a Privacy Blacklist.
Detailed Changes
----------------
[chrome/browser/resources/privacy_blacklist.html]
- Replaced the about:blank place-holder with variable to set the unblock link.
- Open the Privacy Blacklist provider page in a new tab. This works around an
issue where such request for a full-page (rather than a sub-resource) gets
blocked indefinitely.
[chrome/browser/render_host/resource_dispatcher_host.h]
- Added a BlockedResponse member which is now a class rather than a namespace,
see below for more information.
[chrome/browser/render_host/resource_dispatcher_host.cc]
- Generate headers for the blocked response to redirect to the chrome-blocked URL
which prevents an enclosing page from reading the URL of the unblock link. This
was suggested by Darin to avoid scripted bypassing of blocked contents.
- Recover the original URL for blocked content, in order to fetch it during
unblocking.
- Do not create CrossSiteResourceHandler when an unblocked link is requested.
Otherwise the request never resumes as the blocked page never gets closed
since it is not a real page.
[chrome/browser/privacy_blacklist/blocked_response.cc]
- Defined chrome-block and chrome-unblock URL schemes. The block scheme is used
to return the blocked response. The unblock scheme is used request a blocked
resource's URL without being intercepted by the Privacy Blacklist.
- Defined a hash function for a blocked resource as its address in memory.
Function to reverse the hash is therefore trivial.
- Added a function to return headers for a blocked response.
- Added a function to generate a block URL from a requested one.
- Added a function to get an unblock URL from a requested one.
- Added a function to return the original URL for a blocked one.
[chrome/browser/privacy_blacklist/blocked_response.h]
- Made the BlockedResponse namespace into a class.
- Created a member set to keep all the blocked resources URL.
BUG=16932
TEST=none
TBR=darin
Review URL: http://codereview.chromium.org/252001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The result looks just sane.
BUG=10434
TEST=none
Review URL: http://codereview.chromium.org/246061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
of WebKit's expectation.
BUG=8407
TEST=none
Review URL: http://codereview.chromium.org/255024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
https://bugs.webkit.org/show_bug.cgi?id=29798
BUG=23320
TEST=none
Review URL: http://codereview.chromium.org/249055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ascii characters in an URL and repalces spaces with '+'.
Test=Escape.EscapeUrl
BUG=23029
Review URL: http://codereview.chromium.org/244056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/248043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
** browser_tests started failing at this revision. See:
http://build.chromium.org/buildbot/waterfall/builders/Chromium%20XP/builds/7697/steps/browser_tests/logs/stdio
**
I'll reorder the methods in webview_impl.cc in a followup CL. I
wanted to keep this one easy to review.
SetBackForwardListSize is no longer necessary given that
BackForwardListChromium.cpp doesn't care about its capacity.
R=dglazkov
BUG=10033
TEST=none
Review URL: http://codereview.chromium.org/251051
TBR=darin@chromium.org
Review URL: http://codereview.chromium.org/246060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
third_party.
BUG=none
TEST=none
TBR=maruel
Review URL: http://codereview.chromium.org/246055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I got this change approved to try out earlier, and landed it. I rolled
it back (to be conservative) after I got a chromebot run started. Since
that bot run didn't show any giant problems, this will re-land the
change, so we can see how users (such as on a dev channel release) do
with this allocator.
This is really experimental... but it will give us some info to make a
better decision between ongoing tuning of TCMalloc and at least
temporarilly using JEMalloc.
tbr=mbelshe
Review URL: http://codereview.chromium.org/256024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'll re-order the methods in webview_impl.cc in a follow-up CL. I
wanted to keep this one easy to review.
SetBackForwardListSize is no longer necessary given that
BackForwardListChromium.cpp doesn't care about its capacity.
R=dglazkov
BUG=10033
TEST=none
Review URL: http://codereview.chromium.org/251051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(We have to strip the '.' from the file extension.)
BUG=23431
TEST=Make sure images can still be dragged to, e.g., the desktop; make sure images can be dragged to Acorn <http://www.flyingmeat.com/acorn/>.
Review URL: http://codereview.chromium.org/255035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I wanted to see how the chromebot would do with JEMalloc.
I just checked it in, and after a chrome-bot run kicks off, I'll land
this effectively reverting rev 27702 back to using TCMalloc.
tbr=mbelshe
Review URL: http://codereview.chromium.org/242092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r=jamesr,mbelshe
Review URL: http://codereview.chromium.org/244055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=aa
Review URL: http://codereview.chromium.org/255033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
1) pass --user-data-dir when appropriate
2) don't overwrite old .desktop files that share the same name.
BUG=23353
Review URL: http://codereview.chromium.org/255016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch consists only of code deletions. Despite the comments in the
deleted code, it's all okay since sheets are closed:
|TabContents::~TabContents()| calls
|ConstrainedWindowMac::CloseConstrainedWindow()|, which calls
|ConstrainedWindowMacDelegate::DeleteDelegate()|, which should close the
sheet if it's still open. This code path has been in use for quite some
time, since we've allowed (or failed to disallow!) tabs containing
sheets to be closed via the close tab button.
BUG=19427
TEST=Open some tabs (possibly in multiple windows) with some tab modal sheet (e.g., by navigating to <http://www.pagetutor.com/keeper/mystash/secretstuff.html>); close a window containing such a tab, with a tab modal sheet visible or not; quit application while a tab modal sheet is active (not nec. visible).
Review URL: http://codereview.chromium.org/242059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23502
TEST=none
Review URL: http://codereview.chromium.org/249050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Mac side of http://codereview.chromium.org/242082
BUG=23046
Review URL: http://codereview.chromium.org/246054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23046
TEST=Compiled and ran on Windows
Review URL: http://codereview.chromium.org/242082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=3273, 10321
TEST=none
Review URL: http://codereview.chromium.org/248025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
and tweaks some values.
Review URL: http://codereview.chromium.org/242087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a landing of a patch provided by antonm. See:
http://codereview.chromium.org/235022
Also included change to browser_about_handler.cc to fix build, and I set
TCMALLOC_RELEASE_RATE to 1.0 on line 40 of page_heap.cc (I think this
was an inadvertent rollback element).
r=antonm
Review URL: http://codereview.chromium.org/257009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=atwilson
Review URL: http://codereview.chromium.org/249052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/16941
TEST=Right-click on bookmark button; pick copy.
Go to any other app and paste. Make sure you got URL.
Review URL: http://codereview.chromium.org/249048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Make MenuGtk take ownership of submenus.
BUG=none
TEST=valgrind doesn't complain
Review URL: http://codereview.chromium.org/251053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=23082,23361
TEST=1. see issue 23082 comment 8 (http://crbug.com/23082#c8)
2. Connect to a ftp site and try to see the file list.
TBR=wtc
Review URL: http://codereview.chromium.org/258005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the window first comes up.
BUG=23380
TEST=Install an extension that has a browser action. Open a
new window. Browser action menu item should be disabled in
wrench menu.
Review URL: http://codereview.chromium.org/242083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-Switch to UMA_HISTOGRAM_* macros.
-Rename to reflect that extensions are subsuming content scripts, and better fit the common style of histogram names.
-Count css and scripts separately, and fix script count to account for multiple scripts per extension.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/244038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
CID=5060
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/243039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27683 0039d316-1c4b-4281-b951-d872f2087c98
|