| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://chrome-reviews.prom.corp.google.com/996
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
updates. The additional information included here has also been submitted to
Mozilla at https://bugzilla.mozilla.org/show_bug.cgi?id=447815.
This was reviewed in the old repository as pamg/tld-info.
R=pkasting
BUG=1277961, 1283371
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
to the right of the tab whose context menu was used.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
purify-sub angry.
- Not sure what is the issue, purify reports FMM (freeing mismatched memory), but I don't see why.
- Don't do the frees inside the dll unload callback directly.
TBR=erikkay
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
whenever the RenderView is told that a provisional load has started for the main frame.
The DCHECK(params->referrer == params->redirects[0]) was firing because:
a) page A was loaded, triggered WillPerformClientRedirect
b) after the provisional load started for the destination page of A's client redirect, but before this load was committed, the browser makes a Navigation request for page B.
c) When page B's load is committed, the RenderView's completed_client_redirect_src_ was still set, resulting in a CLIENT_REDIRECT transition type and forwarding the src value through params->referrer -- but params->redirects was now completely unrelated. Kaboom.
This fix should be general enough to handle cases (that are relatively likely in the wild) where WebKit legitimately cancels the redirect, instead of just the browser doing so. Note we can't depend on dispatchDidCancelClientRedirect because we get that callback on both completion and cancellation of a client redirect.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
on a specific project.
Remove C++ style ; in python script.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
needing this. This ensures that users in countries where the Google base URL is not "google.com" will see the appropriate keyword for their local country (and can trigger it for tab-to-search, etc.).
BUG=1301290
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
file. These files aren't being built or used yet (though a test case
exists that is ifdef'd out).
BUG=1256202
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BrowserToolbarView and StatusBubble into it.
Also restructures the creation of the Frame. This is significant! The Browser now constructs a frame via a new static BrowserWindow::CreateBrowserWindow method (see browser_window_factory.cc). Recall the diagram in the architectural overview doc - the BrowserView object is the one that implements the interface that the Browser object uses to communicate with the UI. The Browser object communicates to the BrowserView directly through this interface, but not directly to the frame.
What actually happens right now in CreateBrowserWindow is that an XP/VistaFrame is constructed, but this is _not_ the object returned to the Browser, rather when the XP/VistaFrame is init'ed, it constructs a BrowserView that also implements BrowserWindow. This is the object that's returned to the Browser.
Since both BrowserView and XP/VistaFrame implement BrowserWindow, I am now able to gradually migrate functionality from the frames to BrowserView. During this process BrowserWindow functions not handled yet by BrowserView will be forwarded to the appropriate frame.
Modifies the Accessibility UI tests to account for this extra level of indirection (should only be temporary while I'm moving things around).
This does actually pass the UI tests.
See the whiteboard in my office for a diagram. This is a bit confusing right now since there's so much going on. Sadly the only way to get where we need to go incrementally is to make a mess on the way.
B=1031854
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
migrating from Window to DialogClientView, I neglected to insert the check into this function to see if the dialog had already been accepted by the user before trying to abort.
B=1304032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the same number when run several times consecutively.
BUG=None
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
chrome.dll due to interdependencies. This will be fixed later.
The new dlls are not built by default.
BUG=1211534
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
identified to their owning project.
Add #ifdef to make the ChromeMain function exclude parts depending on the
relevancy of the dll generated.
BUG=1211534
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=maruel
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
notification_service.h.
TBR=maruel
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=maruel
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=maruel
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
set, and replaces it with a lock. Rename confusing GotAuth test and set method to was WasAuthHandled, which will optionally marked as handled.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
fail when we execute it during the build.
TBR=cpu
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Linux/Posix/Mac-isms, and fixes:
* Only put Windows settings on the construction environment when PLATFORM == 'win32', and provide a PLATFORM == 'posix' block for necessary settings there.
* Don't hard-code C:/ as the location of Microsoft Visual Studio 8, so we can find memset.obj even on buildbot systems that have it installed on D:.
* Work around how SCons 0.98.3 fails to handle environment variables imported from Visual Studio that use | to separate diferent architecture types in the (e.g.) PATH. (This is fixed in 0.98.4, after which we can remove the workaround.)
* Deep copy the environment we use to build v8_shell.exe so objects therein can't pollute other environments.
TBR: evanm,bradnelson
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=cpu
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
- Forgot to fix one main() function.
TBR=nsylvain
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- Previously this job was done by the CRT's atexit() which runs later than we want and under the loader lock.
- Had to modify most main() functions for the testing executables so we don't trigger leak detectors.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
competing can-be-default choices with the same host and path. Previously we would end up picking the least commonly used engine in this case.
BUG=1303406
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
real-world servers return responses like this and there's no obvious reason to disallow it, even though technically it violates the JSON spec.
BUG=1295216
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
avoid race conditions with tab closing now that it's async.
BUG=1303289
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
BUG=1201008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
moving frame functionality into it.
B=1031854
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Yes this causes duplicate code, but only for a brief while until I can bring up BrowserView at which point this code will move from the frames to that object. "It gets worse before it gets better".
B=1031854
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a large, fast network request to monopolize the IO thread.
This particular bug was tickled by an FTP download where
pause tasks posted to the IO thread from the UI thread were
blocked from running until the FTP transfer was completed,
leading to user noticeable jankiness.
I added histograms to the previous read loop and noticed
that during regular browsing and downloading sessions, the
number of times the loop was traversed was 1 for something
like 99.5% of the time. This leads me to believe that
eliminating the read loop in favor of asynchronous tasks
will not impact performance.
BUG=1270179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
over error handling instead of getting a blank string for invalid encodings. It also allows us to decrease the amount of platform-specific code.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
BUG=1295355
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
rather than the DLL. Very useful for rapid development.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
let us unfork three files in webkit/pending.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
dependencies in human readable form.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This causes some temporary duplication of code in xp/vista frames but it will be temporary. My goal is to move all the top level browser level views into the frames. From there, I will move them from the frames into their new home - BrowserView (chrome/browser/views/frames/browser_view.cc), and each frame will host a BrowserView. This will reduce duplication of code.
To make this change I had to add a bunch of methods to the BrowserWindow (nee ChromeFrame) interface to provide access to some of the toolbar's contents. Excuse the ugly API, we will be improving this incrementally.
B=1031854
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to fix box characters appearing in some pages, such as Gmail.
The problem is that the newline character is treated as a zero-width space in the old patch, but apparently WebKit relies on this turning into a space (or something, I don't totally understand). I just removed control characters from this condition since we don't actually want to change their behavior in this respect.
webkit=https://bugs.webkit.org/show_bug.cgi?id=20237
BUG=1166024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
so that this extension is compatible with Firefox 3.0.*.
R=jhaas
BUG=1303276
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
use the $PLATFORM construction variable supplied in the construction environment instead of passing around our own PLATFORM variable in Python.
R=keunwoo,evanm
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
header. No actual code change.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=1293555
TEST=Run the ssl ui tests.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Now everything in third_party but libxml builds. (libxml will require some effort.)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Since the debugger window hosts a HWND, it should be initialized when the DebuggerView is inserted into the hierarchy, such that it gets sized properly. Also the DebuggerView needed to propagate changes to its own bounds into the inner view.
Also fixes a DCHECK in NavigationController that wasn't handling the existence of the debugger.
B=1302810
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Update src/DEPS to latest icu38 rev.
* Add new browser/views/frame/*.cc files.
* Add new browser/debugger/debugger_contents.cc file.
* Add new views/dialog_client_view.cc file.
* Build new browser/debugger/resources/debugger_resources.rc file.
* Add a new ChromeVersionRC() builder to the environment to provide a simpler, abstract interface for the four *version.rc files we build, with fixed definitions of $VERSION_BAT and $CHROME_SRC_DIR.
* Fix the definition of $HTML_INLINE.
R=deanm,bradnelson
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
under Linux. Uses some temporary shims to detect platform and omit processing of some stuff that doesn't seem to work for me.
As previously discussed, I'm just doing whatever's expedient to getting *something* building under Linux, since we decided with the current state of Chrome head (with the upcoming freeze and release branch) it would be too disruptive to try to land all the latest site_scons in Chrome's copy. The main thing to note is the SConscript.main.linux file which uses
#/../third_party/*
instead of
#/$BUILD_ROOT/third_party/*
and then uses variant_dir in the env.SConscript() call at the bottom to explicitly emit output into Hammer/third_party/*. If either of these hacks is absent, scons under Linux simply concludes that all targets are up to date (there's nothing to build). Explanations for this behavior or alternative workarounds are welcome. Alternatively we could just commit this as-is and let someone with more knowledge of SCons internals try to debug it under Linux.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
homepage to New Tab page.
The fix is to enable the textfield when the NewTabPageIsHomePage setting is changed.
I also left out a change to the header guard from my last checkin (no code change). That's included in this changelist.
BUG=1303177
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193 0039d316-1c4b-4281-b951-d872f2087c98
|