| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149636
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Because the plugin windows must be destroyed by the UI thread,
we store the map of plugin PID -> plugin windows there,
on the RenderWidgetHostView.
This differs slightly from Windows, where the map is stored
on the PluginProcessHost, but is otherwise pretty similar.
TEST=crash a windowed plugin; you should see a sad plugin
icon in the place of the plugin
Review URL: http://codereview.chromium.org/155517
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Menu2... meaning a NativeMenuWin could outlive its model potentially!
http://crbug.com/14594
TEST=none
Review URL: http://codereview.chromium.org/149635
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This seems pointless, but for debugging purposes internally we
use the page title as an annotation on OS-level windows which helps
track them down when looking at a list of all windows. For
reasons too complicated for me to care about this doesn't work when
a page lacks a title, hence this fix.
Review URL: http://codereview.chromium.org/149642
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
in r20680.
See http://crbug.com/16767.
TBR=dimich
Review URL: http://codereview.chromium.org/155545
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jorlow
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/155541
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and fixes some of the "AdditionalDependencies" tags to be just generic
'libraries' tags to be more general.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/149650
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests/http/tests/xmlhttprequest/cross-origin-no-authorization.html
BUG=16754
TEST=none
TBR=jorlow
Review URL: http://codereview.chromium.org/149651
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155539
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
disabled as flakey (not related to roll).
BUG=16676,16754
TEST=none
TBR=jorlow
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149646
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Because the plugin windows must be destroyed by the UI thread,
we store the map of plugin PID -> plugin windows there,
on the RenderWidgetHostView.
This differs slightly from Windows, where the map is stored
on the PluginProcessHost, but is otherwise pretty similar.
TEST=crash a windowed plugin; you should see a sad plugin
icon in the place of the plugin
Review URL: http://codereview.chromium.org/155517
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to new bug 16730.
BUG=15780
TEST=several
Review URL: http://codereview.chromium.org/149633
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is possible to reach ChannelImpl::ProcessConnection
when the pipe is being closed, and in that case
the attempt to connect fails with ERROR_NO_DATA
(documeneted as "the pipe is being closed")
BUG=16022
TEST=none
Review URL: http://codereview.chromium.org/149436
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/155509
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=re-enabled passing layout tests
BUG=15780
Review URL: http://codereview.chromium.org/155512
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149624
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change adds registration of content scripts, parented to a frame's
context. When a frame's context goes away, we unregister it and any content
script contexts for it.
There's a corresponding webkit change that lets us know when a content script
context is created. Filed upstream as
https://bugs.webkit.org/show_bug.cgi?id=27104.
BUG=16228
TEST=install an extension with a content script that communicates with a parent
process. Messages should be sendable both ways.
Review URL: http://codereview.chromium.org/155309
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
automation message to set initial settings.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/155376
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Indian languages.
This is a regression with a new menu implementation.
BUG=7319 (http://crbug.com/7319 )
TEST=Run Chrome with --lang=ml or --lang=bn and see if labels in PageMenu or AppMenu are readable.
Review URL: http://codereview.chromium.org/155403
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Middle clicking on an anchor tag that points to an
in-doc fragment should result in a new background
tab being opened. Before this change, we were
overriding this behavior to cause a middle click to
behave like a left click. This patch allows middle
clicks to function similar to the behavior seen in
Firefox and Safari.
No change in behavior should be seen by users for left
clicks on anchor tags that refer to in-doc fragments.
While testing, I see at times issues due to scrolling
within the tab to the correct fragment identifier or
start of the page. This has already been identified in
issues such as 9319, so I'm ignoring that for now.
BUG=2913
TEST=Load Wikipedia, visit a page with many subheadings,
left click on a subheading, verify the current page
scrolls to the correct heading. Click back, verify you
are taken back to your original position. Middle click
on the same subheading, verify a new tab is loaded in
the background that is scrolled to the correct heading.
Review URL: http://codereview.chromium.org/155522
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
TEST=createImageElement2 layout test
BUG=15977
Review URL: http://codereview.chromium.org/155533
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
keep on this page" since all the other suggestions are pretty bad as
they are.
BUG=None
TEST=The tooltips should have been updated
Review URL: http://codereview.chromium.org/155532
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the tree after committing.
TBR=evan
Review URL: http://codereview.chromium.org/149595
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/15474
TEST=none
Review URL: http://codereview.chromium.org/149594
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
application.
This works by adding the GtkWindow in BrowserWindowGtk to its own
GtkWindowGroup and adding the SelectFile dialog to the same group. The
following call to gtk_grab_add(...) makes the SelectFile dialog modal, but
only to the windows within the same group.
Similarly, the bookmark manager window is also added to its own unique
GtkWindowGroup, so the import/export dialogs behave correctly.
If I'm understanding things correctly, the GtkWindowGroup objects are
reference counted once the have windows attached to them, and will delete
themselves after all references to them are destroyed. I'm not sure how to
verify this.
Test:
- Open two new chrome window: A and B
- Open "Save file as..." dialog in window A
- Verify that window A does not respond to keyboard or mouse events.
- Verify that window B does responde to keyboard and mouse events.
- Open "Save file as..." dialog in window B
- Verify that window B does not respond to keyboard or mouse events.
- Cancel dialog on window A.
- Verify that window A starts responding to keyboard and mouse events.
- Cancel dialog on window B.
- Verify that window B starts responding to keyboard and mouse events.
BUG=8727
patch by Mohit Muthanna <mmuthanna@google.com>
original review URL: http://codereview.chromium.org/149548
Review URL: http://codereview.chromium.org/155518
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=Pass NetUti*.IDN* (net_unittest) and NetUtil*.IDN*Slow runs much faster than before (~ 20 times).
Review URL: http://codereview.chromium.org/149577
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155520
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=nsylvain
Review URL: http://codereview.chromium.org/155531
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fontconfig will return fonts which are unreadable to the current
process if the system cache contains them.
BUG=16715
http://codereview.chromium.org/149628
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
merge 44202:44252.
TBR=dglazkov
TEST=layout test
BUG=12881
Review URL: http://codereview.chromium.org/155452
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I converted it to browser_tests framework, so I can just query RenderProcessHost instead of counting "chrome" processes, which apparently induced the flakiness.
TEST=Covered by browser_tests.
http://crbug.com/16062
Review URL: http://codereview.chromium.org/149559
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=16742
TEST=none
Review URL: http://codereview.chromium.org/149634
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This makes IPC logging show plugin messages on Mac/Linux,
and worker messages on all platforms.
Review URL: http://codereview.chromium.org/155530
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
passwords.
Original CL: http://codereview.chromium.org/155291
Patch contributed by: thiago.farina@gmail.com
Review URL: http://codereview.chromium.org/155513
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
valgrind ui test buildbot.
The docs say we have to free the value:
http://library.gnome.org/devel/gobject/unstable/gobject-The-Base-Object-Type.html#g-object-get
BUG=16724
Review URL: http://codereview.chromium.org/155515
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the test was made platform-independent in change 20646, but I missed deleting
this file in the linux directory
BUG=https://crbug.com/16241
REVIEWER=dglazkov@chromium.org
TEST=none
Review URL: http://codereview.chromium.org/155529
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=16690
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/16664
TEST=The same tests run for Web Workers on Windows should be run on Linux and OSX.
Review URL: http://codereview.chromium.org/155015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16502
TEST=setting defaultPlaybackRate before the media starts playing should be respected when play() is called
Review URL: http://codereview.chromium.org/155404
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149617
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
services. And turns on pinned tabs by default on linux.
BUG=16634
TEST=Currently this linux only. Try tab pinning and make sure it works.
Review URL: http://codereview.chromium.org/149621
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
We support complex text and tab dragging now, so remove those from the
list of non-features. Also, mention font renderer in a bit to stop
people filing bugs for that.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes build breakage.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/149629
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This test runs just under 10 seconds (the default timeout value) on a
fast machine; on a slow machine (or in a VM like my XP VM) it can take
closer to 15-20 seconds and hence timeout.
BUG=https://crbug.org/16240
R=dglazkov
TEST=none
Review URL: http://codereview.chromium.org/149431
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=https://crbug.com/16241
TEST=none
REVIEWER=dglazkov@chromium.org
Review URL: http://codereview.chromium.org/155524
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*) added stylesheet.css, tabs.css, tab_?.gif back in
*) refactored so classtree.html splits names that are too long.
*) removed constructor docs and source link from o3d docs (vs o3djs docs)
*) fixed paths in header.html. They used to be statically
included but now that they are used by both o3d and o3djs
they needed to have certain paths fixed dynamically.
*) Pull in new nixysa.
Review URL: http://codereview.chromium.org/155526
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149582
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Some engines (clearlooks) query the bg color of a widget directly, so wrap the bookmarkbar in an event box so that the bg value set in browser_window_gtk.cc doesn't leak through.
http://crbug.com/16382
Review URL: http://codereview.chromium.org/155504
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20643 0039d316-1c4b-4281-b951-d872f2087c98
|