summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Move another method from WebViewDelegate to WebViewClient.darin@chromium.org2009-09-257-12/+12
| | | | | | | | | | | | This is kinda like yelling, right? R=dglazkov BUG=10033 TEST=none Review URL: http://codereview.chromium.org/241002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27210 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize observer_ in the constructor.jhawkins@chromium.org2009-09-251-1/+3
| | | | | | | | | CID=1483 BUG=none TEST=none Review URL: http://codereview.chromium.org/219039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27203 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize read_buffer_size_ in the constructor.jhawkins@chromium.org2009-09-251-3/+5
| | | | | | | | | CID=1422 BUG=none TEST=none Review URL: http://codereview.chromium.org/224021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27202 0039d316-1c4b-4281-b951-d872f2087c98
* Fix chromeostony@chromium.org2009-09-251-1/+1
| | | | | | | | TBR=brettw Review URL: http://codereview.chromium.org/242007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27201 0039d316-1c4b-4281-b951-d872f2087c98
* OS X First run dialog: hide import option of nothing to import from.jeremy@chromium.org2009-09-258-16/+129
| | | | | | | | | * Modify the Mac First Run dialog so that if the system in question doesn't have any browser profiles to import from, we don't display the option. * Modify SafariImporter to only be enabled if the current user's account actually has a profile attached to it. Review URL: http://codereview.chromium.org/218039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27200 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the initial size of TabContentViews to be based on thetony@chromium.org2009-09-2524-37/+51
| | | | | | | | | | | | | | | | size of another TabContents by having an optional TabContents* passed into the TabContents ctor. This fixes a race condition where it's possible for a web page to load before getting the sizing information from the browser. The new flow passes the size information to the renderer process before passing the URL to load. BUG=20159 Review URL: http://codereview.chromium.org/201130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27199 0039d316-1c4b-4281-b951-d872f2087c98
* Removing the active doc bmp.tommi@chromium.org2009-09-252-2/+0
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/222027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27198 0039d316-1c4b-4281-b951-d872f2087c98
* fix Linux views build.pkasting@chromium.org2009-09-251-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27197 0039d316-1c4b-4281-b951-d872f2087c98
* Use the system WINDOWTEXT color for labels, instead of black. Also use the ↵pkasting@chromium.org2009-09-2520-49/+198
| | | | | | | | | | | | system WINDOW color for InfoBubbles, not white. Several places are made to explicitly use black labels where that's correct or respecting system colors is a non-trivial fix (bugs filed for most). Also, apparently I didn't get all my cleanup changes in the last patch, oops. BUG=92,21027 TEST=Set theme to high-contrast black on white, check that most pieces of chrome UI have readable text Review URL: http://codereview.chromium.org/237005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27196 0039d316-1c4b-4281-b951-d872f2087c98
* Calculate whiteout duration on linux (the time we draw greentony@chromium.org2009-09-252-0/+17
| | | | | | | | | or white because of no backing store). This is mainly just a copy of the Windows code (mac has it too). Review URL: http://codereview.chromium.org/220043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27195 0039d316-1c4b-4281-b951-d872f2087c98
* Improve desktop shortcut creation:phajdan.jr@chromium.org2009-09-252-29/+125
| | | | | | | | | | | | | | - remove more comments (which generally only apply to the browser itself) - add #!/usr/bin/env xdg-open shebang - make the .desktop file placed on the desktop executable - add more tests to make sure we're still secure TEST=Covered by unit_tests. BUG=22589 Review URL: http://codereview.chromium.org/232003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27194 0039d316-1c4b-4281-b951-d872f2087c98
* Update svn:ignore for the new DEPS added in r26184maruel@chromium.org2009-09-250-0/+0
| | | | | | | | | | NO CODE CHANGE. TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27193 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable UnloadTest.BrowserCloseBeforeUnload* tests now that they are ↵dglazkov@chromium.org2009-09-251-2/+2
| | | | | | | | | | | | | | passing again. The http://trac.webkit.org/changeset/48732 fixed it. TBR=senorblanco TEST=none BUG=22696 Review URL: http://codereview.chromium.org/242006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27192 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes a crash in IE8 with ChromeFrame when a new tab was created. ananta@chromium.org2009-09-254-30/+120
| | | | | | | | | | | | | | | | | | | ChromeFrame VTable patches the IInternetProtocol interface for the CLSID_HttpProtocol and CLSID_HttpSProtocol handlers. However we were using the same VTable information to patch both the handlers essentially overwriting the first one. While this all worked purely by chance, it exposed a bug in IE8 where every new tab initially goes into a new process and if the chromeframe is unloaded we would leave behind an IInternetProtocol interface in urlmon patched, which would crash when dereferenced. Added a check in the VTable patching code for this case. This fixes bug http://code.google.com/p/chromium/issues/detail?id=22768 Bug=22768 Review URL: http://codereview.chromium.org/244002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27191 0039d316-1c4b-4281-b951-d872f2087c98
* Add new reliability crash to known_crashes.txt. Blows up in v8, called from ↵senorblanco@chromium.org2009-09-251-0/+3
| | | | | | | | | | | | WebCore::DateExtension::setAllowSleep(). BUG=23043 TEST=reliability builder should be more green TBR=maruel Review URL: http://codereview.chromium.org/241005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27188 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/214030 for Thiago:sky@chromium.org2009-09-255-11/+7
| | | | | | | | | | | Avoids the unnecessary conversion to wstring when calling the WriteBookmarks function, using FilePath instead. BUG=None TEST=run unit_tests.exe Review URL: http://codereview.chromium.org/239002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27186 0039d316-1c4b-4281-b951-d872f2087c98
* Fix color of download item text in incognito window.thakis@chromium.org2009-09-251-0/+4
| | | | | | | | | BUG=22664 TEST=Open incognito window, download something. The download item should contain readable text. Review URL: http://codereview.chromium.org/235018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27185 0039d316-1c4b-4281-b951-d872f2087c98
* Add in the now-moved Chrome Frame perf test reference build.robertshield@chromium.org2009-09-252-6/+6
| | | | | | | | Remove the unused chrome_frame\DEPS file. Review URL: http://codereview.chromium.org/243002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27184 0039d316-1c4b-4281-b951-d872f2087c98
* Update svn:ignore.maruel@chromium.org2009-09-250-0/+0
| | | | | | | | | | NO CODE CHANGE. TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27183 0039d316-1c4b-4281-b951-d872f2087c98
* Moving the Chrome Frame perf reference build out of src and into deps.robertshield@chromium.org2009-09-25274-34894/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27181 0039d316-1c4b-4281-b951-d872f2087c98
* Renaming Chrome Frame reference build in preparation for move.robertshield@chromium.org2009-09-25274-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27180 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the main menu to do the following:sky@chromium.org2009-09-253-41/+130
| | | | | | | | | | | | | | | | | . Creates a TabContents in CreateNewWindow rather than a RenderViewHost. We want to support the ability to open popups from this menu, so going with TabContents directly seemed the best option. . Showing the menu now does a keyboard grab. This is needed so that keyboard events go to the menu and focus doesn't remain whever it was when the menu was shown. BUG=22954 TEST=see bug Review URL: http://codereview.chromium.org/219037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27179 0039d316-1c4b-4281-b951-d872f2087c98
* Place Chrome Frame intermediate files in a more sanely named directory.robertshield@chromium.org2009-09-251-10/+10
| | | | | | Review URL: http://codereview.chromium.org/223023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27178 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Provisional fix for webkit merge: add event listeners panel js.pfeldman@chromium.org2009-09-251-0/+1
| | | | | | Review URL: http://codereview.chromium.org/246001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27177 0039d316-1c4b-4281-b951-d872f2087c98
* This is an implementation of the bridge method for copying arbitrary ↵apavlov@chromium.org2009-09-256-0/+19
| | | | | | | | | | plaintext onto a clipboard in Chromium. The method is declared upstream, in a patch associated with https://bugs.webkit.org/show_bug.cgi?id=29634 Review URL: http://codereview.chromium.org/211052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27176 0039d316-1c4b-4281-b951-d872f2087c98
* Add another Worker suppression for valgrind.dimich@google.com2009-09-251-0/+15
| | | | | | | | | BUG=23018 TEST=none TBR=dank Review URL: http://codereview.chromium.org/235021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27175 0039d316-1c4b-4281-b951-d872f2087c98
* A follow-up change for r26694.hbono@chromium.org2009-09-252-7/+9
| | | | | | | | | | | This change is a follow-up change for r26694 that I wasn't able to review. Nevertheless, this change includes only style nits. BUG=none TEST=none Review URL: http://codereview.chromium.org/234003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27174 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress valgrind leak from WebCore::CSSParser::createFloatingValueList.mattm@chromium.org2009-09-251-0/+18
| | | | | | | | | | BUG=23014 TEST=none TBR=jhawkins Review URL: http://codereview.chromium.org/241003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27173 0039d316-1c4b-4281-b951-d872f2087c98
* Use URL constants instead of writing string literals in test using history ↵tyoshino@google.com2009-09-251-2/+3
| | | | | | | | | | | page address. BUG=none TEST=none Review URL: http://codereview.chromium.org/200142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27172 0039d316-1c4b-4281-b951-d872f2087c98
* Add an additional unit-test for when PAC script is missing newline.eroman@chromium.org2009-09-252-4/+26
| | | | | | | | | | This variation uses a statement without semi-colon, rather than a comment, as the last line. BUG=http://crbug.com/22864 Review URL: http://codereview.chromium.org/238004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27171 0039d316-1c4b-4281-b951-d872f2087c98
* Add Workers valgrind failures (mem leaks) to Mac suppression lists. They are ↵dimich@google.com2009-09-251-0/+18
| | | | | | | | | | | already in the Win+Linux list. BUG=22923,22932 TEST=remove suppressions and nothing bad happens. TBR=leiz Review URL: http://codereview.chromium.org/245001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27170 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented upload progress indicator in status bar.darin@chromium.org2009-09-258-20/+79
| | | | | | | | | | | | | | | | | | | | | | | When sending an HTTP POST request with sufficiently large payload data (such as uploading a file or several), the status bar should display the progress in the form of a percentage. The ResourceDispatcherHost periodically sends upload progress messages to the UI thread as well as to the renderer. If an upload is occurring, other potential LoadStateChanged messages to the same RenderViewHost are ignored; this prevents the upload progress display from being interrupted periodically by "Waiting for <site>" messages. Original code review: http://codereview.chromium.org/211050 Original patch by Simon Radford r=darin BUG=4715 TEST=Try uploading one or more files (e.g. at a file hosting site) and confirm that the percentage is shown in the status bar. Review URL: http://codereview.chromium.org/244001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27169 0039d316-1c4b-4281-b951-d872f2087c98
* Removing valgrind suppressions that have not triggered in the last 100 runs. ↵mattm@chromium.org2009-09-254-313/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (Doesn't cover suppressions_mac.txt) Some suppressions didn't trigger because the test was disabled. It is assumed that before re-enabling such a test someone would fix it and check that it doesn't still need any suppressions: BUG=6522 BUG=11838 Not reproducible, bug is already closed: BUG=10750 BUG=11117 BUG=12539,12549,12661 Not reproducible (or not enough info to try): BUG=4609 BUG=16103 BUG=16129 (probably fixed by r20100) BUG=16578 BUG=16584 BUG=16586 BUG=16625 BUG=16908 BUG=18654 BUG=19385 BUG=19490 Review URL: http://codereview.chromium.org/219021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27168 0039d316-1c4b-4281-b951-d872f2087c98
* Fix gcc warning in chrome os compile.estade@chromium.org2009-09-251-2/+3
| | | | | | | | TBR=jungshik Review URL: http://codereview.chromium.org/242001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27167 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: First cut at tab dragging automation.estade@chromium.org2009-09-255-32/+177
| | | | | | | | | | | | | Also make tab dragging slightly more robust. I tried really hard to avoid hackiness, but after many hours of wrestling with gtk and X, this is the best I could do. The main point of contention is that GTK (and our tab dragging code in particular) seems to be able to get X into a state where gdk_display_warp_pointer() doesn't send back any events (although it does move the X pointer). I tried to fix our code directly, but decided it was GTK that was broken. So I faked some mouse motion events to prod the tab dragging into working. This approach does not appear to be flaky, and is actually closer to the event stream that occurs when a user drags a tab than the obvious approach would be. (The tests themselves are somewhat flaky, but only due to WaitForURLDisplayedForTab() flakiness, which is a separate issue I'll look at later. The tests aren't on any buildbot for now so I'd like to leave them enabled.) BUG=22182 TEST=--gtest_filter=AutomatedUITest.Drag* Review URL: http://codereview.chromium.org/218017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27166 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fix overflow chevron for RTL locales.estade@chromium.org2009-09-251-4/+11
| | | | | | | | BUG=22872 Review URL: http://codereview.chromium.org/218037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27165 0039d316-1c4b-4281-b951-d872f2087c98
* linux: unittest fixevan@chromium.org2009-09-251-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27164 0039d316-1c4b-4281-b951-d872f2087c98
* Add a TODO comment to describe when we can remove the const_cast forwtc@chromium.org2009-09-251-0/+2
| | | | | | | | | | | the NSS function SGN_Update. R=rafaelw BUG=20669 TEST=none Review URL: http://codereview.chromium.org/218035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27163 0039d316-1c4b-4281-b951-d872f2087c98
* Rounds up VirtualAlloc calls on windows to dwAllocationGranularity to ↵jamesr@chromium.org2009-09-251-19/+20
| | | | | | | | | | | | | | | | | | | | | | prevent fragmentation Actually on Windows VirtualAlloc'ated address might have bigger alignment than reported by SYSTEM_INFO.dwPageSize, see SYSTEM_INFO.dwAllocationGranularity. As coalescing of spans in tcmalloc requires that those spans are physically adjacent, using smaller alignment inhibited coalescing. Additional benefit is we now require ways less memory at least in some case. Also adds assert()s for alignment values that would lead to pathological virtual address space waste. No current callers pass in alignment values other than kPageSize and it's unlikely anyone will. Original patch and discussion was at http://codereview.chromium.org/235003 Patch by: antonm@chromium.org BUG=22701 TEST=Manually checked test page that did 10m XHR. Memory use goes from >2GB and a crash to 102MB. Membuster shows the change is roughly within noise and possibly a very slight regression ( <<5% ). Review URL: http://codereview.chromium.org/222028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27162 0039d316-1c4b-4281-b951-d872f2087c98
* linux: drop temp_scaffolding_stubsevan@chromium.org2009-09-258-13/+57
| | | | | | | | | It was mostly unneeded, but I had to excise the last bits of RLZ and move some NOTIMPLEMENTED bits to where they belong. Review URL: http://codereview.chromium.org/219042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27161 0039d316-1c4b-4281-b951-d872f2087c98
* Roll back Markus's CL ( http://codereview.chromium.org/196053)jshin@chromium.org2009-09-256-58/+14
| | | | | | | | | BUG=none TEST=UI test and valgrind test pass TBR=markus Review URL: http://codereview.chromium.org/222031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27160 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed some warnings.apatrick@google.com2009-09-254-14/+14
| | | | | | Review URL: http://codereview.chromium.org/231027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27159 0039d316-1c4b-4281-b951-d872f2087c98
* More fixes for WorkerFastLayoutTests: enable them on Mac and Win, ↵dimich@google.com2009-09-251-1/+7
| | | | | | | | | | | reintroduce Linux guard that was removed by http://codereview.chromium.org/220034, since the test that fails on all platforms was disabled earlier: http://codereview.chromium.org/219033 BUG=none TEST=none TBR=jshin Review URL: http://codereview.chromium.org/224022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27158 0039d316-1c4b-4281-b951-d872f2087c98
* Set background to tabbed pane's content.oshima@chromium.org2009-09-251-0/+10
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/235012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27157 0039d316-1c4b-4281-b951-d872f2087c98
* Change my email address in watchlists so that I can filter the CCs more ↵ben@chromium.org2009-09-251-2/+2
| | | | | | | | | | effectively. TBR=jrg Review URL: http://codereview.chromium.org/208004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27156 0039d316-1c4b-4281-b951-d872f2087c98
* Add the stack signature of a small memory leak found in ↵jshin@chromium.org2009-09-251-0/+22
| | | | | | | | | | | SessionHistoryTest.HistorySearchXSS to the valgrind suppression list. BUG=22984 TEST=Valgrind bot does not report this leak any more when running SessionHistoryTest.HistorySearchXSS TBR=dank Review URL: http://codereview.chromium.org/223030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27155 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION build from 219.2 to 219.3laforge@chromium.org2009-09-251-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27154 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION build from 219.1 to 219.2laforge@chromium.org2009-09-251-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27153 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the BrowerThemeProvider pointer from being ref counted totony@chromium.org2009-09-255-16/+11
| | | | | | | | | not being ref counted. It's owned by the profile and it doesn't need to be ref counted. Review URL: http://codereview.chromium.org/223027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27152 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up a few bits of files that I'm about to modify. The only visible ↵pkasting@chromium.org2009-09-256-82/+66
| | | | | | | | | | change is the removal of some extra spacing Ben erroneously added to the link infobar a while back (clients already do their own spacing as needed, so this just added extra whitespace in mid-sentence). BUG=none TEST=none Review URL: http://codereview.chromium.org/223029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27151 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 17:30:53 +0000