summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* POSIX: In functions where we wait for a process with timeout, increment the ↵thestig@chromium.org2010-04-021-14/+24
| | | | | | | | | | amount of time we sleep between polls from 1 to 256 milliseconds instead of always sleeping 250 milliseconds. BUG=none TEST=Perf tests that use WaitForSingleProcess but finishes under 250 ms will get more accurate results. Review URL: http://codereview.chromium.org/1518008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43463 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a pyauto crash while loading locales.nirnimesh@chromium.org2010-04-021-1/+3
| | | | | | | | | | | | Override base::DIR_MODULE too. This is needed for loading up resources correctly. BUG=40192 TEST=python chrome/test/functional/test_basic.py Review URL: http://codereview.chromium.org/1555005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43462 0039d316-1c4b-4281-b951-d872f2087c98
* Add a folders_only and subtree api to bookmark managerfeldstein@chromium.org2010-04-0211-92/+307
| | | | | | | | | | | | | | | | Adds a new API to the experimental.bookmarkManager namespace getSubtree(id, foldersOnly, callback) Which returns any subtree, and if foldersOnly is true, only returns the folders. At this point, only the bookmark tree is using the new call. BUG=39877 TEST=ExtensionBookmarksTest.* Review URL: http://codereview.chromium.org/1611001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43461 0039d316-1c4b-4281-b951-d872f2087c98
* Add --websocket-live-experiment-host flag to debug websocket live experiment.ukai@chromium.org2010-04-024-15/+51
| | | | | | | | | | | If --websocket-live-experiment-host is specified, it is used for host of websocket live experiment in debug build. BUG=none TEST=none Review URL: http://codereview.chromium.org/1524005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43460 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing js file to gyp filefeldstein@chromium.org2010-04-021-0/+1
| | | | | | | | | | | | | BMM was broken, missing this in the gyp file TBR Arv BUG=none TEST=open the BMM and make sure bookmarks show up Review URL: http://codereview.chromium.org/1584009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43459 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a ChromeFrame crash which occurs while handling the open url ↵ananta@chromium.org2010-04-021-2/+4
| | | | | | | | | | | | | | | notification from Chrome. This crash happens while attempting to dereference a NULL IWebBrowser2 interface pointer, which could occur if the client site is NULL, i.e. chrome frame is in the process of being torn down. This fixes bug http://code.google.com/p/chromium/issues/detail?id=40174 Bug=40174 Review URL: http://codereview.chromium.org/1585014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43457 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a ChromeFrame crash which occurs probably in the upgrade scenario where ↵ananta@chromium.org2010-04-021-1/+4
| | | | | | | | | | | | | | | we fail to cocreate our active document object which was most likely unregistered. Added a check to bail here. Fixes bug http://code.google.com/p/chromium/issues/detail?id=40169 Bug=40169 Review URL: http://codereview.chromium.org/1564008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43456 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a ChromeFrame crash in the bind status callback which occurs due to a ↵ananta@chromium.org2010-04-021-1/+3
| | | | | | | | | | | | | | | | | NULL delegate pointer being dereferenced. It appears that there are cases where the IMoniker::BindToObject function is called with a bind context without a registered callback. In this case we should not do anything. Fix is to revoke our callback if we don't find a previous callback. This fixes bug http://code.google.com/p/chromium/issues/detail?id=40153 Bug=40153 Review URL: http://codereview.chromium.org/1589010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43455 0039d316-1c4b-4281-b951-d872f2087c98
* Add TableModel for geolocation settings.mattm@chromium.org2010-04-025-0/+215
| | | | | | | | | BUG=39817,39820 TEST=manual Review URL: http://codereview.chromium.org/1534013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43454 0039d316-1c4b-4281-b951-d872f2087c98
* Override a few more expectations due to r43444.scherkus@chromium.org2010-04-021-0/+2
| | | | | | | | | | TBR=nsylvain BUG=19113 TEST=Windows layout tests should go green Review URL: http://codereview.chromium.org/1512014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43449 0039d316-1c4b-4281-b951-d872f2087c98
* Change NOTREACHED for a LOG(WARNING) when we can't deletensylvain@chromium.org2010-04-021-4/+8
| | | | | | | | | the cache. This should help the unit tests. BUG:38562 Review URL: http://codereview.chromium.org/1594002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43446 0039d316-1c4b-4281-b951-d872f2087c98
* Fix syncing deleted autofills and properly associate when an autofill is added.zork@chromium.org2010-04-023-23/+37
| | | | | | | | | BUG=39957 TEST=Manually test. Review URL: http://codereview.chromium.org/1546009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43445 0039d316-1c4b-4281-b951-d872f2087c98
* Bilinear video scaling enabled (using Skia).scherkus@chromium.org2010-04-022-15/+25
| | | | | | | | | | | | | | | This has a performance impact on scaled video but looks considerably better. We still use our optimized path for unscaled video. Patch by sergeyu@chromium.org http://codereview.chromium.org/1081011/show BUG=19113 TEST=none Review URL: http://codereview.chromium.org/1535017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43444 0039d316-1c4b-4281-b951-d872f2087c98
* Add Flash EULA to about box on Mac (for branded builds).viettrungluu@chromium.org2010-04-021-2/+24
| | | | | | | | | BUG=none TEST=On Chromium, about box should be the same as before. On Google Chrome, about box should have "Adobe Flash Player License Agreement" below the Google Terms of Service, with "License Agreement" an appropriate link. Review URL: http://codereview.chromium.org/1610001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43443 0039d316-1c4b-4281-b951-d872f2087c98
* Implement closing handshake described in draft-hixie-thewebsocketprotocol-76.ukai@chromium.org2010-04-022-4/+126
| | | | | | | | | | | | | | | | exchange closing frame (0xFF 0x00) to close the WebSocket connection cleanly. Land it again with eliminating LOG(ERROR), because it got arm build fail by relocation overflow in relocation 10 at line 167 (LOG(ERROR) line) in net/base/keygen_handler_nss.cc TBR=rohitrao,jar BUG=none TEST=none Review URL: http://codereview.chromium.org/1605007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43442 0039d316-1c4b-4281-b951-d872f2087c98
* Don't forcibly set our network state to NETWORK_LOADING after media initializes.scherkus@chromium.org2010-04-021-3/+2
| | | | | | | | | | | We already set the network state to NETWORK_LOADING before we kick off initialization. Furthermore, we may end up caching the entire media resource and set our network state to NETWORK_IDLE in which case we really don't want to switch back to NETWORK_LOADING. BUG=25185 TEST=covered by layout tests Review URL: http://codereview.chromium.org/1518013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43441 0039d316-1c4b-4281-b951-d872f2087c98
* Move enable/disable storage to prefs.nick@chromium.org2010-04-0216-167/+242
| | | | | | | | | | | | | | | | | | | | | | | The ProfileSyncService will manage the enabled/disabled types. Remove CustomizeSyncWindowView's DataTypeManager dependency; it should really just be operating on the preferences via the ProfileSyncService. Clarify the difference between types being enabled (meaning the user wants to sync them) versus being advertisable (meaning we support the datatype, and advertise that the user has the option of syncing it). BUG=34209,38340 TEST=After syncing, open the options dialog and recustomize your options. Verify that the enabled types from the wizard match the initial state of the options window. After changing the options and hitting "accept", observe that a breakpoint in DTM::Configure gets triggered, with exactly the new configuration set. Verify that the preferences are preserved on restart, as well as across Stop Syncing / Start Syncing. Review URL: http://codereview.chromium.org/1556009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43440 0039d316-1c4b-4281-b951-d872f2087c98
* Enable support for additional media formats by using the duration from ↵scherkus@chromium.org2010-04-021-1/+7
| | | | | | | | | | | | | | | AVFormatContext, if present. Some media formats do not have a duration specified in the individual audio/video streams. However if the container itself lists a duration we can simply rely on that value. Patch by ducksource@gmail.com BUG=none TEST=additional media formats should be playable in Chrome if enabled in FFmpeg Review URL: http://codereview.chromium.org/1608005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43439 0039d316-1c4b-4281-b951-d872f2087c98
* Fix AutoFillProfile leaks in WebDataService.tim@chromium.org2010-04-021-9/+14
| | | | | | | | TBR=akalin Review URL: http://codereview.chromium.org/1569016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43438 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed bugs related to the GPU process terminating unexpectedly.kbr@google.com2010-04-022-11/+4
| | | | | | | | | | BUG=40173 TEST=ran WebGL tests, killed GPU process, and reloaded page TBR=jam Review URL: http://codereview.chromium.org/1549013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43437 0039d316-1c4b-4281-b951-d872f2087c98
* Add generic "json dict" entry point for pyauto commands. Will preventjrg@chromium.org2010-04-0213-4/+255
| | | | | | | | | | | | | | | | the need to modify the automation proxy anymore. New pyauto commands will only need to edit pyauto.py (to add a new SendJSONCommand() call) and browser_proxy.cc (to implement the other side). Contrast with the normal editing of ~8 files. Also added WaitForAllDownloadsToComplete using new JSON path. BUG=http://crbug.com/39274 Review URL: http://codereview.chromium.org/1547012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43436 0039d316-1c4b-4281-b951-d872f2087c98
* Mark SessionRestoreUITest.ShareProcessesOnRestore as flaky.rohitrao@chromium.org2010-04-021-1/+2
| | | | | | | | BUG=40181 TEST=None Review URL: http://codereview.chromium.org/1569015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43435 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFillDialogController leak fixed.dhollowa@chromium.org2010-04-022-8/+12
| | | | | | | | | | | | | | | | | The AutoFillDialogController was leaking view controllers when dynamically adding and removing AutoFillAddressViewController and AutoFillCreditCardViewController views. Ownership of the controllers was not getting relinquished to the NSArray containers correctly. New checks in the unit tests now explicitly check that the controllers have a single owner. BUG=39720 TEST=AutoFillDialogControllerTest.DeleteAddress, AutoFillDialogControllerTest.DeleteCreditCard TBR=avi@chromium.org Review URL: http://codereview.chromium.org/1551011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43432 0039d316-1c4b-4281-b951-d872f2087c98
* Adding disabled appcaches information along with capability of kkanetkar@chromium.org2010-04-022-27/+121
| | | | | | | | | | | removing appcaches with button clicks. BUG=38463 TEST=Run chrome, navigate to about:appcache-internals, add/view/remove appcaches. Review URL: http://codereview.chromium.org/1576009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43430 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind suppression for an AnimationContainer invalid read.rohitrao@chromium.org2010-04-021-0/+7
| | | | | | | | | | TBR=sky BUG=40177 TEST=None Review URL: http://codereview.chromium.org/1521013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43429 0039d316-1c4b-4281-b951-d872f2087c98
* Disable most commands at startup.arv@chromium.org2010-04-022-1/+11
| | | | | | | | | | Make sure we do not show the menu on right mouse botton. BUG=40078 TEST=Open the bookmark manager and right click Review URL: http://codereview.chromium.org/1518011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43428 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to the Browser to support Database access from Workers.ericu@google.com2010-04-0221-121/+326
| | | | | | | | | | | | This changelist should have no visible effect until the V8 bindings for the Database get added to the Worker context in WebKit. BUG=none TEST=webkit layout tests Review URL: http://codereview.chromium.org/1387001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43427 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to web database and autofill components requiredtim@chromium.org2010-04-0210-57/+302
| | | | | | | | | | | | | | | | | | | | | to sync profiles / addresses. The main part here is adding Refresh to the PersonalDataManager. It changes the expectation that the PDM is the only thing modifying autofill, which is necessary as the sync engine connects directly to the WebDatabase on the DB thread. The tricky part is ID generation, which I spent a great deal of time harping over in my sync change to make sure that everything is in an eventually consistent state. Note that because of the way the autofill window takes an isolated copy of the data, there *are* extremely rare cases where an edit will get dropped - I cover this case in PersonalDataManagerTest.Refresh. TEST=WebDataServiceTest, PersonalDataManagerTest. Review URL: http://codereview.chromium.org/1550007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43426 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an incorrect DCHECK in the OnOpenURL function in ChromeFrameananta@chromium.org2010-04-021-2/+0
| | | | | | Review URL: http://codereview.chromium.org/1527010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43425 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard events of any kind end bookmark bar folder menus.jrg@chromium.org2010-04-023-20/+41
| | | | | | | | BUG=http://crbug.com/38268 Review URL: http://codereview.chromium.org/1572018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43424 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for focus issues in the AutoFill windows dialog, including #37817georgey@chromium.org2010-04-022-22/+197
| | | | | | | | BUG=37817 TEST=You should be successfully able to navigate all controls and buttons with keyboard. + info in the bug. Review URL: http://codereview.chromium.org/1560006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43423 0039d316-1c4b-4281-b951-d872f2087c98
* Add reload mask resource.pkasting@chromium.org2010-04-021-0/+0
| | | | | | | | | | | This is a copy of the current star_mask.png; I'm checking this in separately from removing that or from using it in code so I can run the code change on the trybots. TBR=glen BUG=27570 TEST=none Review URL: http://codereview.chromium.org/1587011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43422 0039d316-1c4b-4281-b951-d872f2087c98
* Remove bookmarks log message.dhollowa@chromium.org2010-04-021-2/+0
| | | | | | | | | BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/1524008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43421 0039d316-1c4b-4281-b951-d872f2087c98
* Disable BrowserTest.FLAKY_SingleBeforeUnloadAfterWindowClose on mac. It is ↵rohitrao@chromium.org2010-04-021-1/+10
| | | | | | | | | | crashy. BUG=40150 TEST=No crashy. Review URL: http://codereview.chromium.org/1545015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43420 0039d316-1c4b-4281-b951-d872f2087c98
* Fix floating bookmark bar on windows.jrg@chromium.org2010-04-021-1/+2
| | | | | | | | | | | | | | | IsBookmarkBarVisible() continues to have a consistent meaning across platforms, but extra logic has been added to windows to be smarter about when to show the bar. Such extra logic also is consistent across platforms (e.g. see browser_window_gtk.cc and bookmark_bar_gtk.cc). Problem introduced with http://codereview.chromium.org/1461001 BUG=http://crbug.com/39559 Review URL: http://codereview.chromium.org/1594009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43419 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash in ChromeFrame in our IBindStatusCallback wrapper which attempts ↵ananta@chromium.org2010-04-021-2/+9
| | | | | | | | | | | | | | | | | to cache the data received in the OnDataAvailable notification. The crash occurs because we receive a STGMEDIUM structure indicating that the medium type is a file and we attempt to dereference it as a stream. Fix is to call the original delegate and bail if we receive anything but a stream. This fixes bug http://code.google.com/p/chromium/issues/detail?id=40152 Bug=40152 Review URL: http://codereview.chromium.org/1576014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43418 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply 43381 - Add some safeguards in DatabaseTracker to prevent writing ↵michaeln@chromium.org2010-04-023-19/+70
| | | | | | | | | | | anything to disk for incognito. This time with more unit tests. TEST=manual and database_tracker_unittest.cc BUG=none Review URL: http://codereview.chromium.org/1572017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43417 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 43413 - Add a notification when the list of startup URLs change.zork@chromium.org2010-04-023-17/+1
| | | | | | | | | | | | BUG=38557 TEST=Run two instances of chromes with difference profiles that are syncing. Change the startup pages. Check that the change propagates. Review URL: http://codereview.chromium.org/1562008 TBR=zork@chromium.org Review URL: http://codereview.chromium.org/1539014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43416 0039d316-1c4b-4281-b951-d872f2087c98
* Patch xss in nodeURL_ in chrome://downloads.inferno@chromium.org2010-04-021-1/+1
| | | | | | | | BUG=40138 Test=None Review URL: http://codereview.chromium.org/1585012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43414 0039d316-1c4b-4281-b951-d872f2087c98
* Add a notification when the list of startup URLs change.zork@chromium.org2010-04-023-1/+17
| | | | | | | | | BUG=38557 TEST=Run two instances of chromes with difference profiles that are syncing. Change the startup pages. Check that the change propagates. Review URL: http://codereview.chromium.org/1562008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43413 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the distributor logo.glen@chromium.org2010-04-018-129/+5
| | | | | | Review URL: http://codereview.chromium.org/1366002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43412 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Polish the keyword/search engine editor based on feedback from the UI ↵rsesek@chromium.org2010-04-012-162/+180
| | | | | | | | | | | | | | | team. XIB changes: * Make the button bar 35px tall. * Change the buttons to have Rounded Textured style. BUG=none TEST=Chromium --> Preferences --> Basic --> [Manage]. Bottom button bar should have a textured appearance. Review URL: http://codereview.chromium.org/1519014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43411 0039d316-1c4b-4281-b951-d872f2087c98
* Add Flash EULA to about box on Linux/GTK (for branded builds).viettrungluu@chromium.org2010-04-014-8/+59
| | | | | | | | | BUG=none TEST=On Chromium, about box should be the same as before. On Google Chrome, about box should have "Adobe Flash Player License Agreement" below the Google Terms of Service, with "License Agreement" an appropriate link. Review URL: http://codereview.chromium.org/1593006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43410 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for a problem introduced by 41865 which causes sync notificationsakalin@chromium.org2010-04-015-28/+117
| | | | | | | | | | | to break for non-gmail.com accounts. BUG=40054 TEST=manual testing Review URL: http://codereview.chromium.org/1558013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43409 0039d316-1c4b-4281-b951-d872f2087c98
* Block plugin HandleURLRequest calls with invalid chars like @,;,\ before the ↵inferno@chromium.org2010-04-011-0/+18
| | | | | | | | | | first / (or start of path) in URL. BUG=40016 TEST=None Review URL: http://codereview.chromium.org/1534010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43408 0039d316-1c4b-4281-b951-d872f2087c98
* Adds AnimationContainer, which can be used to group a set ofsky@chromium.org2010-04-0119-184/+742
| | | | | | | | | | | | | | | animations to have the same timer. By default each animation has one animationcontainer, but I'm going to change the tab renderer to share the animationcontainer so that the pulse effects happen in unison. Also updated the BoundsAnimator so that I can use it by the TabStrip. BUG=none TEST=none Review URL: http://codereview.chromium.org/1575011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43407 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: inspect page action popups.estade@chromium.org2010-04-012-9/+18
| | | | | | | | | | Forgot page actions when I wrote r42389 BUG=24477 TEST=manual Review URL: http://codereview.chromium.org/1558019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43406 0039d316-1c4b-4281-b951-d872f2087c98
* Add a split pane between the tree and the list.arv@chromium.org2010-04-013-11/+174
| | | | | | | | | BUG=39093 TEST=Drag the splitter. Reload the bookmark manager and the size of the tree should be persisted. Review URL: http://codereview.chromium.org/1519016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43405 0039d316-1c4b-4281-b951-d872f2087c98
* Update NaCl revision (1861 -> 1915)gregoryd@google.com2010-04-011-1/+1
| | | | | | Review URL: http://codereview.chromium.org/1567012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43404 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the side tab shadow. I thought I had committed this last week but I ↵ben@chromium.org2010-04-011-0/+3
| | | | | | | | | | | guess I did not. sky already reviewed this. BUG=none TEST=vista glass, make sure there's no shadow over-painting the buttons at the right of the toolbar Review URL: http://codereview.chromium.org/1576007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43403 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 01:46:02 +0000