| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
we can override the via custom_vars in .gclient on the bots
and official builds.
Also pulls JavaScriptCore from webkit.org and updates
the merge script appropriately.
This is blocked on http://code.google.com/p/gclient/source/detail?r=41
being checked in an pushed.
Review URL: http://codereview.chromium.org/19690
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
few Layout tests passing.
Review URL: http://codereview.chromium.org/19490
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
onload-navigation-iframe.html
onload-navigation-iframe-timeout.html
The tests submit a form to about:blank.
They fail because there is no ? at the end of about:blank when we land to the new page.
This is because the GURL implementation treats about:blank as a path URL and sets no query for it.
Note: the test diff files are in my home dir under the layoutest_onload dir.
Review URL: http://codereview.chromium.org/19492
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
request.
Review URL: http://codereview.chromium.org/19476
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=tc
Review URL: http://codereview.chromium.org/19505
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
a little to dangerous to block w/ a global ignore).
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Updated one flaky tests w/ crash status also since it's happened a few times last
24 hours.
Review URL: http://codereview.chromium.org/19708
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
identical to the Windows expectations (and Linux falls back to Windows
results).
Review URL: http://codereview.chromium.org/19500
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19498
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19697
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
synchronization.
Review URL: http://codereview.chromium.org/19693
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
kSetupExe constants to the executable path.
Review URL: http://codereview.chromium.org/19493
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=1609821
Review URL: http://codereview.chromium.org/19694
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Wrong titlebar height
* Titlebars not handling custom font size properly
* Drawing errors in maximized mode
* One-pixel overlap glitch on bottom corners of client edges
* Borders not handling custom border sizes correctly
* Unnecessarily small top resize area (unlike in the main window, there's no competition here between resizing and window dragging in the same small strip)
* Wrong icon sizing (only a problem in theory, no one uses this code ATM)
These files are now very much like simplified versions of the opaque_non_client_view.cc code (which was the goal); eventually all these should be refactorable.
BUG=5054
Review URL: http://codereview.chromium.org/19484
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19485
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a first filter (gzip) has buffered internal data to process, and has
already pushed a full 32K buffer to a second filter (such as sdch), but
the second filter declined to output anything (and instead asserted it
needed more data), then the filter chain was returning FILTER_OK. That
status usually meant that the filter should be called again, but the
calling code decided that a return of no bytes without a FILTER_NEED_MORE_DATA
status must mean the filter was done.
Rather than trying to change the calling infrastructure (which could impact
existing filters than are not part of a chain), this patch ensures that the
chained sequence never returns FILTER_OK without providing some output data.
This matches semantics of individual filters, which only return FILTER_OK
when they have pushed some data into the output buffer.
bug=1609306
r=huanr,openvcdiff
Review URL: http://codereview.chromium.org/19459
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19488
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19692
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
In theory these baselines can be shared between all platforms, but
we don't have a common dir. To reduce the amount of duplicate
work, have run_webkit_tests put the file in the right places.
Review URL: http://codereview.chromium.org/19688
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://clients4.google.com/firefox/metrics/collect,
which has a certificate that matches the host name.
Remove the net::LOAD_IGNORE_CERT_COMMON_NAME_INVALID
load flag.
R=evanm
BUG=b/876021
Review URL: http://codereview.chromium.org/19450
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=sky
Review URL: http://codereview.chromium.org/19489
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19689
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19487
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a proof of concept I converted
FindInPageControllerTest.FindInPageFrames over to this.
See the description in InProcessBrowserTest for how it all works.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/19644
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
formatting changes, i.e. CRLF, space at end of line.
Review URL: http://codereview.chromium.org/19486
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=evanm
Review URL: http://codereview.chromium.org/19482
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This is mostly making sure we have all the symbols we need.
Review URL: http://codereview.chromium.org/19683
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
as passing. It's passed the last 10 or so times on debug and release.
BUG=none
TEST=none
TBR=tc
Review URL: http://codereview.chromium.org/19686
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- The first run import will trigger the eula again : this requires changes in browser_main.cc
so the master prefs are not processed again by the importer process
- The launch of setup.exe to show the eula was using a path that only works on developer builds
this requires relocating a constant from setup_constants to util_constants
BUG=1468838
Review URL: http://codereview.chromium.org/19680
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
changes in OpaqueNonClientView in preparation for fixing similar problems in them, and then refactoring everyone to a common base implementation.
This change should have no visible effect; it merely adds functions, reorganizes code, renames variables, and modifies spacing/style to match OpaqueNonClientView as closely as possible. The subsequent set of functional changes should thus hopefully be easier to review, as should the eventual refactoring changes.
This does away with some useless code since both these views are used for windows which always have titles, and, in ConstrainedWindowNonClientView's case, never have icons. (Technically, DefaultNonClientView never has an icon right now either, but there's some commented-out code in the bookmark manager that speaks of having one one day.)
Review URL: http://codereview.chromium.org/19684
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
--install-extensionChanged manifest filename to end in .json.Updated authoring script to include sha256 hash of zip file.
Review URL: http://codereview.chromium.org/18477
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to the ignored list. Here's what I believe is happening:
// This test has hover effects that change the font size. This test also
// moves the mouse around, resulting in a layout that dances around.
// Depending upon when the snapshot is taken we get different results.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/19681
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
about issues I discovered in this process.
Review URL: http://codereview.chromium.org/19677
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19673
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
it fails because of font size differences.
Review URL: http://codereview.chromium.org/19478
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
chrome_dll (we use the methods in renderer_glue.cc instead).
Review URL: http://codereview.chromium.org/19678
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the UI, just had to manually edit the file.
Review URL: http://codereview.chromium.org/19480
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
also removed support for window frame sizes with unequal widths vs. heights; Windows' UI doesn't actually let you do this and it was making the code more complex than it needed to be.
Review URL: http://codereview.chromium.org/19477
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MessageLoop. I'm going to need this when running ui tests in
process. In this case I'll pass in the IO thread.
I'll change all callers to use the new method, but before doing that
wanted to make sure you're ok with it.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/19039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pointer. Based on the crash dump, the crash occurs in the windows message filter hook, used for tracking whether the plugin enters a modal loop. The global plugin instance pointer gets reset to NULL in the windowed plugin wndproc and HandleEvent. If these events occur in nested order, then it is quite possible for the plugin instance pointer to get set to NULL incorrectly.
Added a check for whether this pointer is NULL in the message filter hook along with a NOTREACHED statement.
We maintain a local global stack to ensure that the plugin instance pointer gets set/reset correctly.
The bug is http://code.google.com/p/chromium/issues/detail?id=6703
The other issue being fixed is to set the modal_loop_pump_messages_event coming in from the plugin
in WebPluginDelegateProxy correctly. This caused the plugin to not receive events when it enters a modal loop like a context menu.
Bug=6703
Review URL: http://codereview.chromium.org/19444
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Turns out we need to broadcast the NOTIFY_USER_SCRIPTS_LOADED message even if
there are no scripts. I just removed the DCHECK that expects scripts.
Review URL: http://codereview.chromium.org/19475
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
get loaded correctly.
Review URL: http://codereview.chromium.org/19676
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19675
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
webkit into unit_tests.
There was also a problem with simple_clipboard_impl.cc which should only be
compiled into test_shell.
I can't remove mock_webkit_glue.cc until I verify that the mac build doesn't
need it anymore.
Review URL: http://codereview.chromium.org/19474
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
this file, but WebCore includes it, and so we can avoid some WebCore
forking by implementing npruntime_impl.h appropriately.
R=dglazkov
Review URL: http://codereview.chromium.org/19472
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19473
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/19674
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8904 0039d316-1c4b-4281-b951-d872f2087c98
|