summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Removed TalkMediator SSL initialization.akalin@chromium.org2010-09-165-75/+6
| | | | | | | | | | | Since we're now using chrome sockets, we don't need this code. BUG=54146 TEST=Unit tests Review URL: http://codereview.chromium.org/3411012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59741 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SimpleFileSystem.getMetadata to readMetadatakinuko@chromium.org2010-09-162-3/+2
| | | | | | | | | BUG=52799 TEST=none Review URL: http://codereview.chromium.org/3441010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59740 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed notifier_unit_tests failures.akalin@chromium.org2010-09-161-1/+13
| | | | | | | | | | | | These were introduced by r59629, but weren't caught since notifier_unit_tests isn't on the waterfall (bug 55799). BUG=None TEST=ran notifier_unit_tests manually Review URL: http://codereview.chromium.org/3416005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59739 0039d316-1c4b-4281-b951-d872f2087c98
* Make a destructor protected per darin@'s request in a previous code review.erg@google.com2010-09-161-2/+4
| | | | | | | | | | TBR=darin@chromium.org BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3390010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59737 0039d316-1c4b-4281-b951-d872f2087c98
* Moves TabStripModelObserver/Delegate into their own headers.sky@chromium.org2010-09-1660-447/+556
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3425009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59733 0039d316-1c4b-4281-b951-d872f2087c98
* Break indirect dependencies on system OpenGL headers through NPAPIkbr@google.com2010-09-162-19/+33
| | | | | | | | | | | | | | | headers in render_view.h. This was preventing code which needs to access the RenderView from also using the GLES2 command buffer headers in gpu/GLES2/. Code which relies on this dependency removal will soon be checked in which will prevent these dependencies from being accidentally reintroduced. BUG=52863 TEST=none (compiled these changes with forthcoming code) Review URL: http://codereview.chromium.org/3413016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59732 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Add page load time histograms for thervargas@google.com2010-09-161-0/+54
| | | | | | | | | | | | cache throttling experiment. BUG=54338 TEST=none Review URL: http://codereview.chromium.org/3420006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59731 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Start an experiment to measure the impact ofrvargas@google.com2010-09-162-6/+39
| | | | | | | | | | | | throttling cache requests. BUG=54338 TEST=none Review URL: http://codereview.chromium.org/3388009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59729 0039d316-1c4b-4281-b951-d872f2087c98
* Re checkin 59671.lzheng@chromium.org2010-09-168-35/+129
| | | | | | | | | | | | | | Revert 59680 - Revert 59671 - Refactor test_server so some python related functions could be shared by other test servers. BUG=none TEST=python_utils_unittest.cc Review URL: http://codereview.chromium.org/3366026 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/3415011 TBR=lzheng@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59728 0039d316-1c4b-4281-b951-d872f2087c98
* Fix problem with extension context menu items losing top-level icon.asargent@chromium.org2010-09-167-21/+172
| | | | | | | | | | | | | | | If an extension adds some context menu items, then removes them all, and adds some more, instead of their actual icon the new items will get the default extension icon in context menus. This is because we use the caching feature of ImageLoadingTracker and get an immediate callback from LoadImage before we've put the request in pending_icons_. BUG=53543 TEST=Steps are outlined in bug report. Review URL: http://codereview.chromium.org/3425007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59726 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 527.0 to 528.0chrome-release@google.com2010-09-161-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59723 0039d316-1c4b-4281-b951-d872f2087c98
* Add two bookmark testcases MC_BiDirectionalPush_AddingSameBMs and ↵rsimha@chromium.org2010-09-161-1/+94
| | | | | | | | | | | | | | | MC_Merge_CaseInsensitivity_InNames, and fix test case MC_BiDirectionalPushAddingBM, not to create bookmarkNode1 from bookmarkModel0. Patch from Vivian Zhi <vivianz@chromium.org>. BUG=NONE TEST=sync_integration_tests Review URL: http://codereview.chromium.org/3333030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59720 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SameObject to not return false when the volume name returned by ↵nsylvain@chromium.org2010-09-161-1/+1
| | | | | | | | | QueryDosDevice ends with more than 2 NULL chars. Review URL: http://codereview.chromium.org/3429010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59719 0039d316-1c4b-4281-b951-d872f2087c98
* Move sqlite preprocessed directory one level up, it's not from upstream.phajdan.jr@chromium.org2010-09-1610-9/+9
| | | | | | | | | | | This is a follow-up to one of my earlier patches. TEST=none BUG=22208, 50769 Review URL: http://codereview.chromium.org/3301019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59717 0039d316-1c4b-4281-b951-d872f2087c98
* Hook users DOMUI with backend.xiyuan@chromium.org2010-09-165-35/+192
| | | | | | | | | BUG=chromium-os:968 TEST=Verify users settings are persisted per machine correctly and only owner is allowed to make changes. Review URL: http://codereview.chromium.org/3403007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59716 0039d316-1c4b-4281-b951-d872f2087c98
* Second try of http://codereview.chromium.org/3322009 since it got reverted.imcheng@chromium.org2010-09-165-130/+242
| | | | | | | | | | | | | | | | Added a media UI test case for fullscreen video implementation for Windows (which is not committed yet). However, it is currently disabled until the webkit patches are here. Also changed the other cases in media_uitest.cc to stop using Sleep() in test code. Instead, NotificationObserver and NotificationRegistrar are used. Thirdly, moved media_uitest.cc from ui_tests to interactive_ui_tests. TEST=ui_tests, interactive_ui_tests BUG=54838 Review URL: http://codereview.chromium.org/3407003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59715 0039d316-1c4b-4281-b951-d872f2087c98
* Fix svn:executable for gmock.thestig@chromium.org2010-09-162-0/+0
| | | | | | | | BUG=none TEST=check_perms passes. Review URL: http://codereview.chromium.org/3410015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59713 0039d316-1c4b-4281-b951-d872f2087c98
* Add a placeholder, overridable DOMUI keyboard.bryeung@chromium.org2010-09-1618-1/+207
| | | | | | | | | | | This change does not add support for displaying the keyboard. That will be provided (along with a more useful keyboard) in follow-up changes. BUG=none TEST=added new override test Review URL: http://codereview.chromium.org/3362019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59712 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Fix the order in which we delete datarvargas@google.com2010-09-1615-54/+356
| | | | | | | | | | | | | | | | | | | | | from the block files. Stress testing the cache reveals a problem with the deletion of some data from an entry: it is possible to crash in a way that the block file thinks a block is free and an entry thinks the block is in use. This CL corrects that issue. There is also some new tests and a bunch of DCHECKS added while looking for the problem, as well as adding tests to make sure that a block file is accessed only from one thread (there is no problem with the current code in that regard) BUG=55605 TEST=netunittests Review URL: http://codereview.chromium.org/3430004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59711 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new net error code for when the load failure was due to connecting to ↵eroman@chromium.org2010-09-168-8/+21
| | | | | | | | | | | | | | | | | | | | | a bad proxy server. Prior to this change, users would likely have seen one of these errors on failure to connect through a proxy server: ERR_NAME_NOT_RESOLVED ERR_ADDRESS_UNREACHABLE ERR_CONNECTION_REFUSED ERR_CONNECTION_TIMED_OUT ERR_CONNECTION_FAILED Whereas now any host resolve or tcp connect error will map to: ERR_PROXY_UNREACHABLE This error code will allow selecting a more suitable error page. BUG=53477 Review URL: http://codereview.chromium.org/3360025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59710 0039d316-1c4b-4281-b951-d872f2087c98
* Make the test code that changes the GoogleBaseURL do a notification (instead oflevin@chromium.org2010-09-162-1/+5
| | | | | | | | | | | | | | | directly calling a method) to more closely mimic the way this usually happens. This is being done to avoid making special "update GoogleBaseURL" method calls both here and in future tests, and helps ensure that the notification observer code is set-up correctly. BUG=38475 TEST=unit_tests --gtest_filter=Temp* Review URL: http://codereview.chromium.org/3420007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59709 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Cleanup MenuGtk to use signals thunk macros.erg@google.com2010-09-162-29/+25
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3426006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59708 0039d316-1c4b-4281-b951-d872f2087c98
* Mark PluginTest.Quicktime as FLAKYinferno@chromium.org2010-09-161-1/+1
| | | | | | | BUG=55915 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59707 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 59698 - Breakpad DEPS roll 657:687inferno@chromium.org2010-09-161-1/+1
| | | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3454003 TBR=thestig@chromium.org Review URL: http://codereview.chromium.org/3422009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59706 0039d316-1c4b-4281-b951-d872f2087c98
* Added implementations of entry points which will shortly be addedkbr@google.com2010-09-162-0/+82
| | | | | | | | | | | upstream for implementing the compositor on top of GraphicsContext3D. BUG=55750 TEST=none Review URL: http://codereview.chromium.org/3430008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59705 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Add a few more keyboard shortcuts to tabpose.thakis@chromium.org2010-09-161-20/+184
| | | | | | | | | | | | | | * shift / tab-shift cycle through all open tabs * arrow keys move selection up, down, left, right * cmd-1-8 selects tab 1-8 and exits tabpose, cmd-9 selects last tab and exits tabpose * cmd-ctrl-t exits tabpose BUG=50307,55530 TEST=try it Review URL: http://codereview.chromium.org/3389010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59703 0039d316-1c4b-4281-b951-d872f2087c98
* GpuProcessHost and GpuChannel do not assert if they receive an IPC message ↵apatrick@chromium.org2010-09-162-6/+9
| | | | | | | | | | | | | | that cannot be routed. Comment added to code: The object to which the message is addressed might have been destroyed. This is expected, for example an asynchronous SwapBuffers notification to a command buffer proxy that has since been destroyed. This function fails silently in that case. TEST=try BUG=none Review URL: http://codereview.chromium.org/3362017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59702 0039d316-1c4b-4281-b951-d872f2087c98
* clang: update gtest to r435 and gmock to r300.evan@chromium.org2010-09-1639-3539/+1143
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This picks up some clang-specific fixes. Unfortunately, the gtest update cascaded into a gmock update. So I picked the earliest gmock version that mentioned a specific gtest version so that they are more likely to work together. gtest changelog: - Fixes a leak in ThreadLocal. - CMake 2.8/Visual Age compatibility patch by Hady Zalek. - C++ Builder compatibility patch by Josh Kelley. - Fixes gtest_filter_unittest and gtest_help_test on systems without death tests. - Simplifies Makefile.am (by Zhanyong Wan and Vlad Losev). - Adds alternative spellings for FAIL, SUCCEED, and TEST. - Over-hauls README, and fixes Makefile. - Fixes gtest-port_test on MinGW. - Implements color output in GNU Screen sessions (issue 277). - Minor improvement to hermetic build support in the CMake script, by Vlad Losev. - Improves support for building Google Test as Windows DLL. - Silence a Clang warning about an unused variable. - Moves the universal printer from gmock to gtest and refactors the cmake script for reusing in gmock (by Vlad Losev). - Suppresses some Clang warnings (by Chandler Carruth, Jeffrey Yasskin, and Zhanyong Wan). - Renames CMake build script options. - Lucid autotools compatibility patch by Jeffrey Yasskin. - Replaces UniversalPrinter<T>::Print(x, os) with UniversalPrint(x, os) as appropriate (by Zhanyong Wan). - Comment tweaks in CMakeLists.txt. - Renames test script flags. - Fixes a typo in comments. - Adds GTEST_REMOVE_REFERENCE_AND_CONST_. - Introduces gtest_force_shared_crt option for CMake build scripts. - Implements printing parameters of failed parameterized tests (issue 71). gmock changelog: - Improves Makefile.am (by Vlad Losev); fixes Makefile and updates README (by Zhanyong Wan). - Fixes a typo in README. - Adds Each(m) (by Wojtek Moczydlowski); removes scripts/test/Makefile (by Zhanyong Wan); pulls in gtest r424. - Adds a synchronization test. - Fixes tests leaking altered values of GMOCK_FLAG(verbose) (issue 110). - Moves the universal printer from gmock to gtest (by Vlad Losev). - Renames test script flags. - Adds CMake build script. - Implements Pointwise(). - Fixes build failure on Windows/CMake (issue 111). - Pulls r435 of gtest. This brings in the gtest_force_shared_crt option in CMake. TEST=all existing tests should still pass Review URL: http://codereview.chromium.org/3427004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59701 0039d316-1c4b-4281-b951-d872f2087c98
* Add methods to ProfileSyncServiceTestHarness to enable / disable sync for ↵rsimha@chromium.org2010-09-163-26/+84
| | | | | | | | | | | | | | datatypes. Some sync integration tests require functionality to enable or disable sync for a given datatype. BUG=55772,55650 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/3390007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59700 0039d316-1c4b-4281-b951-d872f2087c98
* Breakpad DEPS roll 657:687thestig@chromium.org2010-09-161-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3454003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59698 0039d316-1c4b-4281-b951-d872f2087c98
* Change the FileSystem IPCs to take FilePaths as arguments instead ofdumi@chromium.org2010-09-164-83/+67
| | | | | | | | | | | | | string16s. FilePaths are better than string16s, because pepper uses FilePaths, and for the WebFileSystem API it doesn't matter, because it needs to do the string16 --> FilePath conversion once. TEST=none BUG=none Review URL: http://codereview.chromium.org/3383003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59697 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Fix pure call in CrashHandlerHostLinux::Init().thestig@chromium.org2010-09-162-7/+18
| | | | | | | | BUG=55780 TEST=no more random crashes on startup. Review URL: http://codereview.chromium.org/3417005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59696 0039d316-1c4b-4281-b951-d872f2087c98
* Remove use of accessible prop service from render_widget_host_view_win.ccctguil@chromium.org2010-09-165-49/+26
| | | | | | | | | BUG=none TEST=interactive_iu_tests:AccessibilityWinBrowserTest.TestRendererAccessibilityTree Review URL: http://codereview.chromium.org/3415008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59693 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the code that shall not be used in tests: PathService::Get(base::DIR_TEMPlevin@chromium.org2010-09-161-13/+5
| | | | | | | | | | | Use ScopedTempDir instead. BUG=38475 TEST=unit_tests --gtest_filter=Temp* Review URL: http://codereview.chromium.org/3423010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59692 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ↵ctguil@chromium.org2010-09-161-30/+53
| | | | | | | | | | | | | | | browser_tests:RendererAccessibilityBrowserTest.TestCrossPlatformAccessibilityTree for all platforms. - Remove sending of ViewMsg_GetAccessibilityTree. It can request the accessibility tree before the page is loaded. - Remove use of std::string::c_str() when the object is out of scope. - Initialize COM on windows. BUG=53853 TEST=browser_tests:RendererAccessibilityBrowserTest.TestCrossPlatformAccessibilityTree Review URL: http://codereview.chromium.org/3424011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59690 0039d316-1c4b-4281-b951-d872f2087c98
* Make a utility test class that is useful to any code which is trying to createlevin@chromium.org2010-09-166-288/+455
| | | | | | | | | | | | | | | | | a TemplateURLModel and persist it. This only affects test code and should have no functionality change (just code re-arrangement). This change prepares the way for an implementation of SearchProviderInstallData and a unit test for it. BUG=38475 TEST=unit_tests --gtest_filter=Temp* Review URL: http://codereview.chromium.org/3422006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59689 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: make tools/licenses.py happy about third_party/npapiphajdan.jr@chromium.org2010-09-162-0/+34
| | | | | | | | BUG=55168 TEST=tools/licenses.py Review URL: http://codereview.chromium.org/3447005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59688 0039d316-1c4b-4281-b951-d872f2087c98
* Show "DNS" as the authority for DNSSEC validated certficiates.agl@chromium.org2010-09-164-1/+18
| | | | | | | | | | | | | | | | | | | At the moment, if we validate a certificate using DNSSEC the Page Info dialog will show whatever Issuer the site chose as the issuing authority. That's confusing because the site could choose a string like 'US Dept of Homeland Security' (for example) which is misleading. This patch forces the authority string to always be "DNSSEC" in the case that we used DNSSEC to validate the certificate. (The string "DNSSEC" isn't translated as it's an acronym.) BUG=none TEST=none http://codereview.chromium.org/3304016/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59686 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix concurrent access on a non-threadsafe data structure.thakis@chromium.org2010-09-162-12/+33
| | | | | | | | | | | | | | | Also remove a call to cocoa from the non-ui thread. DrawAcceleratedSurfaceInstance is called on the display link thread. plugin_views_ can be written to from the main thread. Since the map is only used to get the view's size, pass in the size right away. There's another problem like this in plugin_container_manager_, which also has a map that is accessed from two threads. I will address this in a follow-up CL. BUG=52491 TEST=none Review URL: http://codereview.chromium.org/3431011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59684 0039d316-1c4b-4281-b951-d872f2087c98
* Fix failing checks that enforce an ordering on test timeout values. This ↵robertshield@chromium.org2010-09-161-5/+9
| | | | | | | | | | | ordering is not yet respected by all test runners. BUG=0 TEST=0 TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/3400010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59683 0039d316-1c4b-4281-b951-d872f2087c98
* Data files for bug 53495 so that trybots will work.aa@chromium.org2010-09-167-0/+35
| | | | | | | TBR=mpcomplete@chromium.org BUG=53495 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59681 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 59671 - Refactor test_server so some python related functions could ↵lzheng@chromium.org2010-09-168-129/+35
| | | | | | | | | | | | | be shared by other test servers. BUG=none TEST=python_utils_unittest.cc Review URL: http://codereview.chromium.org/3366026 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/3415011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59680 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 59668 - Webkit roll 67597:67622inferno@chromium.org2010-09-161-1/+1
| | | | | | | | | | | BUG=none TEST=none TBR=johnnyg TBR=satish@chromium.org Review URL: http://codereview.chromium.org/3450012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59679 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Size popup windows correctly.rohitrao@chromium.org2010-09-161-1/+26
| | | | | | | | BUG=48428 TEST=Popup windows should open with the correct content size (while still respecting the 400x250 minimum window size). Review URL: http://codereview.chromium.org/3408003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59678 0039d316-1c4b-4281-b951-d872f2087c98
* Add testing of the Chrome Frame user-mode installation to ↵robertshield@chromium.org2010-09-1614-123/+164
| | | | | | | | | | | | | | mini_installer_tests.exe. Also do some miscellaneous cleanup and rejiggering such as removing test-only constants from chrome\common, adding more useful prints when tests fail, properly waiting for child processes to terminate and moving a timeout value to test_timeouts.cc in test_support_common. BUG=53127 TEST=Chrome Frame user level installs are tested. Review URL: http://codereview.chromium.org/3297026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59675 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor test_server so some python related functions could be shared by ↵lzheng@chromium.org2010-09-168-35/+129
| | | | | | | | | | other test servers. BUG=none TEST=python_utils_unittest.cc Review URL: http://codereview.chromium.org/3366026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59671 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up policy tests.mnissler@chromium.org2010-09-168-754/+1058
| | | | | | | | | | | Refactor the unit tests for the various ConfigurationPolicyProvider implementations and the ConfigurationPolicyPrefStore, so they are more modular and it becomes easy to add tests for new policies. Also make sure all the existing policies get test coverage. BUG=none TEST=compiles and passes unit tests Review URL: http://codereview.chromium.org/3311005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59669 0039d316-1c4b-4281-b951-d872f2087c98
* Webkit roll 67597:67622satish@chromium.org2010-09-161-1/+1
| | | | | | | | BUG=none TEST=none TBR=johnnyg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59668 0039d316-1c4b-4281-b951-d872f2087c98
* Improvements of SignedSettingsHelper:xiyuan@chromium.org2010-09-163-53/+76
| | | | | | | | | | | | | | | | - Fixed a bug that helper gets stuck waiting for never-happening callback when op's Executed returns false; - Change Cancel -> CancelCallback and execute all pending ops even when its callbacks are canceled. This makes sure that settings change are applied even user dismisses UI before the ops complete; - Update unit tests accordingly; BUG=chromium-os:968 TEST=none. Review URL: http://codereview.chromium.org/3443004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59667 0039d316-1c4b-4281-b951-d872f2087c98
* Use net-yet-implemented message in cellular config view to avoid confusion.xiyuan@chromium.org2010-09-161-1/+11
| | | | | | | | | BUG=none TEST=Verify celluar config view shows not-yet-implemented info instead of fake data. Review URL: http://codereview.chromium.org/3397006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59666 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-15 02:12:02 +0000