summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Enable download_request_manager_unittest on linux.estade@chromium.org2009-03-094-7/+30
| | | | | | Review URL: http://codereview.chromium.org/41002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11288 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes session restore bug where we wouldn't necessarily correctlysky@google.com2009-03-094-8/+29
| | | | | | | | | | | | | | | restore the maximized state. The problem was we were using a boolean when we really needed three values: use the default, explicitly maximized or explicitly normal. I'm also removing a bogus DLOG in info_bubble. BUG=7930 TEST=see bug Review URL: http://codereview.chromium.org/40306 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11287 0039d316-1c4b-4281-b951-d872f2087c98
* hook up history and download menu itemstc@google.com2009-03-095-27/+19
| | | | | | | | | | Small fix to get them to display (need to include webkit strings in our language pak files). Review URL: http://codereview.chromium.org/39296 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11286 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in ResizeCorner. ResizeCorner was caching the BrowserViewsky@google.com2009-03-094-7/+34
| | | | | | | | | | | | | | that created it, but if a tab contained a download shelf and was dragged to a new window the ResizeCorner would be referencing the wrong BrowserView. I've changed the code to look up the ancestor BrowserView as necessary. BUG=8477 TEST=see bug Review URL: http://codereview.chromium.org/41010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11285 0039d316-1c4b-4281-b951-d872f2087c98
* Back out r10845 because it caused too many other regressions.pkasting@chromium.org2009-03-098-113/+49
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11284 0039d316-1c4b-4281-b951-d872f2087c98
* Remove compile warning on OSX if brandedjrg@chromium.org2009-03-091-2/+3
| | | | | | Review URL: http://codereview.chromium.org/40316 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11283 0039d316-1c4b-4281-b951-d872f2087c98
* Remove lines having to do with transforms/3d since all of those tests ignoreddarin@chromium.org2009-03-091-12/+4
| | | | | | | | | | (see tests_ignored.txt). R=ben Review URL: http://codereview.chromium.org/40304 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11282 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline two scroll bar layout tests. There are slight areas in the scroll ↵sidchat@google.com2009-03-095-4/+4
| | | | | | | | bar regions where the shading is off slightly, as found using GIMP. Review URL: http://codereview.chromium.org/40251 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11281 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression in menus. Specifically selecting by way of press,sky@google.com2009-03-091-2/+3
| | | | | | | | | | | | drag then release was broken. It appears that TPM_RIGHTBUTTON disallows this behavior. BUG=8560 TEST=see bug Review URL: http://codereview.chromium.org/41006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11280 0039d316-1c4b-4281-b951-d872f2087c98
* BUG=8345hclam@chromium.org2009-03-094-14/+63
| | | | | | | | | | | | Added a PasswordManagerTableModelObserver to listen for row count change events. PasswordManagerView and PasswordManagerExceptionsView are listening to the event. Move the |instance_| variable from static global to the respective class to avoid future misuse of the variable. Review URL: http://codereview.chromium.org/39313 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11279 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 11277.jcampan@chromium.org2009-03-091-4/+33
| | | | | | | Reverting build bustage Review URL: http://codereview.chromium.org/40315 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11278 0039d316-1c4b-4281-b951-d872f2087c98
* Removing Windows specific code from interstitial pages.jcampan@chromium.org2009-03-091-33/+4
| | | | | | | | BUG=None TEST=Navigate to bad https URL, make sure interstitial page still shows up and works as expected. Review URL: http://codereview.chromium.org/40311 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11277 0039d316-1c4b-4281-b951-d872f2087c98
* Disable flaky TimerTest.DelayTimer_Reset test.phajdan.jr@chromium.org2009-03-092-1/+8
| | | | | | | | | | Not filing a bug because timer test are difficult to make not-flaky on the buildbots. However, added comments to the code so that people who touch this area remember to run all tests. Review URL: http://codereview.chromium.org/40312 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11276 0039d316-1c4b-4281-b951-d872f2087c98
* Changing ForwardMessageToExternalHost to postMessage and passing a propertommi@chromium.org2009-03-0925-69/+427
| | | | | | | | | | | | | | | MessageEvent object to the onmessage handler. Also adding support for origin and target parameters. The origin parameter is implicit but target can be specified when calling postMessage. If no target is specified we default to "*". At the moment I'm only allowing target == "*" messages to pass through since I haven't implemented support for matching more complicated patterns :) Review URL: http://codereview.chromium.org/40128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11275 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes issue 8435 (http://code.google.com/p/chromium/issues/detail?id=8435)munjal@chromium.org2009-03-091-0/+3
| | | | | | Review URL: http://codereview.chromium.org/39303 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11274 0039d316-1c4b-4281-b951-d872f2087c98
* Gyp config updates to fix some Linux build errors.mmoss@chromium.org2009-03-091-12/+14
| | | | | | | | | Far from complete but sending early to sync with others. Review URL: http://codereview.chromium.org/40258 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11273 0039d316-1c4b-4281-b951-d872f2087c98
* Fix my first layout test! The expected and actual results were two ↵jparent@chromium.org2009-03-092-32/+30
| | | | | | | | different representations of the same visual position. Specifically, the expected results were looking for the deep position, but the actual results were a shallow position. This is from a webkit change (http://trac.webkit.org/changeset/39831) where appendTrailingWhitespace was changed to stop modifying the live selection to use the deepEquivalent of the end position, thus leaving it in the shallow position. Review URL: http://codereview.chromium.org/39306 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11272 0039d316-1c4b-4281-b951-d872f2087c98
* Implement right click context menu on gtk.estade@chromium.org2009-03-098-19/+220
| | | | | | Review URL: http://codereview.chromium.org/40266 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11271 0039d316-1c4b-4281-b951-d872f2087c98
* Add a comment describing how Linux falls back to Windows results. Don't addpam@chromium.org2009-03-091-2/+15
| | | | | | | | | | | 'chromium' to expected-result search path if it's already there, and don't fall back to chromium-win results if it's not a Chromium platform. BUG=none TEST=none Review URL: http://codereview.chromium.org/39310 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11270 0039d316-1c4b-4281-b951-d872f2087c98
* Initial Linux chrome.gyp changes (some courtesy mmoss):sgk@google.com2009-03-091-10/+24
| | | | | | | | | | | | | | | | * Exclude .m and .mm files on non-Mac platforms. * browser/autocomplete/edit_drop_target.{cc,h} are gone. * browser/gtk/browser_toolbar_view_gtk.{cc,h} => browser/gtk/browser_toolbar_gtk.{cc,h} * Target 'browser' needs net_resources.h to build on Linux. * Exclude to-be-ported browser/debugger files on Linux. * Comment out url_request_mock_http_job.cc in test_support. (It really belongs there, but it's currently used by production code in automation_provider.cc, so leave it there for now, with appropriate comments.) Review URL: http://codereview.chromium.org/39350 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11269 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize the command line object before initializing the logger. Alsoananta@chromium.org2009-03-091-0/+9
| | | | | | | | | | register/unregister the AtExitManager for the shim. TBR=joshia Review URL: http://codereview.chromium.org/40283 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11268 0039d316-1c4b-4281-b951-d872f2087c98
* Add a copy of DOM checker for testing. DOM checker is a tool to help automatepatrick@chromium.org2009-03-095-0/+1471
| | | | | | | | | | | | | | | | | | | domain security policy enforcement. This copy of DOM checker was fetched from: http://lcamtuf.coredump.cx/dom_checker/ Some values in dom_config.js have been changed. There have been no other modifications. In order to automate this test, there will need to be a few more small changes. To more easily see what changes have been made for Chromium, I'm first checking in a clean copy. BUG=6274 Review URL: http://codereview.chromium.org/40234 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11264 0039d316-1c4b-4281-b951-d872f2087c98
* Instead of marking the test that happens to come next as fail, mac isthomasvl@chromium.org2009-03-091-6/+4
| | | | | | | | explicitly skipping a test that causes the next test (no matter what it is) to fail. Review URL: http://codereview.chromium.org/40308 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11263 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in SessionBackend. I believe what's happeningsky@google.com2009-03-093-7/+62
| | | | | | | | | | | | | | | | | | | | here is we fail to create the file, and so current_session_file_.get() is NULL and we crash. current_session_file_.get() is NULL if OpenAndWriteHeader returns NULL (which is does if the full header isn't written correctly. Here's how I'm changing the code: . The file is now truncated instead of closed/reopened. Hopefully this avoids the possibility of a scanner locking the file and the delete failing. . Added a unit test for coverage of truncation. . The file is opened in exclusive access. There is no reason why a scanner should open this file. . Added null checks. BUG=8476 TEST=none Review URL: http://codereview.chromium.org/39275 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11262 0039d316-1c4b-4281-b951-d872f2087c98
* Add filter_unittest.h to net/base modulejar@chromium.org2009-03-091-0/+1
| | | | | | | r=sgk Review URL: http://codereview.chromium.org/40305 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11261 0039d316-1c4b-4281-b951-d872f2087c98
* Make SecondLaunch UI test not-flaky by using more reliablephajdan.jr@chromium.org2009-03-091-6/+2
| | | | | | | | | | automation calls. BUG=5671 Review URL: http://codereview.chromium.org/40301 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11259 0039d316-1c4b-4281-b951-d872f2087c98
* Add warning comment to FileStream::Truncateagl@chromium.org2009-03-091-0/+2
| | | | | | | Review URL: http://codereview.chromium.org/40299 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11258 0039d316-1c4b-4281-b951-d872f2087c98
* Get gyp-generated test_shell_tests working on Linux bysgk@google.com2009-03-091-0/+7
| | | | | | | | | excluding the tests that aren't working yet on Linux... TBR: mark@chromium.org (based on discussion) Review URL: http://codereview.chromium.org/39302 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11257 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tree: Purify noted I didn't init two bools in a mock-class constructor.jar@chromium.org2009-03-091-1/+5
| | | | | | | tbr=wtc Review URL: http://codereview.chromium.org/41001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11255 0039d316-1c4b-4281-b951-d872f2087c98
* More WebKit API action (chromium side).darin@chromium.org2009-03-0910-58/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds the following methods to WebKitClient: decrementStatsTable incrementStatsTable traceEventBegin traceEventEnd The implementation of initV8CounterFunction is now a no-op. V8Proxy.cpp no longer calls it, and I moved the corresponding work out of WebKit. The embedder now calls the appropriate V8 API before initializing WebKit. Includes some cleanup to WebString and WebCString. I decided that I prefer "data" over "characters" since the latter may be confusing in some cases. For example, the elements of a WebString or WebCString may not be individual characters but may be part of a character. "data" is also consistent with basic_string<T> and so should be plenty familiar. There is wanton disregard for the Chrome+JSC build in this CL, but that's OK. We have already crossed that bridge. R=dglazkov Review URL: http://codereview.chromium.org/39288 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11254 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the stats counter calls for NPObject counts. This code is used in thedarin@chromium.org2009-03-091-7/+0
| | | | | | | | | | | | | | plugin process which should not be using ChromiumBridge. I could try to find another way to implement these stats counters if they are really valuable. Otherwise, it is just simpler to remove them. Ultimately, I don't think our code in the plugin process should be relying on WebKit code, but that is more work to implement. R=mbelshe Review URL: http://codereview.chromium.org/39346 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11252 0039d316-1c4b-4281-b951-d872f2087c98
* Script and configs to generate Debian packages from current build.mmoss@chromium.org2009-03-0911-0/+609
| | | | | | | | | Packages are manually generated now (run ./build.sh after a successful static build), but will be integrated into the main build system soon. Review URL: http://codereview.chromium.org/39088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11250 0039d316-1c4b-4281-b951-d872f2087c98
* Run more unit tests on Linux:phajdan.jr@chromium.org2009-03-0913-89/+100
| | | | | | | | | | | | | | | | - used string16 instead of wstring where needed - replaced GetTickCount calls with portable functions from base/time.h - misc GCC cleanups - enabled following unit tests on Linux: browser/autocomplete/history_contents_provider_unittest.cc browser/autocomplete/history_url_provider_unittest.cc browser/autocomplete/keyword_provider_unittest.cc browser/bookmarks/bookmark_html_writer_unittest.cc Review URL: http://codereview.chromium.org/39335 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11249 0039d316-1c4b-4281-b951-d872f2087c98
* Use FilterContext to allow filters to access URLRequestJob datajar@chromium.org2009-03-0936-165/+405
| | | | | | | r=wtc,darin,huanr Review URL: http://codereview.chromium.org/40138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11248 0039d316-1c4b-4281-b951-d872f2087c98
* Add regression test for bug 7900 and necessary infrastructure.phajdan.jr@chromium.org2009-03-093-1/+62
| | | | | | | | | | | | The test simulates following scenario: user opens a local html page with Chrome when a browser instance is already running. The new Chrome process should notify the existing process about new page and exit. Bug 7900 broke this behavior causing the new process to crash. I verified that the ui_tests infrastructure would catch this crash and cause the test to fail. BUG=7900, 8056 Review URL: http://codereview.chromium.org/39257 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11247 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to latest trunk version containing a fix for an assertionager@chromium.org2009-03-091-1/+1
| | | | | | | | that was triggered when opening the web inspector in the test shell in debug mode. Review URL: http://codereview.chromium.org/39345 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11246 0039d316-1c4b-4281-b951-d872f2087c98
* Adds truncate to FileStream.sky@google.com2009-03-094-0/+73
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/39301 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11245 0039d316-1c4b-4281-b951-d872f2087c98
* Strip CRs from *.in files to allow building from webkit.orgdglazkov@google.com2009-03-092-3/+3
| | | | | | | | R=darin Review URL: http://codereview.chromium.org/39004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11244 0039d316-1c4b-4281-b951-d872f2087c98
* Updating mac tests based on the weekendthomasvl@chromium.org2009-03-091-30/+9
| | | | | | | | | | | | - a few more keyboard input tests pass from Avi's work landing upstream - some other test are passing, probably from core fixes that went in focused on the windows side but helped mac. - updating the comments on one failing test since the test passes, it's a corruption problem from a test that runs before it. Review URL: http://codereview.chromium.org/39343 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11243 0039d316-1c4b-4281-b951-d872f2087c98
* Make page_cycler_tests build on Linux (doesn't run successfully yet).phajdan.jr@chromium.org2009-03-095-55/+72
| | | | | | Review URL: http://codereview.chromium.org/40182 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11239 0039d316-1c4b-4281-b951-d872f2087c98
* Bump for 170 dev cycle. 169 was branched at 11198mal@chromium.org2009-03-091-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11237 0039d316-1c4b-4281-b951-d872f2087c98
* chrome-ui://extensions/ is now populated with data collected from the ↵rafaelw@chromium.org2009-03-0913-60/+456
| | | | | | | | ExtensionsService and ExtensionErrorReporter Review URL: http://codereview.chromium.org/39026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11233 0039d316-1c4b-4281-b951-d872f2087c98
* Change "bleh" for "foo".nsylvain@chromium.org2009-03-081-4/+4
| | | | | | | | This is a dummy change to trigger the bots. Review URL: http://codereview.chromium.org/39328 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11231 0039d316-1c4b-4281-b951-d872f2087c98
* Bringup sys_string_conversions_unittest.cc on Linux.jeremy@chromium.org2009-03-081-1/+0
| | | | | | Review URL: http://codereview.chromium.org/29010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11223 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline for rafaelw@chromium.org2009-03-085-50/+52
| | | | | | | | | | | | | | | | LayoutTests/fast/dom/SelectorAPI/dumpNodeList.html LayoutTests/fast/dom/SelectorAPI/dumpNodeList-almost-strict.html Looks like webkit removed [ConvertUndefinedOrNullToNullString] from the WebCore/dom/Document.idl querySelector & querySelectorAll which resulted in differing expected output. The fast/dom/SelectorAPI/dumpNodeList-*-expected.txt files have the updated (correct) output, but we had branched our expected.txt files because of different TypeError output. Review URL: http://codereview.chromium.org/40265 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11222 0039d316-1c4b-4281-b951-d872f2087c98
* Landing again the CL that adds security info to canceled requests (last time ↵jcampan@chromium.org2009-03-0834-72/+196
| | | | | | | | | it was causing sync XMLHttpRequests to hang, breaking many layout tests). TBR=darin Review URL: http://codereview.chromium.org/39321 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11221 0039d316-1c4b-4281-b951-d872f2087c98
* The MetricsService are not initialized unless the user have opted injar@chromium.org2009-03-081-9/+13
| | | | | | | | | See contributed CL 28315 by Xharze BUG=2278 Review URL: http://codereview.chromium.org/40274 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11219 0039d316-1c4b-4281-b951-d872f2087c98
* Update tests fixable.ericroman@google.com2009-03-081-1/+1
| | | | | | | | TRB=nsylvain Review URL: http://codereview.chromium.org/40281 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11218 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a duplicate expectation. Somehow linting didnt catch this.ericroman@google.com2009-03-081-1/+0
| | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/39318 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11217 0039d316-1c4b-4281-b951-d872f2087c98
* Update test lists following merge. There are some failures on MAC and LINUX ↵ericroman@google.com2009-03-081-0/+10
| | | | | | | | | | which need to be explored. TBR=nsylvain Review URL: http://codereview.chromium.org/40280 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11216 0039d316-1c4b-4281-b951-d872f2087c98