| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/41002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
restore the maximized state. The problem was we were using a boolean
when we really needed three values: use the default, explicitly
maximized or explicitly normal.
I'm also removing a bogus DLOG in info_bubble.
BUG=7930
TEST=see bug
Review URL: http://codereview.chromium.org/40306
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Small fix to get them to display (need to include webkit strings in our
language pak files).
Review URL: http://codereview.chromium.org/39296
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that created it, but if a tab contained a download shelf and was
dragged to a new window the ResizeCorner would be referencing the
wrong BrowserView. I've changed the code to look up the ancestor
BrowserView as necessary.
BUG=8477
TEST=see bug
Review URL: http://codereview.chromium.org/41010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/40316
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(see tests_ignored.txt).
R=ben
Review URL: http://codereview.chromium.org/40304
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
bar regions where the shading is off slightly, as found using GIMP.
Review URL: http://codereview.chromium.org/40251
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
drag then release was broken. It appears that TPM_RIGHTBUTTON
disallows this behavior.
BUG=8560
TEST=see bug
Review URL: http://codereview.chromium.org/41006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added a PasswordManagerTableModelObserver to listen for row count change events.
PasswordManagerView and PasswordManagerExceptionsView are listening to the
event.
Move the |instance_| variable from static global to the respective class to
avoid future misuse of the variable.
Review URL: http://codereview.chromium.org/39313
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Reverting build bustage
Review URL: http://codereview.chromium.org/40315
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Navigate to bad https URL, make sure interstitial page still shows up and works as expected.
Review URL: http://codereview.chromium.org/40311
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Not filing a bug because timer test are difficult to make
not-flaky on the buildbots. However, added comments to the code
so that people who touch this area remember to run all tests.
Review URL: http://codereview.chromium.org/40312
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MessageEvent object to the onmessage handler.
Also adding support for origin and target parameters. The origin parameter is
implicit but target can be specified when calling postMessage. If no target
is specified we default to "*".
At the moment I'm only allowing target == "*" messages to pass through since
I haven't implemented support for matching more complicated patterns :)
Review URL: http://codereview.chromium.org/40128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11275 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39303
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Far from complete but sending early to sync with others.
Review URL: http://codereview.chromium.org/40258
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
different representations of the same visual position. Specifically, the expected results were looking for the deep position, but the actual results were a shallow position. This is from a webkit change (http://trac.webkit.org/changeset/39831) where appendTrailingWhitespace was changed to stop modifying the live selection to use the deepEquivalent of the end position, thus leaving it in the shallow position.
Review URL: http://codereview.chromium.org/39306
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/40266
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
'chromium' to expected-result search path if it's already there, and
don't fall back to chromium-win results if it's not a Chromium platform.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/39310
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Exclude .m and .mm files on non-Mac platforms.
* browser/autocomplete/edit_drop_target.{cc,h} are gone.
* browser/gtk/browser_toolbar_view_gtk.{cc,h}
=> browser/gtk/browser_toolbar_gtk.{cc,h}
* Target 'browser' needs net_resources.h to build on Linux.
* Exclude to-be-ported browser/debugger files on Linux.
* Comment out url_request_mock_http_job.cc in test_support.
(It really belongs there, but it's currently used by
production code in automation_provider.cc, so leave
it there for now, with appropriate comments.)
Review URL: http://codereview.chromium.org/39350
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
register/unregister the AtExitManager for the shim.
TBR=joshia
Review URL: http://codereview.chromium.org/40283
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
domain security policy enforcement.
This copy of DOM checker was fetched from:
http://lcamtuf.coredump.cx/dom_checker/
Some values in dom_config.js have been changed. There have been no other
modifications.
In order to automate this test, there will need to be a few more small changes.
To more easily see what changes have been made for Chromium, I'm first checking
in a clean copy.
BUG=6274
Review URL: http://codereview.chromium.org/40234
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
explicitly skipping a test that causes the next test (no matter what it is)
to fail.
Review URL: http://codereview.chromium.org/40308
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
here is we fail to create the file, and so current_session_file_.get()
is NULL and we crash. current_session_file_.get() is NULL if
OpenAndWriteHeader returns NULL (which is does if the full header
isn't written correctly.
Here's how I'm changing the code:
. The file is now truncated instead of closed/reopened. Hopefully this avoids the possibility of a scanner locking the file and the delete failing.
. Added a unit test for coverage of truncation.
. The file is opened in exclusive access. There is no reason why a scanner should open this file.
. Added null checks.
BUG=8476
TEST=none
Review URL: http://codereview.chromium.org/39275
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r=sgk
Review URL: http://codereview.chromium.org/40305
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
automation calls.
BUG=5671
Review URL: http://codereview.chromium.org/40301
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/40299
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
excluding the tests that aren't working yet on Linux...
TBR: mark@chromium.org (based on discussion)
Review URL: http://codereview.chromium.org/39302
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
tbr=wtc
Review URL: http://codereview.chromium.org/41001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds the following methods to WebKitClient:
decrementStatsTable
incrementStatsTable
traceEventBegin
traceEventEnd
The implementation of initV8CounterFunction is now a no-op. V8Proxy.cpp no
longer calls it, and I moved the corresponding work out of WebKit. The
embedder now calls the appropriate V8 API before initializing WebKit.
Includes some cleanup to WebString and WebCString. I decided that I prefer
"data" over "characters" since the latter may be confusing in some cases. For
example, the elements of a WebString or WebCString may not be individual
characters but may be part of a character. "data" is also consistent with
basic_string<T> and so should be plenty familiar.
There is wanton disregard for the Chrome+JSC build in this CL, but that's
OK. We have already crossed that bridge.
R=dglazkov
Review URL: http://codereview.chromium.org/39288
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
plugin process which should not be using ChromiumBridge. I could try to find
another way to implement these stats counters if they are really valuable.
Otherwise, it is just simpler to remove them. Ultimately, I don't think our
code in the plugin process should be relying on WebKit code, but that is more
work to implement.
R=mbelshe
Review URL: http://codereview.chromium.org/39346
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Packages are manually generated now (run ./build.sh after a successful static build), but will be integrated into the main build system soon.
Review URL: http://codereview.chromium.org/39088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- used string16 instead of wstring where needed
- replaced GetTickCount calls with portable functions from base/time.h
- misc GCC cleanups
- enabled following unit tests on Linux:
browser/autocomplete/history_contents_provider_unittest.cc
browser/autocomplete/history_url_provider_unittest.cc
browser/autocomplete/keyword_provider_unittest.cc
browser/bookmarks/bookmark_html_writer_unittest.cc
Review URL: http://codereview.chromium.org/39335
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r=wtc,darin,huanr
Review URL: http://codereview.chromium.org/40138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The test simulates following scenario: user opens a local html page with Chrome when a browser instance is already running. The new Chrome process should notify the existing process about new page and exit. Bug 7900 broke this behavior causing the new process to crash.
I verified that the ui_tests infrastructure would catch this crash and cause the test to fail.
BUG=7900, 8056
Review URL: http://codereview.chromium.org/39257
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
that was triggered when opening the web inspector in the test shell in
debug mode.
Review URL: http://codereview.chromium.org/39345
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/39301
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=darin
Review URL: http://codereview.chromium.org/39004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- a few more keyboard input tests pass from Avi's work landing upstream
- some other test are passing, probably from core fixes that went in focused
on the windows side but helped mac.
- updating the comments on one failing test since the test passes, it's a
corruption problem from a test that runs before it.
Review URL: http://codereview.chromium.org/39343
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/40182
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
ExtensionsService and ExtensionErrorReporter
Review URL: http://codereview.chromium.org/39026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This is a dummy change to trigger the bots.
Review URL: http://codereview.chromium.org/39328
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/29010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests/fast/dom/SelectorAPI/dumpNodeList.html
LayoutTests/fast/dom/SelectorAPI/dumpNodeList-almost-strict.html
Looks like webkit removed [ConvertUndefinedOrNullToNullString] from the
WebCore/dom/Document.idl querySelector & querySelectorAll which resulted
in differing expected output. The
fast/dom/SelectorAPI/dumpNodeList-*-expected.txt files have the updated
(correct) output, but we had branched our expected.txt files because of
different TypeError output.
Review URL: http://codereview.chromium.org/40265
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
it was causing sync XMLHttpRequests to hang, breaking many layout tests).
TBR=darin
Review URL: http://codereview.chromium.org/39321
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
See contributed CL 28315 by Xharze
BUG=2278
Review URL: http://codereview.chromium.org/40274
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TRB=nsylvain
Review URL: http://codereview.chromium.org/40281
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=nsylvain
Review URL: http://codereview.chromium.org/39318
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
which need to be explored.
TBR=nsylvain
Review URL: http://codereview.chromium.org/40280
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11216 0039d316-1c4b-4281-b951-d872f2087c98
|