summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* In some cases, a WidgetWin can get activated/deactivatedjcampan@chromium.org2009-10-161-0/+3
| | | | | | | | | | | | | | without having been enabled. We were keeping a state in that case that would cause a DCHECK on further activation. BUG=12909 TEST=See bug, open the stack.html file when running Chrome with assertions on. Resize the window, close the dialogs, no assert should happen. Review URL: http://codereview.chromium.org/283003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29290 0039d316-1c4b-4281-b951-d872f2087c98
* A recent change to the way we close tabs (http://codereview.chromium.org/235050)jcampan@chromium.org2009-10-161-2/+5
| | | | | | | | | | | | | | | causes Browser::CanCloseContentsAt() to be called several times for the same tab. This was triggering a DCHECK in the "download in progress" warning. BUG=24974 TEST=See bug. Test thoroughly the "dowload in progress" warning: start a big download, then close Chrome (by closing all tabs, by using the top window close button). Make sure both behaviors (continue/abort closing) work as expected. Review URL: http://codereview.chromium.org/273076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29289 0039d316-1c4b-4281-b951-d872f2087c98
* Implementations of net::CookieStore are supposed to use thread-safe ref ↵cmasone@google.com2009-10-161-15/+16
| | | | | | | | counting. My MockCookieStore objects were just statically allocated and destroyed, so it wasn't a problem, but doing things with a scoped_refptr and obeying the newly-implemented checks is more fool-proof. Review URL: http://codereview.chromium.org/273078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29288 0039d316-1c4b-4281-b951-d872f2087c98
* Landing patch from Thiago Farina:finnur@chromium.org2009-10-161-4/+4
| | | | | | | | | | | | | [Windows] Make the order of the buttons of Languages Tab to match with the Linux version. BUG=None TEST=compiled and tested on windows. Originally review as: http://codereview.chromium.org/269019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29287 0039d316-1c4b-4281-b951-d872f2087c98
* Convert devtools interfaces over to using WebString.darin@chromium.org2009-10-1622-216/+258
| | | | | | | | | | | | | | | | | | | | | | | | Also converts some internal std::string usage to WebCore::String. Note: copying WebString to WebCore::String is very cheap (just increments a reference count). The ugly WebStringToString and StringToWebString calls inside the devtools implementation are temporary. Once this code moves into the WebKit API implementation, those methods will go away. I thought about changing the devtools IPCs to use string16 instead of std::string because that would avoid the UTF8 conversions. I'm not sure if that is worth it though given that UTF16 would increase the amount of data being sent over IPC. I figure this is something that could be studied later. R=pfeldman BUG=24597 TEST=none Review URL: http://codereview.chromium.org/264077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29286 0039d316-1c4b-4281-b951-d872f2087c98
* Getting rid of the final flakiness in the ParseFeed test.finnur@chromium.org2009-10-161-93/+89
| | | | | | | | | | TBR=jcampan BUG=23686 TEST=These are modifications to a browser test. Review URL: http://codereview.chromium.org/285001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29285 0039d316-1c4b-4281-b951-d872f2087c98
* Limit extensions to 1 UI surface (either Page/Browser action, but not both).finnur@chromium.org2009-10-164-1/+22
| | | | | | | | | BUG=24473 TEST=Tested using unit test. Review URL: http://codereview.chromium.org/271117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29284 0039d316-1c4b-4281-b951-d872f2087c98
* Update test expectations to remove newly passing tests.dglazkov@chromium.org2009-10-161-16/+1
| | | | | | | | | | | | | | | TBR=victorw TEST=none BUG=24854 BUG=24142 BUG=24231 BUG=10297 BUG=23464 BUG=24855 Review URL: http://codereview.chromium.org/283012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29283 0039d316-1c4b-4281-b951-d872f2087c98
* Fix heap profiler after a WebKit roll.apavlov@chromium.org2009-10-162-9/+42
| | | | | | | | The API for ProfilesPanel was changed slightly. Review URL: http://codereview.chromium.org/276061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29282 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Eat mouse clicks in the findbar to prevent them from falling through ↵rohitrao@chromium.org2009-10-164-9/+131
| | | | | | | | | | to views below. BUG=http://crbug.com/22854 TEST=See test case in bug. Review URL: http://codereview.chromium.org/273041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29281 0039d316-1c4b-4281-b951-d872f2087c98
* Fix logic test in "remember my choice" dialog for protocols.avi@chromium.org2009-10-161-2/+2
| | | | | | | | | | BUG=http://crbug.com/25035 TEST=as in bug Review URL: http://codereview.chromium.org/283011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29280 0039d316-1c4b-4281-b951-d872f2087c98
* Mark some disabled tests as flaky to increase test coverage.phajdan.jr@chromium.org2009-10-168-19/+19
| | | | | | | | | | | | When a test doesn't hang or crash, it can run on the bots and on developers' machines. BUG=none TEST=none Review URL: http://codereview.chromium.org/269104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29279 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/276054 for sosa:sky@chromium.org2009-10-163-11/+8
| | | | | | | | | | Remove dependency to browser_window TEST=none BUG=none Review URL: http://codereview.chromium.org/274074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29276 0039d316-1c4b-4281-b951-d872f2087c98
* Test has failed a few times in the current waterfall display. The bug that ↵thomasvl@chromium.org2009-10-161-1/+2
| | | | | | | | | | enabled it is still open, so tagging it to that bug and just marking as flaky. TEST=none BUG=20809 Review URL: http://codereview.chromium.org/276060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29275 0039d316-1c4b-4281-b951-d872f2087c98
* Popup width and height are now dynamic.erikkay@chromium.org2009-10-1632-117/+273
| | | | | | | | | BUG=24471 TEST=none Review URL: http://codereview.chromium.org/273046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29274 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a Find method to the HeadersIterator class.tommi@chromium.org2009-10-163-0/+34
| | | | | | | | | TEST=Run the HeadersIterator_Find test. BUG=none Review URL: http://codereview.chromium.org/273072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29273 0039d316-1c4b-4281-b951-d872f2087c98
* Make the auto-update script really smart. It no longer replaces the versionedmark@chromium.org2009-10-162-53/+203
| | | | | | | | | | | directory corresponding to the version that was just replaced or to any version that is in use on the system. BUG=14610 TEST=keystone_install_test.sh, and play with auto-update. A lot. Review URL: http://codereview.chromium.org/285002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29272 0039d316-1c4b-4281-b951-d872f2087c98
* Flagging as flaky again, they like to fail with some frequency on Chromium ↵thomasvl@chromium.org2009-10-161-2/+2
| | | | | | | | | | | XP but not the testers. TBR=finnur@chromium.org TEST=none BUG=23686 Review URL: http://codereview.chromium.org/284011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29271 0039d316-1c4b-4281-b951-d872f2087c98
* Disable backspace until I have fixed it in IME mode.thakis@chromium.org2009-10-161-2/+0
| | | | | | | | | BUG=25000 TEST=hit opt-u backspace. Browser should not go back a page. Browser should in fact never go back when you hit backspace. Review URL: http://codereview.chromium.org/288002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29270 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Mac theme provider so it returns nil when there is no theme provided ↵avi@chromium.org2009-10-162-19/+29
| | | | | | | | | | | color. Partial revert of r28560. BUG=http://crbug.com/24551 TEST=as in bug Review URL: http://codereview.chromium.org/274069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29269 0039d316-1c4b-4281-b951-d872f2087c98
* Updated v8 to 1.3.16.plesner@chromium.org2009-10-161-1/+1
| | | | | | Review URL: http://codereview.chromium.org/283010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29268 0039d316-1c4b-4281-b951-d872f2087c98
* Keep the "place bookmarks here" text vertically centered on the Mac.avi@chromium.org2009-10-162-0/+15
| | | | | | | | | | | | BUG=http://crbug.com/24934 TEST=the text should be vertically centered always: - confirm text is vertically centered when bookmark bar is visible - confirm text is vertically centered when bookmark bar is set to "not visible" but on the new tab page so it is floating Review URL: http://codereview.chromium.org/281009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29267 0039d316-1c4b-4281-b951-d872f2087c98
* frame-limit.html is crashing on windows release some of the time now.thomasvl@chromium.org2009-10-161-0/+2
| | | | | | | | TEST=none BUG=9798 Review URL: http://codereview.chromium.org/289001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29266 0039d316-1c4b-4281-b951-d872f2087c98
* Add AtomicFlag class to base/...timurrrr@chromium.org2009-10-164-0/+147
| | | | | | | | | | This class is intended to replace wrong synchronization via boolean like those in the bugs listed below. TEST=./sconsbuild/Debug/base_unittests --gtest_filter="*AtomicFlag*" BUG=21468,22520,24419 Review URL: http://codereview.chromium.org/276002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29265 0039d316-1c4b-4281-b951-d872f2087c98
* Added back a test that is always failing on mac.thomasvl@chromium.org2009-10-161-0/+1
| | | | | | | | TEST=more waterfall green BUG=10322 Review URL: http://codereview.chromium.org/284010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29264 0039d316-1c4b-4281-b951-d872f2087c98
* Made sync code build and pass unit tests on OS X.akalin@chromium.org2009-10-1624-108/+163
| | | | | | | | | | | | | | | | | | | | Major changes: - Moved sync_setup_{flow,wizard} to sync directory. - Made browser_with_test_window_test compile on non-Windows platform. - Moved localized contents font util functions to app/. BUG=23073 TEST=trybot Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29253 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29255 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29258 Review URL: http://codereview.chromium.org/279004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29263 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 223.1 to 223.2chrome-bot@google.com2009-10-161-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29262 0039d316-1c4b-4281-b951-d872f2087c98
* Supports control characters, like what Windows does.suzhe@chromium.org2009-10-161-15/+59
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This CL fixes issue 21471 by implementing the support of control characters. For the reason of issue 21471, please refer to the code of EditorClientImpl::handleEditingKeyboardEvent() (webkit/glue/editor_client_impl.cc around line 601): ... // Here we need to filter key events. // On Gtk/Linux, it emits key events with ASCII text and ctrl on for ctrl-<x>. // In Webkit, EditorClient::handleKeyboardEvent in // WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp drop such events. // On Mac, it emits key events with ASCII text and meta on for Command-<x>. // These key events should not emit text insert event. // Alt key would be used to insert alternative character, so we should let // through. Also note that Ctrl-Alt combination equals to AltGr key which is // also used to insert alternative character. // http://code.google.com/p/chromium/issues/detail?id=10846 // Windows sets both alt and meta are on when "Alt" key pressed. // http://code.google.com/p/chromium/issues/detail?id=2215 // Also, we should not rely on an assumption that keyboards don't // send ASCII characters when pressing a control key on Windows, // which may be configured to do it so by user. // See also http://en.wikipedia.org/wiki/Keyboard_Layout // TODO(ukai): investigate more detail for various keyboard layout. if (evt->keyEvent()->text().length() == 1) { UChar ch = evt->keyEvent()->text()[0U]; // Don't insert null or control characters as they can result in // unexpected behaviour if (ch < ' ') return false; #if !defined(OS_WIN) // Don't insert ASCII character if ctrl w/o alt or meta is on. // On Mac, we should ignore events when meta is on (Command-<x>). if (ch < 0x80) { if (evt->keyEvent()->ctrlKey() && !evt->keyEvent()->altKey()) return false; #if defined(OS_MACOSX) if (evt->keyEvent()->metaKey()) return false; #endif } #endif } if (!frame->editor()->canEdit()) return false; return frame->editor()->insertText(evt->keyEvent()->text(), evt); ... And gtk implementation of WebInputEventFactory::keyboardEvent() (webkit/api/src/gtk/WebInputEventFactory.cpp, line 225): ... // This should set text to 0 when it's not a real character. // FIXME: fix for non BMP chars // TODO(james.su@gmail.com): // Support control characters input like Windows. // See: http://en.wikipedia.org/wiki/Control_characters result.unmodifiedText[0] = result.text[0] = static_cast<WebUChar>(gdk_keyval_to_unicode(event->keyval)); ... You can see that, on Linux, the text of a keyboard event is set to the unicode char corresponding to |event->keyval| which might be greater than 0x80 when using a non-English keyboard layout, even when ctrl key is pressed. In EditorClientImpl::handleEditKeyboardEvent(), the character will be inserted as text if ch >= 0x80, no matter if ctrl is pressed or not. That's why when using some non-English keyboard layout (eg. Russian), some unexpected characters will be input when press accelerator keys such as ctrl-l. On Windows, ctrl key combinations will generate control characters, see: http://en.wikipedia.org/wiki/Control_characters for details, especially the "How control characters map to keyboards" section. So rather than patching EditorClientImpl::handleEditingKeyboardEvent() to filter out such unexpected inputs, I choose to emulate the control characters behavior of Windows, to make sure no key event with ch >= 0x80 will be generated when ctrl is pressed. This approach not only fixes issue 21471, but also makes the behavior on Linux similar than on Windows. For EditorClientImpl::handleEditKeyboardEvent(), we might need to revise the logic of event filter to see if it has any other potential issues. But I think we can address it separately. BUG=21471: REGRESSION: Ctrl+F results in "а" added to the edit box in belarusian TEST=Switch keyboard layout to Russian or Belarusian, press ctrl-f in any edit box in a web page, search box should be opened and nothing should be input into the edit box. Review URL: http://codereview.chromium.org/195062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29261 0039d316-1c4b-4281-b951-d872f2087c98
* Mark LayoutTests/fast/css/large-list-of-rules-crash.html as DEBUG SLOW.yutak@chromium.org2009-10-161-3/+1
| | | | | | | | | | This test takes long time to finish maybe because of V8's debug logging. BUG=24102 TEST=none Review URL: http://codereview.chromium.org/287001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29260 0039d316-1c4b-4281-b951-d872f2087c98
* Reverted 29258.akalin@chromium.org2009-10-1623-161/+106
| | | | | | TBR: nick@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29259 0039d316-1c4b-4281-b951-d872f2087c98
* Made sync code build and pass unit tests on OS X.akalin@chromium.org2009-10-1623-106/+161
| | | | | | | | | | | | | | | | | | Major changes: - Moved sync_setup_{flow,wizard} to sync directory. - Made browser_with_test_window_test compile on non-Windows platform. - Moved localized contents font util functions to app/. BUG=23073 TEST=trybot Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29253 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29255 Review URL: http://codereview.chromium.org/279004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29258 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash in incognito mode when clicking the wrench menu.nick@chromium.org2009-10-161-0/+4
| | | | | | | | | | | | This was a regression recent sync UI changes. This fixes the regression to match the old incognito mode behavior. TBR=tim@chromium.org BUG=25014 TEST=See bug. It doesn't crash anymore. Review URL: http://codereview.chromium.org/283008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29257 0039d316-1c4b-4281-b951-d872f2087c98
* Reverted 29255.akalin@chromium.org2009-10-1622-160/+105
| | | | | | TBR: nick@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29256 0039d316-1c4b-4281-b951-d872f2087c98
* Made sync code build and pass unit tests on OS X.akalin@chromium.org2009-10-1622-105/+160
| | | | | | | | | | | | | | | | Major changes: - Moved sync_setup_{flow,wizard} to sync directory. - Made browser_with_test_window_test compile on non-Windows platform. - Moved localized contents font util functions to app/. BUG=23073 TEST=trybot Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29253 Review URL: http://codereview.chromium.org/279004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29255 0039d316-1c4b-4281-b951-d872f2087c98
* Reverted 29253.akalin@chromium.org2009-10-1621-159/+104
| | | | | | TBR: nick@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29254 0039d316-1c4b-4281-b951-d872f2087c98
* Made sync code build and pass unit tests on OS X.akalin@chromium.org2009-10-1621-104/+159
| | | | | | | | | | | | | | Major changes: - Moved sync_setup_{flow,wizard} to sync directory. - Made browser_with_test_window_test compile on non-Windows platform. - Moved localized contents font util functions to app/. BUG=23073 TEST=trybot Review URL: http://codereview.chromium.org/279004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29253 0039d316-1c4b-4281-b951-d872f2087c98
* Start/stop Web Socket Secure server if necessary.yuzo@chromium.org2009-10-161-1/+6
| | | | | | | | | | | This change requires http://codereview.chromium.org/273035. TEST=none BUG=none Review URL: http://codereview.chromium.org/264058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29252 0039d316-1c4b-4281-b951-d872f2087c98
* Support WSS in websocket_server.py.yuzo@chromium.org2009-10-161-17/+64
| | | | | | | | | | | | | With this change, websocket_server.py can start a pywebsocket server also for WSS. We'll run two instances of pywebsocket in testing: one for WS, the other for WSS. TEST=none BUG=none Review URL: http://codereview.chromium.org/273035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29251 0039d316-1c4b-4281-b951-d872f2087c98
* Kill WebViewDelegate::WasOpenedByUserGesture, and instead havedarin@chromium.org2009-10-165-15/+12
| | | | | | | | | | | | the RenderView implement the logic that was using that method. R=dglazkov BUG=24598 TEST=none Review URL: http://codereview.chromium.org/276059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29250 0039d316-1c4b-4281-b951-d872f2087c98
* Mark globalhistory tests as WONTFIX.dglazkov@chromium.org2009-10-161-9/+4
| | | | | | | | | | | | | | Our history implementation is completely external to WebKit. TBR=japhet TEST=none BUG=23748 BUG=24768 Review URL: http://codereview.chromium.org/281010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29249 0039d316-1c4b-4281-b951-d872f2087c98
* Remove flaky expectations for accessibility tests. They were put in out of ↵dglazkov@chromium.org2009-10-161-2/+0
| | | | | | | | | | | | laziness by yours truly. TBR=ojan BUG=10322 TEST=none Review URL: http://codereview.chromium.org/267130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29248 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix the build by adding an include.dglazkov@chromium.org2009-10-161-0/+1
| | | | | | | | | | TBR=darin TEST=none BUG=none Review URL: http://codereview.chromium.org/284005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29247 0039d316-1c4b-4281-b951-d872f2087c98
* Move scripting / v8 related methods out of WebKit.hmhm@chromium.org2009-10-1610-54/+141
| | | | | | | | | BUG=24602 TEST=Compiled Webkit/Chromium Review URL: http://codereview.chromium.org/275026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29245 0039d316-1c4b-4281-b951-d872f2087c98
* Move autofill related WebView{Delegate} methods into the WebKit API.darin@chromium.org2009-10-1627-294/+335
| | | | | | | | | | | | This CL also changes a bunch of autofill related wstring values to string16. R=jcampan BUG=24595 TEST=none Review URL: http://codereview.chromium.org/279001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29244 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 'Create an account' and 'Help' links on gaia login dialog.tim@chromium.org2009-10-161-4/+4
| | | | | | | BUG=19918,21509 Review URL: http://codereview.chromium.org/267135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29243 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable worker-script-error.html in ui_test nowlevin@chromium.org2009-10-161-2/+1
| | | | | | | | | | that r49408 form WebKit has been rolled in. BUG=23391 TEST=enabling a test Review URL: http://codereview.chromium.org/281012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29242 0039d316-1c4b-4281-b951-d872f2087c98
* Flesh out the intro and summary for the debugging tutorialkathyw@google.com2009-10-163-105/+258
| | | | | | | | | | | | so I can remove TBDs. Miscellaneous other fixes/improvements. BUG=none TEST=none TBR=aa Review URL: http://codereview.chromium.org/276055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29241 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: nick@chromium.orgakalin@chromium.org2009-10-1619-155/+101
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29240 0039d316-1c4b-4281-b951-d872f2087c98
* Made sync code build and pass unit tests on OS X.akalin@chromium.org2009-10-1619-101/+155
| | | | | | | | | | | | | | Major changes: - Moved sync_setup_{flow,wizard} to sync directory. - Made browser_with_test_window_test compile on non-Windows platform. - Moved localized contents font util functions to app/. BUG=23073 TEST=trybot Review URL: http://codereview.chromium.org/279004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29239 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build bustage of 29235hclam@chromium.org2009-10-161-1/+1
| | | | | | | | | | TBR=scherkus From 1u to static_cast<size_t>(1). Review URL: http://codereview.chromium.org/276057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29238 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 21:04:40 +0000