summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix typo in bug name. I typed '6' instead of '9' by accident. I noticed ↵dkegel@google.com2009-09-141-1/+1
| | | | | | | | | | | | because the valgrind logs have astronomical suppression counts for this. BUG=17966,17996 Review URL: http://codereview.chromium.org/204009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26149 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Adjust toolbar padding.estade@chromium.org2009-09-141-1/+5
| | | | | | | | | | Pixel-perfect with Windows. BUG=21772 Review URL: http://codereview.chromium.org/203054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26148 0039d316-1c4b-4281-b951-d872f2087c98
* Added a few suppressions for ThreadSanitizer on Mac.timurrrr@chromium.org2009-09-141-0/+91
| | | | | | | | This patch was prepared by Alexander Potapenko (cc'ed), we work together on ThreadSanitizer for Chromium. Review URL: http://codereview.chromium.org/194106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26146 0039d316-1c4b-4281-b951-d872f2087c98
* Restore support for loading URLs on the command line.darin@chromium.org2009-09-141-11/+21
| | | | | | | | | | | | | | | I broke this in r25841. The fix makes TestShell support both URLs as well as file paths on the command line. R=dglazkov BUG=none TEST=none Review URL: http://codereview.chromium.org/204007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26145 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up a few tiny things I noticed.pkasting@chromium.org2009-09-143-6/+4
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/196110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26144 0039d316-1c4b-4281-b951-d872f2087c98
* Tries to avoid unnecessary layoutjamesr@chromium.org2009-09-142-6/+4
| | | | | | Review URL: http://codereview.chromium.org/201093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26143 0039d316-1c4b-4281-b951-d872f2087c98
* Fix to use FilePath in more unittests.phajdan.jr@chromium.org2009-09-147-43/+35
| | | | | | | | | | | Landing patch for Thiago Farina, original review: http://codereview.chromium.org/187005 BUG=None TEST=run unit_tests.exe, base_unittests.exe. Review URL: http://codereview.chromium.org/193101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26142 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts linux font change again. Slow down isn't as bad as before. Butsky@chromium.org2009-09-149-264/+306
| | | | | | | | | | | | still not ideal. BUG=none TEST=none TBR=agl Review URL: http://codereview.chromium.org/194105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26141 0039d316-1c4b-4281-b951-d872f2087c98
* Load the http auth dialog from the main bundle.thomasvl@chromium.org2009-09-144-197/+1002
| | | | | | | | | | | | Localize the http auth dialog. Add the explanation to the http auth dialog. Autosize the http auth dialog after putting in the explanation. TEST=http auto ui should now be localized. BUG=20532 Review URL: http://codereview.chromium.org/196109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26140 0039d316-1c4b-4281-b951-d872f2087c98
* Add expat, a lightweight xml parser, to third_party.nick@chromium.org2009-09-1431-0/+15962
| | | | | | | | | | Libjingle depends on it. BUG=none TEST=none Review URL: http://codereview.chromium.org/203022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26139 0039d316-1c4b-4281-b951-d872f2087c98
* Use gtk_window_set_skip_taskbar_hint on info bubble popups so they don't ↵mattm@chromium.org2009-09-141-0/+1
| | | | | | | | show up in the task bar. Review URL: http://codereview.chromium.org/201103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26138 0039d316-1c4b-4281-b951-d872f2087c98
* Fix up the unittest to now expect the image within the bundle.thomasvl@chromium.org2009-09-141-4/+4
| | | | | | | | TEST=chromium mac goes green BUG=none Review URL: http://codereview.chromium.org/194104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26137 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug where content scripts can get GC'd if they don'taa@chromium.org2009-09-143-7/+34
| | | | | | | | | | | attach to any DOM events. BUG=17410 TEST=none Review URL: http://codereview.chromium.org/200116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26136 0039d316-1c4b-4281-b951-d872f2087c98
* The focus is not restored properly when a Windows modal dialogjcampan@chromium.org2009-09-143-43/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | (such as "open file', 'print'...) is closed. We are running these dialogs from a different thread and they cause the browser window to get activated before it has been enabled. This causes the focus restoration to fail as the window is not enabled. In an earlier patch, I fixed it by storing/restoring the focus explicitly before/after the dialog is shown. But the fix did not apply to the print dialog which does not use the code I added my fix in. This CL reverts that previous fix and comes with a simpler solution: if when we are about to restore focus the window is disabled, we delay the focus restoration untill the window is enabled again. BUG=3380 TEST=Set the focus on a page with scroll-bars, right-click to do a 'save as'. Close the dialog. The arrow keys should let you scroll the page. Accelerators such as Ctrl-T should still work. Test 'open a file', 'print' and the font selection dialog (in the options). When closing the dialog the focus should return to the view that last had focus. Review URL: http://codereview.chromium.org/199106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26135 0039d316-1c4b-4281-b951-d872f2087c98
* Make int64 -> Time conversion explicit.phajdan.jr@chromium.org2009-09-143-9/+10
| | | | | | | | | | | Landing Patch for Jacob Mandelson, original review: http://codereview.chromium.org/200093 BUG=none TEST=base_unittests & app_unittests Review URL: http://codereview.chromium.org/205003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26134 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/201102 for Oshima:sky@chromium.org2009-09-142-0/+4
| | | | | | | | | | | | | Don't allow updating group id once it's set. BUG=none TEST=none Review URL: http://codereview.chromium.org/205001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26132 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Don't show extension shelf when it's empty.estade@chromium.org2009-09-142-18/+2
| | | | | | | | | | | | this gets rid of a 1 pixel grey line at the bottom of the web contents. Also, do show the extension shelf in fullscreen (matching windows). BUG=none (regression of crbug.com/17324) TEST=one_in_shelf still works Review URL: http://codereview.chromium.org/194094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26131 0039d316-1c4b-4281-b951-d872f2087c98
* Try to fix the Linux Views build.pkasting@chromium.org2009-09-141-1/+1
| | | | | | | | | TBR=sky BUG=none TEST=none Review URL: http://codereview.chromium.org/203053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26130 0039d316-1c4b-4281-b951-d872f2087c98
* linux: enable plugins by defaultevan@chromium.org2009-09-143-11/+0
| | | | | | | | This is long overdue. Review URL: http://codereview.chromium.org/193100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26129 0039d316-1c4b-4281-b951-d872f2087c98
* About box in one locale (ja) needs additional whitespace to avoid truncation.finnur@chromium.org2009-09-141-1/+1
| | | | | | | | | | | I'm not seeing this on my machine, maybe my Japanese fonts are a little narrower than in QA, but whatever. Shouldn't hurt to increase this a little. BUG=21615 TEST=About box in Chrome Japanese should not have truncated text when a new version is available. Review URL: http://codereview.chromium.org/196108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26128 0039d316-1c4b-4281-b951-d872f2087c98
* Changing a NOTREACHED() to a DLOG as StopAsync can be called before a view ↵tommi@chromium.org2009-09-141-1/+3
| | | | | | | | | | | has been created. TEST=run automation tests. BUG=none Review URL: http://codereview.chromium.org/193099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26127 0039d316-1c4b-4281-b951-d872f2087c98
* Made some style fixes in the remaining code under chrom/browser/sync and ↵idana@chromium.org2009-09-14109-892/+892
| | | | | | | | under chrome/test/sync. Review URL: http://codereview.chromium.org/203043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26126 0039d316-1c4b-4281-b951-d872f2087c98
* Add keyboard shortcuts to reorder tabs left or right on Linux.tony@chromium.org2009-09-146-0/+43
| | | | | | | | | | | | | | | It's standard in GTK+ for tabbed interfaces to be reorderable using ctrl+shift+pgup and ctrl+shift+pgdn (e.g., in Terminal). The plumbing is included on all platforms, but the shortcut is only hooked up on Linux. BUG=21594 Review URL: http://codereview.chromium.org/194088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26125 0039d316-1c4b-4281-b951-d872f2087c98
* Add "New Window" and "New Incognito Window" items to the Dock Menu.sgk@google.com2009-09-143-1/+53
| | | | | | | | | Add a unit test module for AppController with a simple DockMenu test. BUG=21175 TEST=AppControllerTest.DockMenu Review URL: http://codereview.chromium.org/196103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26124 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: remove check that the renderer knows its PID.agl@chromium.org2009-09-141-9/+13
| | | | | | | | | | | | With the SUID sandbox and CLONE_NEWPID, this check is failing. (It'll only trigger on recent kernels which have CLONE_NEWPID support). BUG=21112 http://codereview.chromium.org/202060/ git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26122 0039d316-1c4b-4281-b951-d872f2087c98
* Some initial cleanup of InfoBubble:pkasting@chromium.org2009-09-143-110/+60
| | | | | | | | | | | | | | | | * Remove fading/animation-related code, which didn't do anything * Remove unnecessary #includes * Try and make a few comments better * Make more functions private or protected * Ensure definition order == declaration order Hopefully, there should be no visible effects of this change. BUG=none TEST=none Review URL: http://codereview.chromium.org/204001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26121 0039d316-1c4b-4281-b951-d872f2087c98
* Remove code doing a no-op due to float -> int rounding.phajdan.jr@chromium.org2009-09-1412-42/+59
| | | | | | | | | | | | | | | | Make implicit float -> int/long conversions explicit. (Implicit float -> int conversions can be found by compiling with -Wconversion in gcc [versions 4.1.1 and 4.2.4, and surely many others].) Landing the patch for Jacob Mandelson, original review: http://codereview.chromium.org/201091 BUG=none TEST=app_unittests & base_unittests Review URL: http://codereview.chromium.org/200122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26119 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crasher in full text search (sqlite)cpu@chromium.org2009-09-141-2/+5
| | | | | | | | | | | | | | | | - If the xxx_segdir table gets corrupted, you can have non-contiguous indexes (idx). - This causes an assertion in debug, and a crash later on on release With this change it will return 'corrupted db' We shall wait to get a couple more fixes to upstream to sqlite org. BUG=21377 TEST=see bug Review URL: http://codereview.chromium.org/203046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26118 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/200102 for Oshima:sky@chromium.org2009-09-147-27/+166
| | | | | | | | | | | | | | RadioButton implementation. - gtk implementation uses gkt's grouping mechanism, which was hard to replace. A small refactoring. - changed to use virtual functions instead of if/IsCheckbox - Removed checkbox's CallClicked BUG=none TEST=none Review URL: http://codereview.chromium.org/194102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26117 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at converting font from Skia to Pango. The slow down appears to be ↵sky@chromium.org2009-09-149-306/+264
| | | | | | | | | | | | entirely attributed to asking for the metrics. To get back the performance I did the following: . Only ask for the metrics when needed. We appear to create 6 or so fonts very early on without needing the metrics. This ensures we only take the metrics load hit when needed. . Keep a cache of the metrics around. This ensures that we only load the metrics once. I didn't dig through the Pango source to see why Pango is slow at getting metrics. I suspect it's the first person to ask for metrics incurs a penalty as Pango accesses the disk. The code we have now is the same as that as Gtk. Review URL: http://codereview.chromium.org/199101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26116 0039d316-1c4b-4281-b951-d872f2087c98
* Move sync wizard dimension constants to locale_settings GRD.tim@chromium.org2009-09-1451-6/+116
| | | | | | | | BUG=19896 Review URL: http://codereview.chromium.org/192077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26115 0039d316-1c4b-4281-b951-d872f2087c98
* Use localized strings for Find and Spelling submenus.pinkerton@chromium.org2009-09-142-350/+741
| | | | | | | | BUG=18769 TEST=Edit menu has correct strings. Review URL: http://codereview.chromium.org/194103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26114 0039d316-1c4b-4281-b951-d872f2087c98
* Landing tfarina patch. See http://codereview.chromium.org/195040/showjcampan@chromium.org2009-09-142-22/+23
| | | | | | | | | | Fix some styles issues reported by lint in base\values.h. BUG=None TEST=None Review URL: http://codereview.chromium.org/200112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26113 0039d316-1c4b-4281-b951-d872f2087c98
* Remove cross-frame-callable from test_expectations. The test has passed for ↵victorw@chromium.org2009-09-141-3/+0
| | | | | | | | | | | | days. TBR=japhet TEST=none BUG=none Review URL: http://codereview.chromium.org/200121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26112 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline js layout tests that depend on the output strings.victorw@chromium.org2009-09-1415-662/+409
| | | | | | | | | | | | | | | | | This is a compromised solution. This should be fixed in V8 so V8 outputs the same results as JSC. A bug was filed in V8: http://code.google.com/p/v8/issues/detail?id=438 Before this is fix, we create local baselines for these tests from upstream and remove the chromium's versions, which are basically the same tests. TEST=none BUG=none Review URL: http://codereview.chromium.org/201094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26111 0039d316-1c4b-4281-b951-d872f2087c98
* Update WebKit to r48354darin@chromium.org2009-09-142-1/+8
| | | | | | | | | | | | This meant picking up some failing tests. TBR=brettw BUG=none TEST=none Review URL: http://codereview.chromium.org/196107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26110 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some mixed content layout tests.darin@chromium.org2009-09-148-3/+44
| | | | | | | | | | | | | 1. Make test shell ignore certificate errors. 2. Extend WebFrameClient for new notifications and printf these. R=abarth BUG=21644 TEST=covered by layout tests Review URL: http://codereview.chromium.org/200110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26108 0039d316-1c4b-4281-b951-d872f2087c98
* Implements LocationBarView::AvailableWidth for Gtk.sky@chromium.org2009-09-143-2/+22
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/195068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26107 0039d316-1c4b-4281-b951-d872f2087c98
* Update the sadtab and throbbers to use the helpers for fetching ↵thomasvl@chromium.org2009-09-143-14/+16
| | | | | | | | | | | | | strings/images from pak file. Use the images directly from the pak files instead of having extra copies in the bundle. TEST=sad tab page still works and has all images. throbbers still work. the app should no longer carry the sadtab and throbber images directly. BUG=20230 BUG=21076 Review URL: http://codereview.chromium.org/194101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26106 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash when closing tab with an open http auth sheet.thakis@chromium.org2009-09-141-5/+10
| | | | | | | | | | | Parts of patch by mdm@chromium.org, taken from http://codereview.chromium.org/196104 BUG=19427, 21111, 21304 (not sure about last one) TEST=Open a page with an http auth sheet, open another tab, close tab with the open sheet -- should not crash. Also check that opening a tab with an open sheet, then hitting back, forward, reload still works and doesn't crash. Review URL: http://codereview.chromium.org/194095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26105 0039d316-1c4b-4281-b951-d872f2087c98
* Fix printing project on linux.maruel@chromium.org2009-09-148-67/+72
| | | | | | | | | | | | Enable compilation of every files and fix tests. TEST=unit tests BUG=9847 Review URL: http://codereview.chromium.org/193086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26103 0039d316-1c4b-4281-b951-d872f2087c98
* Use jstemplates in merge and sync setup page.tim@chromium.org2009-09-142-14/+38
| | | | | | | | BUG=19896 Review URL: http://codereview.chromium.org/194092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26102 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the test runner line I had in there by accident.thomasvl@chromium.org2009-09-141-1/+0
| | | | | | | | | BUG=none TEST=none TBR=mark Review URL: http://codereview.chromium.org/204004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26101 0039d316-1c4b-4281-b951-d872f2087c98
* Remove test that has passed for the last 35 runs from the testager@chromium.org2009-09-141-3/+0
| | | | | | | | | | expectations. BUG=21501 TEST=bot color Review URL: http://codereview.chromium.org/200117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26099 0039d316-1c4b-4281-b951-d872f2087c98
* Update to latest GYP (r651).sgk@chromium.org2009-09-141-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/193090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26097 0039d316-1c4b-4281-b951-d872f2087c98
* TBR:nsylvainmmoss@chromium.org2009-09-141-1/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26095 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply r25885 after master restartmmoss@chromium.org2009-09-141-23/+41
| | | | | | | | | | | | Replace test_shell_tests dependency on the test_shell with test_shell_pak dependency. This fixes the missing requirement that test_shell was previously satisifying for test_shell_tests. TBR:sgk Review URL: http://codereview.chromium.org/203051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26094 0039d316-1c4b-4281-b951-d872f2087c98
* Send Breakpad and debugger status to the metrics service on the Mac.mark@chromium.org2009-09-146-41/+77
| | | | | | | | | | BUG=21731 TEST=Metrics data should have the correct values for breakpadregistrationok, breakpadregistrationfail, debuggerpresent, and debuggernotpresent in log.profile.stability. Review URL: http://codereview.chromium.org/203050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26093 0039d316-1c4b-4281-b951-d872f2087c98
* Implement functions to return the primary display dimensions and the numbermark@chromium.org2009-09-141-0/+49
| | | | | | | | | | | of displays connected. BUG=21731 TEST=No more NOTIMPLEMENTED messages for these. Metrics data should have the correct values in log.display. Review URL: http://codereview.chromium.org/194098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26092 0039d316-1c4b-4281-b951-d872f2087c98
* Extension Doc Changes (no building or testable changes) - Build on Mac, find ↵rafaelw@chromium.org2009-09-131-15/+19
| | | | | | | | binaries on network. Review URL: http://codereview.chromium.org/202064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26091 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-23 05:11:34 +0000