summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Updating XTBs based on .GRDs from branch 742kerz@chromium.org2011-06-22152-5817/+10085
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90097 0039d316-1c4b-4281-b951-d872f2087c98
* Convert most remaining resources to use the API/thunk system. The significantbrettw@chromium.org2011-06-2267-2071/+2180
| | | | | | | | | | | | | | | changes here are around the 3D API. Having separate files for the texture mapping interface is no longer necessary for the proxy and the implementation. This also removes the uses of the "old" dynamic casting system (using "GetAs") for other resources that I could find. TEST=ui tests BUG=none Review URL: http://codereview.chromium.org/7206016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90096 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Disable Options in context menu for page actions and browser actions ↵yoz@chromium.org2011-06-221-11/+5
| | | | | | | | | | | | that lack options. BUG=85594 TEST=Check that context menu's Options is disabled. Review URL: http://codereview.chromium.org/7232021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90095 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fix null pointer return and pass by value error.kmadhusu@chromium.org2011-06-223-2/+3
| | | | | | | | | | BUG=none TEST=none CID=8953, 14114 Review URL: http://codereview.chromium.org/7219018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90094 0039d316-1c4b-4281-b951-d872f2087c98
* touch tabstrip: Paint correctly when a tab is removed.sadrul@chromium.org2011-06-221-0/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7231020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90093 0039d316-1c4b-4281-b951-d872f2087c98
* Localize strings, speeds.avi@chromium.org2011-06-2230-276/+554
| | | | | | | | | BUG=86527 TEST=run in non-English. For European languages, during a download the decimal separators should be commas (e.g. "0,0 MB"). (The speeds are in strings files and might take a little time to run through the translation machinery.) Review URL: http://codereview.chromium.org/7189076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90092 0039d316-1c4b-4281-b951-d872f2087c98
* Make TCP FastOpen work again.wtc@chromium.org2011-06-223-20/+17
| | | | | | | | | | | | | | | | In TCPClientSocketLibevent, this requires making IsConnected pretend the socket is connected so that GetPeerAddress will succeed. In SSLClientSocketNSS, revert the workaround because we don't need to delay the GetPeerAddress call. R=mbelshe@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/7155014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90090 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fix pass by value errors.kmadhusu@chromium.org2011-06-229-13/+14
| | | | | | | | | | CID=17236, 16551, 16910, 17131, 16712 BUG=none TEST=none Review URL: http://codereview.chromium.org/7217022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90089 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Null returns and negative returnskmadhusu@chromium.org2011-06-227-3/+19
| | | | | | | | | | CID = 14804, 16939, 16937, 16904, 16793, 16308, 14956, 15404, 11823 BUG=none TEST=none Review URL: http://codereview.chromium.org/7211019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90088 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Pass parameters by reference.jhawkins@chromium.org2011-06-226-10/+14
| | | | | | | | | | | | CID=7875,14289,17142,17143 R=kmadhusu@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7217030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90087 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize member variables.jhawkins@chromium.org2011-06-225-1/+6
| | | | | | | | | | | | CID=13721,14709,16392,17192,17585 BUG=none TEST=none R=kmadhusu@chromium.org Review URL: http://codereview.chromium.org/7206066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90086 0039d316-1c4b-4281-b951-d872f2087c98
* Mac. When a javascript URL cannot be placed on the drag pasteboard, try ↵maf@chromium.org2011-06-221-2/+9
| | | | | | | | | | escaping it. Fixes bugs where badly escaped but popular bookmarklets cannot be dragged to the bookmark bar. BUG=82283,86643 Review URL: http://codereview.chromium.org/7229004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90085 0039d316-1c4b-4281-b951-d872f2087c98
* xi2: We need to look at the slave device that generated the event,sadrul@chromium.org2011-06-221-1/+1
| | | | | | | | | | | instead of the master device to determine if we should process the event or not. BUG=none TEST=test that there is only one mousedown event for a mouseclick Review URL: http://codereview.chromium.org/7232022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90084 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: In gtk-theme mode, we should use gtk drawing for the infobars.erg@google.com2011-06-228-47/+104
| | | | | | | | | | | | This updates the close button, all link buttons and labels, and the background to respond to theme changes. BUG=none TEST=infobars match gtk-theme when in gtk mode, match chrome theme in chrome theme mode. Review URL: http://codereview.chromium.org/7225002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90082 0039d316-1c4b-4281-b951-d872f2087c98
* app: Remove the dependency on app_resources from app_unittests.tfarina@chromium.org2011-06-221-1/+0
| | | | | | | | | | | BUG=72317 TEST=app_unittests R=rsesek@chromium.org Review URL: http://codereview.chromium.org/7233020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90081 0039d316-1c4b-4281-b951-d872f2087c98
* Various pieces of infobar cleanup:pkasting@chromium.org2011-06-226-81/+64
| | | | | | | | | | | | | * Simplify some code in the views implementation. Remove an unnecessary animation Stop() call. Move other code to PlatformSpecificShow(), now that it exists, to try and simplify ViewHierarchyChanged(), and so that it executes "when we actually show the infobar" (doesn't really matter, the two are called right after each other). * Convert InfoBar::animation_ from a scoped_ptr<> to an object; it lives for the life of the InfoBar so there's no real reason to use a pointer. Also convert the const getter to returning a const ref. * Update a comment to be a bit more accurate, especially now that the views code doesn't stop the animation in ViewHierarchyChanged(). * Use |i| for an iterator instead of the verbose |infobar_iterator| BUG=none TEST=none Review URL: http://codereview.chromium.org/7190024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90080 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed a few UNINIT coverity messagesgroby@chromium.org2011-06-221-0/+3
| | | | | | | | | | | | | CID=9250,9251,9252,9253 R=vandebo@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/7217028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90079 0039d316-1c4b-4281-b951-d872f2087c98
* RESOURCE_LEAK coverity fix.binji@chromium.org2011-06-221-1/+3
| | | | | | | | | | | CID=16416 BUG=none TEST=none Review URL: http://codereview.chromium.org/7228002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90076 0039d316-1c4b-4281-b951-d872f2087c98
* Properly initialize delegate variable.avi@chromium.org2011-06-221-1/+2
| | | | | | | | | BUG=85445 TEST=crash should go away Review URL: http://codereview.chromium.org/7230018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90075 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Return if cert creation fails in X509Certificate::CreateSelfSigned.thestig@chromium.org2011-06-221-0/+3
| | | | | | | | | | BUG=none TEST=none CID=16387 Review URL: http://codereview.chromium.org/7218027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90074 0039d316-1c4b-4281-b951-d872f2087c98
* Split iq_request.[h|cc] into multiple files.sergeyu@chromium.org2011-06-2216-510/+660
| | | | | | | | | BUG=None TEST=compiles Review URL: http://codereview.chromium.org/7211033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90073 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up avatar icon drawingsail@chromium.org2011-06-225-30/+30
| | | | | | | | | | | | | This change addresses review feedback from: http://codereview.chromium.org/7003080/ BUG= TEST= Review URL: http://codereview.chromium.org/7229014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90072 0039d316-1c4b-4281-b951-d872f2087c98
* Add a flag to open files in share delete modejochen@chromium.org2011-06-223-0/+40
| | | | | | | | | | BUG=86928 TEST=base_unittests Review URL: http://codereview.chromium.org/7233007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90071 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SetParent for Pepperpiman@chromium.org2011-06-222-10/+30
| | | | | | | | | | | | This allows SetParent() and Initialize() to be called in any order relative to each other. BUG=none TEST=Youtube with Pepper Flash. Review URL: http://codereview.chromium.org/7190026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90070 0039d316-1c4b-4281-b951-d872f2087c98
* Watch for profile destruction in ContentSettingBubbleModel.bauerb@chromium.org2011-06-221-9/+22
| | | | | | | | | | BUG=86914 TEST=See bug Review URL: http://codereview.chromium.org/7216010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90069 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity fixes for CHECKED_RETURNgroby@chromium.org2011-06-224-11/+10
| | | | | | | | | | | | | CID=16094,12870,12867,12738,12649 R=vandebo@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/7218028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90068 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed several FORWARD_NULL issues from Coverity. (I.e. variables can be NULL ↵groby@chromium.org2011-06-222-3/+7
| | | | | | | | | | | | | | | at point of use) CID=16945,17114 R=jhawkins@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/7211034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90067 0039d316-1c4b-4281-b951-d872f2087c98
* Added client-side support for the TLS cached inforkn@chromium.org2011-06-2218-77/+517
| | | | | | | | | | | | extension. This feature is disabled by default and enabled by the flag --enable-cached-info. BUG=84920 TEST=None Review URL: http://codereview.chromium.org/7058049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90066 0039d316-1c4b-4281-b951-d872f2087c98
* Satisfy invariant that a PasswordForm's signon-realm is a prefix of its originrsimha@chromium.org2011-06-222-4/+3
| | | | | | | | | | | | | | | | | src\webkit\glue\password_form.h requires that its signon-realm field is a prefix of its origin field. This patch updates LivePasswordsSyncTest::CreateTestPasswordForm so that it now follows the invariant. This should fix the test failures we were seeing in the racy tests that simultaneously added password forms to two clients and wondered why one of them was missing after sync. BUG=77993 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/7229003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90063 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo: Change _ to - for zip filename.ajwong@chromium.org2011-06-221-1/+1
| | | | | | | | | BUG=none TEST=builds Review URL: http://codereview.chromium.org/7204010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90061 0039d316-1c4b-4281-b951-d872f2087c98
* Additional about:cryptohome infostevenjb@google.com2011-06-221-3/+23
| | | | | | | | | BUG=chromium-os:16577 TEST=Test about:cryptohome; should now have a 'crypto:' section. Review URL: http://codereview.chromium.org/7230014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90060 0039d316-1c4b-4281-b951-d872f2087c98
* Update .DEPS.gitchrome-admin@google.com2011-06-221-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90059 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 89996 - WebKit merge 89393:89412.dimich@chromium.org2011-06-221-1/+1
| | | | | | | | | It caused browser_tests failure that we can not obviously attribute to any change yet. Will throttle changes. TBR=yutak@chromium.org Review URL: http://codereview.chromium.org/7190040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90058 0039d316-1c4b-4281-b951-d872f2087c98
* Clear menu when we lose focus or when esc is pressed.achuith@chromium.org2011-06-221-6/+8
| | | | | | | | | BUG=chromium-os:16133 TEST=download a large file. Click the menu. When you now click outside the download panel, the menu should disappear. Alternatively, you can click esc to dismiss the menu as well. Review URL: http://codereview.chromium.org/7206064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90054 0039d316-1c4b-4281-b951-d872f2087c98
* file manager: switch to v8Locale to localize dates from javascript.rginda@chromium.org2011-06-229-196/+45
| | | | | | | | | | | | | | | Switch from cr.Locale to v8Locale to handle date localizations. cr.Locale was added to satisfy localization issues for the file manager, but it requires localizers to configure a date format. Chrome now has an experimental date localization library which gives us what we need without adding localization overhead. I searched around the chrome codebase and was not able to find another client of cr/locale.js. BUG=chromium-os:15440 TEST=manual testing on chromeos-chrome in linux Review URL: http://codereview.chromium.org/7230004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90053 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity Fixlet - PASS_BY_VALUEscr@chromium.org2011-06-224-5/+5
| | | | | | | | | | | CID=16438,16924 BUG= TEST= Review URL: http://codereview.chromium.org/7216023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90052 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused testing code from media/base/media_win.ccscherkus@chromium.org2011-06-221-19/+1
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7230003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90051 0039d316-1c4b-4281-b951-d872f2087c98
* sync: fetch encryption information before OnBackendInitializedtim@chromium.org2011-06-2211-62/+115
| | | | | | | | | | BUG=none TEST= Review URL: http://codereview.chromium.org/7184033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90050 0039d316-1c4b-4281-b951-d872f2087c98
* Use vector_as_array() in unix_domain_socket_posix.cctzik@chromium.org2011-06-221-3/+3
| | | | | | | | | | BUG=65151 TEST=None Review URL: http://codereview.chromium.org/7216022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90049 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing coverity PASS_BY_VALUE bugs.dpapad@chromium.org2011-06-229-14/+13
| | | | | | | | | | | | CIDs: 13844, 13845, 14689, 14731, 14732, 17117 BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/7219012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90048 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fix unchecked returns.kmadhusu@chromium.org2011-06-224-6/+8
| | | | | | | | | | CID = 17626, 17123, 15395, 15394 BUG=none TEST=none Review URL: http://codereview.chromium.org/7206049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90046 0039d316-1c4b-4281-b951-d872f2087c98
* Improve error messages for pyauto tests in chromeos_security.py.dennisjeffrey@chromium.org2011-06-221-20/+89
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/7231001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90045 0039d316-1c4b-4281-b951-d872f2087c98
* Added separator role in printers listaayushkumar@chromium.org2011-06-221-3/+7
| | | | | | | | | | | | | This patch takes care of the 8th point in the bug report. BUG=83407 TEST=Ensure that in-tab print preview is enabled. Print any random page and then switch on VoiceOver to navigate through the printers list in the preview page. You will hear something more meaningful than "dimmed" in the separators above and below the "Print to PDF" option. Review URL: http://codereview.chromium.org/7189080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90044 0039d316-1c4b-4281-b951-d872f2087c98
* Split up proxy error event test in several sub-testsjochen@chromium.org2011-06-227-64/+106
| | | | | | | | | | | | Since soem sub-systems are triggering network traffic in the background, it's difficult to estimate the number of error events we'll get. Splitting the tests allows for just checking for one error at a time. BUG=none TEST=test shouldn't be flaky anymore Review URL: http://codereview.chromium.org/7232012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90043 0039d316-1c4b-4281-b951-d872f2087c98
* Include port when creating a pattern for a HTTPS URLjochen@chromium.org2011-06-222-3/+6
| | | | | | | | | | BUG=none TEST=unit_tests Review URL: http://codereview.chromium.org/7229005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90042 0039d316-1c4b-4281-b951-d872f2087c98
* Deflakify Prerender Favicon Test by removing timer and usingtburkard@chromium.org2011-06-223-12/+15
| | | | | | | | an observer instead. BUG=85729 Review URL: http://codereview.chromium.org/7218024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90035 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill heuristics checkout files for 06_checkout_urbanoutfitters.com.htmldhollowa@chromium.org2011-06-224-17/+23
| | | | | | | | | | | Extends heuristics engine to look at field values. Tweaks regexes to match idioms in this form. BUG=86606 TEST=FormStructureBrowserTest.* with 06_checkout_urbanoutfitters.com.html Review URL: http://codereview.chromium.org/7206069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90034 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress Valgrind reports in ↵glider@chromium.org2011-06-221-0/+31
| | | | | | | | | | | | net::FileStream::AsyncContext::OnBackgroundIOCompleted (issue 87094) BUG=87094 TBR=willchan Review URL: http://codereview.chromium.org/7232014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90030 0039d316-1c4b-4281-b951-d872f2087c98
* Test download manager fetching CRXes.skerner@chromium.org2011-06-229-73/+447
| | | | | | | | | | | | | | | First round of tests for the download manager handling CRXes. Platform-specific UI interactions are not covered by these tests. It would be nice to test that animations are running. I can't see a way to do that without adding accessors to the platform-specific download item UI classes. Paweł, you expressed concern about *ForTesting() methods before. Is there a better way to test that animations are working? BUG=80010 TEST=DownloadTest.Crx* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89496 Review URL: http://codereview.chromium.org/7104060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90029 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enabled DecimalPointNotDot test.joaodasilva@chromium.org2011-06-221-2/+1
| | | | | | | | | | BUG=None TEST=TimeFormatBrowserTest.DecimalPointNotTest Review URL: http://codereview.chromium.org/7233010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90028 0039d316-1c4b-4281-b951-d872f2087c98