| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
get lost. This caused problems when going in/out of fullscreen mode.
I'm also improving the description of the WidgetGtk types.
CHROMEOS_BUG=1020
TEST=see bug
Review URL: http://codereview.chromium.org/518041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=dank
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/523079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed unnecessary code to reset the JS line number, which was
only added for the Chrome+JSC build. I don't have a way to test
if it would still be necessary, and I'd rather not add a WebKit
API for it unless I can prove that I need it.
R=dglazkov
BUG=28065
TEST=none
Review URL: http://codereview.chromium.org/517038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We used to focus the thumbnail on mousedown which makes the thumbmail hover
effect show up which confuses users.
BUG=31361
TEST=Right click on a thumbnail and dismiss the context menu. The thumbnail
should not be focused.
Review URL: http://codereview.chromium.org/525045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=dank
BUG=31644
TEST=none
Review URL: http://codereview.chromium.org/523078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This used to show up as blank preview.
BUG=None
TEST=Covered by (new) automatic tests.
Review URL: http://codereview.chromium.org/523029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=31517
TEST=ChildProcessSecurityPolicyTest
Review URL: http://codereview.chromium.org/525038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
expectations.
BUG=31642
TEST=None
Review URL: http://codereview.chromium.org/525043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BookmarkModelWorker::CallDoWorkFromModelSafeThreadAndWait.
TBR=tim
BUG=31643
TEST=none
Review URL: http://codereview.chromium.org/526014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
xib change: Deleted NSBox, added NSSplitView instead (with a thin divider and without any child views).
I added the devtools tabcontents to TabContentsController; windows and linux instead add it to the browser window and switch it on every tab change. What I've done makes more sense to me and might work better with a) dragging a tab with docked devtools into a new window and b) toggling fullscreen.
BUG=17368
TEST=
* Inspect element, click the "attach" item in the lower left corner. Devtools should attach to the tab. Click it again, should detach. Re-attach, switch tabs. Should only be in the tab it was attached to. Open another devtools window in another tab, should be attached there. Drag tab with attached devtools into a new window, should work.
* Inspect element with docked devtools, close devtools, inspect another element. devtools should open with the same size it had when it was closed, and should still be docked.
* Hover link with docked devtools. Status bubble should not overlap devtools.
* Go to http://www.pagetutor.com/keeper/http_authentication/index.html and make sure the http auth sheet still shows up
Review URL: http://codereview.chromium.org/526001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
rather than windows-specific logic. Part of notifications port to linux.
BUG=23954
TEST=none
Review URL: http://codereview.chromium.org/524039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/525040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Split up one method in BookmarkTreeController to improve testability.
BUG=13149
TEST=BookmarkTreeControllerTest.MoveNodes
Review URL: http://codereview.chromium.org/523069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
flesh out some more menu model implementation for MenuGtk
BUG=28977
TEST=menu still works as before
Review URL: http://codereview.chromium.org/523049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The change at http://codereview.chromium.org/484006 changed all the close buttons to use a single HoverCloseButton class, but this didn't work for the popup blocker. The reason is that all the initialization was done in awakeFromNib since in most other cases, the button was created in a nib, but was done with initWithFrame for the popup blocker case. I refactored the initialization code out into -initButton to be called from both initWithFrame and awakeFromNib.
I also removed the references to the images and alt images from each of the xib files. The images are specified in the class itself so it was redundant to have it in the xibs, and could probably cause confusion if we change the images later on.
BUG=16041
TEST=Ensure that the popup blocker button has rollover image changing, and that it works correctly still for TabView, InfoBar, and DownloadShelf
Review URL: http://codereview.chromium.org/521010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
These are chromeos specific files to be added to the zip archive
Review URL: http://codereview.chromium.org/521033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=wtc
Review URL: http://codereview.chromium.org/521032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
As a mass-drive-by, I also got rid of unneeded |? YES : NO| (etc.), since
apparently |bool| and |BOOL| are interchangeable.
BUG=31635
TEST=Navigate to non-NTP page; switch theme to, say, "Anna Sui" (or be prepared to look very carefully); toggle bookmark bar (Cmd-Shift-B), back and forth; make sure that it looks correct when hiding.
Review URL: http://codereview.chromium.org/523070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
occurs while tearing down the
ChromeFrameAutomationClient instance, which only gets called from the destructor of the ChromeFramePlugin
class which is a base class of the ChromeFrame ActiveX. When this executes the worker thread which is used
for handling urlmon requests has been destroyed.
The crash occurs in the UrlmonUrlRequest::Stop function while posting a task back to an invalid message loop.
We already clean up the requests in the WM_DESTROY handler, meaning that there seems to be a scenario where
we don't receive a WM_DESTROY. It is unclear what that is.
The fix is to call Uninitialize on the ChromeFramePlugin object in the destructor of the ActiveX which ensures
that it executes while the thread is still valid. Added checks for the message loop in the relevant functions
in the UrlmonUrlRequest class.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=31557
Bug=31557
Review URL: http://codereview.chromium.org/518034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=31586
TEST=Mac Valgrind unit tests
Review URL: http://codereview.chromium.org/519051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
DOMStorageArea.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/488014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
r35540.
TBR=rjkroege
BUG=31634
TEST=none
Review URL: http://codereview.chromium.org/524036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
If you have any suggestions for other unit tests I can write for this, please
suggest them!
TEST=none
BUG=16155
Review URL: http://codereview.chromium.org/491035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=arv
BUG=31632
TEST=none
Review URL: http://codereview.chromium.org/525034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=31558
TEST=build with export GYP_DEFINES="target_arch=x64 chromeos=1 branding=Chrome buildtype=Official"
Review URL: http://codereview.chromium.org/519043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
matches other browsers, and simplifies the code.
To better understand what this means, here are some examples how the behaviors will differ for the user:
(1) You start chrome with --proxy-server="foobar:80".
The server "foobar:80" is refusing connections.
Before: Would fallback to direct after failing to connect through foobar:80.
Now: Will error-out with connection refused after failing to connect through foobar:80.
(2) You start chrome with --proxy-pac-url="file:///foobar.pac".
The server "foobar:80" is unreachable, and foobar.pac reads:
function FindProxyForURL(url, host) {
return "PROXY foobar:80";
}
Before: Would fallback to direct after failing to connect through foobar:80.
Now: Will error-out with connection refused after failing to connect through foobar:80.
(3) You start chrome with --proxy-pac-url="file:///foobar.pac".
The server "foobar:80" is unreachable, and foobar.pac reads:
function FindProxyForURL(url, host) {
return "PROXY foobar:80; DIRECT";
}
*No change, since the fallback to DIRECT is explicit in the PAC script*
BUG=12303
Review URL: http://codereview.chromium.org/502068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/30239
TEST=Popups should not appear under the Dock when the Dock is on the left.
Review URL: http://codereview.chromium.org/510001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Most features are implemented, but Recents, Search and Undo are still missing.
MainMenu.xib: Just added "Bookmark Manager" menu item at top of "Bookmarks" menu.
BookmarkManager.xib: New file, containing Bookmark Manager panel, owned by BookmarkManagerController class.
BUG=13149
TEST=New unit tests for each new class.
Review URL: http://codereview.chromium.org/501073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=31623
Review URL: http://codereview.chromium.org/523065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
flaky tests.
TBR=amit
Bug=31532
Review URL: http://codereview.chromium.org/524035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Rearrange the chrome_frame.gyp file to:
a) Split out most of CF into a static lib to make writing unit tests easier (not having to re-include source files).
b) Remove most of the un-needed xulrunner-sdk includes.
2) Move all OBJECT_ENTRY_AUTO macros to chrome_tab.cc since they don't work without extra work when residing in a lib.
3) Rename npchrome_tab.dll to npchrome_frame.dll.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/523040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/521030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/523053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=31043
TEST=none
Review URL: http://codereview.chromium.org/521026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
that define the size of the nine sub-areas. This makes it consistent with views's ImagePainter. Part of notifications port to linux.
BUG=23954
TEST=none
Review URL: http://codereview.chromium.org/524025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Associate a BlacklistRequestInfo with each URLRequest started by ResourceDispatcherHost so that in various places we get access to the right BlacklistManager (each Profile has its own), and lazily cache a Blacklist::Match.
BlacklistListener controls delaying requests until the privacy blacklist is ready for the request.
BlacklistInterceptor handles substituting real response with a blocking page or blocking image. I've temporarily removed support for unblocking things. It was too hacky.
This change also removes a large block of blacklist-related code from RDH to more focused classes. Should make it a little more readable.
This should also make BlacklistManagerBrowserTest not flaky.
TEST=Covered by browser_tests and unit_tests.
BUG=21541, 29113
Review URL: http://codereview.chromium.org/501082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=31560
TEST=Enable bookmark sync, then attempt to add a bookmark.
Review URL: http://codereview.chromium.org/526007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
64-bit Flash uses the LAHF instruction, which isn't available on
some CPUs. Work around this by catching SIGILL and emulating
the instruction.
BUG=29789
TEST=flash works on more computers than before, nothing else changes
Review URL: http://codereview.chromium.org/517031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Per spec (and other implementations) the Cocoa event model uses the Cocoa
modifier flag definitions, not the old Carbon version.
BUG=none
TEST=Click and key event modifiers should work in plugins (e.g., Flash games that use shift-clicking)
Review URL: http://codereview.chromium.org/518035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This fixes the linux shared build. Error was:
out/Release/lib.target/chrome/libbrowser.so: undefined reference to `JoinString(std::vector<std::basic_string<unsigned short, base::string16_char_traits, std::allocator<unsigned short> >, std::allocator<std::basic_string<unsigned short, base::string16_char_traits, std::allocator<unsigned short> > > > const&, unsigned short)'
Review URL: http://codereview.chromium.org/518037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
tables with lots of deleted elements.
Review URL: http://codereview.chromium.org/521029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ones) on Mac.
BUG=25946
TEST=GlobalKeyboardShortcuts.ShortcutsToWindowCommand
TEST=Go to a Web page, open several tabs and press Cmd-{/}. Make sure the browser tab switches to next or prev. This should work on any keyboards (including ones with non-US layout).
Review URL: http://codereview.chromium.org/503080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=25520
Review URL: http://codereview.chromium.org/523034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jrg
BUG=31586
TEST=Mac Valgrind
Review URL: http://codereview.chromium.org/517035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It needs chromium specific expectations because of difference in v8/jsc.
BUG=31108
TEST=none
Review URL: http://codereview.chromium.org/525021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was necessary for me to use objc types/classes in the unittest.
Separated from http://codereview.chromium.org/503080 to make the rename trackable.
BUG=none (indirectly related to 25946)
TEST=none
Review URL: http://codereview.chromium.org/525023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
started to fail differently.
TBR=dglazkov
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/517034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=29928
TEST=none
Review URL: http://codereview.chromium.org/525020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/flakiness_dashboard.html#tests=websocket%2Ftests%2Furl-with-credential.html
BUG=30593
TEST=none
Review URL: http://codereview.chromium.org/526008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35513 0039d316-1c4b-4281-b951-d872f2087c98
|