summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Remove an unused variable and some includes.thestig@chromium.org2009-09-211-17/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/209043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26727 0039d316-1c4b-4281-b951-d872f2087c98
* Disables the quit menu item for Chrome OS.sky@chromium.org2009-09-212-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/212035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26726 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress a new Mac leakstuartmorgan@chromium.org2009-09-211-0/+10
| | | | | | | | | BUG=22544 TEST=Mac valgind bot Review URL: http://codereview.chromium.org/212036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26725 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the temporary Mac plugin whitelist.amanda@chromium.org2009-09-216-42/+203
| | | | | | | | | | | | | Support Mac NPAPI drawing and event model negotiation. Implement a fallback Quickdraw drawing model implementation so that old plugins don't crash. This change does not address keyboard input issues (see issue 19194), just display issues. BUG=12030 TEST=Quickdraw based plugins (such as the QuickTime plugin) should not crash when invoked, and may even display properly. Review URL: http://codereview.chromium.org/211031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26724 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the realm in BASIC and DIGEST challenges to not be specified.eroman@chromium.org2009-09-215-11/+74
| | | | | | | | | | | | This goes against RFC 2617 which states they are required parameters, but apparently there are servers which do this, and other browsers are less strict. Also allow the empty string as a valid realm value (previously this was being disallowed as an implementation bug to check if it was not specified). BUG=12565,20984 Review URL: http://codereview.chromium.org/211040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26723 0039d316-1c4b-4281-b951-d872f2087c98
* Version number bump for releasebradnelson@google.com2009-09-211-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26720 0039d316-1c4b-4281-b951-d872f2087c98
* Update pthreads-win32 to add corresponding svn:ignore.maruel@chromium.org2009-09-211-1/+1
| | | | | | | | | | NO CODE CHANGE. TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26719 0039d316-1c4b-4281-b951-d872f2087c98
* Copy the leak callstacks onto the stack before crashing in ↵eroman@chromium.org2009-09-212-5/+27
| | | | | | | | | | LeakTracker::CheckForLeaks. This way if it is enabled in release builds, the mini-dump will contain the allocation stacktrace. Review URL: http://codereview.chromium.org/208001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26717 0039d316-1c4b-4281-b951-d872f2087c98
* Added a suppression for yet another data racetimurrrr@chromium.org2009-09-211-0/+6
| | | | | | Review URL: http://codereview.chromium.org/216038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26715 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use NSS databases for non-essential purposes, such as rememberingwtc@chromium.org2009-09-212-10/+14
| | | | | | | | | | | | | | | the intermediate CA certificates we see, because NSS's connections to the SQLite databases go bad if the file system where the databases reside is gone, even just transiently. Add the hostname to the error log message for CERT_PKIXVerifyCert failure. R=eroman,ukai BUG=15630 TEST=existing unit tests should pass. Review URL: http://codereview.chromium.org/214028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26714 0039d316-1c4b-4281-b951-d872f2087c98
* Remove syncer_paused from syncapi.tim@chromium.org2009-09-212-4/+0
| | | | | | Review URL: http://codereview.chromium.org/217003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26713 0039d316-1c4b-4281-b951-d872f2087c98
* Create a dashboard for tracking aggregate numbers of passing/failing layoutojan@chromium.org2009-09-213-313/+524
| | | | | | | | | | | | | | | | | | tests from the JSON used by the flakiness dashboard. Moves a bunch of code into a shared dashboard_base.js file. The displays is just a bunch of ugly tables. I trust dglazkov to make it pretty. :) Now that I have the tables, I can see that some of the data is also just wrong. Not sure how that happened, but I'll clean up the data generation code next week. In the meantime, dglazkov can have at it and make it pretty. The data format will stay the same, just the numbers will change. Review URL: http://codereview.chromium.org/213036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26712 0039d316-1c4b-4281-b951-d872f2087c98
* Update svn:ignore.maruel@chromium.org2009-09-210-0/+0
| | | | | | | | | | | | Give the try slaves some fresh air. NO CODE CHANGE. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26711 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Expose AutocompleteEditViewMac to Cocoa code.shess@chromium.org2009-09-2111-245/+250
| | | | | | | | | This reduces the number of forwarding/delegate shenanigans we have to go through. Review URL: http://codereview.chromium.org/211030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26710 0039d316-1c4b-4281-b951-d872f2087c98
* Switch history thread back to base::Thread. Sync unit tests require more ↵chron@chromium.org2009-09-213-7/+7
| | | | | | | | | | than one history thread. We hope to have a hard unit test dependency on buildbot soon, but we need to fix our tests again now. BUG=22056 Review URL: http://codereview.chromium.org/215023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26709 0039d316-1c4b-4281-b951-d872f2087c98
* The main menu button is now enabled by default.sky@chromium.org2009-09-217-43/+23
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/214034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26708 0039d316-1c4b-4281-b951-d872f2087c98
* allow the handle to be hidden when moles are expandederikkay@chromium.org2009-09-213-90/+143
| | | | | | | | | BUG=15494 TEST=none Review URL: http://codereview.chromium.org/210031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26706 0039d316-1c4b-4281-b951-d872f2087c98
* Update libjingle to build on Linuxzork@chromium.org2009-09-218-58/+306
| | | | | | Review URL: http://codereview.chromium.org/207024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26705 0039d316-1c4b-4281-b951-d872f2087c98
* Retry of r26698.estade@chromium.org2009-09-217-70/+0
| | | | | | | | R=stuartmorgan Review URL: http://codereview.chromium.org/208047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26704 0039d316-1c4b-4281-b951-d872f2087c98
* Whitespace change to trigger gyp rebuildstuartmorgan@chromium.org2009-09-211-0/+1
| | | | | | | | | | | TBR=mark BUG=None TEST=None Review URL: http://codereview.chromium.org/207041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26702 0039d316-1c4b-4281-b951-d872f2087c98
* Fix path mismatch on linux/mac.tony@chromium.org2009-09-211-1/+5
| | | | | | | | | TBR=dpranke Review URL: http://codereview.chromium.org/215034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26701 0039d316-1c4b-4281-b951-d872f2087c98
* Revert a file that slipped into r26699 by mistake.estade@chromium.org2009-09-211-11/+0
| | | | | | | TBR=stuartmorgan git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26700 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting r26698. Somehow this broke scons?estade@chromium.org2009-09-217-0/+80
| | | | | | | | TBR=stuartmorgan Review URL: http://codereview.chromium.org/217004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26699 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Remove linux splash page and printing command line switch.estade@chromium.org2009-09-218-215/+0
| | | | | | | | | BUG=22295 BUG=19911 Review URL: http://codereview.chromium.org/211036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26698 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 23438 which reverted 23408.estade@chromium.org2009-09-211-1/+2
| | | | | | | | | see http://codereview.chromium.org/165534 BUG=22302 Review URL: http://codereview.chromium.org/207035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26697 0039d316-1c4b-4281-b951-d872f2087c98
* Remove leftover directive when we generated source files.thomasvl@chromium.org2009-09-211-1/+0
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/216036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26696 0039d316-1c4b-4281-b951-d872f2087c98
* Forward edit commands to be executed for shortcuts which aren't handled bythakis@chromium.org2009-09-213-34/+103
| | | | | | | | | | | | | | | | | | | | | | | | | | | | javascript. As a result, cocoa keybindings work. The approach: We instantiate a vanilla NSResponder, call interpretKeyEvents on it, and record all of the selectors passed into doCommandBySelector while interpreting the key event. The selectors are converted into edit commands which can be passed to the render process. Caveats: - Shortcuts involving a sequence of key combinations (chords) don't work, because we instantiate a new responder for each event. - We ignore key combinations that don't include a modifier (ctrl, cmd, alt) because this was causing strange behavior (e.g. tab always inserted a tab rather than moving to the next field on the page). BUG=12538 TEST=go to a page with a text field. make sure that ctrl-a moves cursor to beginning of line, ctrl-e goes to the end, ctrl-d deletes to the right, ctrl-h to the left, etc Review URL: http://codereview.chromium.org/209046 Patch from matt@tolton.com. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26694 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline tests whose results changed due to ↵levin@chromium.org2009-09-2111-22/+17
| | | | | | | | | | | | | | http://trac.webkit.org/changeset/47229 Also, add some bugs number for a layout tests. BUG=None TEST=None (These are the tests.) Review URL: http://codereview.chromium.org/212023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26693 0039d316-1c4b-4281-b951-d872f2087c98
* Shift+PageUp and Shift+PageDown should not scroll the web page.tony@chromium.org2009-09-211-1/+1
| | | | | | | | | | | | | | | | | Alt and Ctrl already don't scroll. Win+PageUp/PageDown does scroll. This matches Firefox. It doesn't match IE; IE lets you scroll using ctrl, shift or win. I'm doing this so the standard GTK+ key binding for ctrl+shift+page{up/down} can be used on linux to move tabs left/right (otherwise, the page scrolls and eats the key before we get to it). BUG=21594 Review URL: http://codereview.chromium.org/214026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26692 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a harmless data race in Threadtimurrrr@chromium.org2009-09-211-1/+1
| | | | | | | | | | | Currently, if StopSoon/Stop is called twice (like in ThreadTest.StopSoon) message_loop_ can be accessed simultaneously by ThreadMain():162 and in StopSoon():124. This data race is harmless since stopping_==true, so message_loop_ value is actually un-needed. I'd like to swap the conditions to avoid reading message_loop_ in case stopping_==true. This way ThreadTest.StopSoon will have no race reports under ThreadSanitizer. Currently, this is the only report on base_unittests on ThreadSanitizer linux bot. Review URL: http://codereview.chromium.org/207039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26691 0039d316-1c4b-4281-b951-d872f2087c98
* Tweak an existing Mac suppression for a stack changestuartmorgan@chromium.org2009-09-211-8/+2
| | | | | | | | | | | TBR=dank BUG=22021 TEST=Mac valgrind bots Review URL: http://codereview.chromium.org/212032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26690 0039d316-1c4b-4281-b951-d872f2087c98
* Adds NOTREACHED if we ever hit the max cache size of the render pictsky@chromium.org2009-09-211-1/+10
| | | | | | | | | | | | format cache. BUG=none TEST=none TBR=estade Review URL: http://codereview.chromium.org/217002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26689 0039d316-1c4b-4281-b951-d872f2087c98
* Add histograms for tab count, RenderProcessHost count, and the number ofbrettw@chromium.org2009-09-215-11/+103
| | | | | | | | | | glyph "pages" in memory per load (to check memory consumption). BUG=none TEST=none Review URL: http://codereview.chromium.org/195104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26688 0039d316-1c4b-4281-b951-d872f2087c98
* Task Manager for OS X: Set up columns, show rows.thakis@chromium.org2009-09-214-60/+211
| | | | | | | | | | | This is more work-in-progress for the OS X task manager. The table header is complete (the right columns are there, and right-clicking the header gives a column-selection context menu just like in e.g. Task Manager), and the rows data is displayed. However, all the metrics (memory, cpu, etc) seem to be all wrong. Because of this and because too much stuff is still unimplemented (favicons in rows, the "kill process" button, the link, etc), I won't commit the change to MainMenu.xib, so users still won't be able to open this dialog. BUG=13156 TEST=Connect view->task manager to first responder's commandDispatch:, set the menu item to "enabled", and give the menu item the tag 40005. Now opening the task manager should actually display data. Right-clicking the table header should show a functional menu that lets you select which columns to display. Clicking a column header should not select the column, double-clicking an item should not edit it. Also, when resizing the task manager, stuff should now behave in a sane way. Review URL: http://codereview.chromium.org/208043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26687 0039d316-1c4b-4281-b951-d872f2087c98
* Unescape FTP URL paths, Firefox-compatible.phajdan.jr@chromium.org2009-09-213-30/+55
| | | | | | | | | TEST=See bug. BUG=20304 Review URL: http://codereview.chromium.org/200145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26686 0039d316-1c4b-4281-b951-d872f2087c98
* <html>aa@chromium.org2009-09-218-76/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | <style type="text/css"> <!-- body { font-family: arial,sans-serif; background-color: #fff; margin-top: 2; } .c { width: 4; height: 4; } a:link { color: #00c; } a:visited { color: #551a8b; } a:active { color: #f00; } .form-noindent { background-color: #fff; border: 1px solid #c3d9ff; } --> </style> <style type="text/css"><!-- .gaia.le.lbl { font-family: Arial, Helvetica, sans-serif; font-size: smaller; } .gaia.le.fpwd { font-family: Arial, Helvetica, sans-serif; font-size: 70%; } .gaia.le.chusr { font-family: Arial, Helvetica, sans-serif; font-size: 70%; } .gaia.le.val { font-family: Arial, Helvetica, sans-serif; font-size: smaller; } .gaia.le.button { font-family: Arial, Helvetica, sans-serif; font-size: smaller; } .gaia.le.rem { font-family: Arial, Helvetica, sans-serif; font-size: smaller; } .gaia.captchahtml.desc { font-family: arial, sans-serif; font-size: smaller; } .gaia.captchahtml.cmt { font-family: arial, sans-serif; font-size: smaller; font-style: italic; } --></style> <head> <title>Google Accounts</title> <style type="text/css"><!-- body { font-family: arial, sans-serif; margin: 0; padding: 13px 15px 15px; } .body { margin: 0; } div.errorbox-good {} div.errorbox-bad {} div.errormsg { color: red; font-size: smaller; font-family: arial,sans-serif;} font.errormsg { color: red; font-size: smaller; font-family: arial,sans-serif;} div.topbar { font-size:smaller; margin-right: -5px; text-align:right; white-space:nowrap; } div.header { margin-bottom: 9px; margin-left: -2px; position:relative; zoom: 1 } div.header img.logo { border: 0; float:left; } div.header div.headercontent { float:right; margin-top:17px; } div.header:after{ content:"."; display:block; height:0; clear:both; visibility:hidden; } div.pagetitle { font-weight:bold; } .footer { color: #666; font-size: smaller; margin-top: 40px; text-align: center; } table#signupform { left: -5px; top: -7px; position:relative; } table#signupform td{ padding: 7px 5px; } table#signupform td table td{ padding: 1px; } hr { border: 0; background-color:#DDDDDD; height: 1px; width: 100%; text-align: left; margin: 5px; } --></style> </head> <body dir="ltr" onLoad= "gaia_setFocus();" > <div id="main"> <?sc # for new logo transition ?> <div class=header> <a href='https://www.google.com/accounts/'> <img class=logo src='https://www.google.com/intl/en/images/logos/accounts_logo.gif' alt="Google" /> </img> </a> </div> <div id=maincontent> <table border="0" width="100%" cellpadding=0 cellspacing=0> <tr> <td width="75%" valign="top"> <h3> Chromium Code Reviews uses Google Accounts for Sign In. </h3> <p><font size=-1> Google is not affiliated with the contents of <b>Chromium Code Reviews</b> or its owners. If you sign in, Google will share your email address with <b>Chromium Code Reviews</b>, but not your password or any other personal information. </font></p> <p><font size=-1> <b>Chromium Code Reviews</b> may use your email address to personalize your experience on their website. </font></p> </td> <td style="padding-left: 10px;" valign="top" align="center"> <div id="rhs"> <div id="rhs_login_signup_box"> <script><!-- function gaia_onLoginSubmit() { if (window.gaiacb_onLoginSubmit) { return gaiacb_onLoginSubmit(); } else { return true; } } function gaia_setFocus() { var f = null; if (document.getElementById) { f = document.getElementById("gaia_loginform"); } else if (window.gaia_loginform) { f = window.gaia_loginform; } if (f) { if (f.Email && (f.Email.value == null || f.Email.value == "")) { f.Email.focus(); } else if (f.Passwd) { f.Passwd.focus(); } } } --></script> <style type="text/css"><!-- div.errormsg { color: red; font-size: smaller; font-family:arial,sans-serif; } font.errormsg { color: red; font-size: smaller; font-family:arial,sans-serif; } --></style> <style type="text/css"><!-- .gaia.le.lbl { font-family: Arial, Helvetica, sans-serif; font-size: smaller; } .gaia.le.fpwd { font-family: Arial, Helvetica, sans-serif; font-size: 70%; } .gaia.le.chusr { font-family: Arial, Helvetica, sans-serif; font-size: 70%; } .gaia.le.val { font-family: Arial, Helvetica, sans-serif; font-size: smaller; } .gaia.le.button { font-family: Arial, Helvetica, sans-serif; font-size: smaller; } .gaia.le.rem { font-family: Arial, Helvetica, sans-serif; font-size: smaller; } .gaia.captchahtml.desc { font-family: arial, sans-serif; font-size: smaller; } .gaia.captchahtml.cmt { font-family: arial, sans-serif; font-size: smaller; font-style: italic; } --></style> <form id="gaia_loginform" action="https://www.google.com/accounts/ServiceLoginAuth?service=ah&amp;sig=d71ef8b8d6150b23958ad03b3bf546b7" method="post" onsubmit= "return(gaia_onLoginSubmit());" > <div id="gaia_loginbox"> <table class="form-noindent" cellspacing="3" cellpadding="5" width="100%" border="0"> <tr> <td valign="top" style="text-align:center" nowrap="nowrap" bgcolor="#e8eefa"> <input type="hidden" name="ltmpl" value="gm"> <div class="loginBox"> <table id="gaia_table" align="center" border="0" cellpadding="1" cellspacing="0"> <tr> <td colspan="2" align="center"> <font size="-1"> Sign in with your </font> <table> <tr> <td valign="top"> <img src="google_transparent.gif" alt="Google"> </img> </td> <td valign="middle"> <font size="+0"><b>Account</b></font> </td> </tr> </table> </td> </tr> <script type="text/javascript"><!-- function onPreCreateAccount() { return true; } function onPreLogin() { if (window["onlogin"] != null) { return onlogin(); } else { return true; } } --></script> <tr> <td colspan="2" align="center"> </td> </tr> <tr> <td nowrap="nowrap"> <div align="right"> <span class="gaia le lbl"> Email: </span> </div> </td> <td> <input type="hidden" name="continue" id="continue" value="http://codereview.chromium.org/_ah/login?continue=http://codereview.chromium.org/210007/description" /> <input type="hidden" name="service" id="service" value="ah" /> <input type="hidden" name="ltmpl" id="ltmpl" value="gm" /> <input type="hidden" name="ltmpl" id="ltmpl" value="gm" /> <input type="hidden" name="ahname" id="ahname" value="Chromium Code Reviews" /> <input type="hidden" name="GALX" value="LfA4LnZj1gM" /> <input type="text" name="Email" id="Email" size="18" value="" class='gaia le val' /> </td> </tr> <tr> <td></td> <td align="left"> </td> </tr> <tr> <td align="right" nowrap="nowrap"> <span class="gaia le lbl"> Password: </span> </td> <td> <input type="password" name="Passwd" id="Passwd" size="18" class="gaia le val" /> </td> </tr> <tr> <td> </td> <td align="left"> </td> </tr> <tr> <td align="right" valign="top"> <input type="checkbox" name="PersistentCookie" id="PersistentCookie" value="yes" checked='checked' /> <input type="hidden" name='rmShown' value="1" /> </td> <td> <label for="PersistentCookie" class="gaia le rem"> Stay signed in </label> </td> </tr> <tr> <td> </td> <td align="left"> <input type="submit" class="gaia le button" name="signIn" value="Sign in" /> </td> </tr> <tr id="ga-fprow"> <td colspan="2" height="33.0" class="gaia le fpwd" align="center" valign="bottom"> <a href="http://www.google.com/support/accounts/bin/answer.py?answer=48598&amp;hl=en&amp;ctx=ch_ServiceLogin&amp;p=ah&amp;fpUrl=https%3A%2F%2Fwww.google.com%2Faccounts%2FForgotPasswd%3FfpOnly%3D1%26continue%3Dhttp%253A%252F%252Fcodereview.chromium.org%252F_ah%252Flogin%253Fcontinue%253Dhttp%253A%252F%252Fcodereview.chromium.org%252F210007%252Fdescription%26service%3Dah%26ltmpl%3Dgm" target=_top> Can&#39;t access your account? </a> </td> </tr> </table> </div> </td> </tr> </table> </div> <input type="hidden" name="asts" id="asts" value=""> </form> <form id="gaia_universallogin" action="https://www.google.com/accounts/ServiceLoginAuth?service=ah&amp;sig=d71ef8b8d6150b23958ad03b3bf546b7" method="post" onsubmit="return(gaia_onLoginSubmit());"> <input type="hidden" name="continue" id="continue" value="http://codereview.chromium.org/_ah/login?continue=http://codereview.chromium.org/210007/description" /> <input type="hidden" name="service" id="service" value="ah" /> <input type="hidden" name="ltmpl" id="ltmpl" value="gm" /> <input type="hidden" name="ltmpl" id="ltmpl" value="gm" /> <input type="hidden" name="ahname" id="ahname" value="Chromium Code Reviews" /> <input type="hidden" name="ltmpl" id="ltmpl" value="gm" /> </form> <br/> <table class="form-noindent" border="0" cellpadding="6" cellspacing="3" width="100%"> <tr> <td bgcolor="#e8eefa" align="center" style="font-size:83%"> <b>Don't have a Google Account? </b><br/> <a href='https://www.google.com/accounts/NewAccount?continue=http%3A%2F%2Fcodereview.chromium.org%2F_ah%2Flogin%3Fcontinue%3Dhttp%3A%2F%2Fcodereview.chromium.org%2F210007%2Fdescription&amp;service=ah&amp;ltmpl=gm&amp;sig=909f6cca8e55250406f8bfbd303ab4a9' > <b>Create an account now</b> </a> </td> </tr> </table> </div> <br/> </div> </td> </tr> </table> </div> <div class="footer"> &copy;2009 Google - <a href='http://www.google.com/'>Google Home</a> - <a href='https://www.google.com/accounts/TOS?hl=en'>Terms of Service</a> - <a href='http://www.google.com/intl/en/privacy.html'>Privacy Policy</a> - <a href='http://www.google.com/support/accounts?hl=en'>Help</a> </div> </div> </body> </html> Review URL: http://codereview.chromium.org/210007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26685 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Get rid of utility functions and ExecuteUtilityFunction as a ↵pfeldman@chromium.org2009-09-2113-211/+70
| | | | | | | | whole. Eliminates the need in double-JSON of InjectedScript-related functions. Review URL: http://codereview.chromium.org/201017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26684 0039d316-1c4b-4281-b951-d872f2087c98
* Reimplement video painting for mac using CGContext.ajwong@chromium.org2009-09-212-2/+39
| | | | | | | | | | | | | This is still a bit hacky. We need to avoid doing the double copy of the bits by making the skia::PlatformCanvas take in a CGContext and use that as its backing store. BUG=19536 TEST=watched at video with it :) Review URL: http://codereview.chromium.org/208039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26683 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Save/restore focus in TabContentsViewMac.rohitrao@chromium.org2009-09-212-17/+14
| | | | | | | | BUG=http://crbug.com/12556 TEST=Open two tabs. Focus the omnibox in one, switch tabs and then back again. Omnibox should still have focus. Repeat with the findbar instead of the omnibox. Review URL: http://codereview.chromium.org/206015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26682 0039d316-1c4b-4281-b951-d872f2087c98
* Adding basic window control to the automation provider for the Mac.avi@chromium.org2009-09-214-41/+75
| | | | | | | | | BUG=http://crbug.com/16616 TEST=as described in bug. Review URL: http://codereview.chromium.org/216024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26681 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the "mixed content" security warnings because "no one in the history ↵pinkerton@chromium.org2009-09-211-271/+754
| | | | | | | | | | of the universe used them". BUG=22353 TEST=None Review URL: http://codereview.chromium.org/210033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26680 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress a benign race in SQLLitetimurrrr@chromium.org2009-09-211-0/+11
| | | | | | Review URL: http://codereview.chromium.org/212030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26679 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the $1 in the wrench tooltip that should be the product name.thomasvl@chromium.org2009-09-211-1/+1
| | | | | | | | BUG=22177 TEST=tooltip no longer has a $1 and has the product name. Review URL: http://codereview.chromium.org/215032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26678 0039d316-1c4b-4281-b951-d872f2087c98
* adding some missing ignoresthomasvl@chromium.org2009-09-210-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26676 0039d316-1c4b-4281-b951-d872f2087c98
* Update third_party/icu to 26673 to grab new svn:ignoremaruel@chromium.org2009-09-211-1/+1
| | | | | | | | | | NO CODE CHANGE. TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26674 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the main menu from displaying a static image to loading a page.sky@chromium.org2009-09-205-45/+250
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/208034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26668 0039d316-1c4b-4281-b951-d872f2087c98
* Only show extension shelf on demand again.thakis@chromium.org2009-09-201-1/+0
| | | | | | | | This caused the perf regression, so the ext shelf can stay on. TBR: mark@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26664 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily always show extension shelf.thakis@chromium.org2009-09-201-0/+1
| | | | | | | | This is to check if this caused the perf startup regression. TBR: mark@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26663 0039d316-1c4b-4281-b951-d872f2087c98
* build-bisect.py: Minor tweaks and Mac fixrsesek@chromium.org2009-09-201-10/+16
| | | | | | | | | * Allow user-specified profile directories. * Fix Mac BUILD_EXE_NAME to be the actual binary, rather than the bundle. Review URL: http://codereview.chromium.org/209045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26662 0039d316-1c4b-4281-b951-d872f2087c98
* remove the right-click devtools behaviorerikkay@chromium.org2009-09-191-2/+1
| | | | | | | | | | BUG=20634 TEST=right click on a toolstrip, nothing should happen TBR=aa Review URL: http://codereview.chromium.org/211038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26658 0039d316-1c4b-4281-b951-d872f2087c98