| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=26319
TEST=none
Review URL: http://codereview.chromium.org/342076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patch by Anton Muhin
R=darin
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/345040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=26486
TEST=none
Review URL: http://codereview.chromium.org/353007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26279
TEST=see bug
Review URL: http://codereview.chromium.org/339092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=21440
TEST=Open prefs, select 2nd tab. close & reopen prefs window. 2nd tab should still be selected. close & reopen chrome, open prefs. 2nd tab should still be selected.
Review URL: http://codereview.chromium.org/352003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/341066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=green linux webkit bots
TBR=dglazkov
Review URL: http://codereview.chromium.org/351008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
10.6 loads xibs differently, breaking GTMIBArray
TBR=mark@chromium.org
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Get rid of Arial as default
- Update non-English font choices (based mostly on Mozilla's choices, <http://mxr.mozilla.org/seamonkey/source/modules/libpref/src/init/all.js> cross-referenced with what's installed with the OS)
BUG=http://crbug.com/19135; http://crbug.com/20171
TEST=as in bugs
Review URL: http://codereview.chromium.org/335031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Fix the logic in -[SearchEngineListModel defaultIndex].
* Make the test data URLs in SearchEngineListModelTest replaceable, enabling
more tests.
* Add a test for this bug 21898.
TEST=Preferences-->Manage. Add two new search engines. Make the second one default. The list in main Preferences should not have a blank entry.
BUG=21898
Review URL: http://codereview.chromium.org/341060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=dglazkov
Review URL: http://codereview.chromium.org/343077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=dglazkov
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
The test hangs and/or crashes with both Valgrind tools we use.
BUG=25917,22608
Review URL: http://codereview.chromium.org/351006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- These two pages should now auto size vertically the labels.
- The label should be top aligned with controls in the group when the group is taller.
- The content should be vertically centered when the label is taller.
- All the textfields should always be tall enough to show content.
- Radios/checkbox should word wrap to show all their text.
- The spacing between groups is a little more even
- DEPS roll to pick up newer GTM with GTMIBArray.
- A bunch of changes in the XIB related to evening out spacing, adding the GTMIBArray for referencing stuff, etc.
Note: if a single radio word wraps all radios get space for that many lines, that's just how the OS does it and we aren't trying to change that (at the moment).
Note: some of the horizontal layouts can extend off the side of the window, that will be fixed in a future cl (once under the hood is also cleaned up).
TEST=see cl description for what should be working now.
BUG=20538
Review URL: http://codereview.chromium.org/340045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
from http://trac.webkit.org/changeset/50394).
BUG=none
TEST=will it blend-er, build?
R=kbr
Review URL: http://codereview.chromium.org/352002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=dank
Review URL: http://codereview.chromium.org/353004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=Covered by net_unittests.
BUG=25023
Review URL: http://codereview.chromium.org/340054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This was added erroneously and has never worked, removing.
BUG=7271
TEST=Start Chrome in Hebrew Windows or with cmdline switch "--country=IL --lang=he" , tapuz should not be displayed as a search provider.
Review URL: http://codereview.chromium.org/346013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=darin
Review URL: http://codereview.chromium.org/354001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=25354
TBR=estade
Review URL: http://codereview.chromium.org/353003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
itself a link.
BUG=26406
TEST=Compile and see chrome://extensions
Review URL: http://codereview.chromium.org/340056
Patch from Ramkumar Ramachandra <artagnon@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
specify a destructor trait. This allows browser objects to specify which thread they're terminated on. The benefit is we avoid the need to do manual ref counting when an object posts tasks to itself on different threads, if an object must be destructed on a specific thread.
This patch adds initial support and only shows one example with ResourceMessageFilter. I will do the rest in a follow-up patch to keep things small.
BUG=25354
TEST=added unit tests
Review URL: http://codereview.chromium.org/338065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ChromeThread instead.
BUG=25354
Review URL: http://codereview.chromium.org/342068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
to an Xcode variable, $(BUILT_PRODUCTS_DIR), which is not a shell variable.
The shell tries to treat it as a command expansion. Use ${BUILT_PRODUCTS_DIR}
directly.
BUG=none
TEST=Nico
Review URL: http://codereview.chromium.org/353002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
So when you select:
"http://www.google.com"
The context menu that will appear will be:
"Go to http://www.google.com"
Instead of:
"Search Google for http://www.google.com"
BUG=1978
TEST=open chromium, select a text that is a url, see if appears the menu "Go to..."; click on it,
see if it goes to the desired page.
Review URL: http://codereview.chromium.org/326026
Patch from tfarina.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Lots of fixes to deal better with the floating bar on the
NTP (e.g. chevron resize, chevron enabling only when there is
overflow, ...)
Move layoutSubviews logic from bookmark_bar_toolbar_view to
bookmark_bar_controller to better honor MVC.
BUG=http://crbug.com/24985, http://crbug.com/24827, http://crbug.com/22018
TEST=Lots of moves:
New browser with no bookmarks.
Go to New Tab Page. Show Bookmark Bar.
See "Other Bookmarks" button on right.
Do NOT see chevron.
Hover over and click on Other Bookmarks to be sure it doesn't draw out of bounds.
Disable bookmark bar (so it is now floating).
Repeat hover/click test.
Enable (so now attached).
Add bookmarks until chevron shows up.
Repeat hover/click test with chevron and Other Bookmarks.
Make browser wider and thinner; each time repeat hover/click test.
Detach bookmark bar (so floating on NTP).
Make browser wider and thinner; each time repeat hover/click test.
Carefully make browser wider/thinner so chevron appears/disappears.
Make sure chevron never overlaps a bookmark.
With chevron visible, quit & relaunch. Make sure chevron visible.
With chevron NOT visible, quit & relaunch. Make sure chevron not visible.
Review URL: http://codereview.chromium.org/348017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
These do not build, but are for experimentation.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/344041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/341062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=sgk
Review URL: http://codereview.chromium.org/351003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
So when you select:
"http://www.google.com"
The context menu that will appear will be:
"Go to http://www.google.com"
Instead of:
"Search Google for http://www.google.com"
BUG=1978
TEST=open chromium, select a text that is a url, see if appears the menu "Go to..."; click on it,
see if it goes to the desired page.
Review URL: http://codereview.chromium.org/326026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
A random side effect of this change is that it changes page action hover from bubble to tool tip.
BUG=24645
TEST=ExtensionApiTest.PageActionPopup
Review URL: http://codereview.chromium.org/347016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit f6429666a47eac17a18409d1743841bc44ed9a7a.
Review URL: http://codereview.chromium.org/351001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24604
TEST=None
Review URL: http://codereview.chromium.org/344018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
are needed by AutoFill.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/341042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The results are now sorted before being output, so there is no need
to pass the results through a sort filter.
Byte counts are now printed with comma separators between groups of
3 digits, so that 1234567 is now output as 1,234,567.
The summary.pl now has a number of more precise matches to better
give a quick estimate of blame for each allocation stack.
r=mbelshe
Review URL: http://codereview.chromium.org/348034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I removed a leak of "stack" objects, and made them a little
more lightweight by removing an unused member.
This change is only part of an option for chrome, that is not currently
linked in during any tests. It can only currently be used under XP, so
build-bot tests are not currently appropriate.
r=mbelshe
Review URL: http://codereview.chromium.org/345033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I am splitting out the pepper-specific portions of npapi.h.
This is because his code currently relies on a version
of npapi.h different from third_party\npapi\bindings.
Review URL: http://codereview.chromium.org/343069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
gcc-4.4 produces the warning "declaration does not declare anything", which becomes an error due to -Werror.
BUG=26413
Review URL: http://codereview.chromium.org/343072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a backout of r30647, but also resurrects the change from
http://codereview.chromium.org/341022 to work around the crash that r30647
solved much more elegantly.
We can't really leave things broken on 10.6, though. I killed most of a
perfectly good Friday evening trying to figure out how to salvage r30647,
but the DeferredAutoreleasePool approach seems doomed without making private
calls.
This makes me really sad.
BUG=25857, 26399, 26402
TEST=Does it launch on Snow Leopard now? Does it crash when you close windows?
Review URL: http://codereview.chromium.org/339095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=built chrome-os and non- binaries and made sure they worked as expected
Review URL: http://codereview.chromium.org/342069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=dank
TEST=media should stop being flaky on TSAN/Mac bot
Review URL: http://codereview.chromium.org/344046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
shown for the first timeBUG=26312
TEST=DevToolsSanityTest.TestScriptsTabIsPopulatedOnInspectedPageRefresh
Review URL: http://codereview.chromium.org/341057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I added these to try to look at exit codes in crashes, but we didn't find
antyhing surprising. I'm now removing them.
r=nsylvain
Review URL: http://codereview.chromium.org/343053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We now always walk the last active list backwards rather than consulting the last active then walking the registered browser list forwards. I now also maintain a fallback to walk the entire registered list of browsers forward if the active scan fails. This is likely only in a testing environment where a Browser may never have been activated.
This ensures that when the last active browser is a popup or app frame the last active TYPE_NORMAL browser is located when opening a new tab.
http://crbug.com/17498
TEST=Open an app frame. Open a browser window (Ctrl+N) and load a page. Minimize it. Open another browser window and minimize it. Activate the app frame. Press Ctrl+T. The second browser window should be restored and have a new tab added to it rather than the first.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30531
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30659
Review URL: http://codereview.chromium.org/330013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
code.
BUG=25318
TEST=none
Review URL: http://codereview.chromium.org/339093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
this pass without crashing in browser_tests. It makes the code uglier, but I want to debug and figure out what's going on.
Rework the way the FindBrowserWithProfile/Type methods work.
We now always walk the last active list backwards rather than consulting the last active then walking the registered browser list forwards.
This ensures that when the last active browser is a popup or app frame the last active TYPE_NORMAL browser is located when opening a new tab.
http://crbug.com/17498
TEST=Open an app frame. Open a browser window (Ctrl+N) and load a page. Minimize it. Open another browser window and minimize it. Activate the app frame. Press Ctrl+T. The second browser window should be restored and have a new tab added to it rather than the first.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30531
Review URL: http://codereview.chromium.org/330013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30659 0039d316-1c4b-4281-b951-d872f2087c98
|