summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Refactored FFmpegDemuxerTest to use a test fixture, fixing flakiness in the ↵scherkus@chromium.org2009-04-301-138/+131
| | | | | | | | | | process. BUG=10863 Review URL: http://codereview.chromium.org/100178 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14926 0039d316-1c4b-4281-b951-d872f2087c98
* ClientRectList must provide indexed access method that acts like item() method.ukai@chromium.org2009-04-305-0/+13
| | | | | | | | | | | | | | | | | | | On translate.google.com, it fails to show balloon, because of JavaScript exception in following code: p=a.getClientRects(); ... p[0].top // p[0] is undefined! Current v8 binding misses indexed access method in ClientRectList. CSSOM View Module draft says http://dev.w3.org/csswg/cssom-view/#clientrectlist In ECMAScript implimentations, objects that implement the ClientRectList interface must also have a [[GET]] method that, when invoked with a number, acts like the item() method would when invoked with that argument. BUG=10697 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14925 0039d316-1c4b-4281-b951-d872f2087c98
* Implement removeWindow, onWindowCreated, onWindowRemoved.rafaelw@chromium.org2009-04-308-16/+123
| | | | | | | | | BUG=11200 R=aa Review URL: http://codereview.chromium.org/100164 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14924 0039d316-1c4b-4281-b951-d872f2087c98
* media player wtl_render - video rendererfbarchard@chromium.org2009-04-302-0/+59
| | | | | | Review URL: http://codereview.chromium.org/99117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14922 0039d316-1c4b-4281-b951-d872f2087c98
* Don't insert ASCII character with ctrl(w/o/ alt) or meta is on.ukai@chromium.org2009-04-301-0/+18
| | | | | | | | | | | | | | | | | | | | | On Gtk/Linux, it emits key events with ASCII text and ctrl on for ctrl-<x>. In WebKit, EditorClient::handleKeyboardEvent in WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp drops such events. On Mac, it emits key events with ASCII text and meta is on for Command-<x>. These key events should not emit text insert event. Alt key would be used to insert alternative character, so we should let through. Ctrl-Alt combination may equal to AltGr key, which is also used to insert alternative character. In summary, we can't think of a scenario where you'd use control(w/o alt) or meta to do insertion of a ASCII character. BUG=10846,11070,11165 Review URL: http://codereview.chromium.org/99209 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14921 0039d316-1c4b-4281-b951-d872f2087c98
* Fix race where sometimes CSS is not applied to toolstrips. Iaa@chromium.org2009-04-2913-364/+4
| | | | | | | | | | | | | | think this was happening because we were injecting from the the browser at load_start, but the document might not be established in the renderer by the time this message is received. Since we are now not even showing the toolstrip until load_complete, it is no big deal to delay the CSS injection until then. Review URL: http://codereview.chromium.org/100182 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14914 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid invalid read reported by valgrind, http://crbug.com/11132,dkegel@google.com2009-04-291-1/+6
| | | | | | | | when tab->GetActiveEntry() is NULL. Review URL: http://codereview.chromium.org/100172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14913 0039d316-1c4b-4281-b951-d872f2087c98
* Basic fullscreen mode for Linux, without the animated exit bubble.thestig@chromium.org2009-04-296-5/+40
| | | | | | | | | Parts of the code are from ermilov.maxim@gmail.com. Thanks! BUG=8405 Review URL: http://codereview.chromium.org/100106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14912 0039d316-1c4b-4281-b951-d872f2087c98
* Make "Reopen closed tab" be "Reopen closed window" when a window is the top ↵pkasting@chromium.org2009-04-294-43/+68
| | | | | | | | | | item on the closed tabs stack. Original patch by Miranda Callahan (see http://codereview.chromium.org/100054 ), r=me. BUG=11183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14910 0039d316-1c4b-4281-b951-d872f2087c98
* Move simple_clipboard_impl.cc to webkit/tools/test_shell where it belongs.tc@google.com2009-04-296-14/+4
| | | | | | | Review URL: http://codereview.chromium.org/100144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14909 0039d316-1c4b-4281-b951-d872f2087c98
* Linux tests need rebaselining post WebKit Merge 42932:42994playmobil@google.com2009-04-293-2/+12
| | | | | | | | Also rebaseline another SVG test since eseidel says our result looks ok. Review URL: http://codereview.chromium.org/100187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14907 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a new API for launching Chrome at a given size and location. gwilson@google.com2009-04-292-0/+51
| | | | | | | | | | This only works with post-1.0 Chrome, as it refers to the new Window names. R=kuchhal Review URL: http://codereview.chromium.org/101008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14906 0039d316-1c4b-4281-b951-d872f2087c98
* Remove duplicate expectation files found via dedup-tests.py. These tests ↵tc@google.com2009-04-2923-4903/+0
| | | | | | | | | | | still pass on my machine. TBR=evan Review URL: http://codereview.chromium.org/100185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14904 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor ExtensionView to support a UI-less extension instance.mpcomplete@google.com2009-04-2920-238/+529
| | | | | | | | | | | - Introduce ExtensionHost, which is the guy that talks to the RenderViewHost. - ExtensionView holds an ExtensionHost, and also renders its contents in an HWND. - Added code to load a page optionally specified in the manifest as a background process whenever it exists. Review URL: http://codereview.chromium.org/92043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14902 0039d316-1c4b-4281-b951-d872f2087c98
* Migrating the SSL UI tests to be browser tests.jcampan@chromium.org2009-04-298-88/+899
| | | | | | | | | | | | | Reenabling all of them. Hopefully it'll help with flakiness. Note that I am keeping the SSL UI tests alive until the browser test framework has been ported to Mac and Linux. BUG=6584,2136 TEST=Run the browser tests. Review URL: http://codereview.chromium.org/101013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14901 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline svg tests for WebKit Merge 42932:42994playmobil@google.com2009-04-2925-26/+91
| | | | | | Review URL: http://codereview.chromium.org/100181 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14899 0039d316-1c4b-4281-b951-d872f2087c98
* Move window chrome into drag overlay so they stand out more during a drag ↵pinkerton@chromium.org2009-04-292-1/+14
| | | | | | | | out of a window. Review URL: http://codereview.chromium.org/99206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14898 0039d316-1c4b-4281-b951-d872f2087c98
* Upgrading GTest to r243, to include a patch required by the soon to come ↵jcampan@chromium.org2009-04-291-1/+1
| | | | | | | | | | browser tests. BUG=None TEST=make sure all tests (unit-tests, ui-tests...) still work. Review URL: http://codereview.chromium.org/100032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14897 0039d316-1c4b-4281-b951-d872f2087c98
* Move TabsAPI, bookmarks, and buildbot extensiosn into samples/ dir.aa@chromium.org2009-04-2911-1/+0
| | | | | | Review URL: http://codereview.chromium.org/99201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14896 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a DCHECK hit from RefCountedBase class.kuchhal@chromium.org2009-04-291-2/+2
| | | | | | | Review URL: http://codereview.chromium.org/100170 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14894 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SlideAnimatorGtk::OpenWithoutAnimation().estade@chromium.org2009-04-292-9/+36
| | | | | | | | | | We weren't sizing the GtkFixed widget because the animation delegate callbacks weren't being called. Now we artificially call AnimationProgressed() once we know what size the GtkFixed should be. TEST=switching back to a tab that has an infobar open should properly display that infobar. Review URL: http://codereview.chromium.org/99110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14893 0039d316-1c4b-4281-b951-d872f2087c98
* DEFER new tests on Linux & Mac - WebKit Merge 42932:42994playmobil@google.com2009-04-291-4/+7
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14892 0039d316-1c4b-4281-b951-d872f2087c98
* A better fix for http://www.crbug.com/2044: crashsenorblanco@chromium.org2009-04-294-0/+25
| | | | | | | | | | | | | | | | | | | | | | on large <canvas> elements. We disable the __debugbreak only when skia tells us it is prepared to correctly handle a failed (NULL) malloc(). It does this by calling sk_malloc_flags() without SK_MALLOC_THROW. Note that, since the switch to tcmalloc, the new_handler was not getting called at all (since tcmalloc doesn't support it yet), so this crash is currently unreproducible in trunk. In order to test this change, I reverted the tcmalloc change in my client. This is not the case in the stable branch, since it doesn't use tcmalloc, so this change is still needed there. (It will also be needed in trunk again once mbelshe's re-implementation of the new_handler is in). BUG=http://www.crbug.com/2044 Review URL: http://codereview.chromium.org/100163 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14891 0039d316-1c4b-4281-b951-d872f2087c98
* layout tests: more merge fallout.evan@chromium.org2009-04-291-1/+5
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14890 0039d316-1c4b-4281-b951-d872f2087c98
* missing file from last commitestade@chromium.org2009-04-291-1/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14889 0039d316-1c4b-4281-b951-d872f2087c98
* Enable two more installer tests.kuchhal@chromium.org2009-04-291-2/+2
| | | | | | | Review URL: http://codereview.chromium.org/100177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14888 0039d316-1c4b-4281-b951-d872f2087c98
* Second attempt at cleaning up handling of --disable-popup-blocking. I ↵pkasting@chromium.org2009-04-296-45/+37
| | | | | | | | | didn't realize that now window.open() will result in a popup with this flag, where before it resulted in a tab. This necessitated changes to a test that expected one window and two tabs to expect two windows each with one tab. I also fixed the test to not crash when some expectations were not met (by using ASSERT_ instead of EXPECT_), and to properly use (expected, actual) instead of (actual, expected). Review URL: http://codereview.chromium.org/99203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14886 0039d316-1c4b-4281-b951-d872f2087c98
* Linux findbar improvements:estade@chromium.org2009-04-297-74/+110
| | | | | | | | | * clean up toolbar/infobar/findbar borders * move findbar to BrowserWindowGtk's vbox (so it stacks on top of infobar, as on windows) * properly show findbar when switching between tabs Review URL: http://codereview.chromium.org/99166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14885 0039d316-1c4b-4281-b951-d872f2087c98
* Try --force-uninstall param to see if that fixes installer tests.kuchhal@chromium.org2009-04-292-5/+5
| | | | | | | Review URL: http://codereview.chromium.org/99204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14884 0039d316-1c4b-4281-b951-d872f2087c98
* Don't return true from unimplemented X509Certificate::IsEV.ukai@chromium.org2009-04-292-8/+6
| | | | | | | Move linux version of X509Certificate::IsEV in x509certificate_nss.cc git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14883 0039d316-1c4b-4281-b951-d872f2087c98
* This time, really check in new baselines for WebKit merge 42932:42994playmobil@google.com2009-04-2912-0/+78
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14882 0039d316-1c4b-4281-b951-d872f2087c98
* Patch from <yuzo@google.com>:ben@chromium.org2009-04-291-2/+9
| | | | | | | | | | | | | Disable view-source if the page source is not viewable as text. For example, a page of content type application/x-shockwave-flash is not viewable. http://crbug.com/9562 Review URL: http://codereview.chromium.org/66061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14880 0039d316-1c4b-4281-b951-d872f2087c98
* Implement dropping of tabs into an existing tab strip from another window. ↵pinkerton@chromium.org2009-04-296-41/+162
| | | | | | | | Implement dragging and dropping of tabs within a window. Review URL: http://codereview.chromium.org/102010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14879 0039d316-1c4b-4281-b951-d872f2087c98
* Patch by Shinichiro Hamaji <hamaji@google.com>:ben@chromium.org2009-04-295-1/+23
| | | | | | | | | | | | | | | | | | Allow words to be wrapped in message box. We use DT_WORDBREK|DT_EDITCONTROL as the argument of DrawText(). With this option, DrawText() try to wrap texts at word-breaks first, then wraps at non-word-breaks if one line is still too long. This change only affects for Labels in MessageBox. If we can always use this policy, please let me know and I'll fix the code. http://crbug.com/2441 Review URL: http://codereview.chromium.org/100013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14878 0039d316-1c4b-4281-b951-d872f2087c98
* more extensions bookmarks changes:* add schema verification* add unit tests ↵erikkay@google.com2009-04-298-95/+468
| | | | | | | | for schema* add a few new methods (getTree, getChildren)* add events Review URL: http://codereview.chromium.org/102009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14877 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to a raw kAEOpenDocuments AppleEvent handler for opening dropped ↵avi@google.com2009-04-291-5/+33
| | | | | | | | files to avoid crashes when Cocoa feeds us files specified on the command line. Review URL: http://codereview.chromium.org/100142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14876 0039d316-1c4b-4281-b951-d872f2087c98
* Update Test expectations for WebKit Merge 42932:42994playmobil@google.com2009-04-293-22/+24
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14875 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an include that's no longer necessary (constant moved headers).pinkerton@chromium.org2009-04-291-1/+0
| | | | | | Review URL: http://codereview.chromium.org/99200 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14874 0039d316-1c4b-4281-b951-d872f2087c98
* Add descriptive text for omnibox popup result items.ben@chromium.org2009-04-298-40/+103
| | | | | | | | | | | | | | Fixes a couple of bugs in painting and updating: - properly size the canvas we draw the child views into so the bottom pixel doesn't bleed - properly schedule repaints when the presentation changes for the same number of results so that we repaint selection changes. Back to using system colors. Adds highlight icons. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14826 Review URL: http://codereview.chromium.org/99102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14873 0039d316-1c4b-4281-b951-d872f2087c98
* Part 1 of sample sprucing. Also, change chromium_extension.py to generate a ↵aa@chromium.org2009-04-2925-70/+621
| | | | | | | | | | | | | | | | | | | | | | | | | | | random ID if the manifest doesn't have one. * Create a test/data/extensions/samples directory and add Reader and Gmail samples to it. * Minor fixes to buildbot sample to fit better visually. * Minor fixes to bookmarks sample to use new button styles. * Workaround for bug in bookmark sample where extension APIs do not load the first time. * Move Resizer extension into samples/. * Fix TabsAPI sample to not use old deprecated manifest properties anymore. Part 2 will move the remaining samples into samples/ (don't want to do that at the same time because git-cl doesn't know how to tell Rietveld about moves and it would be confusing to review). Review URL: http://codereview.chromium.org/99172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14872 0039d316-1c4b-4281-b951-d872f2087c98
* When doing the scheme check for applying V8 extensions, check against thempcomplete@google.com2009-04-291-3/+6
| | | | | | | | | activeDocumentLoader's url, not the document's current URL. BUG=10924 Review URL: http://codereview.chromium.org/92090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14871 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in dragging tabs. Specifically if you only have one windowsky@chromium.org2009-04-291-1/+1
| | | | | | | | | | | | | | | with one tab, drag the tab, and while dragging click and release the right mouse button we get all confused. This is because we get two OnMousePressed events in a row, which results in cancelling out the current drag which doesn't work well when only one tab with one window is left. BUG=10800 TEST=see bug Review URL: http://codereview.chromium.org/100169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14870 0039d316-1c4b-4281-b951-d872f2087c98
* Close the hovered tab on middle mouse click in the Linux tabstrip.jhawkins@chromium.org2009-04-292-5/+3
| | | | | | | BUG=11146 Review URL: http://codereview.chromium.org/99194 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14869 0039d316-1c4b-4281-b951-d872f2087c98
* Two changes:sky@chromium.org2009-04-2914-44/+52
| | | | | | | | | | | | . Removes MoveToFront on Widget. . CHanges AsWindow to GetWindow. BUG=none TEST=none Review URL: http://codereview.chromium.org/99133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14868 0039d316-1c4b-4281-b951-d872f2087c98
* Update test_expectations post WebKit merge 42932:42994playmobil@google.com2009-04-291-0/+34
| | | | | | Review URL: http://codereview.chromium.org/99198 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14865 0039d316-1c4b-4281-b951-d872f2087c98
* Stop debugger by escape key.sgjesse@chromium.org2009-04-293-3/+16
| | | | | | | | | BUG=6890 Review URL: http://codereview.chromium.org/92116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14862 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome side of WebKit Merge 42932:42994playmobil@google.com2009-04-292-3/+3
| | | | | | Review URL: http://codereview.chromium.org/99193 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14861 0039d316-1c4b-4281-b951-d872f2087c98
* Add new files to the gyp configuration:sgk@google.com2009-04-291-0/+3
| | | | | | | | chrome/browser/bookmarks/bookmark_codec_unittest.cc chrome/common/accessibility_types.h Review URL: http://codereview.chromium.org/100108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14859 0039d316-1c4b-4281-b951-d872f2087c98
* Add two ui_test valgrind suppressions, fix one old onedkegel@google.com2009-04-291-0/+20
| | | | | | Review URL: http://codereview.chromium.org/99169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14858 0039d316-1c4b-4281-b951-d872f2087c98
* layout tests: mark some more failures.evan@chromium.org2009-04-291-0/+5
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14857 0039d316-1c4b-4281-b951-d872f2087c98