| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
and so it doesn't have a hard-coded path to python...
Review URL: http://codereview.chromium.org/159093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The localtime (and localtime_r) functions try to access /etc/localtime
in the filesystem. For sandboxed renderers, this fails, the the
functions default to a UTC timezone.
These functions are called from within WebCore and V8 and there's no
clean way to patch the source code in place to do a hairpin turn and
manage an IPC. Additionally, we cannot overwrite the calls with the
usual symbol resolution procedures since the same chrome binary must
serve as both the unsandboxed browser and sandboxed renderer.
Thus we patch the GOT at runtime if we find, in the zygote process,
that we are sandboxed.
BUG=16800
TEST=Run javascript:alert(new Date().getTimezoneOffset()) in a sandboxed renderer. The resulting timezone offset (in minutes) should be correct for the local timezone.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
that the task manager window is not resized when a page with a long title is viewed.
BUG=17079
TEST=Open the task manager after navigating to a site with a long page title. The task manager window should not resize to fit the title.
Review URL: http://codereview.chromium.org/159081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=13134
TEST=None
Review URL: http://codereview.chromium.org/155609
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(I don't see a call to hide between the first show and the
animation, but this fixes it so it must be getting called...)
http://crbug.com/14062
Review URL: http://codereview.chromium.org/155717
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In r20548, we switched from using a shell script to copy the ffmpeg
binaries to the output directory, to using the GYP 'copies' stanza.
When built using Scons, any copies for which the source file was
missing began to fail.
Since Ubuntu policy (and size considerations) prohibit the shipping of
the binaries in the source packages of chromium-browser, so add a GYP
variable which can be set to inhibit this copying for cases where the
source files aren't included.
http://codereview.chromium.org/155791
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This doesn't actually hold any panels at the moment, just dummy content.
Review URL: http://codereview.chromium.org/155593
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16500
TEST=play youtube in different window. play another video with video tag and mute sound and make sure it does not affect youtube.
Review URL: http://codereview.chromium.org/159092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16579
TEST=watch valgrind ui bots go green
Review URL: http://codereview.chromium.org/159089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=paul
BUG=http://crbug.com/17287
TEST=NONE
Review URL: http://codereview.chromium.org/159090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155729
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
target: xdg-open.
BUG=15342
TEST=Click show in folder for a download, close the file manager that opens up, make sure the xdg-open process eventually gets reaped.
Review URL: http://codereview.chromium.org/149057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
platform resources.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/155784
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sadly there is some really strange voodoo to make it work.
util.js was using document.getElementsByTagName('script')
and it was not returning all the scripts. Lots of dump()
lines later the voodoo of calling
document.getElementsByTagName('script').length (the length
is important) in some place earlier in the code fixes the
issue.
Also, added the copyright to the compiled file
Added parameter docs
Review URL: http://codereview.chromium.org/159049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=16608
Review URL: http://codereview.chromium.org/159080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=paulg
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/159076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155778
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the UI from ever being completely broken.
It's still possible to get a different Chrome language and GTK+
language, but that seems to be true of any GTK+ app.
BUG=16862
Review URL: http://codereview.chromium.org/155776
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
implements maximum failure counts.
R=eroman
TEST=run test_output_formatter.bat
BUG=none
Review URL: http://codereview.chromium.org/159033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Apparently in Windows 7 we need to define supportedOS to make Program
Compatibility Assistant happy (
http://msdn.microsoft.com/en-us/library/dd371711(VS.85).aspx).
BUG=9431
TEST=Install/uninstall Chromium on windows 7 without elevation and UAC enabled and make sure PAC dialog doesn't show up.
Review URL: http://codereview.chromium.org/159045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=17233
Review URL: http://codereview.chromium.org/155770
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155767
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155766
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=15936
Review URL: http://codereview.chromium.org/155765
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149748
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=mirandac
Review URL: http://codereview.chromium.org/155760
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
In r21039, BrowserThemeProvider::Init was made non-virtual, which meant
that GtkBrowserThemeProvider::Init was never being called. Make it virtual
again (so the linux UI renders properly), and explicitly add Init() to the
ThemeProvider interface so this doesn't happen again.
Review URL: http://codereview.chromium.org/155754
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Make sure clicking the lock/warning icon when visiting a HTTPS page brings the page info and that it reports the correct info. Also check that the "Page/Frame info" right click menu works as well.
TBR=ben
Review URL: http://codereview.chromium.org/155753
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests/media/video-src-change.html is crashing as well, not just failing. I have seen it come and go this week.
BUG=16779
TEST=None
TBR=scherkus, hcalm
Review URL: http://codereview.chromium.org/155755
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
fonts. This patch should fix CHECK failures like this:
yusukes@yusukes-desktop:~/chromium2/src/build$ ../sconsbuild/Release/chrome
[20666:20666:544922424350:FATAL:/home/yusukes/chromium2/src/app/gfx/font_skia.cc(90)]
Check failed: tf. Could not find font: IPA モナー Pゴシック
Since some fonts have multiple font family names, the FontConfigDirect::Match()
function should try to compare post_config_family with _all_ family names in the
font, rather than with only the first (usually English) family name. For
example, a popular Japanese font called ipagpmona.ttf has two family names, an
English name and an internationalized (Japanese) one, and post_config_family for
the font can be either the English name or the Japanese name depending on the
situation.
$ showttf /usr/share/fonts/truetype/ttf-ipamonafont/ipagp-mona.ttf | egrep -A 1
-e
"platform=1 .* Family"
platform=1 plat spec encoding=0 language=0 name=1 Family
strlen=14 stroff=288 IPAMonaPGothic
--
platform=1 plat spec encoding=1 language=b name=1 Family
strlen=20 stroff=871 IPA <83><82><83>i<81>[ P<83>S<83>V<83>b<83>N
Original review URL: http://codereview.chromium.org/155751
BUG=12530
TEST=none
Review URL: http://codereview.chromium.org/159061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
9.04 (x86, 32bit).
% hammer --mode=Release
...
Compiling /home/yusukes/chromium2/src/sconsbuild/Release/obj/courgette/adjustment_method_2.o
Linking /home/yusukes/chromium2/src/sconsbuild/Release/startup_tests
cc1plus: warnings being treated as errors
/home/yusukes/chromium2/src/courgette/adjustment_method_2.cc: In constructor 'courgette::adjustment_method_2::ShinglePattern::Index::Index(const courgette::adjustment_method_2::Shingle*)':
/home/yusukes/chromium2/src/courgette/adjustment_method_2.cc:676: error: 'kind' may be used uninitialized in this function
/home/yusukes/chromium2/src/courgette/adjustment_method_2.cc: In constructor 'courgette::adjustment_method_2::ShinglePattern::Index::Index(const courgette::adjustment_method_2::Shingle*)':
/home/yusukes/chromium2/src/courgette/adjustment_method_2.cc:676: error: 'kind' may be used uninitialized in this function
scons: *** [/home/yusukes/chromium2/src/sconsbuild/Release/obj/courgette/adjustment_method_2.o] Error 1
scons: building terminated because of errors
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=17184,17185,17187,17188
TEST=suppresses all warnings in sh tools/valgrind/valgrind_webkit_tests.sh LayoutTests/editing/pasteboard
Review URL: http://codereview.chromium.org/159058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
their own flags. Add the beginnings of StorageNamespaceProxy since it implements WebCore::StorageNamespace::____StorageNamespace and we'd get link errors otherwise.
--enable-local-storage and --enable-session-storage are the new flags. If you enable them and try to use DOM Storage, Chromium will crash.
BUG=4360
TEST=none
Review URL: http://codereview.chromium.org/149792
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Reported by fta.
Review URL: http://codereview.chromium.org/159055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/17170
TBR=paul
Review URL: http://codereview.chromium.org/159053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/17169
TBR=willchan
TEST=SOCKS5 unit test under valgrind.
Review URL: http://codereview.chromium.org/159052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=NONE
BUG=NONE
TBR=jorlow
Review URL: http://codereview.chromium.org/155744
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
created ones.
The advantage is that GURL's parsing of IPv6 addresses works on all systems, whereas getaddrinfo(ipv6_literal) only succeeds on IPv6 enabled systems.
This allows the tests to run consistently on all systems, including our own WinXP buildbots (which do not support IPv6).
BUG=http://crbug.com/16452
TEST=[net_unittests] SOCKS5ClientSocketTest.IPv6Domain, SOCKSClientSocketTest.SOCKS4AIfDomainInIPv6
Review URL: http://codereview.chromium.org/155618
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
tests, which were using caching to get synchronous resolutions.TEST=existingBUG=NONE (addresses a TODO however).
Review URL: http://codereview.chromium.org/155620
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These match the rendering on windows.
(The gradient positioning on js-late-pattern-creation.svg is somewhat questionable, but it matches the windows baseline so no point failing this on linux).
BUG=NONE
TEST=NONE
TBR=paul
Review URL: http://codereview.chromium.org/155743
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
form.
BUG=http://crbug.com
TBR=evan
Review URL: http://codereview.chromium.org/159051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=paul
TEST=NONE
BUG=NONE
Review URL: http://codereview.chromium.org/159043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Stats suggest that optimal boundary for congestion detection
in DNS pre-resolution may be under 1 second. This change
focuses the field trial on that region.
r=willchan
Review URL: http://codereview.chromium.org/155723
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Re-review with Laforge found that three stats were registered, but not
cleared when we create a new version. This CL clears those stats.
I also cleaned a tiny fragment that relates to one stat (moving the
setting of the stat into a conditional... which may make code more
readable).
r=huanr
Review URL: http://codereview.chromium.org/155722
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=16924, 13907
TEST=none
Review URL: http://codereview.chromium.org/149790
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21046 0039d316-1c4b-4281-b951-d872f2087c98
|