| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Switch FYI bot to run non-emulator tests (see related CL to switch over).
BUG=None
TEST=
Review URL: https://chromiumcodereview.appspot.com/9223034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
below the launcher after showing and hiding the non-modal transient.
BUG=none
TEST=open window type launcher, show and then hide a window using the show/hide button, then open a window-modal window. the window modal window would appear rendered behind the type launcher, but if you clicked on where it would have been you can actually move it out from under. this bug makes sure it is always stacked on top visually also.
Review URL: https://chromiumcodereview.appspot.com/9298038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This version supports dumpAsText, dumpChildFramesAsText, waitUntilDone, and
notifyDone
BUG=111316
TEST=run content_shell --dump-render-tree <some layout test that only uses above functions>
Review URL: http://codereview.chromium.org/9121074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9301009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I found a few more spots that need to have their time structuring
updated. Can you review? Thanks much.
R=apatrick@chromium.org
BUG=108171
TEST=
Review URL: http://codereview.chromium.org/9264040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
No longer necessary because cygwin set up is now done in gclient runhooks, rather than every build.
BUG=111731
Review URL: http://codereview.chromium.org/9104016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"init" process.
This process is now resposible for reaping all child processes that no longer have a
direct parent process.
Often, failure to do this goes unnoticed, because our sandbox'd processes don't often
fork other processes that then continue to turn into daemon processes. But there is no
reason, why they couldn't occasionally do so. And in fact, the seccomp sandbox does do
so for its trusted process.
In the past, this would result in us having lots of uncollected zombie processes that
only disappeared when the browser terminated.
BUG=109944
TEST=Run Chrome with both the suid sandbox and the seccomp sandbox, open and close a few tabs, verify that we don't produce any zombie processes
Review URL: https://chromiumcodereview.appspot.com/9295005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes in 10.7.2 cause install-from-.dmg to no longer add a persistent Dock
tile. By leveraging a the same CFURL private undocumented functions that the
Dock does, Chrome can more robustly make sense of the Dock configuration and
insert itself into the plist.
BUG=111979
TEST=1. Remove Google Chrome.app from /Applications and remove its Dock tile
(if any)
2. Mount GoogleChrome.dmg
3. Launch Google Chrome.app from the .dmg
4. Click "install"
Expect the Dock to restart with a persistent tile for Chrome present
(even after quitting Chrome)
Review URL: https://chromiumcodereview.appspot.com/9264046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A few more uses of the old Sleep(int ms) and PostDelayedTask()
interfaces slipped through since my last round of updates. Can you review
these?
R=jar@chromium.org
BUG=108171
TEST=
Review URL: http://codereview.chromium.org/9104014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/9104017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To be removed when r119687 reaches official builds.
BUG=None
TEST=None
TBR=dennisjeffrey@chromium.org
R=dennisjeffrey@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9233037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=screen not messed up after running CrCompileFile from vim in an xterm.
Review URL: https://chromiumcodereview.appspot.com/9232065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=109872
TEST=safe_browsing on Chromium Mac (Valgrind)(1)
Review URL: https://chromiumcodereview.appspot.com/9233036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is needed to autogenerate about:credits correctly.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/9302011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
With r119520, many browser_tests started failing on GYP_DEFINES="use_aura=1 chromeos=1" builds. This works around the problem (cause still unknown).
BUG=111929
TEST=Linux ChromeOS Aura bot goes green
TBR=jamesr
Review URL: https://chromiumcodereview.appspot.com/9264048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The lock screen container needs a layout manager to respond to resolution changes caused by an external monitor being attached or detached. Marking the login screen widget as fullscreen makes it reshape to track the size change.
BUG=110942
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/9121063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The calculation of the inline_autocomplete_offset_ was incorrect. Eliminated unnecessary function parameter.
BUG=110892
TEST=1) Visit an URL such as "www.amazon.com". 2) Now type 'ama' into the omnibox. 3) Verify that the presentation is "ama[zon.com]" where the bracketted section is the to-be-autocompleted portion. Also enhanced the HistoryQuickProviderTest unit tests.
Review URL: https://chromiumcodereview.appspot.com/9298017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/9159035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pending.
This is a speculative fix for bug 105320. The chain of events that could tickle this is:
1. A HttpNetworkTransaction is canceled while a Read is blocked.
2. When the transaction is deleted:
- It calls HttpPipelinedStream::Close(true), which queues tasks to evict the
other streams on the pipeline.
- It deletes the HttpPipelinedStream, which deletes the active
HttpStreamParser.
4. The response has already arrived and is already on the message queue. It
runs and tries to callback to the deleted HttpStreamParser. We likely crash.
5. The eviction tasks run and delete their streams, which allows the
HttpPipelinedConnectionImpl destructor to run, which closes the socket.
BUG=105320
TEST=net_unittests
Review URL: http://codereview.chromium.org/9223033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=yoz
BUG=109939
Review URL: https://chromiumcodereview.appspot.com/9233034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=111752
TEST=See bug.
Review URL: https://chromiumcodereview.appspot.com/9302008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Instead of having clients optionally call Init() (i.e., player_x11, player_wtl) they are forced to pass null callbacks into Start().
Review URL: https://chromiumcodereview.appspot.com/9269022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=98716
TBR=joi
Review URL: https://chromiumcodereview.appspot.com/9159038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous code was buggy in that it would register twice (when --gtest_repeat
was >1) and create an infinite loop inside ffmpeg (with a circular linked
list). IWBN to *un*register the filter in a dtor or TearDownTestCase, but sadly
libavcodec doesn't offer that API. Instead, cheese by storing a bool.
BUG=105236
TEST=CHROME_HEADLESS=1 ./ninja/Debug/media_unittests --gtest_shuffle --gtest_repeat=-1 doesn't hang.
Review URL: https://chromiumcodereview.appspot.com/9223036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
URL than predicted.
I also took the opportunity to align the order of methods in prerender_manager.cc to that of the header (as it should be) and make a couple of methods const.
BUG=110799,111350
Review URL: http://codereview.chromium.org/9226037
TBR=dominich@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9301012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=jhawkins@chromium.org
BUG=110636
TEST=None
Review URL: http://codereview.chromium.org/9121059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rolling this forward to catch the protobuf that I added for doing PowerStatus updates, so that I can write the Chrome side.
BUG=chromium-os:25489
TEST=none
Review URL: http://codereview.chromium.org/9233031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some of the functions mapped take more than 1 argument, and all the others
are currently always undefined. This breaks locking the default search engine
select box through policy.
BUG=None
TEST=When the DefaultSearchProvider policy is set, the settings UI doesn't allow modifying the default.
Review URL: http://codereview.chromium.org/9104011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Aura draws its own frame and shadow for top level windows. We will want to add support for rounded top corners for panels, but for now I think we can live with square corners.
BUG=106076
TEST=Panels on Aura should now have square corners with a standard aura window shadow behind them.
Review URL: http://codereview.chromium.org/9234046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Aura has download shelf on chromeos instead of the downloads panel like the
other boards. Fix automation.
BUG=chromium-os:23648
TEST=pyauto downloads tests fixed on chromeos aura builds
Review URL: https://chromiumcodereview.appspot.com/9225017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Limiting the width of panels is affecting the behavior of some existing panels on ChromeOS device sized screens.
BUG=111121
TEST=See issue
Review URL: http://codereview.chromium.org/9288048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Various places in the code use NOTIMPLEMENTED() with << "message" like
the other logging macros; this doesn't work when NOTIMPLEMENTED expands
to a semicolon. Expand it to EAT_STREAM_PARAMETERS instead so any
parameters are simply compiled away in this case.
Review URL: http://codereview.chromium.org/9244006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=111731
Review URL: https://chromiumcodereview.appspot.com/9223028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a policy specifies the HomepageLocation, the text field shouldn't be
editable when the user chooses the 2nd radio button.
BUG=None
TEST=Set the HomepageLocation policy to some value. The text field in the homepage UI can't be edited.
Review URL: http://codereview.chromium.org/9302005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
r909: Change some functions in linux_libc_support.h to use intmax_t instead of int.
r908: Fix test addresses to use uintptr_t instead of u_int64_t.
Review URL: https://chromiumcodereview.appspot.com/9298030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
iteration.
The pyauto performance tests that iteratively take performance measurements
now output the perf measurements on-the-fly as each measurement is taken,
thereby ensuring that the (pyauto generated) timestamps printed next to
each measured performance value is accurate in terms of when the measurement
was taken.
This CL also removes the arbitrary limit of 2 decimal places for measured
performance values.
BUG=chromium-os:25456
TEST=Ran the perf tests on my local alex device.
Review URL: https://chromiumcodereview.appspot.com/9297042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-got rid of JavaScriptDialogDelegate since the embedder really only needs to know one callback to give the results to content
-for telling it that the dialog is shown, it seemed that chrome's decision to activate the tab would be in chrome
-used WebContents as the token for resetting dialogs if their tab went away
-used currying to hide the implementation detail of reply_msg from the embedder
-made content handle NULL JS dialog creator interface instead of having a stub one in the public directory
BUG=098716
Review URL: https://chromiumcodereview.appspot.com/9159033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=111861
TEST=build with the 10.6 sdk
TBR=bauerb
Review URL: https://chromiumcodereview.appspot.com/9293009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=104981
TEST=see bug
TBR=ben
Review URL: https://chromiumcodereview.appspot.com/9296040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These were causing some compiles to hang.
BUG=111208
TEST=Compilation terminates.
Review URL: https://chromiumcodereview.appspot.com/9169090
TBR=rsleevi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9303004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I also took the opportunity to align the order of methods in prerender_manager.cc to that of the header (as it should be) and make a couple of methods const.
BUG=110799,111350
Review URL: http://codereview.chromium.org/9226037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Neon optimization
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9290067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=94925
TBR=cmp
Review URL: https://chromiumcodereview.appspot.com/9293013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119693 0039d316-1c4b-4281-b951-d872f2087c98
|