summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Bookmark bar menu/folder button text is left-aligned, not centered.jrg@chromium.org2010-03-124-24/+96
| | | | | | | | | | | | | | | | | | | | | | | | Bookmark bar menu/folder maximum window width is now 1000, not 150. High cosmetic impact. BUG=36487, 17608 TEST=\ 1) Add bookmarks on the bar with small (e.g. 'x') and big titles. Make sure all looks OK (e.g. small ones are small.) 2) Add bookmarks in a folder. Make sure text is left aligned on the menus. 3) Add bookmarks in a folder with long names (e.g. 100 characters). Make sure folder/menus are now much wider. 4) Add bookmarks in a folder with mega long names (e.g. 4000 characters). Make sure menus have a maximum size of ~1000 pixes (no need to be exact but 'no limit' is fail). 5) In a folder, add a subfolder named 'x' and a bookmark with a REAL long name. Make sure the "button" (menu item) is the full width of the menu. Review URL: http://codereview.chromium.org/842005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41387 0039d316-1c4b-4281-b951-d872f2087c98
* Removed custom FFmpegLock. Removed ffmpeg headers from ↵scherkus@chromium.org2010-03-1234-7312/+69
| | | | | | | | | | | | | third_party/ffmpeg/include. Patch by sergeyu@chromium.org BUG=23271 TEST=none Review URL: http://codereview.chromium.org/909002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41386 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark manager: Make sure we open the tabbed bookmark manager in a non OTR ↵arv@chromium.org2010-03-122-5/+22
| | | | | | | | | | | window. BUG=38008 TEST=Press Ctrl+Shift+B when in an incognito window Review URL: http://codereview.chromium.org/909001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41385 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup.mrossetti@chromium.org2010-03-123-5/+3
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/905001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41384 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a hack that, as far as I can tell, isn't needed.pkasting@chromium.org2010-03-121-5/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/871005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41383 0039d316-1c4b-4281-b951-d872f2087c98
* Last set of tweaks to icon positioning code. Clarifies positioning ↵pkasting@chromium.org2010-03-124-131/+86
| | | | | | | | | | algorithm, and for non-Windows, modifies sizing algorithm to just make the icon size be the same as the titlebar font size, minimum 16 px, since the old crazy code just seemed wrong. BUG=none TEST=none Review URL: http://codereview.chromium.org/807001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41382 0039d316-1c4b-4281-b951-d872f2087c98
* New expand icons. Need to add them separately so try on the main CL would ↵georgey@chromium.org2010-03-122-0/+0
| | | | | | | | | | run successfully. BUG=36601 TEST=none Review URL: http://codereview.chromium.org/873005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41381 0039d316-1c4b-4281-b951-d872f2087c98
* extensions: Internationalize error code messages.aa@chromium.org2010-03-122-15/+71
| | | | | | | | | | BUG=23086 TEST=see bug Review URL: http://codereview.chromium.org/682001 Patch from Thiago Farina <thiago.farina@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41380 0039d316-1c4b-4281-b951-d872f2087c98
* Make notifications from extension URLs use extension process.aa@chromium.org2010-03-122-2/+25
| | | | | | | | | | Future changes will hook up extension APIs and add testing. BUG=27247 Review URL: http://codereview.chromium.org/868001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41378 0039d316-1c4b-4281-b951-d872f2087c98
* Flakiness dashboard: use startsWith rather than contains to match ↵jparent@chromium.org2010-03-121-1/+1
| | | | | | | | | | | | | | expectation to test name. Dashboard was incorrectly matching a line like BUGFOO LINUX : media = PASS FAIL TIMEOUT with any test with the substring 'media' in it, like "fast/repaint/intermediate-layout-position-clip.html". TEST=none BUG=none Review URL: http://codereview.chromium.org/848007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41377 0039d316-1c4b-4281-b951-d872f2087c98
* Test expectations cleanup: linux debug.jparent@chromium.org2010-03-121-10/+1
| | | | | | | | | | | | Removes test from expectations that have passed for the last 750 runs. Update fast/frames/frame-set-same-src.html expectation for all platforms. BUG=25955,9798,26045,32683 TEST=none Review URL: http://codereview.chromium.org/907001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41376 0039d316-1c4b-4281-b951-d872f2087c98
* Updates wm_ipc to be in sync with chrome os.sky@chromium.org2010-03-121-0/+55
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/877002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41375 0039d316-1c4b-4281-b951-d872f2087c98
* Nothing had the focus by default in the "Clear browsing data"jcampan@chromium.org2010-03-122-0/+5
| | | | | | | | | | | | dialog. Making the Close button the default focused view. BUG=33942 TEST=Open the "Clear browsing data" dialog. The close button should be focused. Review URL: http://codereview.chromium.org/778004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41374 0039d316-1c4b-4281-b951-d872f2087c98
* Take 2: make bubble more tolerant of notification order when quitting.jrg@chromium.org2010-03-121-0/+12
| | | | | | | | | | | | | | | | BUG=37807 TEST=\ Run a debug build of Chrome like this: NSZombieEnabled=YES xcodebuild/Debug/Chromium.app/Contents/MacOS/Chromium Open a bubble then Cmd-Q. Make sure you don't see a line like this: 2010-03-10 19:24:20.381 Chromium[73024:903] *** -[ChromeBrowserWindow removeChildWindow:]: message sent to deallocated instance 0x18f8b2a0 Repeat 20 times. Review URL: http://codereview.chromium.org/851005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41373 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: more browser action toolbar functionality. estade@chromium.org2010-03-125-38/+207
| | | | | | | | | | | | | | | | - Resize smartly after dragging (animate to the "right" size) - Add the overflow menu (it is clickable, but you can't drag to/from it) - Resize appropriately after adding/removing buttons still TODO: - persist the #icons that are visible BUG=32101 TEST=manual Review URL: http://codereview.chromium.org/897001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41372 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Pass --user-data-dir to the Zygote.thestig@chromium.org2010-03-121-0/+6
| | | | | | | | BUG=none TEST=On Linux, "chrome --enable-logging --user-data-dir=/tmp/foobar" writes renderer logs to chrome_debug.log in /tmp/foobar rather than in $XDG_CONFIG_HOME. Review URL: http://codereview.chromium.org/885003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41369 0039d316-1c4b-4281-b951-d872f2087c98
* This DCHECK occurs when an installed extension that declares the ↵aa@chromium.org2010-03-123-7/+28
| | | | | | | | notification permission is loaded. Review URL: http://codereview.chromium.org/842002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41368 0039d316-1c4b-4281-b951-d872f2087c98
* Heuristically avoid reporting crashes during DLL loading.siggi@chromium.org2010-03-125-18/+117
| | | | | | | | | | | Cleanup white space as requested by Robert in CL 882001. BUG=31980 TEST=Unittests in this change. Review URL: http://codereview.chromium.org/872004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41367 0039d316-1c4b-4281-b951-d872f2087c98
* Fix up baseline oopses made by rebaselining tool.dglazkov@chromium.org2010-03-1210-130/+92
| | | | | | | | | | TBR=japhet TEST=none BUG=none Review URL: http://codereview.chromium.org/861005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41366 0039d316-1c4b-4281-b951-d872f2087c98
* autofill: Tweak the heuristic matching to lower-case form field labels and ↵jhawkins@chromium.org2010-03-122-4/+12
| | | | | | | | | | names. This is a stop-gap until a fix is made for WebKit. Add another variation of middle initial. BUG=37988 TEST=See repro steps in the bug. Review URL: http://codereview.chromium.org/904001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41364 0039d316-1c4b-4281-b951-d872f2087c98
* Grab expectations from the builder that tends to be the fastest, Linux Release.jparent@chromium.org2010-03-121-2/+3
| | | | | | | | | | | | | This makes the dashboard up to date more quickly. Currently is grabbing from Mac debug 3, since it was last in the builders array. TEST=none BUG=none Review URL: http://codereview.chromium.org/861004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41363 0039d316-1c4b-4281-b951-d872f2087c98
* Open tabbed bookmark manager from menus as well.arv@chromium.org2010-03-123-1/+22
| | | | | | | | | | | This is the Mac part of issue 826002. BUG=37372 TEST=Start chrome with --enable-tabbed-bookmark-manage and open the BMM from the app menu, as well as bookmark bar context menu etc. All entries should take you to the tabbed bookmark manager. Review URL: http://codereview.chromium.org/871003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41361 0039d316-1c4b-4281-b951-d872f2087c98
* Only create bookmark bar buttons that we need, not "for all".jrg@chromium.org2010-03-123-58/+108
| | | | | | | | | | | | | | | | | | | | Create the "off the side" menu on demand (since that has "all the rest" in it). BUG= http://crbug.com/32843 TEST=1) Do the "sync 1000+ bookmarks" test from the bug and watch Chrome NOT run out of memory. Make sure these bookmarks are all children of the bar for it to be even harder. 2) Add about 5 bookmarks. Make sure you can grow and shrink (in width) the window to cause the off-the-side chevron to appear and disappear as appropriate, and that the off-the-side menu always has the right contents (bookmarks which fall off the side). 3) Change theme then relaunch; make sure theme set on launch for bookmarks. 4) Using both a big and a small width, make sure the chevron shows (or not, as appropriate) on launch of Chrome. Review URL: http://codereview.chromium.org/853001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41359 0039d316-1c4b-4281-b951-d872f2087c98
* Move MacGPUPluginContainer from src/webkit/ to src/chrome/. Ittony@chromium.org2010-03-127-18/+17
| | | | | | | | | | | was including files from chrome and only used in chrome/browser/renderer_host, so it should live in src/chrome/. TEST=compiles Review URL: http://codereview.chromium.org/852001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41357 0039d316-1c4b-4281-b951-d872f2087c98
* Make all entry points to opening the bookmark manager go through ↵arv@chromium.org2010-03-122-2/+18
| | | | | | | | | | | | | Browser::ShowBookmarkManager. This covers views and gtk. BUG=37372 TEST=None Review URL: http://codereview.chromium.org/826002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41356 0039d316-1c4b-4281-b951-d872f2087c98
* Move Java tests into their own bug and defer them.dglazkov@chromium.org2010-03-111-8/+2
| | | | | | | | | | TBR=vitalyr TEST=none BUG=36681 Review URL: http://codereview.chromium.org/901001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41355 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bad test_expecations.txt entry.japhet@chromium.org2010-03-111-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=jianli git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41354 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a new unit-test that ensures we are showing ajcampan@chromium.org2010-03-111-0/+71
| | | | | | | | | | | | translate info-bar for all supported languages, as they are reported by the CLD. BUG=None TEST=Run the unit-test. Review URL: http://codereview.chromium.org/856001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41352 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 41342 - Make bubble more tolerant of notification order when quitting.jrg@chromium.org2010-03-111-9/+0
| | | | | | | | | | | | | | | | | | | | BUG=http://crbug.com/37807 TEST=\ Run a debug build of Chrome like this: NSZombieEnabled=YES xcodebuild/Debug/Chromium.app/Contents/MacOS/Chromium Open a bubble then CmdQ. Make sure you don't see a line like this: 20100310 19:24:20.381 Chromium[73024:903] *** [ChromeBrowserWindow removeChildWindow:]: message sent to deallocated instance 0x18f8b2a0 Repeat 20 times. Review URL: http://codereview.chromium.org/839003 TBR=jrg@chromium.org Review URL: http://codereview.chromium.org/902001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41350 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a delete test from test_expectations.txtjaphet@chromium.org2010-03-111-4/+0
| | | | | | | | | | BUG=none TEST=make the webkit bots not hurt TBR=jianli git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41349 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for running NaCl-Chrome integration tests on Win64gregoryd@google.com2010-03-113-3/+26
| | | | | | | | BUG=28176 TEST=this change Review URL: http://codereview.chromium.org/791002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41348 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolute password_dialog_view.chocobo@chromium.org2010-03-114-137/+0
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/883002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41347 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show enable/disable network menu items on login.chocobo@chromium.org2010-03-111-18/+18
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/847003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41346 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Properly cleans up any open info bubble popup windows upon app shutdown.andybons@chromium.org2010-03-112-11/+42
| | | | | | | | BUG=37717 TEST=none Review URL: http://codereview.chromium.org/863005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41345 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline tests whose expectations have changed after new googleurl was ↵dglazkov@chromium.org2010-03-114-11/+8
| | | | | | | | | | | | pulled in. TBR=brettw TEST=none BUG=33038 Review URL: http://codereview.chromium.org/855004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41344 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some issues with text size calculation and message boxes.pkasting@chromium.org2010-03-112-60/+59
| | | | | | | | | | | | | | First, size calculations for multi-line, character-breaking strings with no prespecified width were returning useless values, and when given pathological input, could take extremely long time. Second, the flag calculations for text layout were a bit odd. For example, we wouldn't add an ending ellipsis on elided text if it was multi-line, and we wouldn't add an ellipsis on a clipped word if character breaking was off. Fixed these and reordered the calculations to match the order in which the header declares the flags. Third, message boxes shouldn't need to trim their inputs, or add an ellipsis character, as both of these should now be handled safely by the underlying code. BUG=34721 TEST=alert("AAAAA") for strings of As that are, say, 4000 characters long should not cause the UI to hang up for noticeable lengths of time Review URL: http://codereview.chromium.org/810003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41343 0039d316-1c4b-4281-b951-d872f2087c98
* Make bubble more tolerant of notification order when quitting.jrg@chromium.org2010-03-111-0/+9
| | | | | | | | | | | | | | | | | BUG=http://crbug.com/37807 TEST=\ Run a debug build of Chrome like this: NSZombieEnabled=YES xcodebuild/Debug/Chromium.app/Contents/MacOS/Chromium Open a bubble then Cmd-Q. Make sure you don't see a line like this: 2010-03-10 19:24:20.381 Chromium[73024:903] *** -[ChromeBrowserWindow removeChildWindow:]: message sent to deallocated instance 0x18f8b2a0 Repeat 20 times. Review URL: http://codereview.chromium.org/839003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41342 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Move chrome/common/gtk_signal.h to app/ so views-gtk can use it.erg@google.com2010-03-1120-21/+23
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/856003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41341 0039d316-1c4b-4281-b951-d872f2087c98
* Fix "drag cancel" semantics.jrg@chromium.org2010-03-111-9/+7
| | | | | | | | | | | | | | BUG=37967 TEST=\ 1) make sure bookmark buttons still work (click to open) 2) make sure basic DnD of bookmark buttons still works 3) In Debug build, drag a bookmark button. ESC to cancel. Then mouse up. Make sure no crash. Review URL: http://codereview.chromium.org/871002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41340 0039d316-1c4b-4281-b951-d872f2087c98
* Make the suppressions work also on 64bit platform.nsylvain@chromium.org2010-03-111-2/+29
| | | | | | Review URL: http://codereview.chromium.org/871004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41338 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit merge 55822:55853japhet@chromium.org2010-03-117-32/+4
| | | | | | | | | | BUG=none TEST=none TBR=jianli Review URL: http://codereview.chromium.org/892001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41337 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Improve window look from "completely broken" to "pretty broken" when RI ↵thakis@chromium.org2010-03-111-1/+2
| | | | | | | | | | | | | | | | | is enabled. From http://developer.apple.com/mac/library/DOCUMENTATION/UserExperience/Conceptual/HiDPIOverview/HiDPISupport/HiDPISupport.html: "Because of scaling, the coordinates of the window frame and its top-level view (the frame view) are not always the same. [...] These methods provide the means to transform geometry to and from a base coordinate space that is pixel-aligned with the backing store into which the view is being drawn." Stuff is still pretty broken with this patch (it used to be better), but it's a low-hanging fruit. BUG=19476 TEST=Open QuartzDebug, set scale factor to e.g. 1.5. Reopen Chrome. Tabs should be visible. Review URL: http://codereview.chromium.org/893001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41336 0039d316-1c4b-4281-b951-d872f2087c98
* When linking to webkit blamelists from the flakiness dashboard, link to page ↵jparent@chromium.org2010-03-111-1/+2
| | | | | | | | | | | | with full log messages. TEST=none BUG=none Review URL: http://codereview.chromium.org/866006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41335 0039d316-1c4b-4281-b951-d872f2087c98
* Mark spatial navigation layout tests as WontFix.dglazkov@chromium.org2010-03-111-12/+2
| | | | | | | | | | | TBR=michaeln TEST=none BUG=37735 Review URL: http://codereview.chromium.org/842003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41333 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Implement translate toolbar. Tested on spiegel.de, www.lemonde.fr and ↵erg@google.com2010-03-1111-22/+570
| | | | | | | | | | | mainichi.jp (from an English profile). BUG=36714,37528 TEST=Open up a page that's not in your current language. You should be presented with a toolbar offering to apply Google Translate to the page. Review URL: http://codereview.chromium.org/830005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41332 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill field parser fixes.dhollowa@chromium.org2010-03-119-30/+501
| | | | | | | | | | | This fixes a number of form field parsing issues. Ecml field name matching. Adds country field parsing. Adds state field parsing. Multi-line address parsing. Fixes issue with empty field names confusing the parser. Fixes issue with phone field parsing. Adds unit tests in form_structure_unittest.cc to verify parsing order issues. Adds new unit tests address_field_unittest.cc that cover parsing of each address component as well as Ecml variants. BUG=37776 TEST=FormStructureTest.Heuristics:AddressFieldTest.*, as well as manual steps described in bug report. Review URL: http://codereview.chromium.org/867003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41331 0039d316-1c4b-4281-b951-d872f2087c98
* test_expectations cleanup Linux release: update expectations to have no ↵jparent@chromium.org2010-03-111-28/+19
| | | | | | | | | | | | | | | extra entries. Removes all tests that are in expectations but have passed last 750 runs. Updates expectations to match tigher for tests that have not failed linux release in last 750 runs. TEST=none BUG=18584,37962,37896,2844,9798,35858,29737,30930,29737,14009 Review URL: http://codereview.chromium.org/844005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41330 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 41230 - gtk: Notify the TabContents when the browser window has been ↵chase@chromium.org2010-03-111-6/+0
| | | | | | | | | | | moved or resized. This is used to close the AutoFill popup in the renderer. BUG=31865 TEST=none TBR=jhawkins@chromium.org Review URL: http://codereview.chromium.org/878003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41329 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 41316 - gtk: Only notify the TabContents that the browser window has ↵chase@chromium.org2010-03-111-10/+5
| | | | | | | | | | | moved or resized if the window has actually moved or resized. This fixes a ~20ms startup performance regression. BUG=37975 TEST=none TBR=jhawkins@chromium.org Review URL: http://codereview.chromium.org/868002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41328 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Do not hide the menubar if going fullscreen on a secondary monitor.rohitrao@chromium.org2010-03-112-11/+20
| | | | | | | | BUG=37989 TEST=Go fullscreen on a secondary monitor. Should not hide the menubar. Review URL: http://codereview.chromium.org/872003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41327 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-18 05:41:00 +0000