summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* [Mac] Convert Omnibox paste-and-go to use AutocompleteTextFieldObserver.shess@chromium.org2009-09-239-75/+88
| | | | | | | | | | Obvious result of Rohit's addition of paste-and-go and my refactor to add AutocompleteTextFieldObserver. Bonus prize of unit tests for cocoa/ part of Rohit's change. Review URL: http://codereview.chromium.org/207047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26993 0039d316-1c4b-4281-b951-d872f2087c98
* Add more view ids and gtk widget names to so gtkparasite istony@chromium.org2009-09-2312-1/+34
| | | | | | | | easier to navigate. Review URL: http://codereview.chromium.org/221001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26992 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an off by 1 error in the Linux Breakpad guid.thestig@chromium.org2009-09-232-1/+4
| | | | | | | | BUG=22067 TEST=No more random strings in crash client GUIDs. Review URL: http://codereview.chromium.org/213038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26991 0039d316-1c4b-4281-b951-d872f2087c98
* (More) Copyright housecleaning (i missed one before).michaeln@google.com2009-09-231-1/+1
| | | | | | | | | | TBR=jennb BUG=none TEST=none Review URL: http://codereview.chromium.org/222012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26990 0039d316-1c4b-4281-b951-d872f2087c98
* Add LayoutTests/editing/pasteboard/subframe-dragndrop-1.html jshin@chromium.org2009-09-231-2/+2
| | | | | | | | | | | and LayoutTests/http/tests/misc/BOM-override-script.html on Mac to the flaky test list BUG=9797,9798 TEST=Webkit test passes reliably on Mac. TBR=mark Review URL: http://codereview.chromium.org/224008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26989 0039d316-1c4b-4281-b951-d872f2087c98
* Remove --smc-check=all option for Valgrind.timurrrr@chromium.org2009-09-231-1/+0
| | | | | | | | | | This should be OK since http://src.chromium.org/viewvc/chrome?view=rev&revision=23306 This can speed up some tests by 10%...20% I was running Valgrind & TSAN with both patches locally for more than a month and everything was fine. Review URL: http://codereview.chromium.org/220013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26988 0039d316-1c4b-4281-b951-d872f2087c98
* Copyright housecleaningmichaeln@google.com2009-09-237-7/+7
| | | | | | | | | | TBR=jennb BUG=none TEST=none Review URL: http://codereview.chromium.org/218008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26987 0039d316-1c4b-4281-b951-d872f2087c98
* Update documentation on how to merge in new SQLite versions. No code change.mdm@chromium.org2009-09-234-87/+835
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/209058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26986 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize target_message_loop_ in the constructor.jhawkins@chromium.org2009-09-231-1/+2
| | | | | | | | | CID=3970 BUG=none TEST=none Review URL: http://codereview.chromium.org/233001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26985 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize the remaining DropInfo members in the constructor.jhawkins@chromium.org2009-09-231-4/+17
| | | | | | | | | CID=4402 BUG=none TEST=none Review URL: http://codereview.chromium.org/227007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26984 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Add a SavePackageType, SAVE_TYPE_UNKNOWN, which represents the ↵jhawkins@chromium.org2009-09-232-2/+6
| | | | | | | | | | | state of the save type before the user has selected a save type. Initialize save_type_ to this value in the constructor. CID=3809 BUG=none TEST=none Review URL: http://codereview.chromium.org/220016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26983 0039d316-1c4b-4281-b951-d872f2087c98
* Add a very basic test for FTP directory listing, browser side.phajdan.jr@chromium.org2009-09-232-0/+24
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/220015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26982 0039d316-1c4b-4281-b951-d872f2087c98
* Gather more info when AutocompleteBrowserTest flakily fails.phajdan.jr@chromium.org2009-09-231-2/+18
| | | | | | | | | | | | It's most probably a bug in the code being tested, or a bad assumption in the test. TEST=none BUG=19876 Review URL: http://codereview.chromium.org/233002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26981 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 26975.pkasting@chromium.org2009-09-2336-1079/+1186
| | | | | | Review URL: http://codereview.chromium.org/222011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26979 0039d316-1c4b-4281-b951-d872f2087c98
* Update .gitignore to exclude generated files on Windows, as well as ↵nick@chromium.org2009-09-231-0/+8
| | | | | | | | | | | | | | | | | | | | Windows-only DEPS inclusions. Is this safe, given the vcproj files that are in the repository? I believe so. The gitignore documentation states: "Note that all the gitignore files really concern only files that are not already tracked by git; in order to ignore uncommitted changes in already tracked files, please refer to the git update-index --assume-unchanged documentation." TEST=ran "git status" on Windows, saw no generated files BUG=none Review URL: http://codereview.chromium.org/219004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26978 0039d316-1c4b-4281-b951-d872f2087c98
* Effective TLD: sync with upstreamagl@chromium.org2009-09-232-77/+90
| | | | | | | | | | This patch sync's us with Mozilla's upstream version of the eTLD list. BUG=19957 TEST=Enter test.local into the omnibar. The default action should be to load http://test.local, just like test.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26976 0039d316-1c4b-4281-b951-d872f2087c98
* Move functions from skia/ext to app/gfx where possible: most of skia_utils.* ↵pkasting@chromium.org2009-09-2336-1186/+1079
| | | | | | | | | | | | and image_operations.* can be moved because they are not used by WebKit code. This also fixes the spelling of "Convolusion" to "Convolution" and updates some copyrights. BUG=none TEST=none Review URL: http://codereview.chromium.org/207059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26975 0039d316-1c4b-4281-b951-d872f2087c98
* A small fix to Valgrind fork patchtimurrrr@chromium.org2009-09-231-16/+32
| | | | | | | BUG=22563 Review URL: http://codereview.chromium.org/229001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26974 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: create dropped tab windows at the restore size of the source window ↵mdm@chromium.org2009-09-234-12/+13
| | | | | | | | | | | instead of its current size (different when the source is maximized) BUG=22154 TEST=open a window with two tabs, maximize it, then drag one tab out - it should be the original size of the original window Review URL: http://codereview.chromium.org/216053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26972 0039d316-1c4b-4281-b951-d872f2087c98
* Fix perfcoldcomplextheme startup test for mac and linux.mirandac@chromium.org2009-09-231-6/+6
| | | | | | | | BUG= http://crbug.com/22801 TEST= none Review URL: http://codereview.chromium.org/218006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26971 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit update 48665:48679dglazkov@chromium.org2009-09-232-1/+5
| | | | | | | | | | | | Failures are rebaselines. R=levin TEST=none BUG=none Review URL: http://codereview.chromium.org/232004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26970 0039d316-1c4b-4281-b951-d872f2087c98
* Move OCMock from third_party/ocmock to third_party/ocmock/OCMockmark@chromium.org2009-09-2360-1/+1
| | | | | | | | | | | | | | | | | | | | "...may be suffering from what we in the soft sciences call 'Obsessive Compulsive Disorder,' or the 'The O.C. Disorder.'" Here's what we're doing: mkdir OCMock svn add OCMock for i in * ; do if [ "${i}" != "OCMock" ] && [ "${i}" != "README.chromium" ] ; then svn move "${i}" OCMock fi done and make the SVN URL in README.chromium a tiny bit more specific. Review URL: http://codereview.chromium.org/220017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26969 0039d316-1c4b-4281-b951-d872f2087c98
* Fix and reenable AppendRelativePathTest which was broken on Windows.mark@chromium.org2009-09-231-3/+13
| | | | | | | | | Patch by Fred Akalin <akalin@gmail.com> Review URL: http://codereview.chromium.org/205023 Review URL: http://codereview.chromium.org/209070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26968 0039d316-1c4b-4281-b951-d872f2087c98
* Make valgrind.sh and chrome_tests.sh actually find valgrind-10880-redzonedkegel@google.com2009-09-232-6/+5
| | | | | | | | | (oops) Also say which valgrind is being used Review URL: http://codereview.chromium.org/233003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26967 0039d316-1c4b-4281-b951-d872f2087c98
* Move some more methods from WebViewDelegate to WebViewClient.darin@chromium.org2009-09-239-96/+83
| | | | | | | | | | | | | This CL also removes two unnecessary methods on WebViewDelegate: UserMetricsRecordAction and ShowSpellingUI were both never called. R=dglazkov BUG=10033 TEST=none Review URL: http://codereview.chromium.org/227006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26965 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Make about:memory not crash.shess@chromium.org2009-09-231-0/+1
| | | | | | | | | | | | | | http://codereview.chromium.org/177024 enabled about:memory for Linux, but it went from not-implemented to crashing for Mac, due to an out-of-bounds vector access. This returns it to simply not-implemented. http://crbug.com/21830 TEST=Browse to about:memory, don't crash, show a template with obviously null data in it. Review URL: http://codereview.chromium.org/219008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26964 0039d316-1c4b-4281-b951-d872f2087c98
* removing unnecessary invocations of super class constructoroshima@chromium.org2009-09-232-4/+2
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/220012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26963 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "GTK: Use rounded corners in AutocompletePopupViewGtk."erg@google.com2009-09-231-11/+25
| | | | | | | | | | | | | | | This mostly reverts commit e461ca0cebce93375b81a14af7caf5d95a10158c (r25080) and adds a comment about why I reverted it. This breaks on NX, probably because we're shaping a toplevel window from within the expose event. I don't see a different point when we can shape the window reliably (configure-event doesn't appear to work), so just revert rounded corners on the popup for now. BUG=22015 Review URL: http://codereview.chromium.org/224004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26962 0039d316-1c4b-4281-b951-d872f2087c98
* Update more context menus to title casethomasvl@chromium.org2009-09-231-139/+297
| | | | | | | | | | | | | | - tab menus - page and tool menus - menubar sub menus TEST=the above menus should show up in Title case on Mac/GTK. these are new strings, so they will need new translations for the languages. BUG=22254 BUG=22255 BUG=22256 Review URL: http://codereview.chromium.org/214056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26961 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize ssl_cert_id_, ssl_cert_status_, and ssl_security_bits_ ↵jhawkins@chromium.org2009-09-232-1/+6
| | | | | | | | | | | in the constructor. CID=5442 BUG=none TEST=none Review URL: http://codereview.chromium.org/222008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26960 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert "Add back ctrl+shift+delete for bringing up the "Clear ↵tony@chromium.org2009-09-231-0/+2
| | | | | | | | | | | | | | | browsing data""" This reverts commit r26956 and re-applies the keyboard bindings for clearing browsing data. _ph says that the test is just flaky. TBR=estade Review URL: http://codereview.chromium.org/232005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26959 0039d316-1c4b-4281-b951-d872f2087c98
* Add icon support to gtk menu items.chocobo@google.com2009-09-231-4/+16
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/227005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26958 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Linux (nss) implementations of RSAPrivateKey and SignatureCreator"rafaelw@chromium.org2009-09-236-337/+13
| | | | | | | | | | This reverts commit 4e0de697be80a0a91fbcceda63d3c85055f1afcc. TBR=davemoore Review URL: http://codereview.chromium.org/219013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26957 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add back ctrl+shift+delete for bringing up the "Clear browsing data""tony@chromium.org2009-09-231-2/+0
| | | | | | | | | | This reverts commit r26947. TBR=estade Review URL: http://codereview.chromium.org/225015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26956 0039d316-1c4b-4281-b951-d872f2087c98
* Be sure to initialize AppCacheDispatcherHost on the IO thread.michaeln@google.com2009-09-231-1/+5
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/221002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26955 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize statement_cache_ in the constructor.jhawkins@chromium.org2009-09-231-0/+1
| | | | | | | | | CID=5040 BUG=none TEST=none Review URL: http://codereview.chromium.org/225013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26954 0039d316-1c4b-4281-b951-d872f2087c98
* There is a race condition when the HtmlDialogView is closed which causes a ↵ananta@chromium.org2009-09-231-9/+25
| | | | | | | | | | | | | | | | | | | | | | | | crash while dereferencing an invalid delegate_ (HtmlDialogUIDelegate*) member. I could not reproduce this consistently though. The inference is as below:- 1. When the dialog is closed the HtmlDialogView::OnDialogClosed member function is invoked which calls the OnDialogClosed function on the delegate. This in turn causes the delegate to be destroyed. 2. It then sets the delegate to NULL and attempts to close the window. 3. Before the Close method is dispatched if the view attempts to Paint it causes a crash in the HtmlDialogView::GetWindowTitle function because of dereferencing a NULL delegate_. Fix is to add corresponding NULL checks in the relevant functions. This fixes http://b/issue?id=2138035, which was reported with ChromeFrame. Bug=2138035 Review URL: http://codereview.chromium.org/220011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26953 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for a focus related NOTREACHED when closing Chromejcampan@chromium.org2009-09-231-4/+9
| | | | | | | | | | | | | | | | | A focus related asserion was hit when closing Chrome. It was caused by the top level widget being destroyed and deleting itself before its children. When deleted it would delete the focus manager without giving child widgets a chance to remove focus change listener causing the assert. We now delay the deletion of the WidgetGtk so child widget get the destroy message when the top WidgetGtk is still alive. BUG=None TEST=Close Chrome toolkit views. It should not assert because of the focus manager. Review URL: http://codereview.chromium.org/231003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26952 0039d316-1c4b-4281-b951-d872f2087c98
* Linux (nss) implementations of RSAPrivateKey and SignatureCreatorrafaelw@chromium.org2009-09-236-13/+337
| | | | | | | | BUG=20669 Review URL: http://codereview.chromium.org/208032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26950 0039d316-1c4b-4281-b951-d872f2087c98
* Add lib/ to LD_LIBRARY_PATH for chrome shared libs.mmoss@chromium.org2009-09-231-2/+2
| | | | | | | Review URL: http://codereview.chromium.org/218004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26949 0039d316-1c4b-4281-b951-d872f2087c98
* Reorganize recent changes in database-related layout test expectations.dglazkov@chromium.org2009-09-231-8/+7
| | | | | | | | | | TBR=dumi TEST=none BUG=4359 Review URL: http://codereview.chromium.org/224006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26948 0039d316-1c4b-4281-b951-d872f2087c98
* Add back ctrl+shift+delete for bringing up the "Clear browsing data"tony@chromium.org2009-09-231-0/+2
| | | | | | | | | dialog on linux. When we removed the menu item, we lost the keyboard binding as well. Review URL: http://codereview.chromium.org/216056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26947 0039d316-1c4b-4281-b951-d872f2087c98
* IPC & LibEvent fixjeremy@chromium.org2009-09-234-4/+86
| | | | | | | | | | | * Allow IPC::Listeners to send a message on OnChannelConnected. * Fix a bug in MessagePumpLibevent::WatchFileDescriptor causing a read-after-free. BUG=22451 Review URL: http://codereview.chromium.org/209061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26946 0039d316-1c4b-4281-b951-d872f2087c98
* Remove regressions, fixed by rolling out http://trac.webkit.org/changeset/48639.dglazkov@chromium.org2009-09-232-23/+0
| | | | | | | | | | TBR=paul TEST=none BUG=none Review URL: http://codereview.chromium.org/219011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26945 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome/fast/dom/extensions/interval.html to the list of flaky webkit ↵jshin@chromium.org2009-09-231-0/+1
| | | | | | | | | | tests. Unlike on Linux, it doesn't crash on Mac. Also, it's only observed on Mac OS 10.5 debug bot. Because there's no way to mark OS 10.5 separately from other Mac OS versions. I'm just using Mac per Mark. BUG=9798 TBR=dglazkov Review URL: http://codereview.chromium.org/231002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26944 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a DCHECK that was firing in legitimate cases. The cases are described inbrettw@chromium.org2009-09-231-5/+18
| | | | | | | | | | the comment I added to the code. http://crbug.com/21849 TEST=covered by unit tests Review URL: http://codereview.chromium.org/210043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26941 0039d316-1c4b-4281-b951-d872f2087c98
* Add some new histograms for history, and UMA-enable a few others.brettw@chromium.org2009-09-234-11/+38
| | | | | | | | BUG=19773 TEST=none Review URL: http://codereview.chromium.org/212014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26939 0039d316-1c4b-4281-b951-d872f2087c98
* Add SetUpTestFixtureTest/TearDownTestFixtureTest methods to ↵tim@chromium.org2009-09-235-14/+52
| | | | | | | | | | | | | | | InProcessBrowserTest that let tests do what is normally done by overriding SetUp/TearDown methods. This special method is needed because of the way SetUp winds up at the bottom of the stack that invokes your test fixture methods. Make the LiveBookmarksSyncTest class allow direct lookup for google.com domain as part of setup, which these tests need to access GAIA and sync servers. Review URL: http://codereview.chromium.org/214047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26938 0039d316-1c4b-4281-b951-d872f2087c98
* More examples:oshima@chromium.org2009-09-235-4/+287
| | | | | | | | | | | MessageBox, TabbedPane and RadioButton BUG=none TEST=none Review URL: http://codereview.chromium.org/214053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26937 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit update 48642:48665dglazkov@chromium.org2009-09-232-1/+15
| | | | | | | | | | R=levin TEST=none BUG=none Review URL: http://codereview.chromium.org/225010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26936 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-03 20:20:12 +0000