| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
deprecated version.
BUG=None
TEST=unit_tests
Patch from Thiago Farina <thiago.farina@gmail.com>.
Review URL: http://codereview.chromium.org/385112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We don't want to ever go out to disk when looking for data after
startup, since they can be changed by an update.
We *should* just be using the zygote, but the zygote is sandboxed-only
for now, and fixing that has a lengthy dependency graph. In the
interim, /proc/self/exe is the correct executable and exec'ing it should
work as long as the subprocess doesn't need any other files from the
Chrome directory.
BUG=22703
TEST=Start Chrome. Move away the entire Chrome directory; plugins
should still work.
Review URL: http://codereview.chromium.org/403018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
no one is actually sure what they were even supposed to do.
BUG=24192
R=dglazkov@chromium.org
TEST=chrome/http/mime
Review URL: http://codereview.chromium.org/399109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I don't know exactly what's been changed thoguh.
We're going to enable this in build/try bots soon so we can tell when this comes back.
BUG=28046
TEST=browser_tests --gtest_filter=BookmarkManagerTest* should pass.
Review URL: http://codereview.chromium.org/399104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Adding some code elsewhere was causing pure call errors related to this
code, but only for Release builds on gcc 4.2.4. My gcc 4.4.1 computer
was fine. I know better than to claim it's a compiler bug, but this
destructor is unused anyway so this change is harmless.
Review URL: http://codereview.chromium.org/402080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/408019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the marker did not previously exist.
BUG=none
TEST=call the UnregisterNPAPIPlugin entrypoint on npchrome_tab.dll when the NPAPI plug-in is not previously installed with Firefox; it should not return an error.
Review URL: http://codereview.chromium.org/402062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DumpRenderTree's behavior. This causes a couple other tests to produce
output that could be construed as "failing" (in the way that upstream fails
as well). I will file a separate bug in webkit to figure out what to do
about them.
R=eseidel@chromium.org
BUG=27217
TEST=LayoutTests/fast/replaced/applet-rendering-java-disabled.html
Review URL: http://codereview.chromium.org/405026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=erikkay
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/406010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/399095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28211
Review URL: http://codereview.chromium.org/399106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
front-ends send this rather than simply omitting the X-Frame-Options
header altogether.
BUG=none
TEST=chrome_frame_unittests.exe
Review URL: http://codereview.chromium.org/404003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit r32457.
This works for me in Debug and Release, and Lei in Debug, but not
for him or the bots in Release. Hate computers.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/403028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that got put in the wrong place.
Fixing changed name.
BUG=None
TEST=None
TBR=gregoryd
Review URL: http://codereview.chromium.org/403025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=LaForge
Review URL: http://codereview.chromium.org/399105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
painting.
I believe changes to the windowed-ness of the widgetry in the bookmark bar caused this.
BUG=27769
TEST=works in both classic theme mode and gtk theme mode
Review URL: http://codereview.chromium.org/399103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
r32311 fixes the cause of the crash, so enable WebSocket experiment again.
BUG=28096,27856
TEST=none
Review URL: http://codereview.chromium.org/399065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The regression was caused by r32425.
BUG=28203
TEST=Look at NTP detached bookmark bar: it should be medium-ish grey, not black (or is that dark grey)?
Review URL: http://codereview.chromium.org/406009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
On Windows, Ctrl+Alt+B equals to AltGR+B, which corresponds to '{' on Hungarian keyboard.
BUG=27137
TEST=Switch to Hungarian keyboard layout, then try to input '{' in both omnibox and web content area by pressing AltGR+B.
Review URL: http://codereview.chromium.org/401025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
First, we kept points to FlipDelegates rather than references.
Now that the classes are separated, this becomes problematic
because the FlipNetworkTransaction can go away independently
of the FlipSession.
Second, there was a bug with posted data - we were compressing
the frames, and we don't want to.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/402073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We don't want to ever go out to disk when looking for data after
startup, since they can be changed by an update.
We *should* just be using the zygote, but the zygote is sandboxed-only
for now, and fixing that has a lengthy dependency graph. In the
interim, /proc/self/exe is the correct executable and exec'ing it should
work as long as the subprocess doesn't need any other files from the
Chrome directory.
BUG=22703
TEST=Start Chrome. Move away the entire Chrome directory; plugins
should still work.
Review URL: http://codereview.chromium.org/403018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28200
TEST=Tree goes green?
Review URL: http://codereview.chromium.org/402076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27675
TEST=play this http://fbarchard-kir.ad.corp.google.com/mediatests/runthrough.mp4 and do lots of seeks. A crash will occur after about 5 or 10 seeks without this patch.
Review URL: http://codereview.chromium.org/401021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added support for anchor (url fragments). this involves
mainly implementing IPersistHistory. The rest of the stuff
is a song and dance to get called in IPersistHistory in the
first place and then behave correctly when we do.
BUG=23981
TEst=unit tests added and back forward with '#' URLs, sub frames etc.
Review URL: http://codereview.chromium.org/371004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The seccomp sandbox is conditional on ARCH_CPU_X86_FAMILY. When
building for !ARCH_CPU_X86_FAMILY the variable g_proc_fd is
unused, leading to a build error when -Werror is turned on.
Review URL: http://codereview.chromium.org/397040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the purposes of computing statistics at the end and for the sake
of the layout test dashboard.
Flaky tests are listed as follow:
Flaky: Unexpected image failures (1):
LayoutTests/media/video-transformed.html = IMAGE PASS
For now, they won't turn the bot red or yellow. I'll submit
a following change to the log parser to turn the bot yellow
when there is unexpected flakiness.
Also, removed an extraneous commandline flag and a couple
extraneous logging statements.
Review URL: http://codereview.chromium.org/402058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
XP bots were failing on directory Delete. Removing ASSERT_TRUE for deletes solves the problem.
Review URL: http://codereview.chromium.org/408009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=no CRLFs
BUG=none
TBR=jam
Review URL: http://codereview.chromium.org/407009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Don't go off end of screen. push_in doesn't actually work as well as one might hope.
BUG=27800
Review URL: http://codereview.chromium.org/408017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Upstream changes are:
fix a few compiler warnings and make the code more exception safe.
correctly support decomposed forms of two or three part matras
fix shaping of assamese ra
fix bug with Malayalam Samvruthokaram.
add N'Ko support to the arabic shaper
Post substitutions should apply to the whole indic syllable
Review URL: http://codereview.chromium.org/408013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
little (helpeful to make it use ChildProcessLauncher). Note that the test isn't needed anymore as a unit test because since it was written, there have been a couple of tests that exercise this code path through browser_tests. They use sandboxed utility processes so it's more equivalent to what the user experiences.
Review URL: http://codereview.chromium.org/402074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed some style violations.
Made HtmlDialogWindowDelegateBridge stop doing anything after it receives a close notification.
This fixes the crash described in issue 28039.
BUG=28039
TEST=trybots,manual
Review URL: http://codereview.chromium.org/402065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/404033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=541
TEST=None
Review URL: http://codereview.chromium.org/399094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://trac.webkit.org/changeset/51088.
You can see the proof at: http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/flakiness_dashboard.html#tests=char-encoding&showExpectations=true&showLargeExpectations=true&maxResults=500
TBR=ojan
BUG=9798
TEST=layout test try servers
Review URL: http://codereview.chromium.org/404037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tabs dialogs to a tree view.
Nib changes: Removed the NSBrowser and added an NSOutlineView.
BUG=26647,26643,26718,27634
TEST=Bring up the bookmark editor by control-clicking in the bookmarks bar and selecting Add Page... or by selecting the Bookmark this Page... menu item found in the Bookmarks menu. Observe that the folder presentation is now a tree view. Select any folder and click New Folder to verify that new folders can be added. Double-click on the newly created folder to change its name. Added folders will not commit until OK is pressed, which will require that a bookmark actually be added. Also bring up the Bookmark All Tabs dialog by control-clicking in the tab bar with more than one tab open and verify that the folder structure is shown in a tree view.
Review URL: http://codereview.chromium.org/393006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes it easy to defend changing a test because you have the numeric evidence of "this test was flaky 43% of the time before".
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/399093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=jparent
TEST=good eye
BUG=21510
Review URL: http://codereview.chromium.org/403021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
but we don't care.
BUG=28179
TEST=none
Review URL: http://codereview.chromium.org/404036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=10342
TEST=none
Review URL: http://codereview.chromium.org/399091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
on Linux.
Some crashers on window close have been fixed so let's try running this again. I was unable to repro from running the test in a loop for a few hours.
TBR=erikkay
Review URL: http://codereview.chromium.org/408016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/404035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28179
TEST=valgrind bot goes green.
TBR=tony
Review URL: http://codereview.chromium.org/406008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Enable bookmarks on Linux. The dialog should no longer be too large.
Review URL: http://codereview.chromium.org/402070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
and fix includes so service side and compile
with system GL and client side can compile
with Command Buffer GL.
Review URL: http://codereview.chromium.org/407006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/373001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
URLRequestContext it was using for downloads is destroyed.
This avoids the possibility of accessing freed memory when sharing ProxyService amongst request context, and the main context is destroyed first.
BUG=25338
Review URL: http://codereview.chromium.org/387065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/405022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32426 0039d316-1c4b-4281-b951-d872f2087c98
|