| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=60101
TEST=no
Review URL: http://codereview.chromium.org/7005002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
space key.
BUG=chromium-os:14965
TEST=manual
Review URL: http://codereview.chromium.org/6999010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=build with GCC and LLVM
Review URL: http://codereview.chromium.org/6993009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=82224
TEST=unit_tests:BrowserAccessibilityTest.TestTextBoundaries
Review URL: http://codereview.chromium.org/6995040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Causes browser crash, probably genuine.
Needs investigation.
BUG=crbug.com/82247
R=rsimha@chromium.org
TEST=
TBR=rsimha@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47049,69811
TEST=none
Review URL: http://codereview.chromium.org/6995016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert "Move ExtensionFunctionDispatcher to ExtensionTabHelper. This"
This reverts commit 4f08bad13a0cb2e40835869a9a7d9edb16a5be9a.
Revert "Fix clang warning."
This reverts commit 1663f72a9360677aad91a9417b44afd03a41181f.
Revert "Fix chrome os"
This reverts commit 1abb1afe1b78de4bc92a82fdd1e266166bc74707.
TBR=mpcomplete@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This is to work around a problem where passed command line flags (thru pyauto flag --chrome-flags) will not take effect on win.
Review URL: http://codereview.chromium.org/7005007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
chromeos::LoadLibcros()
BUG=crash on start with chromeos touchui
TEST=manually
Review URL: http://codereview.chromium.org/7002005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/7002015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=mpcomplete@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke on vista tests (dbg4).
BUG=none
TEST=PrerenderBrowserTest.PrerenderPopup
Review URL: http://codereview.chromium.org/6955003
TBR=dominich@chromium.org
Review URL: http://codereview.chromium.org/6995043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=mpcomplete@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:14180
TEST=it compiles without warning
Review URL: http://codereview.chromium.org/7000020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
sets the stage for us to expose certain extension functions
to content scripts and normal web pages.
This required two major structural changes:
1. Made EFD stateless, except for the pointer to its
delegate. This is important to gracefully handle the case
of a RVH navigating between different extensions or even
to normal web content. Especially in the case of
TabContents, where the entire RVH can be torn down and
replaced during navigation.
2. Centralize all per-(extension, RVH) setup in
ChromeContentBrowserClient::RenderViewCreated(). In
particular, responsibility for enabling extension bindings
was very spread out before, making it hard to follow when
exactly they were enabled.
BUG=80308
Review URL: http://codereview.chromium.org/6927076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=BUILD
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84843
Review URL: http://codereview.chromium.org/6998009
TBR=dmaclach@chromium.org
Review URL: http://codereview.chromium.org/7001021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the system starts up, chrome fetches the device properties for
all network devices. However, for cellular devices, many of the
Cellular.XXX properties don't become defined until the modem is
enabled. Since chrome doesn't refetch the properties, nor are any
property change signals sent out from flimflam for these properties
(because generally speaking they are ones that don't change),
chrome's cached copies are empty. The result is that when the Device
tab is brought up in the internet settings page, all the fields are
blank.
Chrome now refetches device properties when it sees the value of
the Powered property change.
Also, I removed the LastUpdate item from the device tab. That property
hasn't existed in flimflam for several months.
BUG=chromium-os:14180
TEST=To demonstrate the problem without this fix, reboot the machine,
go to internet settings, click "Options" for the cellular service,
and go to the device tab. The fields should be blank. Log out and
log back in, and the fields in the device tab should be populated,
because chrome restarted and thus fetched the properties again. With
this fix in place, the fields should be populated first time, every
time.
R=nkostylev@chromium.org,zel@chromium.org
Review URL: http://codereview.chromium.org/6903080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
CookieMonster for the automation profile was incorrectly being retrieved (which is NULL), instead of the profile from the ChromeRenderMessageFilter.
TBR=ananta
Review URL: http://codereview.chromium.org/7001020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=BUILD
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84843
Review URL: http://codereview.chromium.org/6998009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=PrerenderBrowserTest.PrerenderPopup
Review URL: http://codereview.chromium.org/6955003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The |match| sometimes did not have a valid template_url, because GetInfoForCurrentText was classifying the match using the wrong parameters. Fixed to use prefer_keyword==true in this case.
BUG=81776
TEST=see bug for repro
Review URL: http://codereview.chromium.org/6995032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=82205
TEST=see bug.
TBR=kmadhusu
Review URL: http://codereview.chromium.org/6995038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeFrame requests over automation.
The crash occurs in the URLRequestAutomationJob which is invoked from the AutomationResourceMessageFilter
which filters the automation channel. A recent change to remove refcounting usage from the URLRequestJob
subclasses also changed the request map to not maintain a refcounted object. Long story short, while processing
the OnRequestEnd IPC message the job can get destroyed midway in the handler.
Fix is to rearrange the code in the URLRequestAutomationJob::OnRequestEnd function to access the pending_buf
only when the job is not complete and we received a valid response.
BUG=none
TEST=ChromeFrame should not crash on startup. This can be reproduced by navigating to meebo.com in IE
TBR=amit
Review URL: http://codereview.chromium.org/7001011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6998007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL also contains recent key label changes in ru, th and zh_TW keyboards.
BUG=chromium-os:14753
TEST=manual
Review URL: http://codereview.chromium.org/6991006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
failure by updating the layout test's net::URL::Delegate to the new cookie interface.
TBR=willchan
Review URL: http://codereview.chromium.org/6982017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with retry logic. Fix for bug Chromium cannot recover from a state
when its DNS requests have been dropped.
Whenever we try to resolve the host, we post a delayed task
to check if host resolution (OnLookupComplete) is completed
or not. If it hasn't completed, then we start a new job
to resolve for the same request.
BUG=73327
TEST=dns host resolver tests
R=eroman,jar
Review URL: http://codereview.chromium.org/6976006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I accidentally included the change that I didn't intend, sorry about that.
TBR=msw@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7002021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7003006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Don't show image behind screen locker.
BUG=chromium-os:14985, chromium-os:13154
TEST=lock the screen, and alt-click or right click passworld field.
Review URL: http://codereview.chromium.org/6997007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added Edit and its subclass that represents a change that can be undone/redone.
Set TestViewsDelegates in examples_main.cc to make cut© work in views_examples.
I'll refactor this soon so that text change is always done by an edit object.
BUG=none
TEST=unit tests for undo/redo
Review URL: http://codereview.chromium.org/6937002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=82118
TEST=PrerenderBrowserTest.PrerenderTaskManager
Review URL: http://codereview.chromium.org/7000006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
NULL.
BUG=81985,81984
TEST=none
Review URL: http://codereview.chromium.org/6997017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=BUILD
Review URL: http://codereview.chromium.org/6998009
TBR=dmaclach@chromium.org
Review URL: http://codereview.chromium.org/7003014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
LoginAsGuest(), and fixes to the PyAuto test chromeos_login.py.
BUG=chromium-os:14990
TEST=Run chromeos_login.py.
Review URL: http://codereview.chromium.org/7000004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/7004011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a flag that will disable building Chrome as a Position Independent Executable.
R=zelidrag@chromium.org,raymes@chromium.org
BUG=chromium-os:15161
TEST=Tested building with and without the flag; with the flag, symbols appear correctly in the remote session.
Review URL: http://codereview.chromium.org/7000015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This appears to prevent some renderer crashes that are
fairly easy to trigger with Thai pages on Chrome OS.
BUG=chromium:75210,chromium-os:15103
TEST=manual: built chromeos-chrome and checked that http://www.pungame.com/sale.html and http://happy.teenee.com/game/ no longer cause crashes
Review URL: http://codereview.chromium.org/7000012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
By checking canceled() again before calling NotifyCompleted, we avoid
assumptions that we're not canceled from the callback. This solves 2 issues:
1) The NOTREACHED in the provider which tries to remove the pending_request.
2) Trying to call DidExecute on a deleted consumer_.
BUG=77777, 82156
R=sky@chromium.org
TEST=python chrome/test/functional/imports.py imports.ImportsTest.testImportFirefoxDataTwice
Review URL: http://codereview.chromium.org/7001015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
content\browser for cookies. ChromeRenderMessageFilter filters that message if it's destined for automation instead.
Review URL: http://codereview.chromium.org/7001007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This conditionally compiles out the dlsym calls when built with newer GTKs.
BUG=30213
TEST=none
Review URL: http://codereview.chromium.org/7002014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/7001005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TEST=TransportSecurityStateTest.*
Review URL: http://codereview.chromium.org/6996001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
print preview tab.
BUG=80346
TEST=none
Review URL: http://codereview.chromium.org/7001001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7005013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
original tab.
BUG=none
TEST=Preview a webpage. Click 'Print' button. Observe the focus on the original tab.
Review URL: http://codereview.chromium.org/7004004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
We can't use CookiePolicy anymore since, being in the network layer, we can't give it render_process_id/render_view_id, which are needed to put up the content settings UI. Instead of the networking code calling CookiePolicy then calling the delegate (ResourceDispatcherHost) to inform it if something is blocked, we directly ask the delegate if something is allowed. ResourceDispatcherHost then calls the embedder, and passes along the IDs to identify the tab. In the next change, I'll use this mechansim in RenderMessageFilter and remove the CookiePolicy class.
BUG=76793
Review URL: http://codereview.chromium.org/6995013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Some changes / fixes added while debugging chromium-os:14417 (which turned out to be a flimflam issue).
BUG=chromium-os:2665,chromium-os:9607
TEST=Connect to VPN, disconnect, then re-connect. Also see http://code.google.com/p/chromium-os/issues/detail?id=9607
Review URL: http://codereview.chromium.org/7002006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
work around an xdg-mime bug.
BUG=70158
Review URL: http://codereview.chromium.org/6982013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84878 0039d316-1c4b-4281-b951-d872f2087c98
|