| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on Linux.
Requires:
- making SetOpacity a cross platform method on Widget, replacing SetLayeredAlpha.
- moving Window::SetBounds to Widget
- replacing usage of MoveWindow in StatusBubbleViews with call to new SetBounds method.
BUG=none
TEST=make sure transparency still works for floating widgets like - status bubble, full screen exit bubble, dragged tabs
Review URL: http://codereview.chromium.org/113846
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113866
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the chrome window closes content popups.
We need to grab all X mouse events using gdk_pointer_grab. This
prevents other windows from getting focus.
We no longer need the focus-out-event signal handler because we'll
get the mouse down outside the browser window, forward it to the
renderer, and it will tell us to close.
I verified manually that killing the renderer while the popup is
showing results in gdk_display_pointer_ungrab getting called. If the renderer hangs, the user just needs to click outside the popup.
Review URL: http://codereview.chromium.org/112052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113873
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
its own window. This change also removes code that was overriding the requested size as a temporary workaround.
BUG=none
TEST=Open a browser window with two tabs. Drag one of the tabs out of the tabstrip. A new window should be created where the mouse is positioned.
Review URL: http://codereview.chromium.org/113874
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We currently register gears in JS-land, despite it not working in
browser-land. We should disable it everywhere until it works.
BUG=12529
Review URL: http://codereview.chromium.org/113870
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/114052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=12549
TEST=none
Review URL: http://codereview.chromium.org/115793
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=10005
Review URL: http://codereview.chromium.org/115723
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(For reference, it was committed with the wrong message: "Patch to make
password patch build.")
This reverts commit r16708.
Review URL: http://codereview.chromium.org/113871
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115801
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115802
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113869
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The logic for resource loading for media file has
a problem in determining the wait condition that it
waited for one extra cycle (about ~5s) to know that
the resource loading has completed, it is fixed in
this patch. Also made clear about the logic in it.
Review URL: http://codereview.chromium.org/113861
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change is exactly the same change as <http://codereview.chromium.org/115353>. I would like to re-send this change because the PC that I created this original change has been dead and I have not been able to commit.
This issue is caused by a stupid mistake of mine that I forgot adding a WM_IME_ENDCOMPOSITION handler to update the find results when a composition is finished (or canceled). This change adds a handler for WM_IME_ENDCOMPOSITION messages to update the find results.
BUG=11863 "Korean find-in-page: Backspace all the way, Chrome will highlight all the characters that contain the first consonant"
TEST=Open a Korean page, type Control+F keys, Switch the input language to Korean, type a right-alt key, type a 'w' key, type a 'k' key, type a 'a' key, type a backspace key, and verify there are not any highlited characters.
Review URL: http://codereview.chromium.org/113847
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
cross-platform.
Review URL: http://codereview.chromium.org/115799
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
We were crashing while trying to load fonts. Your patch for font
fallback fixes the crash.
Review URL: http://codereview.chromium.org/112061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit 071e95bcdcefcd2cb86c9aed5cb073bbcaa7f2a7.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113863
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
previous change that used the wrong parent variable when showing HTML dialogs.
Review URL: http://codereview.chromium.org/113864
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115794
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This checkin adds gmock, and a small example of how to write a gmock-based unittest.
Review URL: http://codereview.chromium.org/113807
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113862
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113865
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115790
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I accidentally removed them and abarth caught them. Now they're back where they ought to be.
TBR=gwilson
BUG=10463
TEST=0
Review URL: http://codereview.chromium.org/113845
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
first-run dialogs.
Review URL: http://codereview.chromium.org/113858
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
There was a bug in HttpResponseHeaders::GetContentRange() that
it didn't respect implied LWS rule, i.e. there can be arbitrary
number of spaces in the header value between tokens.
TEST=HttpResponseHeaders.GetContentRange
Review URL: http://codereview.chromium.org/113675
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115795
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the remainder of the skia source code from the Chromium repo. It now lives over in third_party/skia.
BUG=none
TEST=If it builds, you're happy.
R=dglazkov Review URL: http://codereview.chromium.org/113827
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115786
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=crash handler should not print garbage to the console following the crash id.
Review URL: http://codereview.chromium.org/115796
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r16889 triggered some warnings with GCC 4.3: http://pastebin.com/m3a9415af
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115784
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/12555
TEST=Browse to a page. Bring up a new tab (Command-t), should be able to start typing in autocomplete.
http://crbug.com/12556
TEST=With a partial URL entered, switch tabs, and switch back. Should be able to type to replace autocomplete. This does not fix the entire bug.
Review URL: http://codereview.chromium.org/115734
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ever receiving a drag-motion signal. In this case we'd crash because dragged_tab_ isn't created yet.
BUG=12473
TEST=Open a browser with three tabs. Rapidly click on the first and third tabs. This should not cause the browser to crash.
Review URL: http://codereview.chromium.org/113854
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It's still used by the unit test.
TBR=erg
Review URL: http://codereview.chromium.org/115791
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a crash spike in ChromeBot.
The crash spike is caused by some observers
don't remove themselves from notification list
after being deleted. The clean up done by pkasting
may fix this so I am give this change another
try.
TEST=None
BUG=None
Original change description:
Close browser window synchronously during UI test
tear down. This is an effor to reduce random
failure due to browser crash with multiple window
open during shutdown.
Review URL: http://codereview.chromium.org/113856
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113851
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/113852
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
views build so that we only include the gtk classes we need.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115788
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
up on drags and the buttons look depressed when the menu is showing.
BUG=12427
TEST=back/forward button behavior should be as on windows (see bug desc. for details).
Review URL: http://codereview.chromium.org/113806
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
design doc linked from the bug. This implements the ability to read existing Keychain passwords, but no storage/updating yet, and no adding of our own metadata as passwords are used; all that will be done in follow-up patches.
This also includes a Keychain wrapper for the functionality necessary so far, and a mock Keychain sufficient to unit-test essentially all of the code.
This patch deliberately excludes the step of instantiating a PasswordStoreMac and hooking it up to the profile, because a bug in autocomplete itself prevents passwords we load from actually being used, and we don't want to trigger Keychain UI for passwords that will be ignored. So this won't be used in builds yet, but it will be unit tested.
BUG=11745
TEST=none (no user-visible effect yet)
Review URL: http://codereview.chromium.org/115658
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the uses of V8 Locker in worker execution code when we switch to process-per-worker model. (See WebKit bug 25944 https://bugs.webkit.org/show_bug.cgi?id=25944).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113726
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
is associated with a window, so it should be a NativeWindow instead of
NativeWidget.
Review URL: http://codereview.chromium.org/113850
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Open a browser window with two tabs, pull one of the tabs out of the tab strip. On release, a new window should be created with the dragged tab contents.
Review URL: http://codereview.chromium.org/113787
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
lives over in third_party/skia (I only removed the headers in the first CL, since it was too unwieldy with all these deletes).
BUG=none
TEST=If it builds, you're happy.
R=dglazkov
Review URL: http://codereview.chromium.org/113827
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
views.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113849
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
of chrome. This renames the _win version to _views and makes the header
compilable on non-Windows.
Review URL: http://codereview.chromium.org/113844
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16891 0039d316-1c4b-4281-b951-d872f2087c98
|