summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Only run the UTF-8 assuming sys conversion tests on Linux.deanm@chromium.org2009-06-251-0/+3
| | | | | | | Review URL: http://codereview.chromium.org/147146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19240 0039d316-1c4b-4281-b951-d872f2087c98
* Implement Linux sys_string_conversions using the system APIs.deanm@chromium.org2009-06-252-4/+219
| | | | | | | | | BUG=14826 Review URL: http://codereview.chromium.org/140062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19239 0039d316-1c4b-4281-b951-d872f2087c98
* Integrating GtkIMContext into the RenderWidgetHostViewGtk class (Take 2).hbono@chromium.org2009-06-2510-5/+351
| | | | | | | | | | | | | | | | | | | | | | | | This change is an updated version of <http://codereview.chromium.org/126118> that I reverted because of issue 15024 <http://crbug.com/15024>. This issue 15024 is caused by my bonehead mistake that I forgot handling the case that gtk_im_context_filter_keypress() returns false. (The GtkIMContext usually returns false when we type control keys, such as return, page up, page down, etc.) To handle this case, this change added code that manually creates a Char event and send it to the renderer in RenderWidgetHostViewGtkWidget::KeyPressReleaseEvent(). Except this code, it is exactly the same as <http://codereview.chromium.org/126118>. Unfortunately, this change still uses std::wstring, I'm going to send another change which replace std::wstring with string16. (The following message is copied from <http://codereview.chromium.org/126118>.) This change implements signal handers of the GtkIMContext object to support IMEs anddead-keys. Also, to improve compatibility with Windows Chrome, this changeemulates IPC messages sent on Windows when we input characters and fixes Issue13604 as well as Issue 10953 and 11226. Even though I notice we need more workfor fixing edge cases (e.g. disabling IMEs on a password input) on Linux, Ithink this is the good starting point. (Supporting edge-cases requirescomplicated code and it makes hard to review.) BUG=10953 "IME support" BUG=11226 "Dead keys and accents input not working" BUG=13604 "Hotkeys not working in non-us keyboard layout" BUG=13711 "Alt-D does not work when in editbox" TEST=Open a web page which contains an <input> form, type a '[{' key and an 'A' key on a Canadian-French keyboard, and see a Latin character "U+00E2" is displayed in the <input> form. TEST=Open a web page which contains an <input> form, enable an Chinese Pinyin IME, type a 'W' key, type an 'O' key, and see a Chinese character is displayed in the <input> form. TEST=Change the keyboard layout to Hebrew (or Russian), open a web page which contains an <input> form, input some characters in the <input> form, type control+a, and see the text in the <input> form is selected. TEST=Open a web page which contains a <textarea> form, type a return key, and see a new line is inserted. Review URL: http://codereview.chromium.org/147011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19238 0039d316-1c4b-4281-b951-d872f2087c98
* Landing http://codereview.chromium.org/146142thomasvl@chromium.org2009-06-251-1/+2
| | | | | | | | Fix broken IsLocaleAvailable. test_path should be updated with the result of ReplaceExtension. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19237 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding this, it was failing to compile because of a FRIEND_CHANGE that ↵jcampan@chromium.org2009-06-253-3/+5
| | | | | | | | | | | | | | | | had not been updated with the test disabled name. Disabling 2 browser tests that fail on the build-bot: ExtensionShelfModelTest.Basic WebCacheManagerBrowserTest.CrashOnceOnly BUG=None TEST=None TBR=erikkay,jam Review URL: http://codereview.chromium.org/147140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19236 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust test expectations.abarth@chromium.org2009-06-251-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19235 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 19233.jcampan@chromium.org2009-06-252-4/+2
| | | | | | | | | | | This breaks the build, incrediblously. TEST=None BUG=None TBR=jam Review URL: http://codereview.chromium.org/146141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19234 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling 2 browser tests that fail on the build-bot:jcampan@chromium.org2009-06-252-2/+4
| | | | | | | | | | | | ExtensionShelfModelTest.Basic WebCacheManagerBrowserTest.CrashOnceOnly BUG=None TEST=None TBR=erikkay,jam Review URL: http://codereview.chromium.org/147137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19233 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 14481 - RTL: Chrome is trying to open exe file directly ↵xji@chromium.org2009-06-252-11/+31
| | | | | | | | | | | | | | | | | | | after clicking down arrow on download shelf instead of drawing a context menu After changing the download items in download shelf to be RTL in RTL UI, need to change the computation of x coordinate of drop down button. BUG=http://crbug.com/14481 TEST= 1. Run Hebrew Chrome 2. Download an exe file >> Dangerous file warning should show up now 3. Click "Save" button 4. Click the down arrow on the download shelf 5. Chrome should draw a context menu after clicking down arrow (not trying to open the exe file) Review URL: http://codereview.chromium.org/131091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19232 0039d316-1c4b-4281-b951-d872f2087c98
* Making some browser tests Windows specific as they hang on Linux.jcampan@chromium.org2009-06-251-2/+3
| | | | | | | | BUG=http://crbug.com/15081 TEST=Run the browser tests on Linux. Review URL: http://codereview.chromium.org/146055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19228 0039d316-1c4b-4281-b951-d872f2087c98
* Disable CompactLangDetTest.* to keep XP unit (purify) bot green.jungshik@google.com2009-06-251-0/+3
| | | | | | | | | | | | | Some errors appear to be bogus, but other may be real. BUG=15276 (http://crbug.com/15276 ) TBR=erikkay,sidchat TEST=XP unit (purify) does not fail due to CLD. Review URL: http://codereview.chromium.org/147136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19227 0039d316-1c4b-4281-b951-d872f2087c98
* cancel_transition is flaky on Linux debug as well. Mark it as such. jungshik@google.com2009-06-251-3/+2
| | | | | | | | | | TBR=dglazkov BUG=15627 (http://crbug.com/15627) TEST=Linux webkit (debug) does not report cancel-transition as a failure Review URL: http://codereview.chromium.org/147134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19226 0039d316-1c4b-4281-b951-d872f2087c98
* Run content scripts in their own isolated world. Hidden behind the ↵abarth@chromium.org2009-06-258-131/+212
| | | | | | | | --isolated-world command line argument to let us iterate on this feature.R=aaBUG=12218TEST=None :( (I have a testing plan we can put in place once the upstream half of this CL lands.) Review URL: http://codereview.chromium.org/118188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19225 0039d316-1c4b-4281-b951-d872f2087c98
* Show EV cert info text next to security icon.ukai@chromium.org2009-06-256-81/+114
| | | | | | | | | | | | | Use hbox to pack location entry, security icons and EV cert info text. Change ToolbarModel::GetInfoText not return SkColor. BUG=none TEST=none Review URL: http://codereview.chromium.org/126117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19224 0039d316-1c4b-4281-b951-d872f2087c98
* Add an about:inducebrowsercrashforrealz URL.jeremy@chromium.org2009-06-253-0/+13
| | | | | | | | This facilitates easy QA for browser crash reporting. Review URL: http://codereview.chromium.org/147126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19223 0039d316-1c4b-4281-b951-d872f2087c98
* Make more things possible with mock sockets:phajdan.jr@chromium.org2009-06-252-25/+41
| | | | | | | | | | | | - check connection state in mock read and write - make possible simulating short reads in DynamicMockSocket TEST=none http://crbug.com/15259 Review URL: http://codereview.chromium.org/147117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19222 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r19162,19179 as they caused the toolbar and bookmark bar to regress ↵estade@chromium.org2009-06-254-48/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | and display LTR for RTL locales. r19162 | jhawkins@chromium.org | 2009-06-24 13:15:04 -0700 (Wed, 24 Jun 2009) | 5 lines Add support for RTL languages in the gtk toolbar layout. BUG=none TEST=Open a browser window in a RTL language (--lang=he). The toolbar layout should correctly be in RTL layout. Review URL: http://codereview.chromium.org/147102 r19179 | jhawkins@chromium.org | 2009-06-24 14:38:25 -0700 (Wed, 24 Jun 2009) | 5 lines Add support for RTL languages in the gtk bookmark bar. BUG=none TEST=Open a browser window in a RTL language (--lang=he). The bookmark bar layout should correctly be in RTL layout. Review URL: http://codereview.chromium.org/146105 See http://i139.photobucket.com/albums/q315/failfast/revertrtl.png Review URL: http://codereview.chromium.org/147130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19221 0039d316-1c4b-4281-b951-d872f2087c98
* Paint the spy guy.estade@chromium.org2009-06-254-13/+83
| | | | | | | | | BUG=none TEST=go incognito, toggle custom frame drawing Review URL: http://codereview.chromium.org/146122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19220 0039d316-1c4b-4281-b951-d872f2087c98
* Update test expectations for WebKit update 45086:45111amanda@chromium.org2009-06-251-0/+7
| | | | | | | | TBR=levin Review URL: http://codereview.chromium.org/147133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19219 0039d316-1c4b-4281-b951-d872f2087c98
* Update Skia transfer mode names in browser/* to Skia r239amanda@chromium.org2009-06-255-6/+6
| | | | | | | TBR=levin Review URL: http://codereview.chromium.org/147131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19218 0039d316-1c4b-4281-b951-d872f2087c98
* Update Skia transfer modes for Skia r239amanda@chromium.org2009-06-251-4/+4
| | | | | | Review URL: http://codereview.chromium.org/146134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19217 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/146126ericu@google.com2009-06-253-35/+53
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19216 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/147089ericu@google.com2009-06-252-1/+25
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19215 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add linux-gate.so to the minidump mappings.agl@chromium.org2009-06-253-42/+201
| | | | | | | | | | | | | | | Add linux-gate.so to the minidump mappings list by checking for the load address in the aux vector and adding a filename of linux-gate.so when we encounter that load address. This is necessary for crash reporting to walk the stack correctly when a crash happens while in a system call. http://codereview.chromium.org/147032 Committed for Neal Sidhwaney. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19214 0039d316-1c4b-4281-b951-d872f2087c98
* Update Skia transfer modes to match changes in Skia as of r239amanda@chromium.org2009-06-255-6/+6
| | | | | | Review URL: http://codereview.chromium.org/146131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19213 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typojungshik@google.com2009-06-251-2/+2
| | | | | | | TEST=webkit test runs BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19212 0039d316-1c4b-4281-b951-d872f2087c98
* Update WebKit to 45111 and Skia to 239amanda@chromium.org2009-06-2519-97/+62
| | | | | | Review URL: http://codereview.chromium.org/147121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19211 0039d316-1c4b-4281-b951-d872f2087c98
* Mark two layout tests as flaky.jungshik@google.com2009-06-251-2/+7
| | | | | | | | | | | Mark two existing failure cases as flaky on Windows BUG=13907,15267,15266 TEST=none TBR=dglazkov Review URL: http://codereview.chromium.org/146128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19210 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor media pipeline and filters to use injected message loops.scherkus@chromium.org2009-06-257-173/+266
| | | | | | | | | | | Message loops are provided via MediaFilter::SetMessageLoop(). For now FFmpegDemuxer is the only filter taking advantage of injected message loops, and its unit tests have been updated as well. TEST=FFmpegDemuxer tests should continue to run BUG=none Review URL: http://codereview.chromium.org/145014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19209 0039d316-1c4b-4281-b951-d872f2087c98
* Disable failing tests until I can figure out what's going on.brettw@chromium.org2009-06-251-2/+4
| | | | | | Review URL: http://codereview.chromium.org/146127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19208 0039d316-1c4b-4281-b951-d872f2087c98
* Fork bookmark context menu logic across platforms. There's too much crazy ↵ben@chromium.org2009-06-2514-16/+730
| | | | | | | | | | | stuff going on here, I can't begin to unravel it on more than one platform at a time. TBR=sky BUG=none TEST=none Review URL: http://codereview.chromium.org/146125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19207 0039d316-1c4b-4281-b951-d872f2087c98
* Don't disable view-source mode on cancellation. On error, we should turn offbrettw@chromium.org2009-06-254-3/+44
| | | | | | | | | | | | | | | view-source mode not to show error page in view-source mode. However, on cancellation, it's not necessary and sometimes render non-error page with view-source: prefix in non view-source mode by mistake. In fixing this, I pushed down SetInViewSourceMode to RenderView from WebFrameImpl. We can control view-source state more precisely by this way. Patch by tyoshino@google.com Original review: http://codereview.chromium.org/122026 BUG=4516 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19205 0039d316-1c4b-4281-b951-d872f2087c98
* Add some missing run time dependencies. This fixes unit_tests and ui_tests ↵jam@chromium.org2009-06-251-0/+7
| | | | | | | | so that they can be built from scratch and complete. Review URL: http://codereview.chromium.org/132056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19204 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks dnd:estade@chromium.org2009-06-254-18/+32
| | | | | | | | | | | | | | - Correct row index calculation in bookmark manager drag receive. - Support multiple target dnd also see http://crbug.com/15240 BUG=none TEST=multi dragging in bookmark manager/bookmark bar. See cited bug for explanation of how to multi-drag. Review URL: http://codereview.chromium.org/147107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19203 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up test_shell with the new FTP implementation. On Windowswtc@chromium.org2009-06-255-5/+22
| | | | | | | | | | | | | | | | this is enabled by the --new-ftp command-line switch. On Mac and Linux this is always enabled. Fix some cpplint nits. Remove the obsolete "net/http/http_network_layer.h" inclusion. R=darin BUG=http://crbug.com/4965 TEST=none Review URL: http://codereview.chromium.org/147061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19202 0039d316-1c4b-4281-b951-d872f2087c98
* Revise the webkit test list for 3 flaky tets on Linux.jshin@chromium.org2009-06-251-3/+3
| | | | | | | | | | | | | Mark LayoutTests/tables/mozilla/bugs/45621.html as 'FAIL PASS CRASH' on Linux Mark LayoutTests/fast/body-propagation/overflow/004.html as 'FAIL PASS' on all platforms Mark LayoutTests/http/tests/cache/subresource-expiration.html as 'CRASH PASS' whether it's an opt or a debug build. BUG=9798,9797,14752 TBR=dglazkov TEST=Above 3 tests do now show up as failures on Linux webkit bots Review URL: http://codereview.chromium.org/147120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19201 0039d316-1c4b-4281-b951-d872f2087c98
* implement WebSandboxSupport stub to prevent a null ptr derefdpranke@google.com2009-06-252-5/+9
| | | | | | | | | | | | | | | | | | If FontChromiumWin's Font::drawGlyphs() fails for some reason, we may attempt to reload the font using ChromiumBridge::ensureFontLoaded(). This requires a sandbox routine, SandboxSupport::ensureFontLoaded() to be implemented, and in test_shell, it wasn't, causing a null ptr deref and weird things to happen. Note that there is no easy way to provoke this codepath once the other bugs causing the crash in #10977 are fixed. R=darin BUG=http://crbug.org/10977 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19200 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure we keep overflow: hidden on the #most-visited element whenarv@google.com2009-06-242-3/+6
| | | | | | | | | | | | | | | | | | hidden. Also, update the height of the lower section so that content does not get clipped. BUG=15234, 15106 TEST=Hide the thumbnails on the new new tab page. There should be no way that clicking on some empty space would activate a hidden .thumbnail For the second part of this bug close 5+ tabs and check that the Recently closed section does not get clipped. Review URL: http://codereview.chromium.org/146120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19199 0039d316-1c4b-4281-b951-d872f2087c98
* Now that the tab_table_ of the TaskManager is parent owned, it should not be ↵jcampan@chromium.org2009-06-241-4/+0
| | | | | | | | | | | | accessed after the views have been removed. This was causing a crasher in the browser tests (as a deleted object was accessed). BUG=None TEST=Run the browser tests. Review URL: http://codereview.chromium.org/147110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19198 0039d316-1c4b-4281-b951-d872f2087c98
* Change zh-tw to zh-TW when it's used to find the locale data pack on Linux ↵jshin@chromium.org2009-06-241-1/+1
| | | | | | | | | | | | (case-sensitive file system). BUG=8647 TEST=Pass ui test on Linux TBR=tony Review URL: http://codereview.chromium.org/146117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19197 0039d316-1c4b-4281-b951-d872f2087c98
* Add tooltips to buttons on the new new tab page as well as remove thearv@google.com2009-06-245-37/+46
| | | | | | | | | | | | | | edit link. BUG=14958, 15073 TEST=On the new new tab page. No "edit" link should show up after a long hover of a thumbnail. The pin/unpin, remove, show/hide thumbnails, show/hide list should all show tooltips. Review URL: http://codereview.chromium.org/146108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19196 0039d316-1c4b-4281-b951-d872f2087c98
* Add a framework leak suppression on the Mac.stuartmorgan@chromium.org2009-06-241-1/+11
| | | | | | | | | | Already filed with Apple. BUG=none TEST=fewer leaks reported from the UI tests under valgrind on Mac Review URL: http://codereview.chromium.org/146115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19195 0039d316-1c4b-4281-b951-d872f2087c98
* Merging r18584 into chrome/browser/views/tab_contents/tab_contents_view_win.cc.yusukes@google.com2009-06-242-619/+5
| | | | | | | | | | | | | | My last patch (http://src.chromium.org/viewvc/chrome?view=rev&revision=18584) should have been for chrome/browser/views/tab_contents/tab_contents_view_win.cc, not for chrome/browser/tab_contents/tab_contents_view_win.cc since the latter had been deleted (http://src.chromium.org/viewvc/chrome?view=rev&revision=18368). I've confirmed that no patch other than mine is submitted to the old file: http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents_view_win.cc?view=log BUG=12290 TEST=See http://codereview.chromium.org/125111 Review URL: http://codereview.chromium.org/147074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19194 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/146114jshin@chromium.org2009-06-242-3/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19193 0039d316-1c4b-4281-b951-d872f2087c98
* Fix order of parameters that was causing title and keyword to be switched.ben@chromium.org2009-06-241-1/+1
| | | | | | | | | http://crbug.com/15226 TEST=see bug Review URL: http://codereview.chromium.org/147112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19192 0039d316-1c4b-4281-b951-d872f2087c98
* JS Binding for HTMLAudioElement Constructorkylep@chromium.org2009-06-242-0/+6
| | | | | | Review URL: http://codereview.chromium.org/132036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19191 0039d316-1c4b-4281-b951-d872f2087c98
* Add unit testing to CLD. In addition, remove files from cld/base which are ↵sidchat@google.com2009-06-247-917/+412
| | | | | | | | | | not required, yet were creating compile errors when building unit_tests. BUG=none TEST=none Review URL: http://codereview.chromium.org/132032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19190 0039d316-1c4b-4281-b951-d872f2087c98
* Add looking up/caching of redirect lists to find the best thumbnail.meelapshah@chromium.org2009-06-246-56/+520
| | | | | | | | | Added timer to clean unpopular thumbnails from the cache/disk every hour. Still need to implement removal of blacklisted urls. Review URL: http://codereview.chromium.org/126237 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19189 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug generating thumbnails. We would only use a stashed thumbnail when itbrettw@chromium.org2009-06-241-6/+13
| | | | | | | | | hadn't expired (5 seconds), even if there was no backing store. We now use the stashed one no matter what if there is no backing store to create a new one. Review URL: http://codereview.chromium.org/147087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19188 0039d316-1c4b-4281-b951-d872f2087c98
* Back out all sorts of stuff back to pre-r18933 so that we can regroup andmark@chromium.org2009-06-245-48/+33
| | | | | | | | | | figure these perf regressions out. TEST=graphs BUG=15232 Review URL: http://codereview.chromium.org/147113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19187 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 00:13:06 +0000