| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6474020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
appropriate CSS/JS files.
BUG=72363
TEST=none
Review URL: http://codereview.chromium.org/6471014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6489035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Trying to see if this is related to the media_unittests crash.
Review URL: http://codereview.chromium.org/6486026
TBR=ricow@chromium.org
Review URL: http://codereview.chromium.org/6504001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
a header only.
Review URL: http://codereview.chromium.org/6410007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Clang gfx_unittest passes
Review URL: http://codereview.chromium.org/6502001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the pepper plugin is called into, it has the ability to remove itself from
the DOM, using the Var interface. To prevent the instance from going away while
it's still in the stack, we need to keep a reference to it, any time we call
into the plugin but need to access the interface afterwards.
BUG=chromium-os:11694
TEST=With pepper flash (needs separate fix), go to www.nick.com, let it play the video and check it doesn't crash
Review URL: http://codereview.chromium.org/6488017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Missed the const param part last time.
BUG=chromium:72576
TEST=Build should pass without warning.
Review URL: http://codereview.chromium.org/6499001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=hamaji
Review URL: http://codereview.chromium.org/6474043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduce OffTheRecordProfileIOData and ProfileImplIOData.
They both inherit from ProfileIOData. The former is for the off the record (incognito) profile. The latter is for the normal ProfileImpl profile.
All of the IO related Profile objects are now initialized at the same time, in the subtype implementations of ProfileIOData::LazyInitializeInternal().
I also took this opportunity to clean URLRequestContext up so it is a class and keeps its member variables private. This required touching a fair number of files.
TODO: Remove lots of the refcounting of member variables, since they can now be owned by ProfileIOData.
BUG=67237
TEST=none
Review URL: http://codereview.chromium.org/6500002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We have the SSE2 lying around in the tree just never being used. This will
allow us to use it.
A number of Windows bots have gone red in media_tests on the waterfall:
http://build.chromium.org/p/chromium/builders/XP%20Tests%20%281%29
http://build.chromium.org/p/chromium/builders/XP%20Tests%20%281%29/builds/501/steps/media_unittests/logs/stdio
This seems to be related to r74571. So am reverting to see.
BUG=None
TEST=Chromoting to a host machine and the diff will work correctly
Review URL: http://codereview.chromium.org/6469022
TBR=hclam@chromium.org
Review URL: http://codereview.chromium.org/6502002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
from the place it was being registered in all cases, so I am moving the message tracking to use the existing widget message loop observer which is added post-window-create. Need to talk to jar/darin about exposing this functionality on MessageLoop.
BUG=none
TEST=views_unittests passes
TBR=sky
Review URL: http://codereview.chromium.org/6474042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=find those machines, verify
Review URL: http://codereview.chromium.org/6487025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This achieves the same goal as ScopedImage, namely encapsulating the memory
management of any image type. But ui::gfx::Image goes further by providing
conversion helpers between different image types.
BUG=carnitas
TEST=gfx_unittests and unit_tests
Review URL: http://codereview.chromium.org/6312159
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71326
TEST=verify popup is correct with test page noted in bug writeup.
Review URL: http://codereview.chromium.org/6410125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=pkasting
Review URL: http://codereview.chromium.org/6474041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=ben@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Mark safe_browsing_thread_ as safe for thread join on shutdown.
BUG=chromium:60211, chromium:72696
TEST=bots
Review URL: http://codereview.chromium.org/6476033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Adds logic in |select_control_handler.cc| to fill months that are not zero-padded. Also, addes unit tests for major functionality of the |autofill::FillSelectControl()| function.
BUG=64282
TEST=SelectControlHandlerTest.*
Review URL: http://codereview.chromium.org/6482012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
some code to use it.
Removes some of the Windows-specific stuff from KeyEvent.
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/6487002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To make it possible to change the exact plugin command line without a master restart, the command line is loaded from a bash script. This script is used if clang_use_chrome_plugins and clang are both set in GYP_DEFINES when runhooks runs.
BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74597
Review URL: http://codereview.chromium.org/6461026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that I ended up reverting. I've since landed the change, but I believe
everything has been cleaned up.
BUG=72542
TEST=none
TBR=timurrrr@chromium.org
Review URL: http://codereview.chromium.org/6490023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
broken since r66096.
BUG=72620
TEST=Install user level Chrome then system level Chrome. Observer that user level Chrome removes itself and delegates to system level.
Review URL: http://codereview.chromium.org/6490008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Update shutdown button default color.
BUG=chromium-os:3281, chromium-os:9941
TEST=Manual
Review URL: http://codereview.chromium.org/6469027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
In case the policy is set the generic error message is replaced by a more concrete message stating that updates are disabled by the administrator.
BUG=61056
TEST=Set the Omaha policy to disable updates, go the About Chrome box and check the message in the lower part of the window.
Review URL: http://codereview.chromium.org/6482022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
support vertexptrs
Review URL: http://codereview.chromium.org/6487023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49601
TEST=Manual. Set the policy in the plist file and it should be equivalent to using the --user-data-dir option.
Review URL: http://codereview.chromium.org/6349082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
about:flags right now doesn't support switches like "--foo=bar". It only handles
simple switches like "--quux". The prerender feature has a few options, and to avoid
confusing contradictory mixes of simple switches, we want to use valued switches. But for
that, we'll need lab support.
BUG=none
TEST=AboutFlagsTest.*
Review URL: http://codereview.chromium.org/6483015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To make it possible to change the exact plugin command line without a master restart, the command line is loaded from a bash script. This script is used if clang_use_chrome_plugins and clang are both set in GYP_DEFINES when runhooks runs.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6461026
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/6489036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
To make it possible to change the exact plugin command line without a master restart, the command line is loaded from a bash script. This script is used if clang_use_chrome_plugins and clang are both set in GYP_DEFINES when runhooks runs.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6461026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
CID=14206
Review URL: http://codereview.chromium.org/6482027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This fixes an error clang shows with -Woverloaded-virtual.
BUG=72575
TEST=none
Review URL: http://codereview.chromium.org/6487004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
CID=13412
Review URL: http://codereview.chromium.org/6483011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
CID=14347
Review URL: http://codereview.chromium.org/6476028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
in release.
BUG=72718
TEST=none
Review URL: http://codereview.chromium.org/6489032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:11105
TEST=N/A.
Review URL: http://codereview.chromium.org/6482026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Quick test to see if it is the cause of crashes in media_unittests)
(Test showed this CL is not to blame)
We have the SSE2 lying around in the tree just never being used. This will
allow us to use it.
BUG=None
TEST=Chromoting to a host machine and the diff will work correctly
Review URL: http://codereview.chromium.org/6469022
TBR=hclam@chromium.org
Review URL: http://codereview.chromium.org/6488023
TBR=finnur@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Back out GYP r884, which is causing problems for people who use the make
generator and have CC set to something that includes an argument.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6487022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72698
TBR=willchan
Review URL: http://codereview.chromium.org/6486030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Quick test to see if it is the cause of crashes in media_unittests)
We have the SSE2 lying around in the tree just never being used. This will
allow us to use it.
BUG=None
TEST=Chromoting to a host machine and the diff will work correctly
Review URL: http://codereview.chromium.org/6469022
TBR=hclam@chromium.org
Review URL: http://codereview.chromium.org/6488023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(This change was suspected of causing media_unittest crashes)
(... but it turned out to be not related)
BUG=none
TEST=none
TBR=hamaji
Review URL: http://codereview.chromium.org/6495001
TBR=zmo@google.com
Review URL: http://codereview.chromium.org/6488021
TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/6488022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(This change was suspected of causing media_unittest crashes)
BUG=none
TEST=none
TBR=hamaji
Review URL: http://codereview.chromium.org/6495001
TBR=zmo@google.com
Review URL: http://codereview.chromium.org/6488021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6488020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Logging acquired, re-disable.
BUG=72401
TEST=none
TBR= dhollowa@chromium.org
Review URL: http://codereview.chromium.org/6474033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6486026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We have the SSE2 lying around in the tree just never being used. This will
allow us to use it.
BUG=None
TEST=Chromoting to a host machine and the diff will work correctly
Review URL: http://codereview.chromium.org/6469022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=hamaji
Review URL: http://codereview.chromium.org/6495001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=72401
TEST=none
TBR= dhollowa@chromium.org
Review URL: http://codereview.chromium.org/6484020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
A few files were missed in a previous refactor (http://codereview.chromium.org/6480001/).
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/6488006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74568 0039d316-1c4b-4281-b951-d872f2087c98
|