summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Revert "implement improvements for translate infobar"ajwong@chromium.org2010-03-137-104/+58
| | | | | | | | This reverts commit r41510. Review URL: http://codereview.chromium.org/854012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41520 0039d316-1c4b-4281-b951-d872f2087c98
* Mark 5390681-2.html as failed after webkit roll.jianli@chromium.org2010-03-131-0/+1
| | | | | | | | | | BUG=none TEST=none TBR=yutak Review URL: http://codereview.chromium.org/919001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41519 0039d316-1c4b-4281-b951-d872f2087c98
* This should stop the random hangs due to chrome/app/chrome_dll_main.cc(616)] ↵thestig@chromium.org2010-03-131-6/+0
| | | | | | | | | | | | | | | | Check failed: PathService::Override(chrome::DIR_USER_DATA, user_data_dir)?? Revert 41369 - Linux: Pass userdatadir to the Zygote. BUG=none TEST=On Linux, "chrome enablelogging userdatadir=/tmp/foobar" writes renderer logs to chrome_debug.log in /tmp/foobar rather than in $XDG_CONFIG_HOME. Review URL: http://codereview.chromium.org/885003 TBR=thestig@chromium.org Review URL: http://codereview.chromium.org/848009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41518 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Mac window frame coordinate conversion on multiple monitor setupsstuartmorgan@chromium.org2010-03-132-11/+15
| | | | | | | | | | | | The same bug exists in our event coordinate conversion code in WebInputEventFactory, so this is half of a two-sided patch; WebKit side is: https://bugs.webkit.org/show_bug.cgi?id=35950 BUG=36621 TEST=In conjuction with the WebKit patch, mouseovers in Carbon plugins will work when the plugin is on a non-primary monitor with a different height than the primary monitor. Review URL: http://codereview.chromium.org/751002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41516 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit Roll 55853:55940jianli@chromium.org2010-03-132-2/+27
| | | | | | | | | BUG=none TEST=none TBR=yutak git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41513 0039d316-1c4b-4281-b951-d872f2087c98
* Implement connect to hidden networks. And show passphrase in wifi config dialog.chocobo@chromium.org2010-03-133-4/+17
| | | | | | Review URL: http://codereview.chromium.org/913003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41512 0039d316-1c4b-4281-b951-d872f2087c98
* implement improvements for translate infobarkuan@chromium.org2010-03-137-58/+104
| | | | | | | | | | | | - add "Show original" button to revert translated page (backend is currently a TODO for jay) - modify state machine of translate infobar to show "Translating..." when subsequent translations are triggered for a page i.e. when the user modifies the source or target languages - remove obsolete strings (introduced when privacy dialog was thought to be needed) BUG=35553,36682 TEST=verify per bug reports. Review URL: http://codereview.chromium.org/845006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41510 0039d316-1c4b-4281-b951-d872f2087c98
* Don't fail when default download folder doesn't existkinuko@chromium.org2010-03-131-2/+4
| | | | | | | | | BUG=37836 TEST=as described in the bug Review URL: http://codereview.chromium.org/871001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41509 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: More transition to CHROMEGTK macros.erg@google.com2010-03-122-33/+19
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/840005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41508 0039d316-1c4b-4281-b951-d872f2087c98
* Making the location by visible in the app launcherjcampan@chromium.org2010-03-121-13/+11
| | | | | | | | | BUG=None TEST=Open the app launcher, the location bar should show. Review URL: http://codereview.chromium.org/873004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41507 0039d316-1c4b-4281-b951-d872f2087c98
* Added switch to invalidate the sync xmpp auth token for testing.akalin@chromium.org2010-03-1211-10/+45
| | | | | | | | | BUG=none TEST=manual Review URL: http://codereview.chromium.org/883003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41506 0039d316-1c4b-4281-b951-d872f2087c98
* Added progress bar to the update screen.denisromanov@google.com2010-03-126-14/+66
| | | | | | | | | | | Corrected login wizard screens transitions logic. BUG=35249 TEST=Run out/Debug/chrome --login-manager --login-screen=update. Progress bar should be visible and login screen should appear after it comes to 100%. Review URL: http://codereview.chromium.org/853006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41505 0039d316-1c4b-4281-b951-d872f2087c98
* Mechanical refactor of CrxInstaller signatures. This will makeaa@chromium.org2010-03-128-156/+138
| | | | | | | | | it easier to add additional configuration features to CrxInstaller. Review URL: http://codereview.chromium.org/875003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41503 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Fix official build breakage from r41451.thestig@chromium.org2010-03-123-3/+5
| | | | | | | | BUG=none TEST=Linux official builds succeed. Review URL: http://codereview.chromium.org/842008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41499 0039d316-1c4b-4281-b951-d872f2087c98
* Test expectations cleanup: mac release.jparent@chromium.org2010-03-121-34/+14
| | | | | | | | | | | | Removes all test or adjusts expectations for tests that have passed for the last 750 runs. BUG=9798,10351,29167,37896,37896,2844,28095,27334,28034,27418,27334,18702,10320 TEST=none Review URL: http://codereview.chromium.org/882002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41498 0039d316-1c4b-4281-b951-d872f2087c98
* Change to check for MSVC instead of WINDOWS.jianli@chromium.org2010-03-121-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=dimich Review URL: http://codereview.chromium.org/850007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41497 0039d316-1c4b-4281-b951-d872f2087c98
* Make canary bot happy by disabling warning resulted from StringImpl.h.jianli@chromium.org2010-03-121-0/+3
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/892003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41496 0039d316-1c4b-4281-b951-d872f2087c98
* Fix #1 for multiple request issue (both POST and GET) after activating the ↵tommi@chromium.org2010-03-1224-263/+2534
| | | | | | | | | | | | | | | | | | | | | onhttpequiv approach. There's a ton going on here. Brief summary: I'm introducing a caching layer for top level page requests that we then use again when switching the document from mshtml to cf. Also in this change list: * Removing the previous way of shifting the document moniker over to the worker thread when a new chrome document is created. Instead we use a request cache object. * Refactoring the part of the Bho class that offered access to it via TLS. This was needed for better testability but also makes (imho) the separation clearer and will possibly help in the future if we don't have a Bho object. * Added a bit of logging that I'd prefer to keep in there until we're confident enough with onhttpequiv. * Enabling two previously disabled tests (the ones I added for multiple requests) * Adding several more unit tests for the new code. Review URL: http://codereview.chromium.org/668187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41495 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the remaining chunks for the login panels. It's currently not thesky@chromium.org2010-03-1220-39/+689
| | | | | | | | | | | defualt and hidden behind a switch. BUG=none TEST=none Review URL: http://codereview.chromium.org/906001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41494 0039d316-1c4b-4281-b951-d872f2087c98
* Don't allocate temporary buffer during PNG encoding.erg@google.com2010-03-122-29/+105
| | | | | | | | | | | | | | | | | | PNGCodec::EncodeBGRASkBitmap() was originally designed for dealing with 16x16 pixel favicons. It allocated a temporary buffer to unpremultiply the rgb pixels in the incoming skia image. These days, it's used for any PNG<->SkBitmap task, including the theme system. In one case, I saw multiple 10 megabyte temporary buffers allocated and deallocated here. Instead, juggle the code a little to only allocate one row worth of pixels and to reuse that buffer. BUG=none TEST=Existing PNGCodec.* tests, plus PNGCodec.EncodeBGRASkBitmapDiscardTransparency Review URL: http://codereview.chromium.org/851006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41493 0039d316-1c4b-4281-b951-d872f2087c98
* Re-apply r41458 | estade@chromium.org | 2010-03-12 11:28:50 -0800 (Fri, 12 ↵estade@chromium.org2010-03-1212-396/+263
| | | | | | | | | | | | | | | | | Mar 2010) | 8 lines Fix the rest of the gtk/options directory to use new callback macros. Problematically, the callback macros don't cover the case where the GObject* isn't a GtkWidget* D: BUG=None TEST=compile with fix for unit test Review URL: http://codereview.chromium.org/846005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41492 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 41481 - Secound round of sbox changes for 64 bit portericu@google.com2010-03-1217-340/+155
| | | | | | | | | | | | | | | | | | Handling pointer sized items Beefing up unit tests Beefing up integration tests Enabling Process, Thread and Token IPCs Making validation tests compile again BUG=27218 TEST= unit tests included Review URL: http://codereview.chromium.org/757001 TBR=cpu@chromium.org Review URL: http://codereview.chromium.org/871008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41491 0039d316-1c4b-4281-b951-d872f2087c98
* Patch makes sure that only text fields are saved in Auto-fill "Web Data" ↵aarya@google.com2010-03-121-1/+1
| | | | | | | | | | file on disk. This prevent passwords from being saved on disk without user content as part of autofill history. BUG=36553 TEST=Login on a web site with password field (no autocomplete=off). Check "Web Data" file on disk to see password saved without user content. Review URL: http://codereview.chromium.org/855005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41490 0039d316-1c4b-4281-b951-d872f2087c98
* Remove empty bookmarkmanager extension directories.estade@chromium.org2010-03-120-0/+0
| | | | | | | | | This refuses to upload to rietveld because the diff is empty. TBR=arv git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41489 0039d316-1c4b-4281-b951-d872f2087c98
* Move metrics api to the experimental name space.rogerta@chromium.org2010-03-1211-47/+40
| | | | | | | | | BUG=0 TEST=n/a Review URL: http://codereview.chromium.org/899003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41487 0039d316-1c4b-4281-b951-d872f2087c98
* Sanity integration tests for preference sync.albertb@chromium.org2010-03-128-33/+175
| | | | | | | | | BUG=37353 TEST=this is a test Review URL: http://codereview.chromium.org/843004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41486 0039d316-1c4b-4281-b951-d872f2087c98
* remove itself from parent when deleted.oshima@chromium.org2010-03-121-2/+4
| | | | | | | | | | | | | | In most case, this won't happen because the parent view sets child view's parent to NULL before deletion. This is necessary to safely delete view that is not owned by parent. BUG=none TEST=none Review URL: http://codereview.chromium.org/872006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41485 0039d316-1c4b-4281-b951-d872f2087c98
* Autoslide/hide notifications after timeout.oshima@chromium.org2010-03-1211-25/+295
| | | | | | | | | | | | | | * Introduced panel's state to manage which notifications will be shown.' * Added "OnPanelStateChanged" to PanelController::Delegate method to monitor the panel's state. * Removed unnecessary SetSize in BalloonViewImpl. The size is set in BalloonViewImpl::Layout. BUG=33306 TEST=This requires chromeos's wm and system notification to test (which does not exit yet). None for now but I am writing unittest now. Review URL: http://codereview.chromium.org/874004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41484 0039d316-1c4b-4281-b951-d872f2087c98
* Added textures, texture samplers and render targets to o3d-webgl. Also ↵petersont@google.com2010-03-1236-201/+2246
| | | | | | | | fixed bugs, added calls to parent class constructor to classes that didn't have them before, added a few demos to exhibit/test textures and render surfaces. Review URL: http://codereview.chromium.org/856004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41482 0039d316-1c4b-4281-b951-d872f2087c98
* Secound round of sbox changes for 64 bit portcpu@chromium.org2010-03-1217-155/+340
| | | | | | | | | | | | | | | - Handling pointer sized items - Beefing up unit tests - Beefing up integration tests - Enabling Process, Thread and Token IPCs - Making validation tests compile again BUG=27218 TEST= unit tests included Review URL: http://codereview.chromium.org/757001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41481 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Clicking bookmark bar should dismiss open folder menus as well.thakis@chromium.org2010-03-121-4/+7
| | | | | | | | | BUG=36487 TEST=Open bookmark folder. Clicking both the bookmark bar and its opening folder should dismiss it. Review URL: http://codereview.chromium.org/857009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41480 0039d316-1c4b-4281-b951-d872f2087c98
* If fetching a bitmap from the backing store fails, try to get an image from ↵skerner@chromium.org2010-03-122-19/+10
| | | | | | | | | | | the renderer. BUG=35204 TEST=Manual testing with screenshot extension. Review URL: http://codereview.chromium.org/885006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41479 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the feed sniffing testing part of the RSS extension.finnur@chromium.org2010-03-123-36/+1
| | | | | | | | | | | I suspect it is the cause of the flakiness. BUG=37109 TEST=Watch the bots to see if it is still flaky. Review URL: http://codereview.chromium.org/870008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41478 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting due to two broken tests: FullTabModeIE_SubIFram and ↵ericu@google.com2010-03-124-140/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | FullTabModeIE_UnloadEventTest. Revert 41463 - When ChromeFrame switches to IE on receiving the OnHttpEquiv notification indicating the presence of a meta tag indicating that the page is to be rendered in Chrome, we check if the notification is received for a site rendered in an IFrame to ensure that we don't switch in this case. This code is not reliable and we end up assuming that a top level navigation is actually an embedded frame. To work around this we now maintain a pending navigation count in BeforeNavigate2, which is decremented in NavigateComplete2 and NavigateError. We perform the check for an embedded document only if the pending navigation count is greater than 1. This fixes http://code.google.com/p/chromium/issues/detail?id=36825 The other change made is to add a delay of 100ms in SendString between each character to better reflect actual timing for real user input. Bug=36825 Review URL: http://codereview.chromium.org/837008 TBR=ananta@chromium.org Review URL: http://codereview.chromium.org/877009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41477 0039d316-1c4b-4281-b951-d872f2087c98
* Changed allow-non-google-login to allow-generated-jid.akalin@chromium.org2010-03-124-8/+5
| | | | | | | | | BUG=none TEST=tested manually with non-gmail google account Review URL: http://codereview.chromium.org/863006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41476 0039d316-1c4b-4281-b951-d872f2087c98
* Add CanAccuratelyCopyFromBackingStore() to the backing store class.skerner@chromium.org2010-03-121-0/+11
| | | | | | | | | | | Use the new method to avoid using CopyFromBackingStore() for screen captures when CopyFromBackingStore() will not give a flawless copy. BUG=35204 TEST=Manual testing with example screenshot extension. Review URL: http://codereview.chromium.org/830001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41475 0039d316-1c4b-4281-b951-d872f2087c98
* Fix dashboard for canaries.ojan@chromium.org2010-03-121-3/+11
| | | | | | Review URL: http://codereview.chromium.org/905002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41474 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/669132 for Thiago:sky@chromium.org2010-03-121-2/+6
| | | | | | | | | | | | | | | windows: Add UMA metrics for each time that the bookmarks toolbar menu button it's clicked. Since it isn't fully supported we need this to know how many people are using it. BUG=36191 TEST=none Review URL: http://codereview.chromium.org/885005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41466 0039d316-1c4b-4281-b951-d872f2087c98
* Revert: r41458 | estade@chromium.org | 2010-03-12 11:28:50 -0800 (Fri, 12 ↵estade@chromium.org2010-03-1212-262/+397
| | | | | | | | | | | | | | | | | | Mar 2010) | 8 lines Fix the rest of the gtk/options directory to use new callback macros. Problematically, the callback macros don't cover the case where the GObject* isn't a GtkWidget* D: BUG=None TEST=compile it's breaking unit tests Review URL: http://codereview.chromium.org/886005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41465 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r41459:willchan@chromium.org2010-03-124-6/+3
| | | | | | | | | "Change Mac to DCHECK if NetworkChangeNotifier observer list is not empty by destruction time." Apparently NetworkChangeNotifierMac's observers are still getting leaked in ExtensionApiTest.ShowPageActionPopup. Review URL: http://codereview.chromium.org/871007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41464 0039d316-1c4b-4281-b951-d872f2087c98
* When ChromeFrame switches to IE on receiving the OnHttpEquiv notification ↵ananta@chromium.org2010-03-124-10/+140
| | | | | | | | | | | | | | | | | | | | | | | indicating the presence of a meta tag indicating that the page is to be rendered in Chrome, we check if the notification is received for a site rendered in an IFrame to ensure that we don't switch in this case. This code is not reliable and we end up assuming that a top level navigation is actually an embedded frame. To work around this we now maintain a pending navigation count in BeforeNavigate2, which is decremented in NavigateComplete2 and NavigateError. We perform the check for an embedded document only if the pending navigation count is greater than 1. This fixes http://code.google.com/p/chromium/issues/detail?id=36825 The other change made is to add a delay of 100ms in SendString between each character to better reflect actual timing for real user input. Bug=36825 Review URL: http://codereview.chromium.org/837008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41463 0039d316-1c4b-4281-b951-d872f2087c98
* Show favicons for extensions.arv@chromium.org2010-03-126-28/+102
| | | | | | | | | | | This uses the 16x16 icon as defined in the manifest for extension pages. BUG=36514 TEST=Open the new bookmark manager. It should now show its favicon. Review URL: http://codereview.chromium.org/650185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41462 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark manager: Remove find as you typearv@chromium.org2010-03-121-14/+0
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/894002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41461 0039d316-1c4b-4281-b951-d872f2087c98
* Remove WebCore usage from vector_canvas_unittest.ccdarin@chromium.org2010-03-121-20/+16
| | | | | | | | | | R=maruel BUG=none TEST=none Review URL: http://codereview.chromium.org/916001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41460 0039d316-1c4b-4281-b951-d872f2087c98
* Change Mac to DCHECK if NetworkChangeNotifier observer list is not empty by ↵willchan@chromium.org2010-03-124-3/+6
| | | | | | | | destruction time. Review URL: http://codereview.chromium.org/870003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41459 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the rest of the gtk/options directory to use new callback macros.estade@chromium.org2010-03-1212-397/+262
| | | | | | | | | | | Problematically, the callback macros don't cover the case where the GObject* isn't a GtkWidget* D: BUG=None TEST=compile Review URL: http://codereview.chromium.org/857006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41458 0039d316-1c4b-4281-b951-d872f2087c98
* Enable TCMalloc on Linux by default.willchan@chromium.org2010-03-122-1/+9
| | | | | | | | BUG=36687 Review URL: http://codereview.chromium.org/854005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41457 0039d316-1c4b-4281-b951-d872f2087c98
* Fix test_shell_devtools_agent.cc to not depend on WebKit/chromium/src!darin@chromium.org2010-03-122-10/+8
| | | | | | | | TBR=pfeldman Review URL: http://codereview.chromium.org/895004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41454 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed the Pepper print interface to take in the print dimensions and printer ↵sanjeevr@chromium.org2010-03-126-75/+41
| | | | | | | | | | | DPI only in the PrintBegin method. The plugin is expected to remember this until PrintEnd is called. BUG=None TEST=Test printing with plugins that support the new interface Review URL: http://codereview.chromium.org/858007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41453 0039d316-1c4b-4281-b951-d872f2087c98
* Fix prefs dialog to size properly under RI.avi@chromium.org2010-03-121-3/+8
| | | | | | | | | BUG=19476 TEST=prefs dialog is usable under RI (scrolling Under the Hood is wonky; don't think we can fix that) Review URL: http://codereview.chromium.org/915001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41452 0039d316-1c4b-4281-b951-d872f2087c98