| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6510006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RenderWidgetHostViewViews.
Instead of directly painting to X, paint to the skia canvas from RWHVV. This
will make it easier to apply transformation to views in a uniform way, without
requiring any special-casing for RWHVV.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6246129
TBR=sadrul@chromium.org
Review URL: http://codereview.chromium.org/6517018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=rjkroege@chromium.org
TBR=sadrul@chromium.org
Review URL: http://codereview.chromium.org/6517017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
PrintingContext.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6510007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=rjkroege@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r74561 added a DCHECK to make sure users didn't try to access the ChromeURLRequestContextGetter from the Profile, since the Profile should only be read on the UI thread. ChromeOS apparently tried to access it from another thread, and therefore hit the new DCHECK.
I'm relanding without the DCHECK. I'm also eagerly initializing the off the record context getter to prevent the ChromeOS race. ChromeOS should fix that code so the eager initialization isn't necessary.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6484041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Switch 'use_libjpeg_turbo' flag back to 0 and revert valgrind suppressions from r74269.
BUG=72399
BUG=48789
TEST=build Chromium without errors and pass all existing tests.
Review URL: http://codereview.chromium.org/6332003
TBR=hbono@chromium.org
Review URL: http://codereview.chromium.org/6484040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of directly painting to X, paint to the skia canvas from RWHVV. This
will make it easier to apply transformation to views in a uniform way, without
requiring any special-casing for RWHVV.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6246129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59945
TEST=trybots
Review URL: http://codereview.chromium.org/6519012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
First file converted now that IPC infrastructure has landed. Can you suggest someone on the indexed_db side to look at what we've done to their file?
Review URL: http://codereview.chromium.org/6501006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Don't do anything on blur if the host is not alive.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6514001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
added to the set of available extension APIs.
I also removed some of the plumbing associated with the popup api:
- Drop-shadow support removed from BrowserBubble. This had only been supported on Windows.
- Removed the ExtensionPopup::PopupChrome type. Only popups from the popup API supported rectangle chrome.
- Removed the activate-on-show parameter from ExtensionPopup. This was only used for the popup API. All popups activate on show, by default.
- Removed the AddRef/Release magic from ExtensionPopup. The API required these semantics because of the complex, asynchronous lifetime management required by the popup API. See ExtensionPopup::Observer::ExtensionPopupClosed.
- Removed unneeded methods from ExtensionPopup::Observer, and ExtensionFunctionDispatcher::Delegate.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6334101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
reader is enabled, that Reader is disabled.
Make PluginList not forget that a hardcoded group is disabled by the user after it loads the plugins. Also ensure a lock is grabbed before calling AddToPluginGroups, since it uses groups_to_disable_.
BUG=72617
Review URL: http://codereview.chromium.org/6507001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6500007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We call GetPreferredSize on the tabstrip object, but we were doing so using the BaseTabStrip interface rather than the more general views::View interface. This CL changes it so that we refer to the tabstrip object by its views::View interface.
By asking the container to plan its layout given an arbitrary view rather than a specific BaseTabStrip, the code is more general and less dependent on changes in the BaseTabStrip class. I just think it's more tidy to have containers know as little as possible about of the intimate details about their contained items. It's cleaner and simpler. We don't need to know about the BaseTabStrip class in the FrameView class. We don't need to include the extra header.
Follows 6312196.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6465025
Patch from Chad Faragher <wyck@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6473015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72625
TEST=BufferedResourceLoaderTest.HasSingleOrigin, SimpleDataSourceTest.HasSingleOrigin
Review URL: http://codereview.chromium.org/6488008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
turn off multisampling.
Note that this CL does not hook up the flag with commandbuffer port. Will do so in another patch.
BUG=72778
TEST=try this new flag and see multisampling disabled in webgl.
Review URL: http://codereview.chromium.org/6480040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I discovered there's average and shuffle instructions which simplify the
calculations of UV components. Also the extract instruction was very useful.
In terms of the algorithm I rearranged the memory reads to be sequential.
Overall this gives about 10% improvement on 64-bits machine.
On 32-bits machine this gives 20% improvement. If compiled as 32-bits code this is
quite slow compared to 64-bits, about 2x slow down. So working on MMX code will
be a direction for improvement.
BUG=None
TEST=I tried it, it looks right.
Review URL: http://codereview.chromium.org/6488014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/6518009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
folder and select the file.
I've added code to detect this case, and open the folder (without selecting the file). This isn't a perfect solution, but it's the closest I've been able to find.
BUG=55826
TEST=Click on "Show in Folder" on downloaded items in Vista.
Review URL: http://codereview.chromium.org/6207008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tolerate an empty set of configurations by falling back to generate a Default
configuration. input.py handles this by allays offering a Default
configuration even if the .gyp file didn't specify any, but in a .gyp file
that offers no targets, there's no way for this to make it to the project
scope. xcode.py normally builds a configuration list at the project scope
based on all of the configuration names in all of the targets in an
.xcodeproj. Adding this check protects against that list being empty because
no targets are present.
Review URL: http://codereview.chromium.org/6516006
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6520013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
my last change (only one result set vs 2). There is now one notification when the results change. The edit is the sole listener and updates the popup after it does some processing.
My last change broke keyword state when switching tabs. This is because of the change I did to AutocompleteEditModel::SetUserText, specifically:
keyword_.clear();
is_keyword_hint_ = false;
When you restore a tab we end up in
void AutocompleteEditModel::RestoreState(const State& state) {
...
keyword_ = state.keyword;
is_keyword_hint_ = state.is_keyword_hint;
view_->SetUserText(state.user_text,
DisplayTextFromUserText(state.user_text), false);
Which ends up back in SetUserText and we because of my change the
keyword is effectively chucked.
I added the code to clear out the keyword because of the change of
notifications. Specifically because AutocompletePopupModel::Observe is
now notified before AutocompleteEditModel::Observe yet it expects the
AutocompleteEditModel to have been updated.
Additionally I need to update the keyword_ and keyword_hint_ immediately in the edit if the results go empty. This mirrors what the old code was doing.
BUG=72022
TEST=covered by tests
Review URL: http://codereview.chromium.org/6484015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72927
TBR=glider
TEST=TSan/UI goes greener
Review URL: http://codereview.chromium.org/6484037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:11392
TEST=none
Review URL: http://codereview.chromium.org/6475010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Wording change from "Restart" to "Relaunch" when pertaining to relaunchinging the application after an update. The word "Restart" is specific to restarting the machine as a whole, and "Relaunch" pertains to relaunching a particular application. Making this change across platforms.
BUG=69998
TEST=Visual inspection
Review URL: http://codereview.chromium.org/6510009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
contains the first two parts of the validator:
1. installer::InstallationValidator class, used by setup.exe to confirm that all is well following an installer operation. Violations are logged at ERROR level.
2. validate_installation.exe, used by humans to check the overall state of a machine.
The third part, in which violations fire nonfatal test failures for use in other tests, will follow in a subsequent CL.
BUG=none
TEST=Run validate_installation.exe on machine(s) containing all conceivable permutations of Chrome and Chrome Frame, and see if it reports any violations.
Review URL: http://codereview.chromium.org/6490024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6519010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/6518006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
setting.
BUG=chromium:70097
TEST=unit tests
Review URL: http://codereview.chromium.org/6520005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74816 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71612
TEST=Start Chrome and see whether it prints a line "Bad or missing pref 'state' for extension ...".
Review URL: http://codereview.chromium.org/6447004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72741
TEST=Valgrind bots should be happy again.
Review URL: http://codereview.chromium.org/6475008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I suspect it was crashing due to a problem unrelated to this test.
Also remove some debugging code.
BUG=64304
TEST=AllUrlsApiTest.RegularExtensions
Review URL: http://codereview.chromium.org/6469024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
filepath.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6482018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72549,67778
TEST=
Review URL: http://codereview.chromium.org/6469030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54831
TEST=none
Review URL: http://codereview.chromium.org/6456027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
CID=14296
Review URL: http://codereview.chromium.org/6469031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71666
TEST=none
Review URL: http://codereview.chromium.org/6468002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
CID=14335
Review URL: http://codereview.chromium.org/6482028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/6484032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
CID=14627
Review URL: http://codereview.chromium.org/6478025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
CID=14593
Review URL: http://codereview.chromium.org/6476030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I missed this failure in the previous webkit roll.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6516009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72913
TEST=TSan/unit goes green
TBR=oshima
Review URL: http://codereview.chromium.org/6515008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=canary
TBR=pkasting
Review URL: http://codereview.chromium.org/6517007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
CID=14460
Review URL: http://codereview.chromium.org/6471022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
CID=14690
Review URL: http://codereview.chromium.org/6469029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
CID=7562
Review URL: http://codereview.chromium.org/6482025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
CID=14405
Review URL: http://codereview.chromium.org/6480031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74792 0039d316-1c4b-4281-b951-d872f2087c98
|