summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* views: Some more layer change, and add/update some tests for layers.sadrul@chromium.org2011-10-1113-29/+131
| | | | | | | | | | | | | | | | Hide the RootView's layer when a Widget is hidden. Call OnNativeWidgetVisibilityChanged on NativeWidgetGtk's hide/show callbacks. The tests: . Make sure Layer bounds change with a View even if it's not visible. . Make sure Layer visibility is updated with a View's visibility. . Make sure Layers get unparented properly when a View is removed from the parent view. BUG=none TEST=views_unittests Review URL: http://codereview.chromium.org/8202026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104846 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 104831 - [Sync] Change default session commit delay to 5s.zea@chromium.org2011-10-111-4/+1
| | | | | | | | | | | | | | The default 10s delay was causing problems in the sync integration tests. BUG=none TEST=none Review URL: http://codereview.chromium.org/8222026 TBR=zea@chromium.org Review URL: http://codereview.chromium.org/8223020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104845 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce dependencies for the AutofillProfileSyncableServiceisherman@chromium.org2011-10-1112-61/+54
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/8221028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104844 0039d316-1c4b-4281-b951-d872f2087c98
* views: Change MessageBoxView API to string16.tfarina@chromium.org2011-10-1111-52/+52
| | | | | | | | | BUG=68267 R=sky@chromium.org Review URL: http://codereview.chromium.org/8221015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104843 0039d316-1c4b-4281-b951-d872f2087c98
* views: Convert download_shelf_context_menu_view.cc to views menu.tfarina@chromium.org2011-10-114-32/+27
| | | | | | | | | BUG=99404 R=sky@chromium.org Review URL: http://codereview.chromium.org/8196004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104842 0039d316-1c4b-4281-b951-d872f2087c98
* Move comctl32.lib dep from content_unittests to content_browser.willchan@chromium.org2011-10-112-5/+1
| | | | | | | | | | | browser_main.cc uses InitCommonControlsEx(). BUG=none TEST=none Review URL: http://codereview.chromium.org/8220025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104841 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leak of HttpServerProperties in URLRequestContextStorage.willchan@chromium.org2011-10-112-2/+2
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/8222022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104840 0039d316-1c4b-4281-b951-d872f2087c98
* Under Aura the Aura Theme takes precedence over the ChromeOS one.saintlou@chromium.org2011-10-111-0/+2
| | | | | | | | | | | TBR=sky@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/8223015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104839 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 104832 - Move ResourceDispatcherHostDelegate to ↵jam@chromium.org2011-10-1116-45/+59
| | | | | | | | | | | | content\public\common. I've added a set delegate function on ChildThread (which will soon be on content::ChildThread interface) so that we don't have to expose ResourceDispatcher to embedders. BUG=98716 Review URL: http://codereview.chromium.org/8224019 TBR=jam@chromium.org Review URL: http://codereview.chromium.org/8226015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104836 0039d316-1c4b-4281-b951-d872f2087c98
* clang: Let update.sh look in chromium_deps/DEPS if it exists.thakis@chromium.org2011-10-111-0/+4
| | | | | | | | | | | | For bare webkit checkouts. BUG=97043 TEST=none Review URL: http://codereview.chromium.org/8220021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104834 0039d316-1c4b-4281-b951-d872f2087c98
* Changed the CHECK condition in PutPredecessor to return false. The upper ↵lipalani@chromium.org2011-10-117-21/+28
| | | | | | | | | | | | layers handle that by either doing a CHECK or doing an unrecoverable error. BUG=91281 TEST= Review URL: http://codereview.chromium.org/8206020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104833 0039d316-1c4b-4281-b951-d872f2087c98
* Move ResourceDispatcherHostDelegate to content\public\common. I've added a ↵jam@chromium.org2011-10-1116-59/+45
| | | | | | | | | set delegate function on ChildThread (which will soon be on content::ChildThread interface) so that we don't have to expose ResourceDispatcher to embedders. BUG=98716 Review URL: http://codereview.chromium.org/8224019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104832 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Change default session commit delay to 5s.zea@chromium.org2011-10-111-1/+4
| | | | | | | | | | | The default 10s delay was causing problems in the sync integration tests. BUG=none TEST=none Review URL: http://codereview.chromium.org/8222026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104831 0039d316-1c4b-4281-b951-d872f2087c98
* [webui] Migrate login_prompt_ui.cc to base::Bind().csilv@chromium.org2011-10-111-1/+4
| | | | | | | BUG=98478 Review URL: http://codereview.chromium.org/8224022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104830 0039d316-1c4b-4281-b951-d872f2087c98
* Certificate host matching rules should accept both absolute and relative DNS ↵rsleevi@chromium.org2011-10-112-9/+32
| | | | | | | | | | | | names. BUG=98627 TEST=net_unittests:X509CertificateNameVerifyTest.VerifyHostname Review URL: http://codereview.chromium.org/8084017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104829 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Final cleanup in history.[cc,h].jhawkins@chromium.org2011-10-112-39/+51
| | | | | | | | | | | BUG=none TEST=none R=csilv@chromium.org Review URL: http://codereview.chromium.org/8211001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104828 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed behavior of the bookmark bar visibility.joaodasilva@chromium.org2011-10-1132-204/+127
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Removed the kEnableBookmarkBar preference. This was only used from the policy code, and duplicated what the kShowBookmarkBar preference already does. Removed custom policy code that handle this. - Fixed the pref UI for the kShowBookmarkBar preference, which wasn't working when set to true by the associated policy. Removed custom UI code for this. - Fire NOTIFICATION_BOOKMARK_BAR_VISIBILITY_CHANGED from a single place, and every time that the preference changes. - Made ChromeWebUI::force_bookmark_bar_visible a virtual method instead, so that subclasses can recompute the state dynamically. The previous implementation wouldn't react to pref changes on existing NTPs. Current behavior of the bookmark bar: - If kShowBookmarkBar is true, it is shown as part of the tab; - If kShowBookmarkBar is false, it is shown inline IF the policy is not set, AND - using the old NTP, OR - using the new NTP without bookmark features. The policy forces the bar to be always visible in all tabs, or to never appear at all. BUG=98918 TEST=The BookmarkBarEnabled policy does what it's supposed to do in the old NTP, new NTP, and new NTP with bookmarks. The show-bookmark-bar shortcut also does the right thing in all versions. Review URL: http://codereview.chromium.org/8135001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104827 0039d316-1c4b-4281-b951-d872f2087c98
* Don't expose RenderViewImpl to tests which use RenderViewTest through its ↵jam@chromium.org2011-10-1113-244/+322
| | | | | | | | | header. Instead add a few methods to RenderViewTest that Chrome tests need. BUG=98716 Review URL: http://codereview.chromium.org/8222014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104826 0039d316-1c4b-4281-b951-d872f2087c98
* aura: Remove browser/ui/views/aura/ paths from build.derat@chromium.org2011-10-101-6/+0
| | | | | | | | | | | | % find chrome/browser/ui/views/aura find: `chrome/browser/ui/views/aura': No such file or directory BUG=none TEST=successfully built with use_aura=1 Review URL: http://codereview.chromium.org/8220018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104824 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Decrease the info bubble fade in animation to 75ms.rsesek@chromium.org2011-10-101-1/+1
| | | | | | | | | | BUG=99311 TEST=Visual. Review URL: http://codereview.chromium.org/8224016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104823 0039d316-1c4b-4281-b951-d872f2087c98
* Disable plugins.PluginsTest.testDisableEnableAllPlugins on win toonirnimesh@chromium.org2011-10-101-0/+2
| | | | | | | | | | TBR=dennisjeffrey@chromium.org BUG=97140 TEST= Review URL: http://codereview.chromium.org/8218024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104822 0039d316-1c4b-4281-b951-d872f2087c98
* Send NOTIFICATION_PANEL_WINDOW_SIZE_KNOWN when window size is known on Linux.prasadt@chromium.org2011-10-101-0/+5
| | | | | | | | | BUG=NONE TEST=Existing PanelBrowserTest.*. Review URL: http://codereview.chromium.org/8226011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104819 0039d316-1c4b-4281-b951-d872f2087c98
* Fix up Autofill GUID computation to support multiple AddressBook addresses ↵isherman@chromium.org2011-10-102-37/+61
| | | | | | | | | | | | in a single me card. BUG=92694 TEST=create a me card with multiple addresses, try to autofill using the second address. Review URL: http://codereview.chromium.org/8189002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104815 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Make the avatar button and menu accessible.rsesek@chromium.org2011-10-105-11/+103
| | | | | | | | | | | | | XIB changes: * Make the checkbox, profile image, and sync state all accessiblity ignored BUG=99405 TEST=Use Accessibility Inspector to verify the accessibility layout. Review URL: http://codereview.chromium.org/8221010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104814 0039d316-1c4b-4281-b951-d872f2087c98
* [print preview] Improve appearance of select control separators.csilv@chromium.org2011-10-102-25/+21
| | | | | | | | | | | | Separators were implemented as options with blank name/values. These appear as blank spaces in the select menu. By using an HR, WebKit will render a menu separator which looks visually nicer. BUG=99534 TEST=Verify printer destination menu in print preview window shows platform separators. Review URL: http://codereview.chromium.org/8207005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104813 0039d316-1c4b-4281-b951-d872f2087c98
* Revved up system library.zelidrag@chromium.org2011-10-101-1/+1
| | | | | | | | BUG=chromium-os:20745 TEST=none Review URL: http://codereview.chromium.org/8220019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104812 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bad NOTREACHED.sky@chromium.org2011-10-101-1/+1
| | | | | | | | | | | BUG=none TEST=none R=ben@chromium.org TBR=ben@chromium.org Review URL: http://codereview.chromium.org/8221026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104810 0039d316-1c4b-4281-b951-d872f2087c98
* Adding more detailed checks for connecting to hidden wifi test.stanleyw@chromium.org2011-10-101-1/+3
| | | | | | | | | | | | | | | | Connecting to wifi networks has an additional error code ERROR_NO_ERROR which is an empty string (This is a bug crosbug.com/21394). Even though we fail to connect to the wifi network, the test thinks otherwise. Test has been updated to avoid this confusion. BUG=NONE TEST=run testConnectToNonExistentWiFiNetwork Change-Id: I9db8f4de5dc10e2b1ac568bd4968183c71f6a77e Review URL: http://codereview.chromium.org/8194007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104809 0039d316-1c4b-4281-b951-d872f2087c98
* Views: Rebuild wrench menu if error is added or removedsail@chromium.org2011-10-104-6/+31
| | | | | | | | | | | | This CL rebuilds the wrench menu model if a new GlobalError object is added or removed. BUG=96608 TEST= Review URL: http://codereview.chromium.org/8201006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104808 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a DCHECK which fires in single process mode indicating that the in proc ↵ananta@chromium.org2011-10-101-6/+10
| | | | | | | | | | | | | | | renderer thread (RendererMainThread) was not quit properly. We initially set this tls flag to true in RendererMainThread::Init to get around this. However there are other threads like the compositor, etc which are started from this thread which set this tls flag to false. Fix is to set the flag to true in the Cleanup function of this thread. This basically caused the debug runs of the chrome frame net tests suite to fail consistently on the try servers. Review URL: http://codereview.chromium.org/8216024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104807 0039d316-1c4b-4281-b951-d872f2087c98
* profile: Add a way for each ProfileKeyedServiceFactory to specify its user ↵erg@chromium.org2011-10-1021-170/+310
| | | | | | | | | | | | | | | | | | | | | prefernces. To allow us to compile individual features in/out of a chrome build, we need to attack browser_prefs.cc, which is a giant static registration. This used to be done through another big code path starting in ProfileImpl which call browser::RegisterUserPrefs() which linked to other static methods. Now this is done through overridding ProfileKeyedServiceFactory::RegisterUserPrefs(), and there are no additional dependencies. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104412 Review URL: http://codereview.chromium.org/7901027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104806 0039d316-1c4b-4281-b951-d872f2087c98
* add default plugin stub for aura to get ui_tests to compile.alicet@chromium.org2011-10-104-2/+199
| | | | | | | | | | BUG=99362 TEST=None Review URL: http://codereview.chromium.org/8226001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104805 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the extension sample pages to show packaged apps.dmazzoni@chromium.org2011-10-1013-14/+172
| | | | | | | | | | | This reveals ttsdemo and ttsdebug, but doesn't affect any other samples. It still excludes hosted apps. BUG=none TEST=none Review URL: http://codereview.chromium.org/8216015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104804 0039d316-1c4b-4281-b951-d872f2087c98
* Aura - Add NativeThemeAura, extract NativeThemeGtk, add sample widget window.jamescook@chromium.org2011-10-1020-150/+473
| | | | | | | | | | | | | | | + Add native_theme_aura and native_theme_gtk, fix button background colors + Fix native_theme_chromeos instance generation + Rename button-related image resources + Rename class NativeThemeLinux to NativeThemeBase + Add window showing sample widgets BUG=98305 TEST=manual Review URL: http://codereview.chromium.org/8199021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104803 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove a static initializer in pickle.cc.thestig@chromium.org2011-10-101-4/+2
| | | | | | | | | BUG=94925 TEST=none Review URL: http://codereview.chromium.org/8207011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104802 0039d316-1c4b-4281-b951-d872f2087c98
* Sync Promo: Add advanced link to promosail@chromium.org2011-10-108-14/+41
| | | | | | | | | | | | | | | This CL adds an advanced link to the sync promo. Clicking on the link takes the user to the settings version of the sign in page. Screenshot: http://www.dropmocks.com/mbBaC BUG=98844 TEST= Review URL: http://codereview.chromium.org/8226003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104801 0039d316-1c4b-4281-b951-d872f2087c98
* set the user agent to match chrome's for consistency in running thedpranke@chromium.org2011-10-101-0/+11
| | | | | | | | | | | | | unit tests regardless of whether content is linked into the same DLL or a separate one. R=akalin@chromium.org BUG=none TEST= Review URL: http://codereview.chromium.org/8222012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104800 0039d316-1c4b-4281-b951-d872f2087c98
* Deprecate task.hwillchan@chromium.org2011-10-101-0/+25
| | | | | | | | | | BUG=35223 TEST=none Review URL: http://codereview.chromium.org/8223010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104799 0039d316-1c4b-4281-b951-d872f2087c98
* [web-ui] Partial migration of certificate_manager_handler.cc to base::Bind().csilv@chromium.org2011-10-101-39/+70
| | | | | | | BUG=98478 Review URL: http://codereview.chromium.org/8207008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104797 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Cleanup in test_shell.jhawkins@chromium.org2011-10-1024-240/+288
| | | | | | | | | | | BUG=none TEST=none R=csilv@chromium.org Review URL: http://codereview.chromium.org/8215002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104796 0039d316-1c4b-4281-b951-d872f2087c98
* Make ExtensionSettingsHandler only listen to notifications pertaining to its ↵yoz@chromium.org2011-10-101-20/+42
| | | | | | | | | | | profile. BUG=98996 TEST=covered by existing tests Review URL: http://codereview.chromium.org/8199022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104795 0039d316-1c4b-4281-b951-d872f2087c98
* Allow controlling the Instant field trial through a command line flag.sreeram@chromium.org2011-10-106-7/+23
| | | | | | | | | | | | | This also allows us to disable the field trial for all tests, without hacking around the kInstantEnabledOnce preference. BUG=none TEST=none Review URL: http://codereview.chromium.org/8198027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104794 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that a ContextGroup is not destroyed if it was not correctly initialized.apatrick@chromium.org2011-10-101-2/+6
| | | | | | | | | The counting of contexts in the group was out of sync, causing an assertion in release builds. BUG=97775 Review URL: http://codereview.chromium.org/8205021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104791 0039d316-1c4b-4281-b951-d872f2087c98
* Disable notifications.NotificationsTest.testNotificationOrderAfterClosingOne ↵aocampo@google.com2011-10-101-0/+2
| | | | | | | | | in Linux too BUG=66072 Review URL: http://codereview.chromium.org/8216023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104790 0039d316-1c4b-4281-b951-d872f2087c98
* Task manager: Properly observe background contents from incognito profiles.yoz@chromium.org2011-10-101-4/+11
| | | | | | | | | BUG=99420 TEST=follow instructions in bug. don't crash. Review URL: http://codereview.chromium.org/8205011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104789 0039d316-1c4b-4281-b951-d872f2087c98
* Allow a window to be passed to WebGraphicsContext3DInProcessImplpiman@chromium.org2011-10-105-26/+57
| | | | | | | | | | BUG=None TEST=Webkit compositor in browser process Review URL: http://codereview.chromium.org/8202021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104787 0039d316-1c4b-4281-b951-d872f2087c98
* Allow FlushSyncs to short circuitjbauman@chromium.org2011-10-106-111/+74
| | | | | | | | | | | | All messages on a channel are now executed in order, so Flushs have to wait for all previous AsyncFlushs to finish. This is generally unnecessary, so we replace Flush with a GetStateFast message. All commands are queued up when they enter the gpu process, and GetStateFast commands are moved to the head of the line. BUG= TEST=trybots, webgl conformance tests Review URL: http://codereview.chromium.org/8198017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104786 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Rebuild wrench menu if error is added or removedsail@chromium.org2011-10-102-5/+28
| | | | | | | | | | | | This CL rebuilds the wrench menu model if a new GlobalError object is added or removed. BUG=96608 TEST= Review URL: http://codereview.chromium.org/8200006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104783 0039d316-1c4b-4281-b951-d872f2087c98
* Notify users about certain changes in installed extensions.miket@chromium.org2011-10-1013-7/+533
| | | | | | | | | | | | | | | | | | | | | | | | This is an interim checkin. The added code is unreachable. Remaining: - Implement concept of orphaned extensions. Currently hardcoded false. - Once GlobalError's view supports DOMView, enhance to allow selective disabling of extensions. - Add unit test for ExtensionGlobalError (though there isn't much to test). - Get real UI layout and text. Currently placeholder text. - Bug: extensions page opens in new window, not new tab. - Bug: once we've determined that an alert needs to be displayed, the alert doesn't actually display until the next window open. We ought to add a different trigger. This might be a systemwide decision, so I'd like sail's input. BUG=94494 TEST=enhanced ExtensionPref unit tests. Review URL: http://codereview.chromium.org/8202011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104782 0039d316-1c4b-4281-b951-d872f2087c98
* Move some testing classes used by chrome to content\renderer, to match what ↵jam@chromium.org2011-10-1010-19/+15
| | | | | | | | | we're doing with other test classes. BUG=98716 Review URL: http://codereview.chromium.org/8216019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104781 0039d316-1c4b-4281-b951-d872f2087c98