summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Convert history to use new sql wrappers. Enhance wrappers in several ways tobrettw@chromium.org2009-10-0243-1311/+1135
| | | | | | | | | | support the needs of history. BUG=none TEST=covered by unit tests Review URL: http://codereview.chromium.org/246053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27832 0039d316-1c4b-4281-b951-d872f2087c98
* Make sudden termination into a counter.estade@chromium.org2009-10-023-0/+23
| | | | | | | | | | | | | | | | | We were incorrectly interpreting enableSuddenTermination to mean "enable sudden termination". Really it should just decrement a counter, and we should only enable sudden termination when that counter reaches 0. Related to, but not the fix for, http://crbug.com/5638 This may have been causing memory corruption due to shutting down the renderer process while writing to a storage area or icon database (although honestly I don't actually know if we even use those parts of webkit). Also, add a ui test that fails before this patch and succeeds with this patch. BUG=none TEST=sudden termination still works on a simple page Review URL: http://codereview.chromium.org/245036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27831 0039d316-1c4b-4281-b951-d872f2087c98
* Adding one more test to test_expectations.txt, in hopes of more green.senorblanco@chromium.org2009-10-021-0/+1
| | | | | | | | | | BUG=none TEST=greener? TBR=dglazkov Review URL: http://codereview.chromium.org/251068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27830 0039d316-1c4b-4281-b951-d872f2087c98
* Don't run RenderViewTest.ImeComposition under ThreadSanitizertimurrrr@chromium.org2009-10-021-0/+2
| | | | | | | BUG=23580 Review URL: http://codereview.chromium.org/259007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27829 0039d316-1c4b-4281-b951-d872f2087c98
* Add a few more failing tests test_expectations.txt (to be rebaselined).senorblanco@chromium.org2009-10-021-0/+3
| | | | | | | | | BUG=none TEST=green bots TBR=dglazkov git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27828 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS for Skia 341:364. Don't be alarmed -- the broken layout testssenorblanco@chromium.org2009-10-022-1/+79
| | | | | | | | | | | just need rebaselines for minor pixel diffs. BUG=none TEST=green bots TBR=dglazkov Review URL: http://codereview.chromium.org/255056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27827 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Remove unnecessary GetPasswordFormAt call.mattm@chromium.org2009-10-021-1/+0
| | | | | | | | | | CID=6161 BUG=none TEST=none Review URL: http://codereview.chromium.org/242108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27826 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Check GetInteger & GetBoolean return.mattm@chromium.org2009-10-021-2/+2
| | | | | | | | | | CID=5937,5838 BUG=none TEST=none Review URL: http://codereview.chromium.org/255051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27825 0039d316-1c4b-4281-b951-d872f2087c98
* Add some initial code for the top sites service. This will be a replacement forbrettw@chromium.org2009-10-028-21/+605
| | | | | | | | | | | | | | | | | | | | | | | | | | | the thumbnail database, and will also replace the ThumbnailStore which was the previous replacement we didn't ship. This component will be very much like the ThumbnailStore wtih the addition of the actual most visited data (not just thumbnails) and that it is threadsafe. This class is designed to be called on any thread. When it is complete, thumbnails will be added to it from the UI thread of the browser. Requests for thumbnails and the most visited data can be serviced directly on the I/O thread without going through the UI thread, and since the data is cached, the request won't also have to go through the history thread. The current state is that it cqan store and update the the most visited list and thumbnails. There are unit tests covering this behavior. I also added support for redirect ranking to ThumbnailScore. This is to duplicated the ranking function in history currently, where it prefers thumbnails closer to the end of a redirect chain. Since we won't be using the history service and are only storing thumbnails for the most visited items, we have to track the redirect index ourselves. BUG=none TEST=covered by unit tests (hopefully!) Review URL: http://codereview.chromium.org/251002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27824 0039d316-1c4b-4281-b951-d872f2087c98
* For some reason, if the interactive test that I added runs after inprocess ↵jam@chromium.org2009-10-022-41/+37
| | | | | | | | | | tests (still in interactive tests), it gives an assert in Linux before it starts because the existing process count is 2. Moving it to a different file solves the prolbem. TBR=jcampan BUG=5496 Review URL: http://codereview.chromium.org/259010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27823 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix the Linux views buildjam@chromium.org2009-10-021-2/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27822 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r27819 because it causes net_unittests to crash in thewtc@chromium.org2009-10-021-20/+38
| | | | | | HTTPSRequestTest.HTTPSGetTest test. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27821 0039d316-1c4b-4281-b951-d872f2087c98
* Adding new files for http://codereview.chromium.org/245036/showestade@chromium.org2009-10-023-0/+56
| | | | | | | | | | The trybots are failing that patch, so I am going to try checking in these changes separately, then try the rest of the patch. TBR=nsylvain Review URL: http://codereview.chromium.org/249064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27820 0039d316-1c4b-4281-b951-d872f2087c98
* Map SEC_ERROR_OCSP_BAD_HTTP_RESPONSE (-8073) towtc@chromium.org2009-10-021-38/+20
| | | | | | | | | | | | | | | | | | CERT_STATUS_UNABLE_TO_CHECK_REVOCATION. Change ParsePrincipal to take the decoded CERTName as argument. Use the NSS functions for getting the common name, locality name, state or province name, and country name because they escape the strings properly. R=dank BUG=none TEST=none (covered by existing unit tests) Review URL: http://codereview.chromium.org/248028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27819 0039d316-1c4b-4281-b951-d872f2087c98
* Set the LITE runtime optimization flag in sync.proto.nick@chromium.org2009-10-024-109/+92
| | | | | | | | | | | This generates c++ code without support for protobuf reflections, and shaves 175000 bytes off of the final release size of syncapi.dll. BUG=none TEST=tested sync interactively with two clients. Review URL: http://codereview.chromium.org/249034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27818 0039d316-1c4b-4281-b951-d872f2087c98
* Check in the binary resources from:aa@chromium.org2009-10-024-0/+5
| | | | | | | | | | http://codereview.chromium.org/259004 separately so that the code changes can be run on the try bot. TBR=erikkay@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27817 0039d316-1c4b-4281-b951-d872f2087c98
* Add Profile::DeleteSpellChecker(), which my MemoryPurger will use to purge ↵pkasting@chromium.org2009-10-025-58/+58
| | | | | | | | | | | | | | the spellchecker objects from memory. This reworks the SpellChecker management functions inside the ProfileImpl for simplicity. The only notable side effect is that GetSpellChecker() will now cause a notification if it inits |spellchecker_|, just like ReinitializeSpellChecker() already did. This was just to simplify the code; at the point this fires, no one will be listening yet, so it won't actually do anything. Also use a temporary at one spot in browser_render_process_host.cc instead of calling a heavyweight function twice in a row. BUG=23400 TEST=none Review URL: http://codereview.chromium.org/259009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27816 0039d316-1c4b-4281-b951-d872f2087c98
* Rollback broken change, again.aa@chromium.org2009-10-028-129/+4
| | | | | | TBR=erikkay@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27815 0039d316-1c4b-4281-b951-d872f2087c98
* Don't send tab switching/killing/creating keyboard accelerators to pages. ↵jam@chromium.org2009-10-0225-30/+198
| | | | | | | | | | This avoids tabs maliciously preventing closing using ctrl+f4/ctrl+w/alt+f4, and also hung/slow renderers from making tab cycling sluggish. BUG=5496 TEST=added ui test Review URL: http://codereview.chromium.org/224023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27814 0039d316-1c4b-4281-b951-d872f2087c98
* Check in http://codereview.chromium.org/259004 again.aa@chromium.org2009-10-028-4/+129
| | | | | | | | First cut at badge implementation. TBR=erikkay@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27812 0039d316-1c4b-4281-b951-d872f2087c98
* Replace Read/Write lock with a plain old chrome lock.chron@chromium.org2009-10-023-261/+68
| | | | | | | | BUG=19895 Review URL: http://codereview.chromium.org/246056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27811 0039d316-1c4b-4281-b951-d872f2087c98
* Add UMA histograms for sqlite errorscpu@chromium.org2009-10-022-0/+48
| | | | | | | | | | | | | - cookies - history db TEST=none BUG=none Review URL: http://codereview.chromium.org/243055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27810 0039d316-1c4b-4281-b951-d872f2087c98
* Rolling DEPS to include latest FFmpeg binaries for Windows.scherkus@chromium.org2009-10-021-1/+1
| | | | | | | | | | TBR=cpu BUG=23189 Review URL: http://codereview.chromium.org/251063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27809 0039d316-1c4b-4281-b951-d872f2087c98
* Put the dummy implementations in testing_profile.h on one line where ↵pkasting@chromium.org2009-10-021-114/+44
| | | | | | | | | | possible, making the file feel a little less verbose and more readable. (A few functions already did this.) BUG=none TEST=none Review URL: http://codereview.chromium.org/249063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27808 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: check Thread::Start return value.mattm@chromium.org2009-10-021-3/+3
| | | | | | | | | | CID=6207,6206 BUG=none TEST=none Review URL: http://codereview.chromium.org/242105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27807 0039d316-1c4b-4281-b951-d872f2087c98
* Fix linux views build.estade@chromium.org2009-10-021-2/+2
| | | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/255049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27805 0039d316-1c4b-4281-b951-d872f2087c98
* Change a phishing report URL param.paul@chromium.org2009-10-021-1/+1
| | | | | | | | | BUG=22542 TEST=None. Review URL: http://codereview.chromium.org/242110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27804 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes the following issueananta@chromium.org2009-10-024-34/+47
| | | | | | | | | | | | | | | | | | | | | | | | Ensures Alt and Alt + character keys work correctly in ChromeFrame. There were two issues here:- a. Chrome would not forward unhandled Keyup messages. For the curious this carries WM_SYSKEYUP which is needed for Alt key to work. b. WM_SYSCHAR is not handled by the TranslateAccelerator function in IOleControlSite and IBrowserService2::v_MayTranslateAccelerator MSHTML does the same thing and also dispatches the message. We need to understand this better. For now we just post the message back to our parent which works. This fixes http://code.google.com/p/chromium/issues/detail?id=22996 Bug=22996 Review URL: http://codereview.chromium.org/257019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27803 0039d316-1c4b-4281-b951-d872f2087c98
* Fix missing import.ojan@chromium.org2009-10-011-0/+1
| | | | | | Review URL: http://codereview.chromium.org/242113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27802 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Detach bookmark bar on NTP.estade@chromium.org2009-10-0111-71/+298
| | | | | | | | | | | | | | | | | | | TODO=get alignment right for NTP background when alignment != top TODO=fancy-pants animation (on windows this animation looks rather janky anyway so I'm not eager to work on this) TODO=tweak in gtk mode (border color=?) TEST=fiddle a lot, make sure there are no problems with find bar occlusion. TEST=install a bunch of different themes; everything looks right (up to TODOs) TEST=switch back and forth between gtk theme and chromium theme TEST=popup windows still work TEST=poked around in valgrind TEST=poked around with fullscreen BUG=18780 Review URL: http://codereview.chromium.org/243057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27801 0039d316-1c4b-4281-b951-d872f2087c98
* Add the GL ES 2.0 header files.gman@google.com2009-10-013-0/+919
| | | | | | | | | Not sure this is the best place for them but we can move them later. Review URL: http://codereview.chromium.org/256031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27800 0039d316-1c4b-4281-b951-d872f2087c98
* Improve error reporting for the case where you don't have anyojan@chromium.org2009-10-011-5/+6
| | | | | | | | modifiers supplied for a test. Before this change it would leave options_string == None, which throws a confusing error in _GetOptionsList. Review URL: http://codereview.chromium.org/242112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27799 0039d316-1c4b-4281-b951-d872f2087c98
* Add some debugging junk to ExtensionMessageService to track down a crash.mpcomplete@chromium.org2009-10-017-4/+66
| | | | | | | | | BUG=21201 TEST=no Review URL: http://codereview.chromium.org/256029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27798 0039d316-1c4b-4281-b951-d872f2087c98
* Add (yet another) option to allow stripping the chrome binary after dumping ↵thestig@chromium.org2009-10-013-7/+19
| | | | | | | | | | symbols. Chromebot does not like 200MB zip files and 800MB chrome binaries. BUG=none TEST=none Review URL: http://codereview.chromium.org/259008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27795 0039d316-1c4b-4281-b951-d872f2087c98
* A small cleanup to the sync setup flow.nick@chromium.org2009-10-013-3/+6
| | | | | | | | | BUG=20339 TEST=none Review URL: http://codereview.chromium.org/243065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27794 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the SslInitializationSingleton over to a base/singleton.nick@chromium.org2009-10-011-14/+3
| | | | | | | | | | | | | The existing implementation crashed when I switched syncapi to static linkage, I think because pthreads had already been unloaded when CleanupSSL happened. BUG=19895 TEST=basic two-client sync run-through, start-up, shutdown. Review URL: http://codereview.chromium.org/246067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27792 0039d316-1c4b-4281-b951-d872f2087c98
* Update test_expectations to better match the state of the bots.ojan@chromium.org2009-10-011-10/+64
| | | | | | | | Mainly, identify all the LayoutTests/accessibility tests that actually always FAIL instead of FAIL PASS. Review URL: http://codereview.chromium.org/249062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27791 0039d316-1c4b-4281-b951-d872f2087c98
* Landing font change again. I don't believe early flakiness was thesky@chromium.org2009-10-012-16/+28
| | | | | | | | | | | | result of my change. test_shell doesn't use font at all. This is exactly the same change as was earlier landed. BUG=22791 TEST=see bug TBR=agl Review URL: http://codereview.chromium.org/242111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27790 0039d316-1c4b-4281-b951-d872f2087c98
* Override mechanism for features.gypiyaar@chromium.org2009-10-012-2/+47
| | | | | | | | This will allow us to have a different set of feature_defines for upstream and downstream webkit builds. Review URL: http://codereview.chromium.org/242102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27789 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure my recent changes are represented in the patches.cevans@chromium.org2009-10-013-391/+1934
| | | | | | | | | | | Split out the fts2 changes a little. BUG=NONE TEST=Applied the patches in order to check for mistakes. Review URL: http://codereview.chromium.org/243068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27787 0039d316-1c4b-4281-b951-d872f2087c98
* Do some cleanup of BrowserRenderProcessHost::Init to try to reduce thebrettw@chromium.org2009-10-012-141/+198
| | | | | | | | | | complexity and clean up some of the ifdefs. BUG=none TEST=none Review URL: http://codereview.chromium.org/254008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27786 0039d316-1c4b-4281-b951-d872f2087c98
* Only highlight tests that take > 1 second as needing to be marked as slow.ojan@chromium.org2009-10-011-1/+11
| | | | | | | | There are too many tests that take ~1 second every couple hundred runs. It's not worth the manual maintenance effort. Review URL: http://codereview.chromium.org/242106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27785 0039d316-1c4b-4281-b951-d872f2087c98
* Rolling WebKit DEPS to 48976.atwilson@chromium.org2009-10-012-1/+6
| | | | | | | | | | Rebaselining mouse-drag-from-frame-to-other-frame because the upstream test is failing and they updated the expectations upstream to reflect the failure output. This breaks us, because we are not failing, so we have to rebaseline. TEST=none TBR=jparent Review URL: http://codereview.chromium.org/251061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27784 0039d316-1c4b-4281-b951-d872f2087c98
* Update some strings in the options dialog w.r.t. themes.tony@chromium.org2009-10-012-7/+12
| | | | | | | | | | | Changed the heading from Themes: to Appearance: and switch from 'Set to XXX theme' to 'Use XXX theme'. BUG=21504 Review URL: http://codereview.chromium.org/243059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27783 0039d316-1c4b-4281-b951-d872f2087c98
* Rename EscapeUrl and expand the code comment.brg@chromium.com2009-10-014-6/+6
| | | | | | | | BUG=none TEST=Escape.EscapeUrlEncodedData Review URL: http://codereview.chromium.org/257021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27782 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure ChromeURLRequestContext finds out first about extension loading.rafaelw@chromium.org2009-10-015-53/+71
| | | | | | | | | | This prevents races from arising where extension renderers may try to navigate to extension urls before the request context knows how to map the urls to extension resources. BUG=22668 Review URL: http://codereview.chromium.org/255047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27781 0039d316-1c4b-4281-b951-d872f2087c98
* Move various methods from glue/webview.h to api/public/WebView.h darin@chromium.org2009-10-0122-179/+110
| | | | | | | | | | | | | | | | | | I'll re-order the methods in webview_impl.cc in a follow-up CL. I wanted to keep this one easy to review. SetBackForwardListSize is no longer necessary given that BackForwardListChromium.cpp doesn't care about its capacity. R=dglazkov BUG=10033 TEST=none Originally reviewed here: http://codereview.chromium.org/251051 Review URL: http://codereview.chromium.org/255042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27780 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up wifi menu button UI to ChromeOS shared library.chocobo@google.com2009-10-019-134/+344
| | | | | | | | BUG=none TEST=23090 Review URL: http://codereview.chromium.org/246057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27779 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in test_shell on linux. When closing the window we can getsky@chromium.org2009-10-011-1/+5
| | | | | | | | | | | | notification of focus changes after the WebWidgetHost has been deleted, resulting in a crash. BUG=none TEST=none Review URL: http://codereview.chromium.org/255046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27778 0039d316-1c4b-4281-b951-d872f2087c98
* A couple usability improvements to the dashboard:ojan@chromium.org2009-10-011-9/+18
| | | | | | | | | | | | | | | | | | 1. Pick a color for wrong-expectations that is more different from the browser's selection color. 2. Make the webkit merge color grey instead of black to avoid confusing it with passing results. 3. Make single-clicking on test paths select the whole test path for easier copy-pasting. One functionality improvement. Walk through the paths in test_expectations in sorted order, not reverse sorted. We want to hit the more specific expectations *last*, but we were hitting them first. So the less-specific expectations (e.g. LayoutTests/foo) were overriding the more-specific (e.g. LayoutTests/foo/bar.html). Review URL: http://codereview.chromium.org/249060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27777 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 23:59:30 +0000