| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
to see if it fixes the gmock crashes we've been seeing since the
change has been made.
The original change was split between r74660, r74168, r74059
Review URL: http://codereview.chromium.org/6473006
TBR=nsylvain@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64049
TEST=
Review URL: http://codereview.chromium.org/6513002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59945
TEST=trybots
Review URL: http://codereview.chromium.org/6507012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=tested on Linux desktop
oshima landed for penghuang
Review URL: http://codereview.chromium.org/6480036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for Widget, and will merge the common functionality between NativeWidgetWin and WidgetGtk.
Right now it does nothing other than implement Widget (for compatibility) and the new NativeWidgetListener interface, imported from ui/views/widget. This new interface is the NativeWidget's way of notifying the Widget of events.
Also bring across the NativeWidget interface from ui/views/widget, which will be implemented by NativeWidgetWin in a future changelist.
BUG=72040
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/6510008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
signature found.
The present pattern does not have a single quotation mark after destructor.
Below is taken from the log (with newlines added for the readability)
Checking new crashes...
INFO: NEW stack trace signature found:
webcore::shadowdata::`scalar deleting destructor'___
webcore::shadowdata::`scalar deleting destructor'___
webcore::shadowdata::`scalar deleting destructor'___
webcore::shadowdata::`scalar deleting destructor'___
..... and goes on ...
INFO: known stack trace signature found.
(match REGEX, tcmalloc.+webcore.+)
REGRESSION: NEW crash stack traces found
--------------------
Repro information:
UI sequence: SetUp,newtab,navigate,openwindow,navigate,pagedown,showbookmarks,back,navigate,back,navigate
Stack trace:
chrome_2590000!WebCore::ShadowData::`scalar deleting destructor'+0xa
chrome_2590000!WebCore::ShadowData::`scalar deleting destructor'+0x11
chrome_2590000!WebCore::ShadowData::`scalar deleting destructor'+0x11
chrome_2590000!WebCore::ShadowData::`scalar deleting destructor'+0x11
chrome_2590000!WebCore::ShadowData::`scalar deleting destructor'+0x11
chrome_2590000!WebCore::ShadowData::`scalar deleting destructor'+0x11
chrome_2590000!WebCore::ShadowData::`scalar deleting destructor'+0x11
chrome_2590000!WebCore::ShadowData::`scalar deleting destructor'+0x11
chrome_2590000!WebCore::ShadowData::`scalar deleting destructor'+0x11
chrome_2590000!WebCore::ShadowData::`scalar deleting destructor'+0x11
chrome_2590000!WebCore::ShadowData::`scalar deleting destructor'+0x11
BUG=70031
TEST=NONE
TBR=huanr
Review URL: http://codereview.chromium.org/6507011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6489015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59945
TEST=trybots
Review URL: http://codereview.chromium.org/6509004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59945
TEST=trybots
Review URL: http://codereview.chromium.org/6512002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* More separation of presentation from content.
* Brought css file in line with Chrome style.
* Fixed a JS error on page load.
BUG=72363
TEST=none
Review URL: http://codereview.chromium.org/6480038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=71947
TEST=Verify that throbber renders properly when zoomed to 120%.
Review URL: http://codereview.chromium.org/6250208
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to see if it fixes the gmock crashes we've been seeing since the
change has been made.
The original change was split between r74660, r74168, r74059
Review URL: http://codereview.chromium.org/6473006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=68868
TEST=Ensure that the HTTPS info bubble in the location bar is properly centered in popup windows. This can be seen by visiting engadget.com, clicking on a DISCUSS thread, and attempting to sign on with a twitter account (sample URL: http://www.engadget.com/2011/02/10/inq-cloud-touch-preview/#comments).
Review URL: http://codereview.chromium.org/6476029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
phishing detection.
This CL just adds a framework for running these checks, and adjusts the
renderer-side logic to delay phishing classification until the browser has
sent an IPC signaling that it should run. Future CL's will add the actual
checks, which will include a whitelist lookup, intranet hostname checks, and
per-day ping limit.
BUG=none
TEST=updated existing tests
Review URL: http://codereview.chromium.org/6398001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
NaCl builds the CommandBuffer sources with -pedantic.
BUG=NaCl:1420
TEST=Compiling NaCl's SDK succeeds without removing -pedantic.
Review URL: http://codereview.chromium.org/6507009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change puts ShowExtensionInstalledBubble() in a common cross platform header.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6490015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=70097
TEST=unit tests
Review URL: http://codereview.chromium.org/6488013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The sync integration tests must use a non-encrypted password store on
Linux in order to run on the Chromium buildbots and trybots, or else
they might end up relying on an encryption daemon that may be missing on
the bots.
See http://code.google.com/p/chromium/wiki/LinuxPasswordStorage.
This patch makes the sync tests use the --password-store=basic flag to
ensure that we always use a basic password store.
BUG=69146
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/6486023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/6510001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
loaded document.
This is because they expect ChromeFrame to implement interfaces like IHTMLDocument2 on the same
lines as regular IE documents. Currently in ChromeFrame we patch the invoke methods of these
BHO's prior to firing navigation events from ChromeFrame. However this is not enough as
these objects also crash for regular navigation events fired from IE when ChromeFrame is loaded.
We now don't fire navigation events for buggy BHO's if ChromeFrame is the current document.
The BuggyBho handler instance is now created once for the thread. We patch when we receive
navigation notifications from Chrome as before. When we receive a notification
on our patched event sink we check if CF is loaded and if yes skip the call.
Added helpers to chrome frame utils to check if CF is loaded in the current web browser instance.
BUG=55932
TEST=none
Review URL: http://codereview.chromium.org/6493002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59945
TEST=trybots
Review URL: http://codereview.chromium.org/6507006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=simulate sleeping watchdog thread, try
BUG=72697
Review URL: http://codereview.chromium.org/6503007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=find those machines, verify
Review URL: http://codereview.chromium.org/6504006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Note: This is one out of two patches that together will fix sub-frame exporting during 'save page as'. The other one is here: https://bugs.webkit.org/show_bug.cgi?id=53897
Patch from Magnus Danielsson <fuzzac@gmail.com>
Original CL: http://codereview.chromium.org/6286140/
BUG=25303
TEST=Open www.cnn.com and click 'save page as'. Check the log to make sure no files failed to save due to too long file names.
Review URL: http://codereview.chromium.org/6474018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6502009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= 59945
TEST=trybots
Review URL: http://codereview.chromium.org/6485016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Click to open Wrench menu. Click the +/- buttons. Page zooms and percentage updates.
Review URL: http://codereview.chromium.org/6488016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a page loads additional content via secondary
connections from its own domain, this CL should
learn from those connections, and reserve additional
connections during the primary connection.
r=mbelshe@chromium.org
bug=72666
Review URL: http://codereview.chromium.org/6487019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
into chrome.packed.7z
BUG=http://code.google.com/p/nativeclient/issues/detail?id=1418
TEST=None
Review URL: http://codereview.chromium.org/6502008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
V8 includes native JSON support (part of ECMA-262, ed. 5) and we don't
have to worry about compatibility with other JavaScript backends.
BUG=69500
TEST=
Review URL: http://codereview.chromium.org/6503009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=72637
TEST=none
Review URL: http://codereview.chromium.org/6503010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Not handling correctly caused a crash. Added unit tests to cover those cases.
BUG=71953
TEST=covered by installer util unit tests
Review URL: http://codereview.chromium.org/6485026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=NaCl:910
Review URL: http://codereview.chromium.org/6505002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TODO(willchan): Whack the other old suppressions that this supercedes.
BUG=72698
TEST=none
Review URL: http://codereview.chromium.org/6474048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
constructor.
R=cbentzel
CID=8793
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6492001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Put the SSE2 block differ code back in.
TBR=dhollowa
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/6501005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
FormStructureBrowserTest.DataDrivenHeuristics.
BUG=72401
TEST=
Review URL: http://codereview.chromium.org/6486027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is accomplished with hashtags, which also make it possible to copy/paste a search URL.
I also removed the special hash handling in content settings exceptions, because it's enough to check the hash in didShowPage (to make that possible, I made it so the history/address bar updates before didShowPage is called).
TESTS:
1. if you type something in the search field, then click away (either on a link or nothing), that search page is persisted in history
2. go to browser page. Search for a. click on the right pane. Add more text to the search and click a subpage overlay. Clicking back should walk back through both searches all the way to the basics page.
3. search for something and click away from the search field. close the tab. re-open with ctrl-shift-t. You should get back to the search page you were on.
4. Clicking the same link in the navbar twice shouldn't add more than 1 entry to history.
note that 3 sometimes fails, but I think it's a problem of session restore not updating quickly enough (the wrong URL is populated for the restored tab).
BUG=71477
TEST=see above
Review URL: http://codereview.chromium.org/6420001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6487015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Open input method drop-down, press alt-shift, observe selected input method changed in drop-down.
oshima landed for vsevik
Review URL: http://codereview.chromium.org/6246138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is necessary to get context menus working in Pepper.
MenuClosed is called on views+win and native gtk, so this seems like the right thing to do.
BUG=none
TEST=Ran Pepper Flash on a Chrome OS build, made sure context menus work
Review URL: http://codereview.chromium.org/6250098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
due to this.
BUG=chromium-os:10655
TEST=manual
Review URL: http://codereview.chromium.org/6476011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reland V8 update since it didn't make media_unittests pass.
Trying to see if this is related to the media_unittests crash.
Review URL: http://codereview.chromium.org/6486026
TBR=ricow@chromium.org
Review URL: http://codereview.chromium.org/6504001
TBR=tony@chromium.org
Review URL: http://codereview.chromium.org/6500009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Currently just log them to console for now; I'll do something with them
in a future CL.
BUG=69500
Review URL: http://codereview.chromium.org/6480018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, restore non-editability to location and notifications exceptions.
BUG=72355
TEST=manual
Review URL: http://codereview.chromium.org/6486019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/6485015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compile
Review URL: http://codereview.chromium.org/6485017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
selection border. This should fix it.
BUG=51181
TEST=Go to bookmarks manager and right click a folder and select 'Rename...'. The blue borders should not be covered by the input boxes. The text in the input boxes should align exactly with the text before and after editing.
Review URL: http://codereview.chromium.org/6468001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6487017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6489023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74655 0039d316-1c4b-4281-b951-d872f2087c98
|