| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
That patch wasn't what caused the regression in the page cycler.
BUG=51411,52103
TEST=still compiles
Review URL: http://codereview.chromium.org/3106018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50699
TEST=First three (or two in Vietnam and Iran) search engine logos always available on import in --organic Chrome (not Chromium).
Review URL: http://codereview.chromium.org/3189004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For each resolution request this checks to see if this 'host' is a literal ip address. If so, it synthesises a struct addrinfo and returns it without adding it to the cache.
BUG=39830
TEST=unit tests, new and old
Review URL: http://codereview.chromium.org/3023048
TBR=vandebo@chromium.org
Review URL: http://codereview.chromium.org/3115014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
For each resolution request this checks to see if this 'host' is a literal ip address. If so, it synthesises a struct addrinfo and returns it without adding it to the cache.
BUG=39830
TEST=unit tests, new and old
Review URL: http://codereview.chromium.org/3023048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
follow up to http://codereview.chromium.org/3170023/show
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3193003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
not look broken.
TBR=ben
BUG=none
TEST=Run in Aero with --lang=he, hit ctrl-shift-n, Incognito image should not be broken in two
Review URL: http://codereview.chromium.org/3117016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TabStrip::SetBackgroundOffset() into a single call in a different place.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3107012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chromium. It is a network level implementation and should constitute a good
enough bottleneck to manage every outgoing http request.
Committing for malavv@google.com.
Original review: http://codereview.chromium.org/2487001/show
BUG=none
TEST=unit tests
Review URL: http://codereview.chromium.org/3005049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
a bug in tabapplescript. Added more examples.
patch from (v.a.shreyas@gmail.com)
BUG=none
TEST=run tests included in CL.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Thumbnails file is renamed to Favicons.
The new "Top Sites" DB file is added.
TEST=about:histograms
BUG=none
Review URL: http://codereview.chromium.org/3113002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
selecting/focusing elements. Change context menu tests to use this approach.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3115002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Follow up to http://src.chromium.org/viewvc/chrome?view=rev&revision=56299
BUG=22109,16096
Review URL: http://codereview.chromium.org/3170023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
list.
I have also set the svn:ignore property for the 'speex' subdir under third_party directory, though I guess it can't be seen in the review.
BUG=none
TEST=none yet
Review URL: http://codereview.chromium.org/3143022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(http://code.google.com/p/chromium-os/issues/detail?id=4448)
Moved PopupNonClientFrameView to its own file and moved FrameView initialization logic to BrowserFrameChromeos::Init.
TEST=See issue. Additionally, ensure that non-chromeos Chrome popup window behavior is unaffected, and that the address bar is still visible for popup windows not generated by apps (e.g popped out google chat windows), on chromeos and non-chromeos.
Review URL: http://codereview.chromium.org/3133001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Apply 10% white to selected menu button;
- Remove the menu offset so that the menu is top aligned with toolbar;
- Make all status area buttons derive from StatusAreaButton;
- Move ClockMenuButton's text size logic into StatusAreaButton to share the
logic with LanguageMenuButton;
- Strip unused space from LanguageMenuButton so that it looks good with 10%
white highlight;
- Make LanguageMenuButton and ClockMenuButton center aligned;
- Add 1-pixel padding at top when the vertical space is odd number so that text
looks properly aligned with the icons;
BUG=chromium-os:5517
TEST=Verify fix for chromium-os:5517.
Review URL: http://codereview.chromium.org/3141019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
translate" infobar when in Incognito mode.
BUG=52305
TEST=See bug.
Review URL: http://codereview.chromium.org/3164016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3109025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This happens mainly in chrome frame where password manager
or the web data service could be invalid due to failed sqllite
initialization. The failure is due to chrome.exe running in low
integrity mode while deleting browser history. This a temporary
fix to avoid crash the right fix is to run chrome.exe at medium
integrity and that involves some investigation.
Now why chrome.exe runs in the low integrity mode is a long
story. Chrome Frame implements IDeleteBrowsingHistory to
participate in history/user data deletion. IE8 tries to be
smart and invokes IDeleteBrowsingHistory methods in by
launching a separate process, rundll32.exe. However, when
npchrome_frame.dll's implementation is invoked the container
rundll32.exe is in low integrity. IE's elevation policy does
not work for us to elevate chrome_launcher.exe to medium in
this case (since this is not IE). so we end up launching
chrome.exe in low integrity.
BUG=51949
TEST=load gcf:about:version in Chrome Frame with IE8 on Win7
and delete browsing history.
Review URL: http://codereview.chromium.org/3133019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The itteration is performed in the browser process
when the list of field-trial settings is passed to
the renderer. I failed to acquire the lock prior
to the itteration, and it appears that some code
is deciding on a field trial VERY late in browser
startup and racing against this render-spawn
operation. The code in FieldTrial is wrong
(but fixed here), but I'll still need to
track down the racing thread that is performing
such a late FieldTrial definition (the results
of which will not be passed to some renderers).
BUG=49409
R=huanr
Review URL: http://codereview.chromium.org/3134015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
some logics are moved into system memory path only. ( such as allocation of output buffer, and usage of FTBDoneACK messages.
Review URL: http://codereview.chromium.org/3141014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
reduce the amount of false positive crash reports - when exception is swallowed
and is almost always not a problem due ChromeFrame code.
BUG=51830
TBR=amit@chromium.org
Review URL: http://codereview.chromium.org/3148015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Part of http://codereview.chromium.org/3191002 missed during checkin.
BUG=49091
TEST=None
Review URL: http://codereview.chromium.org/3149018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=48100
TEST=net_unittests
Review URL: http://codereview.chromium.org/3048058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
on NDEBUG builds too.
TBR: zelidrag
BUG=48920
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Spotted in previous review.
BUG=23581
Review URL: http://codereview.chromium.org/3152019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=51449
TEST=JsonSchemaTest.TestNumber
Review URL: http://codereview.chromium.org/3158015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Unit tests in file_watcher_unittest.cc.
Review URL: http://codereview.chromium.org/3149004
TBR=mnissler@chromium.org
Review URL: http://codereview.chromium.org/3165027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
as navigation state.
Review URL: http://codereview.chromium.org/3110018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
layout tests
BUG=45080,46299
Review URL: http://codereview.chromium.org/3116015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49091
TEST=Open DOMUI prefs, and click the "Manage..." button for search engines. Search engines should be listed, the default should be changeable, and entries should be removable.
Review URL: http://codereview.chromium.org/3191002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This has reappeared on TSan UI FYI bot between r56211 and r56252
http://build.chromium.org/buildbot/waterfall.fyi/builders/Linux%20Tests%20(tsan%20ui)/builds/1796
Sample "getenv" callstack:
Concurrent read(s) happened at (OR AFTER) these points:
T0 (WR-L{L144}/RD-L{L1, L36, L144}):
#0 getenv /lib/tls/i686/cmov/libc-2.7.so
#1 __dcigettext /lib/tls/i686/cmov/libc-2.7.so
#2 dcgettext /lib/tls/i686/cmov/libc-2.7.so
#3 gdk_pango_renderer_class_intern_init /build/buildd/gtk+2.0-2.12.9/gdk/gdkpango.c:487
#4 g_type_class_ref /build/buildd/glib2.0-2.16.6/gobject/gtype.c:1880
#5 g_type_class_ref /build/buildd/glib2.0-2.16.6/gobject/gtype.c:2400
#6 g_object_new_valist /build/buildd/glib2.0-2.16.6/gobject/gobject.c:988
#7 g_object_new /build/buildd/glib2.0-2.16.6/gobject/gobject.c:795
#8 gtk_text_layout_draw /build/buildd/gtk+2.0-2.12.9/gtk/gtktextdisplay.c:731
#9 gtk_text_view_expose_event /build/buildd/gtk+2.0-2.12.9/gtk/gtktextview.c:4462
TBR=glider
TEST=TSan/UI should become greener
BUG=41314
Review URL: http://codereview.chromium.org/3191005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
(Everything goes to hell when the try servers don't work.)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
content_setting_bubble_contents.[cc/h]
(Note: that was a TODO for bulach).
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3177016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change moves the Response class to the top level to save other
files from having to #include the header in order to get a pointer to
a Response object.
This change also modifies the semantics of resolution: the callback
will now be made of the origin MessageLoop, rather than a random
thread.
TEST=net_unittests
BUG=none
http://codereview.chromium.org/3110015/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Unit tests in file_watcher_unittest.cc.
Review URL: http://codereview.chromium.org/3149004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and margin.
BUG=51124
TEST=none
Review URL: http://codereview.chromium.org/3184008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crosbug.com/5376
TEST=Manual
Review URL: http://codereview.chromium.org/3114011/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=51729
TEST=see bug
Review URL: http://codereview.chromium.org/3145016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=52415
TEST=none
Review URL: http://codereview.chromium.org/3104014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It seems WebKit r65468 is causing crashes, but I'm not sure why it crashes.
TBR=johnnyg
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3113020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://src.chromium.org/viewvc/chrome?view=rev&revision=56332
BUG=45535
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the chromium side of https://bugs.webkit.org/show_bug.cgi?id=43922.
For all speech input requests WebKit now sends a 'requestId' which identifies the input element within the page. This requestId is returned back to WebKit in all the speech input callbacks/events. Within chromium, the pair (render view id, request id) uniquely identifies a caller and we introduce the SpeechInputCallerId to hold this data. All code which was previously using render view id now uses this caller id.
Once this is working fully on both ends I'll add relevant browser tests.
BUG=none
TEST=manually
Review URL: http://codereview.chromium.org/3130018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Implementation of a location provider that uses the Windows 7 Location API. Currently uses polling to get the users location, I will update this to use signals provided by the API in a future patch.
BUG=45535
TEST=Two test files included.
Review URL: http://codereview.chromium.org/3015053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=IndexedDBBrowserTest, IndexTest
Review URL: http://codereview.chromium.org/3148009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
resize controls.
BUG=51778
TEST=Automatically saved windows are correctly restored (see bug), unit test: WindowSizeAutosaverTest.*
Review URL: http://codereview.chromium.org/3115005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Added a check to see if tab_contents is NULL before adding the next infobar. If it is NULL the pending request will be canceled and it will continue to search for more pending requests.
BUG=51787
TEST=Find a site with two geolocation permission requests (maybe iGoogle?) leave two pending permission requests and navigate to another site, Chrome should no longer crash.
Review URL: http://codereview.chromium.org/3112006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
CID=12547
Review URL: http://codereview.chromium.org/3190001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
CID=1473, 5546, 11622
Review URL: http://codereview.chromium.org/3123009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56322 0039d316-1c4b-4281-b951-d872f2087c98
|