summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Allow Chrome-in-Aura to start.ben@chromium.org2011-09-1212-13/+151
| | | | | | | | | | Nothing (much) renders. WIP. http://crbug.com/93947 TEST=none Review URL: http://codereview.chromium.org/7849004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100773 0039d316-1c4b-4281-b951-d872f2087c98
* Check return value of XGetWindowAttributes.reveman@google.com2011-09-124-9/+29
| | | | | | | | | | | There is a chance that window is no longer valid and the call to XGetWindowAttributes will fail and leave |attributes| uninitialized. BUG=chromium-os:16986 TEST=manual Review URL: http://codereview.chromium.org/7831063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100772 0039d316-1c4b-4281-b951-d872f2087c98
* NetworkChangeNotifierMac: synchronize destruction order with helper thread.adamk@chromium.org2011-09-122-14/+13
| | | | | | | | | | | | | | Previously, it was possible for NetworkChangeNotifierMac to unschedule the SCNetworkReachability callback before it had been scheduled. Under the hypothesis that this is causing crashes on shutdown, this change makes sure that the helper thread (on which reachability is initially scheduled) runs to completion before we check to see if we need to unschedule the callback. BUG=91767 Review URL: http://codereview.chromium.org/7862006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100771 0039d316-1c4b-4281-b951-d872f2087c98
* Clang fix for http://codereview.chromium.org/7870011/stevenjb@google.com2011-09-121-0/+1
| | | | | | | | | | | | Appease the clang bot. BUG=chromium-os:19908 TEST=clang bot succeeds TBR=dmazzoni@chromium.org Review URL: http://codereview.chromium.org/7845027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100770 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind: Disable several flaky AutomatedUITestBase tests.thestig@chromium.org2011-09-121-0/+8
| | | | | | | | | BUG=96312,96313 TEST=none TBR=jhawkins Review URL: http://codereview.chromium.org/7877001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100769 0039d316-1c4b-4281-b951-d872f2087c98
* touchui: In the absence of a real window manager, move/resize the window as ↵sadrul@chromium.org2011-09-121-0/+9
| | | | | | | | | | | necessary for maximize. BUG=none TEST=none Review URL: http://codereview.chromium.org/7748047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100768 0039d316-1c4b-4281-b951-d872f2087c98
* Make the NaCl windows 64 bit binaries not depend on chrome targets. These ↵jam@chromium.org2011-09-1249-998/+461
| | | | | | | | | | | | | targets are very simple and used little code from chrome targets. However their dependency on chrome targets was problematic because a lot of code wasn't being built for 64 bit on Windows, and so there were a lot of "dummy" files being added with stub functions and code was also being compiled out in random places for NACL_WIN64. I've made the NaCl 64 bit windows targets self contained. They do use a few files from common, but those files are self-contained. In the future, we could move these to be in the same 64 bit target as the constants from common. However that won't make a maintenance difference since someone could still introduce link dependencies to other files in common. Additionally, since we're not using chrome code anymore, we can avoid having both nacl.exe and nacl.dll. nacl.exe is sufficient, and this saves 1.4MB of uncompresed binaries in the installer. BUG=86322 Review URL: http://codereview.chromium.org/7863024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100767 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 100589 - Access Session::config() on the correct thread.sergeyu@chromium.org2011-09-123-22/+16
| | | | | | | | | | | | BUG=88600 TEST=Unittests Review URL: http://codereview.chromium.org/7867019 TBR=sergeyu@chromium.org Review URL: http://codereview.chromium.org/7880002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100766 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a race where Init gets called right after FastShutdownIfPossible before ↵achuith@chromium.org2011-09-122-0/+8
| | | | | | | | | | channel_ has been reset by OnChannelError after a round-trip. BUG=chromium-os:18390 TEST=Open a new tab on cros. Close all other tabs. Navigate to google.com. Close the tab. Should no longer see the sad tab. Review URL: http://codereview.chromium.org/7864019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100765 0039d316-1c4b-4281-b951-d872f2087c98
* Add UI changes for OpenVPN and Group Name.stevenjb@google.com2011-09-128-134/+242
| | | | | | | | | | | | | + Fixes clang issue Original CL: http://codereview.chromium.org/7828064/ BUG=chromium-os:19908, chromium-os:19252 TEST=Test UI connectint to a VPN Review URL: http://codereview.chromium.org/7870011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100764 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a non-existant source file from the gypi (it was removed in r100705).erikwright@chromium.org2011-09-121-1/+0
| | | | | | | | BUG=None TEST=gyp runs without error TBR=lipalani git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100763 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust RenderTextWin ScriptShape loop and error handling.msw@chromium.org2011-09-121-10/+22
| | | | | | | | | | | | | | ScriptShape was incorrectly handling USP_E_SCRIPT_NOT_IN_FONT. The previous code would hang on unshapable text. For now, unshapable glyphs are rendered as missing (⛿). I added a TODO regarding the need for actual font fallback. BUG=90426 TEST=No hang on hebrew text, etc. Review URL: http://codereview.chromium.org/7863010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100762 0039d316-1c4b-4281-b951-d872f2087c98
* base: Get rid of references to gtk_util.* from base.gypi.tfarina@chromium.org2011-09-121-2/+0
| | | | | | | | | | | These entries were added at revision r51409, but they were moved to ui/gfx/ at revision r73530. R=sky@chromium.org,evan@chromium.org Review URL: http://codereview.chromium.org/7873008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100761 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 100327 - sync: pass the gaia password through a rough ASP regextim@chromium.org2011-09-124-52/+0
| | | | | | | | | | | | | | | If the text entered into the password field has 16 lowercase alphabetical characters, or is 4 clusters of 4 lowercase alphabetical characters separated by spaces, add a second confirmation step to reduce the chance users encrypt their data with an ASP. BUG=none TEST=enter an ASP into the password field on sync signin, notice warning message. Review URL: http://codereview.chromium.org/7859011 TBR=tim@chromium.org Review URL: http://codereview.chromium.org/7877003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100760 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 100757 - Data race on boolean in WebDataService::WebDataRequestdmazzoni@chromium.org2011-09-123-62/+59
| | | | | | | | | | | | | | Fix for data race in WebDataService::WebDataRequest::Cancel. Also removes the suppression. This was happening with very low frequency. Probably during shutdown. It appears to have been largely benign because the lock within WebDataService::CancelRequest would protect the important structures. This change adds a lock to the WebDataRequest::Cancel() operation and makes the query WebDataRequest::IsCancelled() atomic with respect to the consumer and the cancelled state. BUG=40244 TEST=Run TSAN on bots, see that they stay green. Review URL: http://codereview.chromium.org/7870007 TBR=dhollowa@chromium.org Review URL: http://codereview.chromium.org/7879001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100759 0039d316-1c4b-4281-b951-d872f2087c98
* More comments for PPB_Flash_TCPSocket.SSLHandshake.yzshen@chromium.org2011-09-121-0/+4
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/7780015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100758 0039d316-1c4b-4281-b951-d872f2087c98
* Data race on boolean in WebDataService::WebDataRequestdhollowa@chromium.org2011-09-123-59/+62
| | | | | | | | | | | Fix for data race in WebDataService::WebDataRequest::Cancel. Also removes the suppression. This was happening with very low frequency. Probably during shutdown. It appears to have been largely benign because the lock within WebDataService::CancelRequest would protect the important structures. This change adds a lock to the WebDataRequest::Cancel() operation and makes the query WebDataRequest::IsCancelled() atomic with respect to the consumer and the cancelled state. BUG=40244 TEST=Run TSAN on bots, see that they stay green. Review URL: http://codereview.chromium.org/7870007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100757 0039d316-1c4b-4281-b951-d872f2087c98
* [chromeos] Create Consents file atomically using pyautonirnimesh@chromium.org2011-09-121-4/+13
| | | | | | | | | | | BUG=chromium-os:18413 R=mkrebs@chromium.org TEST= Review URL: http://codereview.chromium.org/7780018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100756 0039d316-1c4b-4281-b951-d872f2087c98
* Update Native Client Authors to be Chromium Authors for the code moved from thebrettw@chromium.org2011-09-12242-248/+245
| | | | | | | | | | | native client repo to the Chrome one. The Native Client Authors are currently a subset of the Chromium Authors. TEST=none BUG=none Review URL: http://codereview.chromium.org/7778046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100755 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 100748 - This patch tries to remove most of the manual registration ↵dmazzoni@chromium.org2011-09-12147-1620/+2426
| | | | | | | | | | | | | | | | | | | | | | | | | for Pepper interfaces, and replaces it with a list of macros. When files want to know which Pepper interface names and structs there are, they define what they want to do with the macros, and then include the relevant files for the classes of interfaces they want (stable, private, dev). This does not convert all the dev interfaces. I just did a few to keep the patch smaller. So there is still a lot of manual registration. This fixes the previous design problem where we assumed one *_Proxy object == one interface. We have been hacking around this lately with duplicate GetInfo calls, but this doesn't work for PPP interfaces. Now, a _Proxy object is just there to help keep things organized. One proxy can handle zero, one, or many interfaces, and this mapping is controlled by just one line in the interfaces file. So for example, to add a new function to a new version of an interface with backward compatibility, you would add that function to the _api.h file, and write a thunk for the new interface. Then you only need to add one line to the interfaces_ppb_public_stable.h file and that will be hooked up with the proxy and the implementation. This removes some _proxy objects/files that were used only to declare that the interfaces existed, since they're no longer necessary. I folded Console into the Instance API which removed a bunch of code. I removed FileChooser 0.4. I think everybody has converted to the new one, and I think parts of it weren't even hooked up properly anymore. Review URL: http://codereview.chromium.org/7740038 TBR=brettw@chromium.org Review URL: http://codereview.chromium.org/7844018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100754 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 100751 - Fix Windows build by renaming interface to iface.dmazzoni@chromium.org2011-09-122-9/+9
| | | | | | | | | | TEST=it compiles Review URL: http://codereview.chromium.org/7871005 TBR=brettw@chromium.org Review URL: http://codereview.chromium.org/7872007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100752 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Windows build by renaming interface to iface.brettw@chromium.org2011-09-122-9/+9
| | | | | | | TEST=it compiles Review URL: http://codereview.chromium.org/7871005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100751 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 99124: Revert 99099 Fix up more WaitForNavigation calls.gbillock@chromium.org2011-09-128-45/+66
| | | | | | | | | | | | | | | Revert task manager test. This one looks to be more complicated. See http://codereview.chromium.org/7745037/ (original review) R=phajdan.jr@chromium.org BUG=None. TEST=browser_tests,ui_tests Review URL: http://codereview.chromium.org/7831020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100749 0039d316-1c4b-4281-b951-d872f2087c98
* This patch tries to remove most of the manual registration for Pepper ↵brettw@chromium.org2011-09-12147-2426/+1620
| | | | | | | | | | | | | | | | | | | | | | interfaces, and replaces it with a list of macros. When files want to know which Pepper interface names and structs there are, they define what they want to do with the macros, and then include the relevant files for the classes of interfaces they want (stable, private, dev). This does not convert all the dev interfaces. I just did a few to keep the patch smaller. So there is still a lot of manual registration. This fixes the previous design problem where we assumed one *_Proxy object == one interface. We have been hacking around this lately with duplicate GetInfo calls, but this doesn't work for PPP interfaces. Now, a _Proxy object is just there to help keep things organized. One proxy can handle zero, one, or many interfaces, and this mapping is controlled by just one line in the interfaces file. So for example, to add a new function to a new version of an interface with backward compatibility, you would add that function to the _api.h file, and write a thunk for the new interface. Then you only need to add one line to the interfaces_ppb_public_stable.h file and that will be hooked up with the proxy and the implementation. This removes some _proxy objects/files that were used only to declare that the interfaces existed, since they're no longer necessary. I folded Console into the Instance API which removed a bunch of code. I removed FileChooser 0.4. I think everybody has converted to the new one, and I think parts of it weren't even hooked up properly anymore. Review URL: http://codereview.chromium.org/7740038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100748 0039d316-1c4b-4281-b951-d872f2087c98
* Memory leak fix for suppression bug_52371_b. Removed supression bug_52371_a ↵zelidrag@chromium.org2011-09-122-18/+2
| | | | | | | | | | since the code path does not exist anymore. BUG=52371 TEST=none Review URL: http://codereview.chromium.org/7863021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100747 0039d316-1c4b-4281-b951-d872f2087c98
* Conditionally disable accelerated compositing for certain testsnduca@chromium.org2011-09-126-39/+47
| | | | | | Review URL: http://codereview.chromium.org/7826034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100746 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the suppression for the issue 87997.satorux@chromium.org2011-09-121-12/+0
| | | | | | | | | | | The leak from IBusController was fixed in crrev.com/100723 TEST=the leak is now gone BUG=87997 Review URL: http://codereview.chromium.org/7748046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100745 0039d316-1c4b-4281-b951-d872f2087c98
* Remove stale valgrind suppression in CreateTCPClientSocket().asanka@chromium.org2011-09-121-11/+0
| | | | | | | | | | | DefaultClientSocketFactory::CreateTCPClientSocket() hasn't existed since 80781 where it was renamed to CreateTransportClientSocket(). BUG=22450 TEST=none Review URL: http://codereview.chromium.org/7872003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100744 0039d316-1c4b-4281-b951-d872f2087c98
* Adding owners file to RLZ subdirectory.rogerta@chromium.org2011-09-121-0/+4
| | | | | | | | | BUG=None TEST=No code change Review URL: http://codereview.chromium.org/7847024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100743 0039d316-1c4b-4281-b951-d872f2087c98
* Upstream Android change for libeventmichaelbai@google.com2011-09-125-0/+548
| | | | | | | | | | | Add proper config for Android to libevent. Enable libevent to compile without needing __linux__. BUG= TEST= Review URL: http://codereview.chromium.org/7866018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100742 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind: Suppress a leak in ComponentUpdaterTest.ProdVersionCheck.thestig@chromium.org2011-09-121-0/+7
| | | | | | | | | BUG=96295 TEST=none TBR=jhawkins Review URL: http://codereview.chromium.org/7867050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100741 0039d316-1c4b-4281-b951-d872f2087c98
* Added l10n support to Mac host dialogs.jamiewalch@google.com2011-09-1210-193/+137
| | | | | | | | | | | The XIB changes involve unifying the 'connected' message and username field into a single text field and adding some links to we can access the button in order to set its text. BUG=93088 TEST=Manual Review URL: http://codereview.chromium.org/7796024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100740 0039d316-1c4b-4281-b951-d872f2087c98
* Register signal handlers after shutdown pipe is setup.oshima@google.com2011-09-122-21/+28
| | | | | | | | | | | | Chrome fails at RAW_CHECK(g_shutdown_pipe_write_fd != -1) if it receives signal in a window where signal handlers are registered, but shutdown pipe isn't setup yet. BUG=chromium-os:17606 TEST=autotest with session manager sending SIGTERM no longer crash Review URL: http://codereview.chromium.org/7464013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100739 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind Mac: Widen a suppression, disable a failing test, and add a new ↵thestig@chromium.org2011-09-122-28/+23
| | | | | | | | | | | suppression. BUG=53989,96298,96300 TEST=none TBR=jhawkins Review URL: http://codereview.chromium.org/7844015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100738 0039d316-1c4b-4281-b951-d872f2087c98
* This splits the use of GaiaOAuthFetcher such that UI elements are handled by ↵rickcam@chromium.org2011-09-129-42/+61
| | | | | | | | | | | | | SyncSetupHandler, which also handles the UI for ClientLogin and for other parts of Sync setup. It leaves the non-UI elements, such as token exchange and user info, in SigninManager, which also handles similar tasks for the ClientLogin flow. BUG=95803 TEST=manual Review URL: http://codereview.chromium.org/7848016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100737 0039d316-1c4b-4281-b951-d872f2087c98
* Add ThreadRestrictions::AssertIOAllowed to platform_file_posix callsevan@chromium.org2011-09-121-0/+12
| | | | | | | | | | It wasn't clear to me in some codepaths whether these functions were being called on the correct thread. This assertion will help catch errors. Review URL: http://codereview.chromium.org/7867011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100736 0039d316-1c4b-4281-b951-d872f2087c98
* Mark UninstallExtension as FLAKY on Win.dmazzoni@chromium.org2011-09-121-2/+8
| | | | | | | | BUG=96296 TEST=ExtensionServiceTest.UninstallExtension Review URL: http://codereview.chromium.org/7844013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100735 0039d316-1c4b-4281-b951-d872f2087c98
* Fix startup/shutdown Debug checks in libcrosstevenjb@google.com2011-09-125-9/+26
| | | | | | | | | BUG=chromium-os:20268 TEST=tests and autotests succeed Review URL: http://codereview.chromium.org/7863011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100734 0039d316-1c4b-4281-b951-d872f2087c98
* Cancel plugin channel requests when the renderer goes away.willchan@chromium.org2011-09-129-63/+215
| | | | | | | | | | | | | | | | | Logic: - Profile shutdown kills all renderer processes - When the RMF detects the channel closing, it kills off any plugin channel requests from: * PluginService (which needs to check the PluginServiceFilter on the FILE thread) * PluginProcessHost (which may need to wait for the channel to get established) - RMF uses the new OnPluginProcessHostFound() to cancel at the PluginService or PluginProcessHost BUG=94704 TEST=New PluginService test, no known manual test Review URL: http://codereview.chromium.org/7867031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100733 0039d316-1c4b-4281-b951-d872f2087c98
* Nuke the deprecated ctor of TabMenuModel.tfarina@chromium.org2011-09-123-48/+6
| | | | | | | | | R=sky@chromium.org TEST=unit_tests --gtest_filter=TabMenuModelTest* Review URL: http://codereview.chromium.org/7844004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100732 0039d316-1c4b-4281-b951-d872f2087c98
* Heapchecker: Suppress a leak in ComponentUpdater tests.thestig@chromium.org2011-09-121-0/+6
| | | | | | | | | BUG=96295 TEST=none TBR=jhawkins Review URL: http://codereview.chromium.org/7844011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100731 0039d316-1c4b-4281-b951-d872f2087c98
* Reset RPH's channel.willchan@chromium.org2011-09-123-10/+14
| | | | | | | | | | | This is important for shutdown ordering to make sure the objects hanging off the channel get deleted before objects they reference (like data in ResourceContext) go away. BUG=91398 TEST=none Review URL: http://codereview.chromium.org/7796029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100730 0039d316-1c4b-4281-b951-d872f2087c98
* Moved from http://codereview.chromium.org/7811020/ (same CL but was on a ↵caitkp@chromium.org2011-09-127-0/+81
| | | | | | | | | | | | | | | | | | | read-only check-out) BUG=94920 -Related: Check in a new CRX: http://codereview.chromium.org/7828014/ Check in a few GYP changes: http://codereview.chromium.org/7827021/ -Modified profile_impl to search for and auto-install apps found in DIR_DEFAULT_APPS when profile created -Added tracking code for number of extension installs and uninstalls and number of webstore visits. Review URL: http://codereview.chromium.org/7839009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100727 0039d316-1c4b-4281-b951-d872f2087c98
* Replace ancient crufty AppCacheThread with much improved MessageLoopProxy usage.michaeln@google.com2011-09-1211-226/+35
| | | | | | Review URL: http://codereview.chromium.org/7863009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100726 0039d316-1c4b-4281-b951-d872f2087c98
* Move handling of the ViewHostMsg_WebUISend out of Chrome. This message is ↵ananta@chromium.org2011-09-125-21/+26
| | | | | | | | | | | | | | | | handled by ChromeOS the balloon notification class which is a RVHD. We now handle this message in RVH and call out the new virtual function in WebUISend in the RVHD interface which the balloon class overrides. Continuing changes to get rid of the pattern of IPC messages spanning across content and chrome. BUG=87335 TEST=No change in functionality Review URL: http://codereview.chromium.org/7864016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100725 0039d316-1c4b-4281-b951-d872f2087c98
* [ntp4] Improve styling for bookmarks header bar.csilv@chromium.org2011-09-123-13/+7
| | | | | | | | BUG=94968 TEST=Visual Review URL: http://codereview.chromium.org/7867045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100724 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a memory leak caused by IBusControllersatorux@chromium.org2011-09-123-41/+50
| | | | | | | | | | | | | | | | IBusController used to be a singleton, but this change lets IBusController be owned by InputMethodManager. FWIW, here's the command line to run a test in the browser_tests: % sh tools/valgrind/chrome_tests.sh --build_dir=out/Release -t browser --gtest_filter=ExtensionApiTest.InputMethodApiBasic BUG=chromium:86146 TEST=ran a browser test locally and the leak is gone after the change. Alos tested on the device to confirm that input methods worked as before. Review URL: http://codereview.chromium.org/7864023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100723 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 100710 - Refactoring dialogs to add KDE support in a subsequent CL.dpapad@chromium.org2011-09-124-171/+97
| | | | | | | | | | | Retry of r100550 with the gypi file fixed. Review URL: http://codereview.chromium.org/7796028 TBR=dfilimon@google.com Review URL: http://codereview.chromium.org/7754027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100722 0039d316-1c4b-4281-b951-d872f2087c98
* ntp4: minor polish around app iconsestade@chromium.org2011-09-122-23/+47
| | | | | | | | | | | | | 1. never resize the web store icon when showing the promo 2. don't pulse anything other than app-contents (the icon + span). This includes for example apps-promo-extras and the app notification) 3. don't pulse when the user clicks inside app/app-contents, but outside the clickable region BUG=94783 TEST=see above Review URL: http://codereview.chromium.org/7860013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100721 0039d316-1c4b-4281-b951-d872f2087c98
* Reenable WorkerFileSystemTest.FileEntryToURISyncoshima@google.com2011-09-121-2/+0
| | | | | | | | | | | | this no longer reports leak. TBR=jochen@chromium.org BUG=90963 TEST=none Review URL: http://codereview.chromium.org/7844005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100717 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-24 22:43:59 +0000