| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
TBR=glider
BUG=47331
Review URL: http://codereview.chromium.org/3087005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR: pfeldman@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=50936
TBR=glider
Review URL: http://codereview.chromium.org/3086008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=51055
TBR=glider
Review URL: http://codereview.chromium.org/3058035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
click-to-play is enabled.
BUG=50506
TEST=none
Review URL: http://codereview.chromium.org/3033046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Valgrind suppressions locally
TEST=./tools/valgrind/waterfall.sh fetch && ./tools/valgrind/waterfall.sh match
Review URL: http://codereview.chromium.org/3044041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45464,10764
TEST=See first bug for manual test.
Review URL: http://codereview.chromium.org/3029040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=atwilson
Review URL: http://codereview.chromium.org/3029054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crosbug.com/4411
TEST=On login screen change the language through new user pod and verify that for existing user pods text is translated to the new language.
Review URL: http://codereview.chromium.org/3047044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
connect page.
Review URL: http://codereview.chromium.org/3071016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Run chromium with --remote-debugging-port=9222
2. Open another tab with url localhost:9222
What is the expected result?
Page with the list of available tabs.
What happens instead?
Page doesn't open and stay in waiting state.
BUG=50749
TEST=none
Review URL: http://codereview.chromium.org/3012037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=50416
Review URL: http://codereview.chromium.org/3013057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3037037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The webRequest API doesn't support the planned filter and extraInfoSpec parameters yet, these will be added later.
BUG=50943
TEST=ExtensionApiTest.WebRequest,ExtensionApiTest.WebNavigation
Review URL: http://codereview.chromium.org/3061041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3005044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
click-to-play is enabled.
Screenshot: http://imgur.com/ZKsQB.png
XIB changes: Add a rounded rect button hooked up to |loadAllPlugins:| in the File's Owner and referenced by its |loadAllPluginsButton_| outlet, wrapped in a GTMWidthBasedTweaker.
BUG=49677
TEST=ContentSettingBubbleModelTest.*
Review URL: http://codereview.chromium.org/3015036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This enables the renderer to get more information about a plugin than just the path.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3015029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3017049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
After a while this will be used in a PRESUBMIT script
TEST=python tools/valgrind/suppressions.py -> self-test
Review URL: http://codereview.chromium.org/2836078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49662
TEST=Enable/Disable metrics reporting through policy and check whether the crash reporter respects that.
Review URL: http://codereview.chromium.org/3084008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Without explicit management of the cirucular reference to HttpNetworkTransaction, it can get deleted at inopportune times and cause undesirable effects (i.e. triggering a pool to delete itself while in the middle of other operations). This change breaks the cirucular reference at points in execution where it is safe.
BUG=50822, 49254
TEST=green reliability bot
Review URL: http://codereview.chromium.org/3084011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ClientSocketPool treats all pending SocketParams as interchangeable. Therefore they can not contain any connection specific data. This only affects the Http Proxy tunnel case. The lowest risk change to fix this problem is to create the HttpAuthController in the HttpProxyClientSocket. If we get a 407 and need to restart the Tunnel, the pending HttpProxyClientSocket is returned to the HttpNetworkTransaction in the additional error state of the connection and then complete the auth in a pair of states in the HttpNetworkTransaction. This reintroduces a dependency between tunnel setup and the HttpNetworkTransaction, but that will need to be fixed at a later date.
Original Review URL: http://codereview.chromium.org/3058013
BUG=49493
TEST=existing unit tests + manually visiting many SSL sites through a kerberized http proxy.
Review URL: http://codereview.chromium.org/3029052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the former's shutdown logic depends on the latter.
BUG=50553
TEST=see bug
Review URL: http://codereview.chromium.org/3051029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If SocketStream closes while waiting ResolveProxy, it badly
calls DoResolveProxyComplete from DoLoop invoked by SocketStream::Close,
and real callback of ResolveProxy failed to call SocketStream::OnIOCompleted.
So, don't run DoLoop when closed, if SocketStream is calling APIs of
proxy_service or resolver. Check closing_ after the API calls back
and closes the SocketStream.
BUG=50394,46750
TEST=websocket/tests doesn't crash
Review URL: http://codereview.chromium.org/3054039
TBR=ukai@chromium.org
Review URL: http://codereview.chromium.org/3017053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If SocketStream closes while waiting ResolveProxy, it badly
calls DoResolveProxyComplete from DoLoop invoked by SocketStream::Close,
and real callback of ResolveProxy failed to call SocketStream::OnIOCompleted.
So, don't run DoLoop when closed, if SocketStream is calling APIs of
proxy_service or resolver. Check closing_ after the API calls back
and closes the SocketStream.
BUG=50394,46750
TEST=websocket/tests doesn't crash
Review URL: http://codereview.chromium.org/3054039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=pfeldman
BUG=51036
Review URL: http://codereview.chromium.org/3071015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:4460
TEST=Boot chromium os. Switch to a virtual console. Run "ps aux | grep ibus" and check that ibus is not running. Switch back to the login screen. Switch the input method to Dvorak. Check that Dvorak works. Reboot. Check that the input method is dvorak.
Review URL: http://codereview.chromium.org/2806083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I forgot to include this item in the previous CL.
Use type=number rather than touch-slider (used in original UI) for number of suggestions.
Also clean up some of ARRAYSIZE_UNSAFE() usages in language_preferences.h.
TEST=manually check on the netbook by uncommenting TODO lines in options.html.
BUG=chromium-os:4809
Review URL: http://codereview.chromium.org/3020054
Patch from Takayoshi Kochi <kochi@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=pfeldman
Review URL: http://codereview.chromium.org/3090003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
chrome-team.
BUG=NONE
TEST=FileUtilTest.NormalizeFilePath*
Review URL: http://codereview.chromium.org/3031041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MessageLoop::DeletePendingTasks().
BUG=6532
TEST=existing unit tests
Review URL: http://codereview.chromium.org/3076015
TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/2878074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now EnvVarGetter do much more than getting environment variables.
Per suggestion from Pawel in http://codereview.chromium.org/3043018/.
BUG=None
TEST=trybots
Signed-off-by: Thiago Farina <tfarina@chromium.org>
Review URL: http://codereview.chromium.org/3052034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* We no longer detected that the user was dragging the permanent_text_, and thus that we could give the drag a title and favicon.
* We no longer scored hitting enter on the URL as a RELOAD.
BUG=47555
TEST=Visit www.google.com. Drag the omnibox text to the desktop. The shortcut should have a title and favicon.
Review URL: http://codereview.chromium.org/3030039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
supplied URLs.
This also fixes a bug in Linux Views where calling BrowserWindow::Show() wouldn't synchronously call BrowserList::SetLastActive(). This happens naturally in Windows and was already explicitly done in BrowserWindowGtk and BrowserWindowCocoas, but missing it for Linux Views resulted in crashes when the kiosk code tried to get the last active window before the message loop had pumped the async activation change message.
BUG=none
TEST=Set Chrome to "open windows and tabs from last time", then run with --kiosk. Should start in kiosk mode (fullscreen, no status bubble).
Review URL: http://codereview.chromium.org/2847090
TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/3017052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3029044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Provide a more clear error message when the commit fails due to exceeding the quota.
TEST=MasterEntryFailStoreNewestCacheTest
BUG=50985
Review URL: http://codereview.chromium.org/2836075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=pkasting, ncarter
TEST=compile
Review URL: http://codereview.chromium.org/3060037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=ncarter
TEST=compile; also autocomplete popup text aligns with omnibox text
Review URL: http://codereview.chromium.org/3053036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
All resource files
_ Made text unselectable on all 3 screens
_ Change the default font size to 11pt and 1.8em line height spacing
gaia_login
_ Introduction paragraph is now using 11pt font and new spaced line height
_ Moved the cancel button into the GAIA login box.
_ Error message
> Made permanent space for the error msg between intro paragraph and GAIA login
> Error message now as the same orange background as on choosedatatypes
> Error shows on Captcha view if there's an error
setup_done
_ Got rid of the tables
_ Header is now the right size
_ Synced to user@gmail.com is now bold
BUG=49704
Original patch by dudley@chromium.org
Original review: http://codereview.chromium.org/3085003
Review URL: http://codereview.chromium.org/2856081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=50994
TEST=None
Review URL: http://codereview.chromium.org/3058031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The first is a FOAF.ME cert generated for this purpose. The second is one of my
expired MIT certificates.
R=wtc
BUG=50980
TEST=none
Review URL: http://codereview.chromium.org/2836082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
committing out-of-date results after the edit had changed. Simply not doing this commit would make the popup appear less responsive, so instead we're more careful to not try and update the edit with the out-of-date data, and instead force the popup to get newer results in cases where it might have been out-of-date.
BUG=46315
TEST=Type a letter that inline autocompletes, then immediately hit ctrl-a. You should get everything selected, not nothing. Also, typing a letter that inline autocompletes, then immediately a random other letter and the down arrow key, should show a popup with results for the two letters you typed, not just the first.
Review URL: http://codereview.chromium.org/3047041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These changes mirror pkasting's work on windows for milestone6.
TODO (in a follow up patch): convert the wrench menu into a CustomDrawButton (you will notice that currently it is too wide and has the wrong sort of background hover appearance).
BUG=50682
TEST=look of upper chrome
Review URL: http://codereview.chromium.org/3007018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Digest authentication uses a uri field to prevent replay attacks.
When authenticating to an HTTP proxy to establish a secure tunnel (via CONNECT), the uri should be the hostname of the server and the destination port, such as "www.example.com:443". When authenticating to an HTTP proxy for a non-secure content, the uri should be the path at the server, i.e. "/index.html".
If the site we are trying to connect to previously advertised "Alternate-Protocol: 443:spdy-npn/1" a request to "http://www.example.com" will be attempted on a secure port.
However, the URL passed into the digest authenticator was an unsecure one, and it decided to have a uri in the form "/index.html" rather than the correct "www.example.com:443". This causes persistent failure with the password and many password prompts.
BUG=49865
TEST=net_unittests --gtest_filter="HttpNetworkTransactionTest.SpdyAlternateProtocolThroughProxy"
Review URL: http://codereview.chromium.org/3040032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
net/base/escape.h, and net/base/net_errors.h from DRT.
Make wrapper functions of features used by DRT.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2873088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
registered on the system at all, rather than checking whether it has a known MIME type. Many known extensions have no MIME type.
BUG=7499
TEST=Save a text file as "foo.reg" and ensure it doesn't get ".txt" appended.
Review URL: http://codereview.chromium.org/3050031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=erg
BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3078018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This also fixes a bug in Linux Views where calling BrowserWindow::Show() wouldn't synchronously call BrowserList::SetLastActive(). This happens naturally in Windows and was already explicitly done in BrowserWindowGtk and BrowserWindowCocoas, but missing it for Linux Views resulted in crashes when the kiosk code tried to get the last active window before the message loop had pumped the async activation change message.
BUG=none
TEST=Set Chrome to "open windows and tabs from last time", then run with --kiosk. Should start in kiosk mode (fullscreen, no status bubble).
Review URL: http://codereview.chromium.org/2847090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
that create FormDatas, and we shouldn't need to initialize user_submitted for
each call site.
BUG=50423
TEST=none
Review URL: http://codereview.chromium.org/3074023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54641 0039d316-1c4b-4281-b951-d872f2087c98
|