summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add one more sqlite suppression for bug 47331timurrrr@chromium.org2010-08-031-0/+16
| | | | | | | | TBR=glider BUG=47331 Review URL: http://codereview.chromium.org/3087005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54743 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DownloadTest.NewWindowbauerb@chromium.org2010-08-031-1/+1
| | | | | | TBR: pfeldman@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54742 0039d316-1c4b-4281-b951-d872f2087c98
* Widen suppression for bug 50936timurrrr@chromium.org2010-08-031-5/+4
| | | | | | | | BUG=50936 TBR=glider Review URL: http://codereview.chromium.org/3086008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54741 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress uninit read in net_unittests (bug #51055)timurrrr@chromium.org2010-08-031-0/+15
| | | | | | | | BUG=51055 TBR=glider Review URL: http://codereview.chromium.org/3058035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54740 0039d316-1c4b-4281-b951-d872f2087c98
* DCHECK that CreatePlugin is only called for blocked plugins when ↵bauerb@chromium.org2010-08-031-6/+5
| | | | | | | | | | | click-to-play is enabled. BUG=50506 TEST=none Review URL: http://codereview.chromium.org/3033046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54739 0039d316-1c4b-4281-b951-d872f2087c98
* Add a first version of memory waterfall sheriff helper script to try ↵timurrrr@chromium.org2010-08-032-0/+153
| | | | | | | | | Valgrind suppressions locally TEST=./tools/valgrind/waterfall.sh fetch && ./tools/valgrind/waterfall.sh match Review URL: http://codereview.chromium.org/3044041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54738 0039d316-1c4b-4281-b951-d872f2087c98
* Only close a newly opened download tab if there's more than one tab.bauerb@chromium.org2010-08-036-10/+33
| | | | | | | | | BUG=45464,10764 TEST=See first bug for manual test. Review URL: http://codereview.chromium.org/3029040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54737 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 64534:64541.pfeldman@chromium.org2010-08-032-45/+1
| | | | | | | | TBR=atwilson Review URL: http://codereview.chromium.org/3029054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54736 0039d316-1c4b-4281-b951-d872f2087c98
* Landing http://codereview.chromium.org/3032043/show for Denis (dilmah).avayvod@chromium.org2010-08-037-98/+181
| | | | | | | | | BUG=http://crosbug.com/4411 TEST=On login screen change the language through new user pod and verify that for existing user pods text is translated to the new language. Review URL: http://codereview.chromium.org/3047044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54731 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 484.0 to 485.0chrome-release@google.com2010-08-031-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54729 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: fix remote debugging dispatch, provide encoding in the main ↵pfeldman@chromium.org2010-08-031-4/+2
| | | | | | | | connect page. Review URL: http://codereview.chromium.org/3071016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54727 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Remote debugging doesn't work on mac.loislo@chromium.org2010-08-031-0/+3
| | | | | | | | | | | | | | | | | | 1. Run chromium with --remote-debugging-port=9222 2. Open another tab with url localhost:9222 What is the expected result? Page with the list of available tabs. What happens instead? Page doesn't open and stay in waiting state. BUG=50749 TEST=none Review URL: http://codereview.chromium.org/3012037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54726 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: re-enable pause test.pfeldman@chromium.org2010-08-031-2/+1
| | | | | | | | BUG=50416 Review URL: http://codereview.chromium.org/3013057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54725 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: follow up to r54722, remove unused classes.pfeldman@chromium.org2010-08-033-54/+0
| | | | | | Review URL: http://codereview.chromium.org/3037037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54724 0039d316-1c4b-4281-b951-d872f2087c98
* Add the definition of the webRequest and webNavigation APIs.jochen@chromium.org2010-08-0312-1/+4897
| | | | | | | | | | | The webRequest API doesn't support the planned filter and extraInfoSpec parameters yet, these will be added later. BUG=50943 TEST=ExtensionApiTest.WebRequest,ExtensionApiTest.WebNavigation Review URL: http://codereview.chromium.org/3061041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54723 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Get rid of DevTools RPC.pfeldman@chromium.org2010-08-0322-165/+81
| | | | | | Review URL: http://codereview.chromium.org/3005044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54722 0039d316-1c4b-4281-b951-d872f2087c98
* Add "Load all plugins on this page" button to blocked plugins bubble if ↵bauerb@chromium.org2010-08-0321-39/+375
| | | | | | | | | | | | | | | click-to-play is enabled. Screenshot: http://imgur.com/ZKsQB.png XIB changes: Add a rounded rect button hooked up to |loadAllPlugins:| in the File's Owner and referenced by its |loadAllPluginsButton_| outlet, wrapped in a GTMWidthBasedTweaker. BUG=49677 TEST=ContentSettingBubbleModelTest.* Review URL: http://codereview.chromium.org/3015036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54720 0039d316-1c4b-4281-b951-d872f2087c98
* Replace ViewHostMsg_GetPluginPath with ViewHostMsg_GetPluginInfo.bauerb@chromium.org2010-08-039-69/+77
| | | | | | | | | | | This enables the renderer to get more information about a plugin than just the path. TEST=none BUG=none Review URL: http://codereview.chromium.org/3015029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54719 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to version 2.3.4.1.whesse@chromium.org2010-08-031-1/+1
| | | | | | Review URL: http://codereview.chromium.org/3017049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54718 0039d316-1c4b-4281-b951-d872f2087c98
* Add Valgrind suppressions parser & matcher script.timurrrr@chromium.org2010-08-031-0/+218
| | | | | | | | After a while this will be used in a PRESUBMIT script TEST=python tools/valgrind/suppressions.py -> self-test Review URL: http://codereview.chromium.org/2836078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54717 0039d316-1c4b-4281-b951-d872f2087c98
* [linux] Hook up crash reporter initialization with configuration management.mnissler@chromium.org2010-08-033-28/+29
| | | | | | | | | BUG=49662 TEST=Enable/Disable metrics reporting through policy and check whether the crash reporter respects that. Review URL: http://codereview.chromium.org/3084008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54716 0039d316-1c4b-4281-b951-d872f2087c98
* Mange ciricular reference to HttpNetworkTransaction in HttpProxyClientSocktPool.vandebo@chromium.org2010-08-031-2/+9
| | | | | | | | | | | Without explicit management of the cirucular reference to HttpNetworkTransaction, it can get deleted at inopportune times and cause undesirable effects (i.e. triggering a pool to delete itself while in the middle of other operations). This change breaks the cirucular reference at points in execution where it is safe. BUG=50822, 49254 TEST=green reliability bot Review URL: http://codereview.chromium.org/3084011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54715 0039d316-1c4b-4281-b951-d872f2087c98
* Recommit 54405 - Fix late binding induced mismatch of Socket and AuthControllervandebo@chromium.org2010-08-0316-437/+417
| | | | | | | | | | | | | ClientSocketPool treats all pending SocketParams as interchangeable. Therefore they can not contain any connection specific data. This only affects the Http Proxy tunnel case. The lowest risk change to fix this problem is to create the HttpAuthController in the HttpProxyClientSocket. If we get a 407 and need to restart the Tunnel, the pending HttpProxyClientSocket is returned to the HttpNetworkTransaction in the additional error state of the connection and then complete the auth in a pair of states in the HttpNetworkTransaction. This reintroduces a dependency between tunnel setup and the HttpNetworkTransaction, but that will need to be fixed at a later date. Original Review URL: http://codereview.chromium.org/3058013 BUG=49493 TEST=existing unit tests + manually visiting many SSL sites through a kerberized http proxy. Review URL: http://codereview.chromium.org/3029052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54714 0039d316-1c4b-4281-b951-d872f2087c98
* Shutdown the notification UI manager before the notifications service, as ↵johnnyg@chromium.org2010-08-031-0/+3
| | | | | | | | | | | the former's shutdown logic depends on the latter. BUG=50553 TEST=see bug Review URL: http://codereview.chromium.org/3051029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54713 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 54707 - Fix WebSocket crash bug.ukai@chromium.org2010-08-032-34/+6
| | | | | | | | | | | | | | | | | | | | If SocketStream closes while waiting ResolveProxy, it badly calls DoResolveProxyComplete from DoLoop invoked by SocketStream::Close, and real callback of ResolveProxy failed to call SocketStream::OnIOCompleted. So, don't run DoLoop when closed, if SocketStream is calling APIs of proxy_service or resolver. Check closing_ after the API calls back and closes the SocketStream. BUG=50394,46750 TEST=websocket/tests doesn't crash Review URL: http://codereview.chromium.org/3054039 TBR=ukai@chromium.org Review URL: http://codereview.chromium.org/3017053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54709 0039d316-1c4b-4281-b951-d872f2087c98
* Fix WebSocket crash bug.ukai@chromium.org2010-08-032-6/+34
| | | | | | | | | | | | | | | | | If SocketStream closes while waiting ResolveProxy, it badly calls DoResolveProxyComplete from DoLoop invoked by SocketStream::Close, and real callback of ResolveProxy failed to call SocketStream::OnIOCompleted. So, don't run DoLoop when closed, if SocketStream is calling APIs of proxy_service or resolver. Check closing_ after the API calls back and closes the SocketStream. BUG=50394,46750 TEST=websocket/tests doesn't crash Review URL: http://codereview.chromium.org/3054039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54707 0039d316-1c4b-4281-b951-d872f2087c98
* Mark special-key-events-in-input-text.html as failing.atwilson@chromium.org2010-08-031-0/+2
| | | | | | | | | TBR=pfeldman BUG=51036 Review URL: http://codereview.chromium.org/3071015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54706 0039d316-1c4b-4281-b951-d872f2087c98
* Don't launch the IME on the login screen unless needed.zork@chromium.org2010-08-036-26/+87
| | | | | | | | | BUG=chromium-os:4460 TEST=Boot chromium os. Switch to a virtual console. Run "ps aux | grep ibus" and check that ibus is not running. Switch back to the login screen. Switch the input method to Dvorak. Check that Dvorak works. Reboot. Check that the input method is dvorak. Review URL: http://codereview.chromium.org/2806083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54705 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing "number of suggestions" configuration item in Mozc DOMUIsatorux@chromium.org2010-08-034-9/+35
| | | | | | | | | | | | | | I forgot to include this item in the previous CL. Use type=number rather than touch-slider (used in original UI) for number of suggestions. Also clean up some of ARRAYSIZE_UNSAFE() usages in language_preferences.h. TEST=manually check on the netbook by uncommenting TODO lines in options.html. BUG=chromium-os:4809 Review URL: http://codereview.chromium.org/3020054 Patch from Takayoshi Kochi <kochi@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54703 0039d316-1c4b-4281-b951-d872f2087c98
* Roll 64469:64523atwilson@chromium.org2010-08-031-1/+1
| | | | | | | | TBR=pfeldman Review URL: http://codereview.chromium.org/3090003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54702 0039d316-1c4b-4281-b951-d872f2087c98
* Fix incorect tests against INVALID_FILE_HANDLE, as pointed out by cpu on ↵skerner@chromium.org2010-08-032-5/+5
| | | | | | | | | | | chrome-team. BUG=NONE TEST=FileUtilTest.NormalizeFilePath* Review URL: http://codereview.chromium.org/3031041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54701 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 54584 - Delete tasks unconditionally in ↵akalin@chromium.org2010-08-031-2/+21
| | | | | | | | | | | | | | MessageLoop::DeletePendingTasks(). BUG=6532 TEST=existing unit tests Review URL: http://codereview.chromium.org/3076015 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/2878074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54697 0039d316-1c4b-4281-b951-d872f2087c98
* base: Rename EnvVarGetter to Environment.tfarina@chromium.org2010-08-0348-197/+192
| | | | | | | | | | | | | | | Now EnvVarGetter do much more than getting environment variables. Per suggestion from Pawel in http://codereview.chromium.org/3043018/. BUG=None TEST=trybots Signed-off-by: Thiago Farina <tfarina@chromium.org> Review URL: http://codereview.chromium.org/3052034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54696 0039d316-1c4b-4281-b951-d872f2087c98
* Fix two bugs caused by scheme stripping:pkasting@chromium.org2010-08-031-2/+4
| | | | | | | | | | | * We no longer detected that the user was dragging the permanent_text_, and thus that we could give the drag a title and favicon. * We no longer scored hitting enter on the URL as a RELOAD. BUG=47555 TEST=Visit www.google.com. Drag the omnibox text to the desktop. The shortcut should have a title and favicon. Review URL: http://codereview.chromium.org/3030039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54694 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 54643 - Fix --kiosk to work regardless of the startup pref setting or ↵pkasting@chromium.org2010-08-033-23/+15
| | | | | | | | | | | | | | | supplied URLs. This also fixes a bug in Linux Views where calling BrowserWindow::Show() wouldn't synchronously call BrowserList::SetLastActive(). This happens naturally in Windows and was already explicitly done in BrowserWindowGtk and BrowserWindowCocoas, but missing it for Linux Views resulted in crashes when the kiosk code tried to get the last active window before the message loop had pumped the async activation change message. BUG=none TEST=Set Chrome to "open windows and tabs from last time", then run with --kiosk. Should start in kiosk mode (fullscreen, no status bubble). Review URL: http://codereview.chromium.org/2847090 TBR=pkasting@chromium.org Review URL: http://codereview.chromium.org/3017052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54691 0039d316-1c4b-4281-b951-d872f2087c98
* Implement import data overlaysargrass@google.com2010-08-034-19/+160
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/3029044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54673 0039d316-1c4b-4281-b951-d872f2087c98
* Undo in memory changes made by an update job if the commit to disk fails. ↵michaeln@chromium.org2010-08-0311-39/+172
| | | | | | | | | | Provide a more clear error message when the commit fails due to exceeding the quota. TEST=MasterEntryFailStoreNewestCacheTest BUG=50985 Review URL: http://codereview.chromium.org/2836075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54667 0039d316-1c4b-4281-b951-d872f2087c98
* [GTK] compile fix, try2estade@chromium.org2010-08-031-4/+4
| | | | | | | | | TBR=pkasting, ncarter TEST=compile Review URL: http://codereview.chromium.org/3060037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54659 0039d316-1c4b-4281-b951-d872f2087c98
* [GTK] Remove reference to obsolete constant.estade@chromium.org2010-08-031-13/+2
| | | | | | | | | TBR=ncarter TEST=compile; also autocomplete popup text aligns with omnibox text Review URL: http://codereview.chromium.org/3053036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54656 0039d316-1c4b-4281-b951-d872f2087c98
* UI changes to sync dialogs to improve formatting and font sizes.tim@chromium.org2010-08-034-75/+87
| | | | | | | | | | | | | | | | | | | | | | | | | | | | All resource files _ Made text unselectable on all 3 screens _ Change the default font size to 11pt and 1.8em line height spacing gaia_login _ Introduction paragraph is now using 11pt font and new spaced line height _ Moved the cancel button into the GAIA login box. _ Error message > Made permanent space for the error msg between intro paragraph and GAIA login > Error message now as the same orange background as on choosedatatypes > Error shows on Captcha view if there's an error setup_done _ Got rid of the tables _ Header is now the right size _ Synced to user@gmail.com is now bold BUG=49704 Original patch by dudley@chromium.org Original review: http://codereview.chromium.org/3085003 Review URL: http://codereview.chromium.org/2856081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54653 0039d316-1c4b-4281-b951-d872f2087c98
* Pass value of enable-accelerated-compositing runtime flag down to the renderer.vangelis@chromium.org2010-08-031-0/+1
| | | | | | | | BUG=50994 TEST=None Review URL: http://codereview.chromium.org/3058031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54652 0039d316-1c4b-4281-b951-d872f2087c98
* Add two client certificates for use with unit testsdavidben@chromium.org2010-08-033-0/+30
| | | | | | | | | | | | | The first is a FOAF.ME cert generated for this purpose. The second is one of my expired MIT certificates. R=wtc BUG=50980 TEST=none Review URL: http://codereview.chromium.org/2836082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54650 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a number of problems caused by the AutocompleteController purposefully ↵pkasting@chromium.org2010-08-035-20/+43
| | | | | | | | | | committing out-of-date results after the edit had changed. Simply not doing this commit would make the popup appear less responsive, so instead we're more careful to not try and update the edit with the out-of-date data, and instead force the popup to get newer results in cases where it might have been out-of-date. BUG=46315 TEST=Type a letter that inline autocompletes, then immediately hit ctrl-a. You should get everything selected, not nothing. Also, typing a letter that inline autocompletes, then immediately a random other letter and the down arrow key, should show a popup with results for the two letters you typed, not just the first. Review URL: http://codereview.chromium.org/3047041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54649 0039d316-1c4b-4281-b951-d872f2087c98
* [GTK] fix up spacing in upper chrome.estade@chromium.org2010-08-039-82/+60
| | | | | | | | | | | | | These changes mirror pkasting's work on windows for milestone6. TODO (in a follow up patch): convert the wrench menu into a CustomDrawButton (you will notice that currently it is too wide and has the wrong sort of background hover appearance). BUG=50682 TEST=look of upper chrome Review URL: http://codereview.chromium.org/3007018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54648 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY Alternate-Protocol works through a Digest authentication proxy.cbentzel@chromium.org2010-08-034-13/+188
| | | | | | | | | | | | | | | Digest authentication uses a uri field to prevent replay attacks. When authenticating to an HTTP proxy to establish a secure tunnel (via CONNECT), the uri should be the hostname of the server and the destination port, such as "www.example.com:443". When authenticating to an HTTP proxy for a non-secure content, the uri should be the path at the server, i.e. "/index.html". If the site we are trying to connect to previously advertised "Alternate-Protocol: 443:spdy-npn/1" a request to "http://www.example.com" will be attempted on a secure port. However, the URL passed into the digest authenticator was an unsecure one, and it decided to have a uri in the form "/index.html" rather than the correct "www.example.com:443". This causes persistent failure with the password and many password prompts. BUG=49865 TEST=net_unittests --gtest_filter="HttpNetworkTransactionTest.SpdyAlternateProtocolThroughProxy" Review URL: http://codereview.chromium.org/3040032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54647 0039d316-1c4b-4281-b951-d872f2087c98
* webkit_support: Prepareation to remove dependencies to base/time.h,tkent@chromium.org2010-08-032-0/+63
| | | | | | | | | | | | net/base/escape.h, and net/base/net_errors.h from DRT. Make wrapper functions of features used by DRT. BUG=none TEST=none Review URL: http://codereview.chromium.org/2873088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54646 0039d316-1c4b-4281-b951-d872f2087c98
* When picking a filename to save, check whether the user's extension is ↵pkasting@chromium.org2010-08-032-93/+42
| | | | | | | | | | registered on the system at all, rather than checking whether it has a known MIME type. Many known extensions have no MIME type. BUG=7499 TEST=Save a text file as "foo.reg" and ensure it doesn't get ".txt" appended. Review URL: http://codereview.chromium.org/3050031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54645 0039d316-1c4b-4281-b951-d872f2087c98
* Forgot to land this when I landed all the image resource changes.pkasting@chromium.org2010-08-031-0/+0
| | | | | | | | | TBR=erg BUG=50107 TEST=none Review URL: http://codereview.chromium.org/3078018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54644 0039d316-1c4b-4281-b951-d872f2087c98
* Fix --kiosk to work regardless of the startup pref setting or supplied URLs. pkasting@chromium.org2010-08-033-15/+23
| | | | | | | | | | This also fixes a bug in Linux Views where calling BrowserWindow::Show() wouldn't synchronously call BrowserList::SetLastActive(). This happens naturally in Windows and was already explicitly done in BrowserWindowGtk and BrowserWindowCocoas, but missing it for Linux Views resulted in crashes when the kiosk code tried to get the last active window before the message loop had pumped the async activation change message. BUG=none TEST=Set Chrome to "open windows and tabs from last time", then run with --kiosk. Should start in kiosk mode (fullscreen, no status bubble). Review URL: http://codereview.chromium.org/2847090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54643 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Add a default constructor for FormData. There are too many placesjhawkins@chromium.org2010-08-031-0/+2
| | | | | | | | | | | | that create FormDatas, and we shouldn't need to initialize user_submitted for each call site. BUG=50423 TEST=none Review URL: http://codereview.chromium.org/3074023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54641 0039d316-1c4b-4281-b951-d872f2087c98