| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=75247
TEST=none
TBR=glider@chromium.org
Review URL: http://codereview.chromium.org/6623079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=75246
TEST=none
TBR=glider@chromium.org
Review URL: http://codereview.chromium.org/6628076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This includes temporary webkit test expectactions until we land that upstream.
Review URL: http://codereview.chromium.org/6625055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:12715
TEST=Manual
Review URL: http://codereview.chromium.org/6621064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Old interface is obsoleted by https://bugs.webkit.org/show_bug.cgi?id=55453
This is a sequel of the change:
http://src.chromium.org/viewvc/chrome?view=rev&revision=77118
Pass around preferred language to font fallback selection. For Fixing chinese font issue.
BUG=chromium-os:11699
TEST=manually
Review URL: http://codereview.chromium.org/6626050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
InfoBarContainer::RemoveInfoBar() instead of calling parent()->RemoveChildView() directly, so that the container knows the infobar is gone. (The container was trying to access deleted infobars because it never saw them go away.) Unlike the first version of this patch, we don't try to deref a NULLed |container_| in the middle of Close().
This also removes the "if (container_)" conditional in Close() because it cannot be called with a NULL |container_|, and opportunistically makes it private.
BUG=75021
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/6623075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6621066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change updates the app icons for chromium.
BUG=None
TEST=Ran on Mac and Linux. Verified that the app icon and the About dialog look ok. Windows build pending.
Review URL: http://codereview.chromium.org/6628068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=74894
TEST=browser_tests --gtest_filter=FormManagerTest.FillFormNonEmptyField
Review URL: http://codereview.chromium.org/6635028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
they depend on and which depends on them.TBR=avi
Review URL: http://codereview.chromium.org/6628071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=andreip, steveblock
Review URL: http://codereview.chromium.org/6635036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[This is a re-landing of CL 6623059, which broke the
shared library build on windows in revision 77207.
An ifdef has been added to avoid the unresolved variable
when allocator_shim.cc is never even compiled]
Continue to support selection of a browser allocator
selection via the environment variable CHROME_ALLOCATOR,
and also add CHROME_ALLOCATOR_2 that can select the
allocator to use in subprocesses, such as a renderer.
Temporarilly set the browser default to the
default windows heap allocator, and the subprocess
allocator to TCMalloc to help detect memory corruption
in a cannary for a few days.
This may illuminate some flakiness in the tree, as
double frees (hidden by races) may cause crashes.
Add minor cleanup (removing reserved word "override"
etc.).
BUG=74901
TBR=mbelshe
Review URL: http://codereview.chromium.org/6623072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome sync is dependent on other areas of chrome, and patches committed to
these areas could potentially break sync. In the past, we have seen
sync integration test failures caused by patches to chrome/common/net.
This patch adds a PRESUBMIT.py file to this directory, that will cause the
sync integration tests to be run on any code that touches the directory as
part of their try runs.
BUG=70311
TEST=modify something under chrome/common/net and do a "git try" or "gcl try"
Review URL: http://codereview.chromium.org/6624087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
InfoBarContainer::RemoveInfoBar() instead of calling parent()->RemoveChildView() directly, so that the container knows the infobar is gone. (The container was trying to access deleted infobars because it never saw them go away.)
This also removes the "if (container_)" conditional in Close() because it cannot be called with a NULL |container_|, and opportunistically makes it private.
BUG=75021
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/6627069
TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/6624088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome sync is dependent on other areas of chrome, and patches committed to
these areas could potentially break sync. In the past, we have seen
sync integration test failures caused by patches to net, jingle and base.
This patch adds a PRESUBMIT.py file to each of these directories, that
will result the sync integration tests being run on any code that
touches these directories as part of their try runs.
BUG=70311
TEST=modify something under base, net or jingle and do a "git try" or "gcl try"
Review URL: http://codereview.chromium.org/6624086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
fileapi::FileSystemUsageCache::Read.
BUG=75018
TEST=none
Review URL: http://codereview.chromium.org/6621061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Go to NTP. The logo should be in the lower left corner. Also close some of
the sections. The should now be right aligned.
Review URL: http://codereview.chromium.org/6623062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
InfoBarContainer::RemoveInfoBar() instead of calling parent()->RemoveChildView() directly, so that the container knows the infobar is gone. (The container was trying to access deleted infobars because it never saw them go away.)
This also removes the "if (container_)" conditional in Close() because it cannot be called with a NULL |container_|, and opportunistically makes it private.
BUG=75021
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/6627069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
-Tests were failing due to the new country drop-down list field.
-The dictionary entry for ADDRESS_HOME_COUNTRY were no longer matching the country name within profiles due to casing mismatch.
BUG=74843
TEST=none
Review URL: http://codereview.chromium.org/6624084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
During a code review I noticed that RenderViewHost::FromID was being called from the IO thread, but there were no automated assertions that fired.
BUG=None
TEST=DCHECK fires when I add bad code. Otherwise Chrome works without crashing in Debug build.
Review URL: http://codereview.chromium.org/6591108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Cleanup files in /home/chronos not just /home/chronos/user
BUG=
TEST=
Review URL: http://codereview.chromium.org/6625073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
observe-prefetch-without-actually-prefetching.
Also, drop prefetch probability to 0%.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6621044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=youtube, nba, amazon
Review URL: http://codereview.chromium.org/6625034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed GPU plugin.
Pepper 3D v2 does not use the GPU plugin. It is integrated with the accelerated compositor.
TEST=PPAPI 3D v2 still works, trybots
BUG=none
Review URL: http://codereview.chromium.org/6635026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50307
TEST=tab overview mode looks different
Review URL: http://codereview.chromium.org/6621056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
has loaded.
BUG=74088
TEST=see bug.
Review URL: http://codereview.chromium.org/6623061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=75224
TEST=none
TBR=jochen
Review URL: http://codereview.chromium.org/6628070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit r77106.
Takes ots from 56 -> 50. Win Reliability has been read since its
commit. Logs here:
http://build.chromium.org/p/chromium/builders/Win/builds/2947
http://build.chromium.org/p/chromium/builders/Win%20Reliability/builds/2491
This is a provisional revert to see if it makes things green.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6625072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in Firefox (since it does not support Cocoa). This lets us use O2D in FF without porting it to Quickdraw.
Also tweak the drawing model behaviour so that we select the best possible model for the requested RenderMode.
TEST=RenderMode=Auto and =2D in FF on an MBP6,2 and verified 2D avoids issues with the dynamic GPU switching feature of that hardware; RenderMode=2D in Chrome and Safari
BUG=none
Review URL: http://codereview.chromium.org/6626059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6633002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=Manual mouse event testing.
Review URL: http://codereview.chromium.org/6591120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The last param is for languages, which is already a std::string in
most places.
BUG=23581
Review URL: http://codereview.chromium.org/6627061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
HttpPortAllocatorSession uses libjingle's http client to establish relay
connection. This will not work in the sanboxed case since it access OS
level of network directly.
This patch replaces the http client with URL loader in pepper. This goes
through the standard URL fetching system for chrome to get around the
sandbox problem.
BUG=51198
TEST=Force libjingle to use relay and try it with this code.
Review URL: http://codereview.chromium.org/6623048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The scripts compile a c++ test case and compares the compiler output against a golden file.
BUG=carnitas
TEST=(For developers only; QA ignore): ./test.sh <path to Release+Asserts>
Review URL: http://codereview.chromium.org/6623065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes it clear that it's not an override of WidgetGtk::Show
No intended functionality change.
BUG=70465,72205
TEST=none
Review URL: http://codereview.chromium.org/6635031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also eliminate stupid and unnecessary conversion of data to a big string, only
to be parsed back.
BUG=none
TEST=everything still works
Review URL: http://codereview.chromium.org/6635009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The current toast (re-activation) experiment suffers from the following problems:
1- False negative: the toast can be triggered even if chrome is being used
2- Nested message loop crash: If chrome tries to run while the toast is being shown, it crashes
This change addresses both conditions. Before running the toast we leverage the
process_singleton to detect another instance. If so we abort with "no thanks".
When showing the toast and its nested message loop we take the process_singleton lock which
inhibits dispatch of the wm_copydata message which spawns new tabs in the current process if
we try to span a new tab while in the nested message loop we crash.
BUG=32026
TES=see bug
Review URL: http://codereview.chromium.org/6625037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=74492
TEST=unit-tested
Review URL: http://codereview.chromium.org/6621004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6614023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This brings in a fix that makes -Woverloaded-virtual not warn for
static functions, which is required for the linux_views bot (r126966).
It also contains a fix (r127176) for a regression introduced in r126797.
BUG=70465,72205
TEST=none
Review URL: http://codereview.chromium.org/6628034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
for a state that wasn't bad.
BUG=none
TEST=installation and uninstallation still work
Review URL: http://codereview.chromium.org/6625063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=nduca
Review URL: http://codereview.chromium.org/6625064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Continue to support selection of a browser allocator
selection via the environment variable CHROME_ALLOCATOR,
and also add CHROME_ALLOCATOR_2 that can select the
allocator to use in subprocesses, such as a renderer.
Temporarilly set the browser default to the
default windows heap allocator, and the subprocess
allocator to TCMalloc to help detect memory corruption
in a cannary for a few days.
Add minor cleanup (removing reserved word "override"
etc.).
r=mbelshe
bug=74901
Review URL: http://codereview.chromium.org/6623059
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/6623069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Continue to support selection of a browser allocator
selection via the environment variable CHROME_ALLOCATOR,
and also add CHROME_ALLOCATOR_2 that can select the
allocator to use in subprocesses, such as a renderer.
Temporarilly set the browser default to the
default windows heap allocator, and the subprocess
allocator to TCMalloc to help detect memory corruption
in a cannary for a few days.
Add minor cleanup (removing reserved word "override"
etc.).
r=mbelshe
bug=74901
Review URL: http://codereview.chromium.org/6623059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Mac/Linux we keep the socket open, so don't get an OnChannelConnected
message when a new Chromium launches and connects to the service, so we weren't
properly marking ourselves as having a client connected. When the service was
disable and Chromium exited, it meant we weren't properly exiting
immediately. This is only a partial fix for the bug.
BUG=74983
TEST=Start Chromium, enable the proxy, quit Chromium, start Chromium, disable the proxy, quit Chromium. With this fix the service process immediately exits.
Review URL: http://codereview.chromium.org/6635023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=No visible change.
Review URL: http://codereview.chromium.org/6626054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
PPAPI's MakeDirectoryIncludingAncestors() (ppapi/cpp/dev/file_ref_dev.cc) uses recursive CreateDirectory.
BUG=74841
TEST=none
Review URL: http://codereview.chromium.org/6627028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(incl. the full Uyghur translations)
Review URL: http://codereview.chromium.org/6628062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77203 0039d316-1c4b-4281-b951-d872f2087c98
|