summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add WebstoreInlineInstaller (downloads store data, shows the install UI, and ↵mihaip@chromium.org2011-08-2919-115/+627
| | | | | | | | | | | | | | | | | | | | | | | | starts the install). The flow is: 1. Fetch store metadata as JSON (using URLFetcher) 2. Parse response in utility process (via SafeWebstoreResponseParser) 3. Parse manifest and get icon data using WebstoreInstallHelper 4. Show install UI 5. Whitelist extension ID for download and start download Still missing are a way of informing the page that the inline install succeeded or failed. Also removes ExtensionTabHelper::GetCustomFrameNativeWindow, since it wasn't actually overriding anything (the method was removed from ExtensionFunctionDispatcher::Delegate by r74835). R=asargent@chromium.org Review URL: http://codereview.chromium.org/7741037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98712 0039d316-1c4b-4281-b951-d872f2087c98
* content: Reapply "Start splitting up chrome/browser/ui/gtk/gtk_util.h" (r98287)erg@google.com2011-08-2952-179/+255
| | | | | | | | | | | | | | | | | Now with fixes for builds that trybots don't cover by default. (This yak needs shaving because chunks of gtk using code in chrome/ are being moved to content/ to build the content_shell, but we can't depend on code in chrome/. While I'm here, split gtk_util.h into a set of logical chunks: hig constants, widget factory functions, etc instead of just moving the file.) BUG=93804 TEST=none; code move First Review URL: http://codereview.chromium.org/7737001 Review URL: http://codereview.chromium.org/7748026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98711 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 98706 - Initial checkin of the compositor_model_bench toolpiman@google.com2011-08-2966-2086/+0
| | | | | | | | | | | | | | | | | | | | This tool simulates the GPU demands of Chromium's GPU-accelerated compositor. In the current version, we simulate the performance of the existing forward rendering model; coming changes will prototype a new model. BUG=None TEST=self This is http://codereview.chromium.org/7718020/ with trivial fixes Original change by Joshua Trask <joshtrask@google.com> Review URL: http://codereview.chromium.org/7792002 Patch from Joshua Trask <joshtrask@google.com>. TBR=piman@google.com Review URL: http://codereview.chromium.org/7792016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98710 0039d316-1c4b-4281-b951-d872f2087c98
* PNGcrushed images that were added earlier today.saintlou@chromium.org2011-08-2914-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | chrome/app/theme/large_tab_active_center.png | Bin 47721 -> 13026 bytes chrome/app/theme/large_tab_active_left.png | Bin 49114 -> 13782 bytes chrome/app/theme/large_tab_active_right.png | Bin 48883 -> 13502 bytes chrome/app/theme/large_tab_alpha_left.png | Bin 48033 -> 13349 bytes chrome/app/theme/large_tab_alpha_right.png | Bin 49813 -> 13238 bytes chrome/app/theme/large_tab_close.png | Bin 47134 -> 13018 bytes chrome/app/theme/large_tab_close_h.png | Bin 53363 -> 13621 bytes chrome/app/theme/large_tab_close_mask.png | Bin 48963 -> 13366 bytes chrome/app/theme/large_tab_close_p.png | Bin 54518 -> 13749 bytes chrome/app/theme/large_tab_drop_down.png | Bin 51151 -> 13789 bytes chrome/app/theme/large_tab_drop_up.png | Bin 50911 -> 13808 bytes chrome/app/theme/large_tab_inactive_center.png | Bin 47525 -> 13086 bytes chrome/app/theme/large_tab_inactive_left.png | Bin 50316 -> 13808 bytes chrome/app/theme/large_tab_inactive_right.png | Bin 48411 -> 13477 bytes BUG=none TEST=none TBR=sail@chromium.org Review URL: http://codereview.chromium.org/7794009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98709 0039d316-1c4b-4281-b951-d872f2087c98
* NaCl Test: fix typo in .nmf.polina@google.com2011-08-291-1/+1
| | | | | | | | BUG=none TEST=bots Review URL: http://codereview.chromium.org/7764012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98708 0039d316-1c4b-4281-b951-d872f2087c98
* more updates to official builds expectationskerz@chromium.org2011-08-291-5/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98707 0039d316-1c4b-4281-b951-d872f2087c98
* Initial checkin of the compositor_model_bench toolpiman@google.com2011-08-2966-0/+2086
| | | | | | | | | | | | | | | | | This tool simulates the GPU demands of Chromium's GPU-accelerated compositor. In the current version, we simulate the performance of the existing forward rendering model; coming changes will prototype a new model. BUG=None TEST=self This is http://codereview.chromium.org/7718020/ with trivial fixes Original change by Joshua Trask <joshtrask@google.com> Review URL: http://codereview.chromium.org/7792002 Patch from Joshua Trask <joshtrask@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98706 0039d316-1c4b-4281-b951-d872f2087c98
* Update to libcros 166stevenjb@google.com2011-08-291-1/+1
| | | | | | | | | BUG=none TEST=Chrome builds and runs on ChromeOS Review URL: http://codereview.chromium.org/7779004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98705 0039d316-1c4b-4281-b951-d872f2087c98
* ImportantFileWriter: Flush the data before closing thervargas@google.com2011-08-291-7/+22
| | | | | | | | | | | temporary file so that the subsequent rename always operates with data in disk. BUG=89356 TEST=none Review URL: http://codereview.chromium.org/7695014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98704 0039d316-1c4b-4281-b951-d872f2087c98
* Mark WebUIBidiCheckerBrowserTest.TestSettingsAutofillPageLTR as Flaky on Macdmaclach@chromium.org2011-08-291-1/+7
| | | | | | | | | BUG=94642 TEST=BUILD Review URL: http://codereview.chromium.org/7790012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98703 0039d316-1c4b-4281-b951-d872f2087c98
* File Manager: Assorted fixes and polishrginda@chromium.org2011-08-298-34/+95
| | | | | | | | | | | | | | | | | Add chromeish button style Fix dialog gradient and transitions Fix harness file creation Fix task button rendering Make list header gradient not leak outside of list Show checkmark even when only a single item is selected (multi-select mode only). Add a delay to the mock tasks callback to better simulate the real world. BUG=chromium-os:17028, chromium-os:19373, chromium-os:19693 TEST=manual testing Review URL: http://codereview.chromium.org/7764011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98701 0039d316-1c4b-4281-b951-d872f2087c98
* Makes bookmark bar view reset PageNavigator on menu when PageNavigatorsky@chromium.org2011-08-292-4/+17
| | | | | | | | | | | | | of BookmarkBarView changes. My last patch added the plumbing, this wires it up. BUG=92994 TEST=make sure bookmark menus still work; covered by tests too. R=ben@chromium.org Review URL: http://codereview.chromium.org/7787001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98700 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 98679 - Restoring a session should restore window minimization state ↵dhollowa@chromium.org2011-08-2935-266/+224
| | | | | | | | | | | | | | | | | on Windows These changes enable save and restore of minimized window state on Windows. (Mac and Linux came prior). The window state is now saved whenever size-changed notifications fire (in addition to the original activation and close cases). BUG=43274 TEST=Manual. Launch Chrome on Windows, create two browser windows, minimize "a" window, quit. Relaunch, expect "a" to be minimized. Review URL: http://codereview.chromium.org/7748036 TBR=dhollowa@chromium.org Review URL: http://codereview.chromium.org/7790010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98699 0039d316-1c4b-4281-b951-d872f2087c98
* Another round of debugging code. This time to TabStripModel. It seemssky@chromium.org2011-08-292-3/+13
| | | | | | | | | | | | | | as though a TabSTripModel is getting notified that has a NULL in contents_data_. That doesn't seem possible though, so something weird must be happening. BUG=93747 TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/7767010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98698 0039d316-1c4b-4281-b951-d872f2087c98
* Increased the unresponsive_threshold from 6 to 12rtenneti@chromium.org2011-08-291-1/+17
| | | | | | | | | | | | | | in Beta channel and XP. We will crash the browser if UI/IO threads don't respond within 24 secs (instead of 12 secs) in Beta channel and Windows XP. BUG=90095 R=jar TEST=thread_watcher unit tests Review URL: http://codereview.chromium.org/7744015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98697 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 98355 (was semantically incorrect, caused assertion failures in Debug ↵kbr@google.com2011-08-291-4/+1
| | | | | | | | | | | | | | | | builds with some apps) - Further attempted workarounds for Mac- and NVIDIA-specific crash. Can not reproduce this crash in house any more, so adding more code along the lines of the earlier fix which was known to work on some hardware. BUG=94103 TEST=none (tested manually to verify no regression) Review URL: http://codereview.chromium.org/7756001 TBR=kbr@google.com Review URL: http://codereview.chromium.org/7795006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98694 0039d316-1c4b-4281-b951-d872f2087c98
* Speculative fix for 93314. I suspect thesky@chromium.org2011-08-292-2/+5
| | | | | | | | | | | | | | | OptionMenuModel::translate_infobar_delegate_ has been deleted. This may be possible if BeforeTranslateInfoBar is deleted while the menu is showing. Changing the code like I'm doing makes sure the menu is deleted if BeforeTranslateInfoBar is deleted too. BUG=93314 TEST=none R=pkasting@chromium.org Review URL: http://codereview.chromium.org/7745057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98693 0039d316-1c4b-4281-b951-d872f2087c98
* Disables camera hardware dependent tests.perkj@chromium.org2011-08-291-19/+29
| | | | | | | | | | | Also increase the time the test is allowed to wait for a video frame. TEST= BUG=94134 Review URL: http://codereview.chromium.org/7757002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98691 0039d316-1c4b-4281-b951-d872f2087c98
* Remove BrowserSignin, as it's not used anywhere.atwilson@chromium.org2011-08-2918-905/+4
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7748038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98690 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for point conversions to ui::Layer.ben@chromium.org2011-08-2910-0/+430
| | | | | | | | | | Also adds a skeleton for testing compositor API changes. BUG=none TEST=see unittest Review URL: http://codereview.chromium.org/7769001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98689 0039d316-1c4b-4281-b951-d872f2087c98
* Change google search parameter to gcx from cx in experimentjar@chromium.org2011-08-291-3/+1
| | | | | | | | bug=94454 r=pkasting Review URL: http://codereview.chromium.org/7801001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98688 0039d316-1c4b-4281-b951-d872f2087c98
* Add more functionality to graphics3d test (more to follow...)nfullagar@google.com2011-08-293-0/+11
| | | | | | | | | | | | - Call Core->ReleaseResource() on multiple graphics3d resources. Fix for NaCl ppapi graphics 3d resource, so it can be released without crashing the untrusted plugin. Add a few more debug prints for future use. BUG= none TEST= ppapi_ppb_graphics3d.cc (included) Review URL: http://codereview.chromium.org/7736006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98686 0039d316-1c4b-4281-b951-d872f2087c98
* ntp4: fix app load/unload race conditionestade@chromium.org2011-08-293-5/+14
| | | | | | | | | | BUG=94095 TEST=open ntp and chrome://extensions, spam disable/enable on something that's both an app and an extension (such as weatherbug). NTP should not start creating multiple copies of the icon. Review URL: http://codereview.chromium.org/7764013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98685 0039d316-1c4b-4281-b951-d872f2087c98
* ppapi: Make 0.4 the default for PPP_Printing_Dev, leave backwards-compat.dmichael@chromium.org2011-08-2911-121/+26
| | | | | | | | | | | | | Since I didn't land this before the NaCl proxy move to chrome, I had to incorporate the proxy changes that were in http://codereview.chromium.org/7714041/ After PDF lands, I should be able to remove backwards-compat code. BUG=80696 TEST=ppapi tests, manual test of PDF plugin Review URL: http://codereview.chromium.org/7718004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98684 0039d316-1c4b-4281-b951-d872f2087c98
* Save Breakpad symbol files for main executable name variants.mark@chromium.org2011-08-292-5/+52
| | | | | | | | | | | | | | This allows symbolization of Google Chrome Canary, Google Chrome Helper EH, and Google Chrome Helper NP. The practical effect of this is that _main and start will be properly symbolized by Breakpad. BUG=94540 TEST=Look at the Breakpad crash reports for the canary browser process, plug-in process, and NaCl loader process. The bottom of each stack should show ChromeMain being called by main, which is in turn called by start. Review URL: http://codereview.chromium.org/7799005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98682 0039d316-1c4b-4281-b951-d872f2087c98
* Even more PNGssaintlou@chromium.org2011-08-298-0/+0
| | | | | | | | | | BUG=none TEST=none TBR=sky@chromium.org Review URL: http://codereview.chromium.org/7790007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98681 0039d316-1c4b-4281-b951-d872f2087c98
* [cros] User image selection wraps when navigating with arrow keys.ivankr@chromium.org2011-08-291-7/+4
| | | | | | | | | | BUG=chromium-os:19010 TEST=Manual: open user image selection dialog, move to the last image and press the right arrow. Review URL: http://codereview.chromium.org/7784003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98680 0039d316-1c4b-4281-b951-d872f2087c98
* Restoring a session should restore window minimization state on Windowsdhollowa@chromium.org2011-08-2935-224/+266
| | | | | | | | | | | | These changes enable save and restore of minimized window state on Windows. (Mac and Linux came prior). The window state is now saved whenever size-changed notifications fire (in addition to the original activation and close cases). BUG=43274 TEST=Manual. Launch Chrome on Windows, create two browser windows, minimize "a" window, quit. Relaunch, expect "a" to be minimized. Review URL: http://codereview.chromium.org/7748036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98679 0039d316-1c4b-4281-b951-d872f2087c98
* Adding PNGssaintlou@chromium.org2011-08-296-0/+0
| | | | | | | | | | BUG=none TEST=none TBR=sky@chromium.org Review URL: http://codereview.chromium.org/7793005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98678 0039d316-1c4b-4281-b951-d872f2087c98
* Add GPU job object restrictionjschuh@chromium.org2011-08-291-5/+17
| | | | | | | | | | Use the job object to prevent the GPU from spawning child processes on Windows. BUG=None. TEST=None. Review URL: http://codereview.chromium.org/7768004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98677 0039d316-1c4b-4281-b951-d872f2087c98
* minor fixes to get virtual keyboard work on views desktop without ibusoshima@google.com2011-08-293-6/+10
| | | | | | | | | | | | | * Call OnTextInputTypeChanged from Mock class (which is used when ibus is not present) * Don't create InputMethod in desktop window. * Fix comment on RWHVV to be more accurate. BUG=none TEST=none Review URL: http://codereview.chromium.org/7761008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98676 0039d316-1c4b-4281-b951-d872f2087c98
* Exlucde tests that are failing due to mmap erroroshima@google.com2011-08-291-0/+13
| | | | | | | | | | TBR=timurrrr@chromium.org BUG=28439 TEST=none Review URL: http://codereview.chromium.org/7790004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98674 0039d316-1c4b-4281-b951-d872f2087c98
* Now gracefully deals with TypedURLs with no typed visits.atwilson@chromium.org2011-08-292-0/+31
| | | | | | | | | | BUG=94308 TEST=Run unit tests - I don't have any way to reproduce the corrupted DB this CL works around. Review URL: http://codereview.chromium.org/7747040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98673 0039d316-1c4b-4281-b951-d872f2087c98
* Update .DEPS.gitchrome-admin@google.com2011-08-291-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98672 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 93977:93984.levin@chromium.org2011-08-292-1/+3
| | | | | | | | TBR=apavlov@chromium.org Review URL: http://codereview.chromium.org/7798001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98670 0039d316-1c4b-4281-b951-d872f2087c98
* Set noparent for chromeos/cros OWNERS file.stevenjb@google.com2011-08-292-2/+4
| | | | | | | | | | | Also adding myself to chromeos watchlist. BUG=none TEST=none Review URL: http://codereview.chromium.org/7753026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98669 0039d316-1c4b-4281-b951-d872f2087c98
* Add glib to system.gyp for cros static library (load.cc)stevenjb@google.com2011-08-291-0/+17
| | | | | | | | | | | An upcoming libcros change adds a header dependency on glib, so we need an entry in system.gyp for cros_api.gyp to reference. BUG=chromium-os:19576 TEST=none Review URL: http://codereview.chromium.org/7799001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98668 0039d316-1c4b-4281-b951-d872f2087c98
* Mark ParseHostAndPort() as NET_EXPORT instead of NET_EXPORT_PRIVATE.sergeyu@chromium.org2011-08-291-2/+2
| | | | | | | | | | | I need to use this function in content/rendeder/p2p. TEST=None BUG=None Review URL: http://codereview.chromium.org/7714027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98666 0039d316-1c4b-4281-b951-d872f2087c98
* Update .DEPS.gitchrome-admin@google.com2011-08-291-3/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98665 0039d316-1c4b-4281-b951-d872f2087c98
* Rolling Skia DEPS 2172 -> 2183epoger@google.com2011-08-291-1/+1
| | | | | | Review URL: http://codereview.chromium.org/7789001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98664 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash caused by unknown saved language.mad@chromium.org2011-08-292-2/+9
| | | | | | | | | | | | | The language index in the dump referred by the crbug is left to -1, meaning that the language passed to TranslateInfoBarDelegate's constructor... The call stack showed that the call came from an auto translate preference, so my only guess would be that a preference was saved for a language that is not available anymore, so I added code to protect against that. BUG=93291 TEST=TranslateManagerTest.UnsupportedSavedLanguage Review URL: http://codereview.chromium.org/7764003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98661 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 98656 - Make a new integer field in sql::MetaTable (a per-profile db) ↵dmaclach@chromium.org2011-08-2932-379/+111
| | | | | | | | | | | | | | | | | | | | | | containing a counter for the next download id, so that this id is unique across sessions. This id will allow us to merge download id with db_handle and merge most/all of the maps in DownloadManager in future CLs. Make DownloadManager read this field to initialize its next_id_ counter in Init(). Put a fine-grained mutex in DownloadManager::GetNextId() so that it can be called directly from any thread. Define a thunk wrapping DM::GNI() to be passed around between threads to guard against other threads calling any other DM methods. This thunk owns a scoped_refptr<DM> to manage life-time issues. This pattern is implemented for DM elsewhere. Store this thunk in ResourceContext to be called by ResourceDispatchHost/DownloadThrottlingResourceHandler on the IO thread. Pass the returned DownloadId into DownloadResourceHandler. The alternative way to obtain ids on the IO thread is to jump over to the UI thread and back. This way would add significant latency to a critical path. GetNextId() should be fast and easily accessible from any thread. Now that ids are per-profile, define a class DownloadId containing a per-profile id and an indication of which profile, currently the DownloadManager*. DownloadIds are hashable, comparable, globally unique, not persistent, and are used by DownloadFileManager. When the download is added to the history, MetaTable.next_download_id will be set to the new download's id +1 if that number is greater than MT.next_download_id. Increasing this counter at the same time as the download is added to the db prevents the counter from desyncing from the db, which was the primary concern re storing the counter in the BrowserPrefs. See also http://codereview.chromium.org/7192016 LMK what to write a test for if anything. Review URL: http://codereview.chromium.org/7237034 TBR=benjhayden@chromium.org Review URL: http://codereview.chromium.org/7793003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98660 0039d316-1c4b-4281-b951-d872f2087c98
* [ntp4] User interface adjustments to NTP4's bookmarks page.csilv@chromium.org2011-08-292-8/+12
| | | | | | | | | | | | | | * Disable underlining for links * Add more padding between the button and the title. * Discard the button gradient in favor of white. * Move favicons two lower-left. * Display favicons at natural size (TODO: they need to be size constrained) * Other bookmarks folder will be hidden if empty. BUG=92921 Review URL: http://codereview.chromium.org/7749029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98659 0039d316-1c4b-4281-b951-d872f2087c98
* [ntp4] Observe and process bookmark change notifications from the bookmarks ↵csilv@chromium.org2011-08-295-29/+337
| | | | | | | | | data model. BUG=93144 Review URL: http://codereview.chromium.org/7713026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98657 0039d316-1c4b-4281-b951-d872f2087c98
* Make a new integer field in sql::MetaTable (a per-profile db) containing a ↵benjhayden@chromium.org2011-08-2932-111/+379
| | | | | | | | | | | | | | | | | | | counter for the next download id, so that this id is unique across sessions. This id will allow us to merge download id with db_handle and merge most/all of the maps in DownloadManager in future CLs. Make DownloadManager read this field to initialize its next_id_ counter in Init(). Put a fine-grained mutex in DownloadManager::GetNextId() so that it can be called directly from any thread. Define a thunk wrapping DM::GNI() to be passed around between threads to guard against other threads calling any other DM methods. This thunk owns a scoped_refptr<DM> to manage life-time issues. This pattern is implemented for DM elsewhere. Store this thunk in ResourceContext to be called by ResourceDispatchHost/DownloadThrottlingResourceHandler on the IO thread. Pass the returned DownloadId into DownloadResourceHandler. The alternative way to obtain ids on the IO thread is to jump over to the UI thread and back. This way would add significant latency to a critical path. GetNextId() should be fast and easily accessible from any thread. Now that ids are per-profile, define a class DownloadId containing a per-profile id and an indication of which profile, currently the DownloadManager*. DownloadIds are hashable, comparable, globally unique, not persistent, and are used by DownloadFileManager. When the download is added to the history, MetaTable.next_download_id will be set to the new download's id +1 if that number is greater than MT.next_download_id. Increasing this counter at the same time as the download is added to the db prevents the counter from desyncing from the db, which was the primary concern re storing the counter in the BrowserPrefs. See also http://codereview.chromium.org/7192016 LMK what to write a test for if anything. Review URL: http://codereview.chromium.org/7237034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98656 0039d316-1c4b-4281-b951-d872f2087c98
* Add myself as an owner of chrome/browser/chromeos/login/enrollment.mnissler@chromium.org2011-08-291-0/+1
| | | | | | | | | | | BUG=none TEST=none R=avayvod@chromium.org Review URL: http://codereview.chromium.org/7784002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98655 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure none of content brings in views.jam@chromium.org2011-08-292-6/+5
| | | | | | Review URL: http://codereview.chromium.org/7736005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98654 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the note about content script files not being able tokathyw@chromium.org2011-08-292-16/+0
| | | | | | | use predefined messages, per Cira. Review URL: http://codereview.chromium.org/7794001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98653 0039d316-1c4b-4281-b951-d872f2087c98
* Update .DEPS.gitchrome-admin@google.com2011-08-291-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98652 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 93973:93977.levin@chromium.org2011-08-291-1/+1
| | | | | | | | TBR=apavlov@chromium.org Review URL: http://codereview.chromium.org/7795001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98651 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 01:46:20 +0000