| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This should fix the following error:
FATAL:common/pref_service.cc(314)] Check failed: false. Trying to read an unregistered pref: security.mixed_content_filtering
Review URL: http://codereview.chromium.org/39006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/40116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
over the last few builds.
TEST=covered by buildbots
BUG=none
Review URL: http://codereview.chromium.org/39138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add a net_test_support library to hold the disk_cache_test_util.*
object file used by several of the test executables.
* Generate the net_resources.h file by re-using the existing net_resources
'grit' rule defined for Windows, not by rolling our own flavor.
* Give the grit.py rule all of its generated output files (*.h, *.rc, *.pak).
* Fix the path of the grit-generated *.h file (it's in a grit/ subdir).
Review URL: http://codereview.chromium.org/40083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(as was done for mac) and add the include directory
to the .gyp file.
Review URL: http://codereview.chromium.org/40101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I guess CalculateWindowSizeForClientSize() disappeared in that reorg? That's the one part of the old change I can't find where to put.
BUG=8151
Review URL: http://codereview.chromium.org/39074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=8310
Review URL: http://codereview.chromium.org/39087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/40113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=kasperl
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also fix a leak while I'm here.
TBR=brettw
Review URL: http://codereview.chromium.org/40112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
test bot. It's causing it to crash some of the time, and causing some UMRs and MLKs.
TBR=mpcomplete,deanm
BUG=8362,8363,8314
Review URL: http://codereview.chromium.org/40111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=8314
Review URL: http://codereview.chromium.org/39125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
'eval' optimization code.
Review URL: http://codereview.chromium.org/39122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Implement GM_xmlhttpRequest
Review URL: http://codereview.chromium.org/39121
Patch from Steve Krulewitz <skrulx@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
extension was loaded twice the first run after
installation.
I still ExtensionServiceBackend is begging to be split apart into individual tasks, this was just a quick spruce-up while I was in the file.
The main things I changed are:
* Moved extension_path_ from a member back into parameters where relevant. This just didn't feel right as state to me. It isn't relevant to all the methods the way alert_on_error_ and frontend_ are. This created the majority of the noise in the change, but is the least important.
* Renamed OnExtensionsLoadedFromDirectory to OnExtensionsLoaded since it is called in response to LoadExtension() too.
* Made install_directory_ be a parameter to backend's constructor instead of passed into each appropriate method. Again, this felt more appropriate because the install directory is relevant to the whole object.
* Hoisted checking for uninstalled external extensions up out of LoadExtension() into LoadExtensionsFromInstallDirectory(). It wasn't doing any harm in LoadExtension(), but it didn't seem relevant to other places where LoadExtension() is used (for example --load-extension and --install-extension).
* Hoisted installation success notification up out of InstallOrUpdateExtension() into InstallExtension(). This prevented having to pass around a be_noisy argument since InstallExtension() is only used for handling --install-extension, and InstallOrUpdateExtension() is just the private impl.
Review URL: http://codereview.chromium.org/40002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
unnecessary WebKit:: scoping.
This is part of a speculative fix for the intl1 page cycler regression.
TBR=dglazkov
Review URL: http://codereview.chromium.org/39120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
(net, webkit, chrome) to *_main.scons, so we can use GYP=1 on the command
line to switch between old and new while tracking down the remaining
inconsistencies.
Review URL: http://codereview.chromium.org/39080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
gets deleted after first message is sent from a
background thread.
Review URL: http://codereview.chromium.org/39034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
if this might explain the intl1 performance regression. The theory is that
this function is called a lot (once per anchor), so it may be a hot-spot.
Previously, we did not have this extra string copy.
TBR=brettw
Review URL: http://codereview.chromium.org/39118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/40099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the intl1 perf regression.
TBR=dglazkov
Review URL: http://codereview.chromium.org/39112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to Browser.
Turns out the test regression was actually caused by r10806 which
removed an anonymous namespace causing the TestView class to collide
with the same class in render_widget_host_unittest.cc.
For now, fix by adding the TestView in the view unittest to the
anon namespace. shess is going to try to re-add the namespace to
render_widget_host_unittest.cc too.
TBR=pkasting
Review URL: http://codereview.chromium.org/40058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to be virtual, either.
This also changes how the display URL is computed. Instead of doing it
preemptively, we now do so lazily. This allows us to do the URL formatting
correctly using the elider so that we can do IDN and unescaping.
I changed string_util's singleton functions. I was worried that other code
might make a singleton of string, which would give you this same value as a
non-const string. This would mean our empty strings might no longer be empty.
Review URL: http://codereview.chromium.org/39022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=darin
Review URL: http://codereview.chromium.org/40097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a registerExtension function available in our WebKit public API.
Once this is in place, another changelist will include actually using it.
R=mbelshe,darin
Review URL: http://codereview.chromium.org/39070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
explains the intl1 page cycler regression.
This is a windows only change.
TBR=dglazkov
Review URL: http://codereview.chromium.org/40096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
not-broken as before) - I forgot to add this line to the nav controller.
BUG=8212
Review URL: http://codereview.chromium.org/40076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
coming in with the wrong slash direction and escaping, which was OK for non-exes, but strangely bad for exes.
BUG=8327
Review URL: http://codereview.chromium.org/40068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
controls (Pause/Cancel).* Help deblock download UI creation (timeout in downloads.html, kMaxDownloads in downloads_ui.cc)* Allow resume for paused downloads
BUG=8271,8270,8130,8330
Review URL: http://codereview.chromium.org/40047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a workaround to force the New Tab Page title to 'New Tab' (8282)
Make DOMUI Pages get focus correctly (8271)
Please also sanity-check DOMUI/DOMUIContents integration.
BUG=8294,8282,8271
Review URL: http://codereview.chromium.org/39057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Update callers as well.
This patch builds on a patch by mark.a.lindner@gmail.com which can be found at http://codereview.chromium.org/28294
Review URL: http://codereview.chromium.org/27370
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
uninstall time via the uninstall survey page.These uninstall metrics are collected according to the same opt-in policy as the existing UMA code. They are stored along with other prefs in the browser's Local State file. At uninstall time, the Local State file is copied to a temporary location during the file deletion stage and then read to extract the uninstall metrics. If the user selected to have metrics reported, the uninstall metrics are then sent up to the uninstall survey page that is currently opened.
Review URL: http://codereview.chromium.org/27092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=nsylvain
Review URL: http://codereview.chromium.org/39107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
maximized. This is because of the nonclient frameview/clientview hierarchy changes.
Make sure that the frame gets a chance to respond to GetViewForPoint before the client view if the client view does not visually overlap.
http://crbug.com/8312
Review URL: http://codereview.chromium.org/40062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=nsylvain
Review URL: http://codereview.chromium.org/37007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
depends
on (and that depend on it).
Unforking Document.idl and HTMLCanvasElement.idl
Original review URL: http://codereview.chromium.org/39050
TBR=mbelshe
Review URL: http://codereview.chromium.org/39103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
for Chrome Release builds.
Review URL: http://codereview.chromium.org/39046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10849 0039d316-1c4b-4281-b951-d872f2087c98
|